rmagick 2.13.4 → 2.14.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 508f276e9009e084323676549e393518a5d4bb86
-  data.tar.gz: 25255ce344cfe6c13ad3e8c86196af8c4acfc1df
+  metadata.gz: 7f1d40197e527e46372e4ad8c265c3f2e929eddd
+  data.tar.gz: d559dc36017d771ac142cc90029037402c355e4d
 SHA512:
-  metadata.gz: d6c520465ccb71d40bc6930e5c21d857c13f6f5d48d38d9ebce852ed6a7a96db4e840ddf9c959b9692de0d495ba74c122272592cf76de690c02c272273338310
-  data.tar.gz: 224f1cc16579906b338ee8e5bd6052b08e736d4b22cb314984abff9600a2dabb13a8f287fa2c9adeada88673ca5a6d51f0b87ac8567a07675e458e577965b1aa
+  metadata.gz: 577e9dcde875183b07218696b2302e73849e292b632c5464294320583e2c209971e0958cf96faf14a3c45e11c76b2af90eab1b5c0b743fdeefabd87296d9ae74
+  data.tar.gz: 63ccbc7117ba02dbd5229f3ebbb52bf1d135aea0a73ca1bbcd5d1df80088798926e6cb9eb29d29552972e2cf283d33d79a7dbf8af4135f6965345448d2ef994a

data/.hound.yml

@@ -0,0 +1,2 @@
+ruby:
+  config_file: .rubocop.yml

data/.rubocop.yml

@@ -0,0 +1,284 @@
+# This configuration was generated by `rubocop --auto-gen-config`
+# on 2015-02-08 00:25:41 +0300 using RuboCop version 0.29.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+Lint/HandleExceptions:
+  Enabled: false
+
+# Offense count: 1
+Lint/RescueException:
+  Enabled: false
+
+# Offense count: 1
+Lint/ShadowingOuterLocalVariable:
+  Enabled: false
+
+# Offense count: 1
+Lint/UnderscorePrefixedVariableName:
+  Enabled: false
+
+# Offense count: 9
+# Cop supports --auto-correct.
+Lint/UnusedBlockArgument:
+  Enabled: false
+
+# Offense count: 17
+# Cop supports --auto-correct.
+Lint/UnusedMethodArgument:
+  Enabled: false
+
+# Offense count: 22
+Lint/UselessAssignment:
+  Enabled: false
+
+# Offense count: 187
+Metrics/AbcSize:
+  Max: 567
+
+# Offense count: 1
+Metrics/BlockNesting:
+  Max: 4
+
+# Offense count: 17
+# Configuration parameters: CountComments.
+Metrics/ClassLength:
+  Max: 1124
+
+# Offense count: 22
+Metrics/CyclomaticComplexity:
+  Max: 42
+
+# Offense count: 886
+# Configuration parameters: AllowURI, URISchemes.
+Metrics/LineLength:
+  Max: 278
+
+# Offense count: 180
+# Configuration parameters: CountComments.
+Metrics/MethodLength:
+  Max: 157
+
+# Offense count: 13
+# Configuration parameters: CountKeywordArgs.
+Metrics/ParameterLists:
+  Max: 8
+
+# Offense count: 14
+Metrics/PerceivedComplexity:
+  Max: 41
+
+# Offense count: 4
+Style/AccessorMethodName:
+  Enabled: false
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/BarePercentLiterals:
+  Enabled: false
+
+# Offense count: 7
+Style/CaseEquality:
+  Enabled: false
+
+# Offense count: 14
+Style/ClassAndModuleCamelCase:
+  Enabled: false
+
+# Offense count: 6
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/ClassAndModuleChildren:
+  Enabled: false
+
+# Offense count: 126
+Style/ConstantName:
+  Enabled: false
+
+# Offense count: 12
+# Cop supports --auto-correct.
+Style/DeprecatedHashMethods:
+  Enabled: false
+
+# Offense count: 63
+Style/Documentation:
+  Enabled: false
+
+Style/DotPosition:
+  EnforcedStyle: leading
+
+# Offense count: 24
+# Configuration parameters: Exclude.
+Style/FileName:
+  Enabled: false
+
+# Offense count: 68
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/FormatString:
+  Enabled: false
+
+# Offense count: 43
+# Configuration parameters: AllowedVariables.
+Style/GlobalVars:
+  Enabled: false
+
+# Offense count: 7
+# Configuration parameters: MinBodyLength.
+Style/GuardClause:
+  Enabled: false
+
+# Cop supports --auto-correct.
+Style/HashSyntax:
+  EnforcedStyle: hash_rockets
+
+# Offense count: 28
+# Configuration parameters: MaxLineLength.
+Style/IfUnlessModifier:
+  Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/Lambda:
+  Enabled: false
+
+# Offense count: 48
+# Cop supports --auto-correct.
+Style/LeadingCommentSpace:
+  Enabled: false
+
+# Offense count: 4
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/MethodName:
+  Enabled: false
+
+Style/MultilineOperationIndentation:
+  EnforcedStyle: indented
+
+# Offense count: 1
+Style/MultilineTernaryOperator:
+  Enabled: false
+
+# Offense count: 3
+# Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles.
+Style/Next:
+  Enabled: false
+
+# Offense count: 21
+# Cop supports --auto-correct.
+Style/NumericLiterals:
+  MinDigits: 18
+
+# Offense count: 1
+Style/OpMethod:
+  Enabled: false
+
+# Offense count: 19
+# Cop supports --auto-correct.
+# Configuration parameters: PreferredDelimiters.
+Style/PercentLiteralDelimiters:
+  Enabled: false
+
+# Offense count: 10
+# Cop supports --auto-correct.
+Style/PerlBackrefs:
+  Enabled: false
+
+# Offense count: 4
+# Configuration parameters: NamePrefix, NamePrefixBlacklist.
+Style/PredicateName:
+  Enabled: false
+
+# Offense count: 3
+# Configuration parameters: MaxSlashes.
+Style/RegexpLiteral:
+  Enabled: false
+
+# Offense count: 2
+Style/RescueModifier:
+  Enabled: false
+
+# Offense count: 2
+# Configuration parameters: Methods.
+Style/SingleLineBlockParams:
+  Enabled: false
+
+# Offense count: 7
+# Cop supports --auto-correct.
+Style/SingleSpaceBeforeFirstArg:
+  Enabled: false
+
+# Offense count: 1112
+# Cop supports --auto-correct.
+Style/SpaceAfterComma:
+  Enabled: false
+
+# Offense count: 91
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/SpaceAroundEqualsInParameterDefault:
+  Enabled: false
+
+# Offense count: 1060
+# Cop supports --auto-correct.
+Style/SpaceAroundOperators:
+  Enabled: false
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/SpaceBeforeBlockBraces:
+  Enabled: false
+
+# Offense count: 209
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
+Style/SpaceInsideBlockBraces:
+  Enabled: false
+
+# Offense count: 6
+# Cop supports --auto-correct.
+Style/SpaceInsideBrackets:
+  Enabled: false
+
+# Offense count: 68
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SupportedStyles.
+Style/SpaceInsideHashLiteralBraces:
+  Enabled: false
+
+# Offense count: 35
+# Cop supports --auto-correct.
+# Many method calls in consecutive lines in RMagick have parameters aligned vertically.
+# Therefore this cop should better be disabled.
+# But you can delete this rule temporarily, run `rubocop -a`, and commit good fixes only.
+Style/SpaceInsideParens:
+  Enabled: false
+
+Style/StringLiterals:
+  EnforcedStyle: single_quotes
+
+# Offense count: 12
+# Cop supports --auto-correct.
+# Configuration parameters: IgnoredMethods.
+Style/SymbolProc:
+  Enabled: false
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
+Style/TrailingComma:
+  Enabled: false
+
+# Offense count: 2
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/VariableName:
+  Enabled: false
+
+# Offense count: 7
+# Cop supports --auto-correct.
+# Configuration parameters: WordRegex.
+Style/WordArray:
+  MinSize: 3

data/.simplecov

@@ -0,0 +1,27 @@
+# https://github.com/colszowka/simplecov#using-simplecov-for-centralized-config
+# see https://github.com/colszowka/simplecov/blob/master/lib/simplecov/defaults.rb
+# vim: set ft=ruby
+SimpleCov.profiles.define 'rmagick' do
+  load_profile  'test_frameworks'
+
+  add_group "Long files" do |src_file|
+    src_file.lines.count > 100
+  end
+  class MaxLinesFilter < SimpleCov::Filter
+    def matches?(source_file)
+      source_file.lines.count < filter_argument
+    end
+  end
+  add_group "Short files", MaxLinesFilter.new(5)
+
+  # Exclude these paths from analysis
+  add_filter 'bundle'
+  add_filter 'bin'
+end
+
+## RUN SIMPLECOV
+if ENV['COVERAGE'] =~ /\Atrue\z/i
+  SimpleCov.start 'rmagick'
+  puts '[COVERAGE] Running with SimpleCov HTML Formatter'
+  SimpleCov.formatters = [SimpleCov::Formatter::HTMLFormatter]
+end

data/.travis.yml

@@ -2,51 +2,63 @@ language: ruby
 
 os:
   - linux
-  #- osx
 
 env:
   # Currently successful release
   - IMAGEMAGICK_VERSION=6.6.9-10
+  - IMAGEMAGICK_VERSION=6.6.9-10 STYLE_CHECKS=true
   # Ubuntu's current stable release
   - IMAGEMAGICK_VERSION=6.7.7-10
   # Latest 6.7 release
   - IMAGEMAGICK_VERSION=6.7.9-10
   # Latest 6.8 release
-  - IMAGEMAGICK_VERSION=6.8.9-6
+  - IMAGEMAGICK_VERSION=6.8.9-10
   # Try with HDRI support, we don't mind if this fails currently.
-  - IMAGEMAGICK_VERSION=6.8.9-6 CONFIGURE_OPTIONS=--enable-hdri
+  - IMAGEMAGICK_VERSION=6.8.9-10 CONFIGURE_OPTIONS=--enable-hdri
+  # Latest release
+  - IMAGEMAGICK_VERSION=latest
 
 before_install:
   - source before_install_$TRAVIS_OS_NAME.sh
 
 rvm:
+  - 1.8
   - 1.9
   - 2.0
   - 2.1
+  - 2.2
 
 matrix:
   exclude:
-#    - rvm: 1.9
-#      env: IMAGEMAGICK_VERSION=6.7.7-10
+    - rvm: 1.8
+      env: IMAGEMAGICK_VERSION=6.6.9-10 STYLE_CHECKS=true
+    - rvm: 1.8
+      env: IMAGEMAGICK_VERSION=6.7.9-10
+    - rvm: 1.8
+      env: IMAGEMAGICK_VERSION=6.7.7-10
+    - rvm: 1.8
+      env: IMAGEMAGICK_VERSION=6.8.9-10 CONFIGURE_OPTIONS=--enable-hdri
+    - rvm: 1.8
+      env: IMAGEMAGICK_VERSION=6.8.9-10
     - rvm: 1.9
       env: IMAGEMAGICK_VERSION=6.7.9-10
-#    - rvm: 1.9
-#      env: IMAGEMAGICK_VERSION=6.8.9-6
     - rvm: 1.9
-      env: IMAGEMAGICK_VERSION=6.8.9-6 CONFIGURE_OPTIONS=--enable-hdri
+      env: IMAGEMAGICK_VERSION=6.8.9-10 CONFIGURE_OPTIONS=--enable-hdri
     - rvm: 2.0
       env: IMAGEMAGICK_VERSION=6.7.7-10
     - rvm: 2.0
       env: IMAGEMAGICK_VERSION=6.7.9-10
     - rvm: 2.0
-      env: IMAGEMAGICK_VERSION=6.8.9-6
+      env: IMAGEMAGICK_VERSION=6.8.9-10
     - rvm: 2.0
-      env: IMAGEMAGICK_VERSION=6.8.9-6 CONFIGURE_OPTIONS=--enable-hdri
+      env: IMAGEMAGICK_VERSION=6.8.9-10 CONFIGURE_OPTIONS=--enable-hdri
   allow_failures:
+    - rvm: 1.8
+    - rvm: 2.2
+    - env: IMAGEMAGICK_VERSION=6.6.9-10 STYLE_CHECKS=true
     - env: IMAGEMAGICK_VERSION=6.7.7-10
     - env: IMAGEMAGICK_VERSION=6.7.9-10
-    #- env: IMAGEMAGICK_VERSION=6.8.9-6
-    - env: IMAGEMAGICK_VERSION=6.8.9-6 CONFIGURE_OPTIONS=--enable-hdri
+    - env: IMAGEMAGICK_VERSION=6.8.9-10 CONFIGURE_OPTIONS=--enable-hdri
 
 notifications:
   webhooks:

data/ChangeLog

@@ -1,4 +1,16 @@
 HEAD
+    o RMagick.rb moved to deprecated directory - @mockdeep
+    o Better ImageMagick feature detection - @bf4
+    o Prevent compilation failures if prefix is an empty string - @voxik
+    o SplineInterpolatePixel preprocessor check removed - @joshk
+    o Make error format a string literal - @mtasaka
+    o Automatically set ARCHFLAGS on OS X - @u338steven
+    o Fixed 'rmagick/version' require failure - @u338steven
+    o Fixed escaping of '%' in Draw#get_type_metrics - @mkluczny
+    o Silence warnings on Ruby 2.2 when comparing Enums - @meanphil
+    o Multiple test suite improvements - @mockdeep, @bf4
+    o Ruby source code formatting with RuboCop - @vassilevsky
+
 RMagick 2.13.4
     #129 from @theschoolmaster
       proof of concept for using pkg-config in place of Magick-config on debian based systems

data/Gemfile

@@ -3,5 +3,8 @@ source 'https://rubygems.org'
 # Specify your gem's dependencies in rmagick.gemspec
 gemspec
 
+group :development, :test do
+  gem 'simplecov', :require => false
+end
 # Used by README.textile
 # gem "RedCloth"

data/README.textile

@@ -1,6 +1,6 @@
 h1. RMagick
 
-!https://img.shields.io/gem/v/rmagick.svg?style=flat(RubyGems)!:http://rubygems.org/gems/rmagick !https://img.shields.io/gem/dt/rmagick.svg?style=flat! !https://www.versioneye.com/ruby/rmagick/reference_badge.svg?style=flat(VersionEye)!:https://www.versioneye.com/ruby/rmagick/references !https://img.shields.io/travis/gemhome/rmagick.svg?style=flat(Travis CI)!:https://travis-ci.org/gemhome/rmagick !https://img.shields.io/codeclimate/github/gemhome/rmagick.svg?style=flat(Code Climate)!:https://codeclimate.com/github/gemhome/rmagick !https://badges.gitter.im/Join%20Chat.svg(Gitter)!:https://gitter.im/gemhome/rmagick?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge
+!https://img.shields.io/gem/v/rmagick.svg?style=flat(RubyGems)!:http://rubygems.org/gems/rmagick !https://img.shields.io/gem/dt/rmagick.svg?style=flat! !https://www.versioneye.com/ruby/rmagick/reference_badge.svg?style=flat(VersionEye)!:https://www.versioneye.com/ruby/rmagick/references !https://img.shields.io/travis/gemhome/rmagick/master.svg?style=flat(Travis CI)!:https://travis-ci.org/gemhome/rmagick !https://img.shields.io/codeclimate/github/gemhome/rmagick.svg?style=flat(Code Climate)!:https://codeclimate.com/github/gemhome/rmagick !https://badges.gitter.im/Join%20Chat.svg(Gitter)!:https://gitter.im/gemhome/rmagick?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge
 
 This is the official fork of RMagick. The decision to create a fork "originated here":https://github.com/rmagick/rmagick/issues/18#issuecomment-50022523, where you can read more about why it happened.
 
@@ -13,6 +13,7 @@ h3. Table of Contents
 * "Upgrading":#upgrade
 * "More samples":#samples
 * "Reporting Bugs":#bugs
+* "Development Setup":#dev-setup
 * "Contact Information":#contact
 * "Credits":#credits
 * "License":#license
@@ -114,6 +115,67 @@ installation and configuration. Information about reporting problems and
 getting help for ImageMagick is available at the "ImageMagick web site":http://www.imagemagick.org
 or the "ImageMagick Forum":http://www.imagemagick.org/discourse-server.
 
+h2(#dev-setup). Development Setup
+
+In order to minimize issues on your local machine, we recommend that you make
+use of a "Vagrant installation":https://github.com/tjschuck/rake-compiler-dev-box.
+
+Steps to get up and running with a passing build are as follows:
+
+h4. 1) set up the Vagrant environment
+
+If you don't already have Vagrant installed, you can download and install it
+from "here":https://www.vagrantup.com/. Once installed, we can set up a pre-built environment:
+
+<pre>
+git clone https://github.com/tjschuck/rake-compiler-dev-box.git
+cd rake-compiler-dev-box
+vagrant up
+</pre>
+
+This last part will probably take a while as it has to download an Ubuntu image
+and configure it. If there is an error during this process, you may need to
+reboot your computer and enable virtualization in your BIOS settings.
+
+h4. 2) clone RMagick and log in to the vagrant box
+
+Within the `rake-compiler-dev-box` directory:
+
+<pre>
+git clone https://github.com/gemhome/rmagick.git # or your fork
+vagrant ssh
+</pre>
+
+h4. 3) install ImageMagick and additional environment stuff
+
+<pre>
+cd /vagrant/rmagick
+export IMAGEMAGICK_VERSION=6.6.9-10 # the only known passing version as of this writing
+sh ./before_install_linux.sh
+</pre>
+
+This will take just a few minutes to build ImageMagick
+
+h4. 4) build RMagick
+
+<pre>
+rake
+</pre>
+
+This compiles the RMagick extensions and runs the tests. If all goes well
+you'll see a lot of output, eventually ending in something like:
+
+<pre>
+Finished tests in 35.865734s, 11.3758 tests/s, 6560.3007 assertions/s.
+
+408 tests, 235290 assertions, 0 failures, 0 errors, 0 skips
+</pre>
+
+And you're all set! The copy of RMagick within `/vagrant/rmagick` inside your
+Vagrant session is the same as the one in the `rake-compiler-dev-box` directory
+on your machine. You can make changes locally and run tests within your `ssh`
+session.
+
 h2(#contact). Contact Information
 
 *Author:* Tim Hunter, Omer Bar-or, Benjamin Thomas