rma-payment-gateway 1.0.2 → 1.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bc31ce3ef352488d411e27123665afbe880004be3ae232e18c021e25d2221d87
-  data.tar.gz: 52aaece35817e948239e8a7d7f8184fce8715e928508c8996f310616ab711dfa
+  metadata.gz: 8761398358087d863249d34a3d6df1a14b374829cde1fa6ae5b66fc6b42d8e3b
+  data.tar.gz: b7fdbfeb4d801c9c33ae681adfc98875eec6ad8391274563951fe1ce885a1450
 SHA512:
-  metadata.gz: fc2689e5f19f3e9a92b7261f529071d3b55cf3cc55e0e9269dce09b267a0e94bb57f083a97e43875001214e37088197df9422f7aad15354d13aac99b48be0912
-  data.tar.gz: 5aa1c1f656d85fd7b5734340910e5e77094f461aace32e70679a3dedd162ad458cc1fb035358b0496ae5c7c30970fa9585da2a3a570dca0b12bd863c0bfc8775
+  metadata.gz: d6c84e3a1444a374259f54bf3e3459058c304d1be2e2934b773ac043fe9d01a3e5d358d16498f42966fe40e1830d4491d54b2d20c5c1bebe1db9c61c6311237e
+  data.tar.gz: ad5b6800446530c316a499b453c255bb65996aeb3acbe3fa4659e5b88fb417157bc558f7b3703579e5b3e38b5454266b677e935469d6c5ff76d317c2cc7038b3

data/lib/rma/payment/gateway/account_inquiry.rb

@@ -27,15 +27,7 @@ module Rma
           @transaction_id = transaction_id
           @bank_id = bank_id
           @account_no = account_no
-          response = client.post(
-            body: account_inquiry_request_body
-          )
-
-          validate_account_inquiry_response!(response)
-
-          response["result"]
-        rescue StandardError => e
-          raise AuthenticationError, "Failed to fetch account inquiry: #{e.message}"
+          client.post(body: account_inquiry_request_body)
         end
 
         private
@@ -50,17 +42,6 @@ module Rma
           }
         end
 
-        def validate_account_inquiry_response!(response)
-          unless response.is_a?(Hash) && response["result"]["bfs_responseCode"] == "00"
-            error_detail = response["result"]["bfs_responseDesc"] || "Unknown error"
-            raise AuthenticationError, "Account inquiry failed: #{error_detail}"
-          end
-
-          # :nocov:
-          return if response["result"]
-          raise AuthenticationError, "No response data in response"
-          # :nocov:
-        end
       end
     end
   end

data/lib/rma/payment/gateway/authorization.rb

@@ -28,13 +28,7 @@ module Rma
           @amount = amount
           @email = email
           validate_authorization_request!
-          response = client.post(body: authorization_request_body)
-
-          validate_authorization_response!(response)
-
-          response["result"]
-        rescue StandardError => e
-          raise AuthenticationError, "Failed to authorize: #{e.message}"
+          client.post(body: authorization_request_body)
         end
 
         private
@@ -60,18 +54,6 @@ module Rma
           raise InvalidParameterError, "Email is required" if email.to_s.strip.empty?
           raise InvalidParameterError, "Email must be a valid email" unless Utils.valid_email?(email.to_s)
         end
-
-        def validate_authorization_response!(response)
-          unless response.is_a?(Hash) && response["result"]["bfs_responseCode"] == "00"
-            error_detail = response["result"]["bfs_responseDesc"] || "Unknown error"
-            raise AuthenticationError, "Authorization failed: #{error_detail}"
-          end
-
-          # :nocov:
-          return if response["result"]
-          raise AuthenticationError, "No response data in response"
-          # :nocov:
-        end
       end
     end
   end

data/lib/rma/payment/gateway/client.rb

@@ -2,6 +2,7 @@
 
 require "faraday"
 require "json"
+require "openssl"
 
 module Rma
   module Payment
@@ -17,13 +18,17 @@ module Rma
       #
       # @param config [Rma::Payment::Gateway::Configuration] Configuration instance
       class Client
-        attr_reader :config, :access_token, :private_key
+        attr_reader :config, :access_token
 
         def initialize(config = nil)
           @config = config || Rma::Payment::Gateway.configuration
           validate_configuration!
         end
 
+        def private_key
+          @private_key ||= load_private_key
+        end
+
         # Authorization methods
         def authorization
           @authorization ||= Authorization.new(self)
@@ -41,7 +46,8 @@ module Rma
 
         # HTTP request methods
         def post(body: {}, headers: {})
-          request(:post, body: body, headers: headers)
+          signed = body.empty? ? body : body.merge(bfs_checkSum: compute_checksum(body))
+          request(:post, body: signed, headers: headers)
         end
 
         def get(headers: {})
@@ -50,6 +56,23 @@ module Rma
 
         private
 
+        def compute_checksum(params)
+          sorted_values = params.sort_by { |k, _| k }.to_h.values.join("|")
+          signature = private_key.sign(OpenSSL::Digest.new("SHA1"), sorted_values)
+          signature.unpack1("H*")&.upcase
+        end
+
+        def load_private_key
+          key_content = if !config.rsa_key_path.to_s.strip.empty?
+                          File.read(config.rsa_key_path)
+                        else
+                          config.rsa_key
+                        end
+          OpenSSL::PKey::RSA.new(key_content)
+        rescue OpenSSL::PKey::RSAError => e
+          raise ConfigurationError, "Invalid RSA key: #{e.message}"
+        end
+
         def validate_configuration!
           raise ConfigurationError, "Configuration is required" if config.nil?
           return if config.valid?
@@ -99,13 +122,13 @@ module Rma
 
         def handle_client_error(response)
           body = parse_body(response.body) || {}
-          error_message = body.dig("result", "bfs_responseDesc") || "Client error"
+          error_message = body["bfs_responseDesc"] || "Client error"
           raise InvalidParameterError, error_message
         end
 
         def handle_server_error(response)
           body = parse_body(response.body) || {}
-          error_message = body.dig("result", "bfs_responseDesc") || "Server error"
+          error_message = body["bfs_responseDesc"] || "Server error"
           raise APIError, error_message
         end
 

data/lib/rma/payment/gateway/debit_request.rb

@@ -26,13 +26,7 @@ module Rma
         def call(transaction_id, otp)
           @transaction_id = transaction_id
           @otp = otp
-          response = client.post(body: debit_request_body)
-
-          validate_debit_request_response!(response)
-
-          response["result"]
-        rescue StandardError => e
-          raise AuthenticationError, "Failed to fetch debit request: #{e.message}"
+          client.post(body: debit_request_body)
         end
 
         private
@@ -45,18 +39,6 @@ module Rma
             bfs_msgType: "DR"
           }
         end
-
-        def validate_debit_request_response!(response)
-          unless response.is_a?(Hash) && response["result"]["bfs_responseCode"] == "00"
-            error_detail = response["result"]["bfs_responseDesc"] || "Unknown error"
-            raise AuthenticationError, "Debit request failed: #{error_detail}"
-          end
-
-          # :nocov:
-          return if response["result"]
-          raise AuthenticationError, "No response data in response"
-          # :nocov:
-        end
       end
     end
   end

data/lib/rma/payment/gateway/version.rb

@@ -3,7 +3,7 @@
 module Rma
   module Payment
     module Gateway
-      VERSION = "1.0.2"
+      VERSION = "1.0.4"
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rma-payment-gateway
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.4
 platform: ruby
 authors:
 - Tashi Dendup