rley 0.7.07 → 0.7.08

data/spec/rley/parse_rep/ambiguous_parse_spec.rb

@@ -19,11 +19,11 @@ module Rley # Open this namespace to avoid module qualifier prefixes
       include ExpectationHelper # Mix-in with expectation on parse entry sets
 
       # Emit a text representation of the current path.
-      def path_to_s()
+      def path_to_s
         text_parts = subject.curr_path.map do |path_element|
           path_element.to_string(0)
         end
-        return text_parts.join('/')
+        text_parts.join('/')
       end
 
       def next_event(eventType, anEntryText)
@@ -88,28 +88,28 @@ module Rley # Open this namespace to avoid module qualifier prefixes
 
           next_event(:visit, 'S. | 4') # Event 5
           path_prefix = 'P[0, 5]/S[0, 5]/Alt(S => S * S .)[0, 5]'
-          expected_curr_path(path_prefix + '/S[4, 5]')
+          expected_curr_path("#{path_prefix}/S[4, 5]")
 
           next_event(:visit, 'S => L . | 4') # Event 6
-          expected_path5 = path_prefix + '/S[4, 5]'
+          expected_path5 = "#{path_prefix}/S[4, 5]"
           expect(path_to_s).to eq(expected_path5)
 
           next_event(:visit, 'L. | 4') # Event 7
-          expected_curr_path(path_prefix + '/S[4, 5]/L[4, 5]')
+          expected_curr_path("#{path_prefix}/S[4, 5]/L[4, 5]")
 
           next_event(:visit, 'L => integer . | 4') # Event 8
-          expected_curr_path(path_prefix + '/S[4, 5]/L[4, 5]')
+          expected_curr_path("#{path_prefix}/S[4, 5]/L[4, 5]")
           expected_first_child('integer[4, 5]')
 
           next_event(:visit, 'L => . integer | 4') # Event 9
-          expected_curr_path(path_prefix + '/S[4, 5]/L[4, 5]')
+          expected_curr_path("#{path_prefix}/S[4, 5]/L[4, 5]")
 
           next_event(:visit, '.L | 4') # Event 10
-          expected_curr_path(path_prefix + '/S[4, 5]')
+          expected_curr_path("#{path_prefix}/S[4, 5]")
 
           next_event(:visit, 'S => . L | 4') # Event 11
           expected_curr_parent('S[4, 5]')
-          expected_curr_path(path_prefix + '/S[4, 5]')
+          expected_curr_path("#{path_prefix}/S[4, 5]")
 
           next_event(:visit, '.S | 4') # Event 12
           expected_curr_parent('Alt(S => S * S .)[0, 5]')
@@ -123,73 +123,73 @@ module Rley # Open this namespace to avoid module qualifier prefixes
           expected_curr_path(path_prefix)
 
           next_event(:visit, 'S. | 0') # Event 15
-          expected_curr_path(path_prefix + '/S[0, 3]')
+          expected_curr_path("#{path_prefix}/S[0, 3]")
 
           next_event(:visit, 'S => S + S . | 0') # Event 16
           expected_curr_parent('S[0, 3]')
-          expected_curr_path(path_prefix + '/S[0, 3]')
+          expected_curr_path("#{path_prefix}/S[0, 3]")
 
           next_event(:visit, 'S. | 2') # Event 17
-          expected_curr_path(path_prefix + '/S[0, 3]/S[2, 3]')
+          expected_curr_path("#{path_prefix}/S[0, 3]/S[2, 3]")
 
           next_event(:visit, 'S => L . | 2') # Event 18
-          expected_curr_path(path_prefix + '/S[0, 3]/S[2, 3]')
+          expected_curr_path("#{path_prefix}/S[0, 3]/S[2, 3]")
 
           next_event(:visit, 'L. | 2') # Event 19
-          expected_curr_path(path_prefix + '/S[0, 3]/S[2, 3]/L[2, 3]')
+          expected_curr_path("#{path_prefix}/S[0, 3]/S[2, 3]/L[2, 3]")
 
           next_event(:visit, 'L => integer . | 2') # Event 20
-          expected_curr_path(path_prefix + '/S[0, 3]/S[2, 3]/L[2, 3]')
+          expected_curr_path("#{path_prefix}/S[0, 3]/S[2, 3]/L[2, 3]")
           expected_first_child('integer[2, 3]')
 
           next_event(:visit, 'L => . integer | 2') # Event 21
-          expected_curr_path(path_prefix + '/S[0, 3]/S[2, 3]/L[2, 3]')
+          expected_curr_path("#{path_prefix}/S[0, 3]/S[2, 3]/L[2, 3]")
 
           next_event(:visit, '.L | 2') # Event 22
           expected_curr_parent('S[2, 3]')
-          expected_curr_path(path_prefix + '/S[0, 3]/S[2, 3]')
+          expected_curr_path("#{path_prefix}/S[0, 3]/S[2, 3]")
 
           next_event(:visit, 'S => . L | 2') # Event 23
-          expected_curr_path(path_prefix + '/S[0, 3]/S[2, 3]')
+          expected_curr_path("#{path_prefix}/S[0, 3]/S[2, 3]")
 
           next_event(:visit, '.S | 2') # Event 24
-          expected_curr_path(path_prefix + '/S[0, 3]')
+          expected_curr_path("#{path_prefix}/S[0, 3]")
 
           next_event(:visit, 'S => S + . S | 0') # Event 24
-          expected_curr_path(path_prefix + '/S[0, 3]')
+          expected_curr_path("#{path_prefix}/S[0, 3]")
           expected_first_child('+[1, 2]')
 
           next_event(:visit, 'S => S . + S | 0') # Event 25
-          expected_curr_path(path_prefix + '/S[0, 3]')
+          expected_curr_path("#{path_prefix}/S[0, 3]")
 
           next_event(:visit, 'S. | 0') # Event 27
           expected_curr_parent('S[0, 1]')
-          expected_curr_path(path_prefix + '/S[0, 3]/S[0, 1]')
+          expected_curr_path("#{path_prefix}/S[0, 3]/S[0, 1]")
 
           next_event(:visit, 'S => L . | 0') # Event 28
-          expected_curr_path(path_prefix + '/S[0, 3]/S[0, 1]')
+          expected_curr_path("#{path_prefix}/S[0, 3]/S[0, 1]")
 
           next_event(:visit, 'L. | 0') # Event 29
-          expected_curr_path(path_prefix + '/S[0, 3]/S[0, 1]/L[0, 1]')
+          expected_curr_path("#{path_prefix}/S[0, 3]/S[0, 1]/L[0, 1]")
 
           next_event(:visit, 'L => integer . | 0') # Event 30
-          expected_curr_path(path_prefix + '/S[0, 3]/S[0, 1]/L[0, 1]')
+          expected_curr_path("#{path_prefix}/S[0, 3]/S[0, 1]/L[0, 1]")
           expected_first_child('integer[0, 1]')
 
           next_event(:visit, 'L => . integer | 0') # Event 31
-          expected_curr_path(path_prefix + '/S[0, 3]/S[0, 1]/L[0, 1]')
+          expected_curr_path("#{path_prefix}/S[0, 3]/S[0, 1]/L[0, 1]")
 
           next_event(:visit, '.L | 0') # Event 32
-          expected_curr_path(path_prefix + '/S[0, 3]/S[0, 1]')
+          expected_curr_path("#{path_prefix}/S[0, 3]/S[0, 1]")
 
           next_event(:visit, 'S => . L | 0') # Event 33
-          expected_curr_path(path_prefix + '/S[0, 3]/S[0, 1]')
+          expected_curr_path("#{path_prefix}/S[0, 3]/S[0, 1]")
 
           next_event(:visit, '.S | 0') # Event 34
-          expected_curr_path(path_prefix + '/S[0, 3]')
+          expected_curr_path("#{path_prefix}/S[0, 3]")
 
           next_event(:visit, 'S => . S + S | 0') # Event 35
-          expected_curr_path(path_prefix + '/S[0, 3]')
+          expected_curr_path("#{path_prefix}/S[0, 3]")
 
           next_event(:revisit, '.S | 0') # REVISIT Event 36
           expected_curr_parent('Alt(S => S * S .)[0, 5]')
@@ -210,42 +210,42 @@ module Rley # Open this namespace to avoid module qualifier prefixes
           next_event(:backtrack, 'S. | 0') # BACKTRACK Event 41
 
           expected_curr_path('P[0, 5]/S[0, 5]')
-          
+
           next_event(:visit, 'S => S + S . | 0') # Event 42
           expected_curr_parent('Alt(S => S + S .)[0, 5]')
           path_prefix = 'P[0, 5]/S[0, 5]/Alt(S => S + S .)[0, 5]'
           expected_curr_path(path_prefix)
 
           next_event(:visit, 'S. | 2') # Event 43
-          expected_curr_path(path_prefix + '/S[2, 5]')
+          expected_curr_path("#{path_prefix}/S[2, 5]")
 
           next_event(:visit, 'S => S * S . | 2') # Event 44
-          expected_curr_path(path_prefix + '/S[2, 5]')
-          
+          expected_curr_path("#{path_prefix}/S[2, 5]")
+
           # Up to now everything was running OK.
-          # Next steps are going wrong...          
+          # Next steps are going wrong...
 
           next_event(:revisit, 'S. | 4') # Event 45
-          expected_curr_path(path_prefix + '/S[2, 5]')
+          expected_curr_path("#{path_prefix}/S[2, 5]")
           expected_first_child('S[4, 5]')
-          
+
           next_event(:visit, 'S => S * . S | 2') #  Event 46
-          expected_curr_path(path_prefix + '/S[2, 5]')
+          expected_curr_path("#{path_prefix}/S[2, 5]")
           expected_first_child('*[3, 4]')
 
           next_event(:visit, 'S => S . * S | 2') #  Event 47
-          expected_curr_path(path_prefix + '/S[2, 5]')
-          
+          expected_curr_path("#{path_prefix}/S[2, 5]")
+
           next_event(:revisit, 'S. | 2') #  Event 48
-          expected_curr_path(path_prefix + '/S[2, 5]')
+          expected_curr_path("#{path_prefix}/S[2, 5]")
 
           next_event(:visit, 'S => . S * S | 2') #  Event 49
-          expected_curr_path(path_prefix + '/S[2, 5]')
+          expected_curr_path("#{path_prefix}/S[2, 5]")
 
           next_event(:revisit, '.S | 2') #  Event 50
           expected_curr_parent('Alt(S => S + S .)[0, 5]')
           expected_curr_path(path_prefix)
-          
+
           # TODO: review previous and next steps...
 
           next_event(:revisit, 'S => S + . S | 0') #  Event 51
@@ -269,7 +269,7 @@ module Rley # Open this namespace to avoid module qualifier prefixes
           expected_curr_path('P[0, 5]')
 
           next_event(:revisit, '.P | 0') #  Event 57
-          expected_curr_path('')           
+          expected_curr_path('')
         end
       end # context
     end # describe

data/spec/rley/parse_rep/ast_builder_spec.rb

@@ -12,16 +12,15 @@ require_relative '../support/expectation_helper'
 require_relative '../support/grammar_b_expr_helper'
 require_relative '../support/grammar_arr_int_helper'
 
-
 module Rley # This module is used as a namespace
   module ParseRep # This module is used as a namespace
     ArrayNode = Struct.new(:children) do
-      def initialize()
+      def initialize
         super
         self.children = []
       end
 
-      def interpret()
+      def interpret
         return children.map(&:interpret)
       end
     end
@@ -33,17 +32,18 @@ module Rley # This module is used as a namespace
         self.position = aPosition
       end
 
-      def interpret()
+      def interpret
         value
       end
     end
 
+    # rubocop: disable Naming/VariableNumber
     class ASTBuilder < ASTBaseBuilder
       Terminal2NodeClass = {
         'integer' => IntegerNode
       }.freeze
 
-      def terminal2node()
+      def terminal2node
         Terminal2NodeClass
       end
 
@@ -80,10 +80,10 @@ module Rley # This module is used as a namespace
         return node
       end
     end # class
+    # rubocop: enable Naming/VariableNumber
   end # module
 end # module
 
-
 module Rley # Open this namespace to avoid module qualifier prefixes
   module ParseRep
     describe ASTBuilder do

data/spec/rley/parse_rep/cst_builder_spec.rb

@@ -71,8 +71,8 @@ module Rley # Open this namespace to avoid module qualifier prefixes
         end
       end # context
 
-      
-      
+
+
       context 'Parse tree construction (no null symbol):' do
         before(:each) do
           parser = Parser::GFGEarleyParser.new(sample_grammar)
@@ -119,7 +119,7 @@ module Rley # Open this namespace to avoid module qualifier prefixes
         # Event: revisit .S | 0 0
         # Event: visit P => . S | 0 0
         # Event: visit .P | 0 0
-        
+
         it 'should react to a first end event' do
           event = @walker.next
           expect { subject.receive_event(*event) }.not_to raise_error
@@ -428,10 +428,10 @@ module Rley # Open this namespace to avoid module qualifier prefixes
           next_event('visit P => . arr | 0 0')
           expect(stack).to be_empty
           expect(@instance.result).not_to be_nil
-          
+
           next_event('visit .P | 0 0')
           expect(stack).to be_empty
-          expect(@instance.result).not_to be_nil          
+          expect(@instance.result).not_to be_nil
         end
       end # context
     end # describe

data/spec/rley/parse_rep/groucho_spec.rb

@@ -25,41 +25,41 @@ module Rley # Open this namespace to avoid module qualifier prefixes
         builder = Rley::Syntax::GrammarBuilder.new do
           add_terminals('N', 'V', 'Pro')  # N(oun), V(erb), Pro(noun)
           add_terminals('Det', 'P')       # Det(erminer), P(reposition)
-          rule 'S' => %w[NP VP]
-          rule 'NP' => %w[Det N]
-          rule 'NP' => %w[Det N PP]
+          rule 'S' => 'NP VP'
+          rule 'NP' => 'Det N'
+          rule 'NP' => 'Det N PP'
           rule 'NP' => 'Pro'
-          rule 'VP' => %w[V NP]
-          rule 'VP' => %w[VP PP]
-          rule 'PP' => %w[P NP]
+          rule 'VP' => 'V NP'
+          rule 'VP' => 'VP PP'
+          rule 'PP' => 'P NP'
         end
         builder.grammar
       end
 
       # The lexicon is just a Hash with pairs of the form:
       # word => terminal symbol name
-      Groucho_lexicon = {
-        'elephant' => 'N',
-        'pajamas' => 'N',
-        'shot' => 'V',
-        'I' => 'Pro',
-        'an' => 'Det',
-        'my' => 'Det',
-        'in' => 'P'
-      }.freeze
+      let(:groucho_lexicon) do
+        {
+          'elephant' => 'N',
+          'pajamas' => 'N',
+          'shot' => 'V',
+          'I' => 'Pro',
+          'an' => 'Det',
+          'my' => 'Det',
+          'in' => 'P'
+        }
+      end
 
       # Highly simplified tokenizer implementation.
       def tokenizer(aText, aGrammar)
         pos = Rley::Lexical::Position.new(1, 2) # Dummy position
-        tokens = aText.scan(/\S+/).map do |word|
-          term = Groucho_lexicon[word]
+        aText.scan(/\S+/).map do |word|
+          term = groucho_lexicon[word]
           raise StandardError, "Word '#{word}' not found in lexicon" if term.nil?
 
           terminal = aGrammar.name2symbol[term]
           Rley::Lexical::Token.new(word, terminal, pos)
         end
-
-        return tokens
       end
 
       let(:sentence_tokens) do
@@ -73,11 +73,11 @@ module Rley # Open this namespace to avoid module qualifier prefixes
       end
 
       # Emit a text representation of the current path.
-      def path_to_s()
+      def path_to_s
         text_parts = subject.curr_path.map do |path_element|
           path_element.to_string(0)
         end
-        return text_parts.join('/')
+        text_parts.join('/')
       end
 
       def next_event(eventType, anEntryText)

data/spec/rley/parse_rep/parse_forest_builder_spec.rb

@@ -26,12 +26,12 @@ module Rley # Open this namespace to avoid module qualifier prefixes
           builder = Syntax::GrammarBuilder.new do
             add_terminals('a', 'b')
             rule 'Phi' => 'S'
-            rule 'S' => %w[A T]
-            rule 'S' => %w[a T]
+            rule 'S' => 'A T'
+            rule 'S' => 'a T'
             rule 'A' => 'a'
-            rule 'A' => %w[B A]
+            rule 'A' => 'B A'
             rule 'B' => []
-            rule 'T' => %w[b b b]
+            rule 'T' => 'b b b'
           end
           builder.grammar
       end
@@ -48,11 +48,11 @@ module Rley # Open this namespace to avoid module qualifier prefixes
       subject { ParseForestBuilder.new(sample_tokens) }
 
       # Emit a text representation of the current path.
-      def path_to_s()
+      def path_to_s
         text_parts = subject.curr_path.map do |path_element|
           path_element.to_string(0)
         end
-        return text_parts.join('/')
+        text_parts.join('/')
       end
 
       def next_event(eventType, anEntryText)
@@ -209,7 +209,7 @@ module Rley # Open this namespace to avoid module qualifier prefixes
           path_prefix = 'Phi[0, 4]/S[0, 4]/Alt(S => A T .)[0, 4]/A[0, 1]/'
 
           next_event(:visit, 'A => a . | 0') # Event 21
-          expected_curr_path(path_prefix + 'Alt(A => a .)[0, 1]')
+          expected_curr_path("#{path_prefix}Alt(A => a .)[0, 1]")
           expect(subject.curr_path[-2].refinement).to eq(:or)
 
           next_event(:visit, 'A => . a | 0') # Event 22
@@ -244,24 +244,24 @@ module Rley # Open this namespace to avoid module qualifier prefixes
           path_prefix = 'Phi[0, 4]/S[0, 4]/Alt(S => A T .)[0, 4]/A[0, 1]/'
 
           next_event(:visit, 'A => B A . | 0') # Event 29
-          expected_curr_path(path_prefix + 'Alt(A => B A .)[0, 1]')
+          expected_curr_path("#{path_prefix}Alt(A => B A .)[0, 1]")
 
           next_event(:revisit, 'A. | 0') # REVISIT Event 30
-          expected_curr_path(path_prefix + 'Alt(A => B A .)[0, 1]')
+          expected_curr_path("#{path_prefix}Alt(A => B A .)[0, 1]")
 
           next_event(:visit, 'A => B . A | 0') # Event 31
-          expected_curr_path(path_prefix + 'Alt(A => B A .)[0, 1]')
+          expected_curr_path("#{path_prefix}Alt(A => B A .)[0, 1]")
 
           next_event(:visit, 'B. | 0') # Event 32
-          expected_curr_path(path_prefix + 'Alt(A => B A .)[0, 1]/B[0, 0]')
+          expected_curr_path("#{path_prefix}Alt(A => B A .)[0, 1]/B[0, 0]")
 
           # Entry with empty production!
           next_event(:visit, 'B => . | 0') # Event 33
-          expected_curr_path(path_prefix + 'Alt(A => B A .)[0, 1]/B[0, 0]')
+          expected_curr_path("#{path_prefix}Alt(A => B A .)[0, 1]/B[0, 0]")
           expected_first_child('_[0, 0]')
 
           next_event(:visit, '.B | 0') # Event 34
-          expected_curr_path(path_prefix + 'Alt(A => B A .)[0, 1]')
+          expected_curr_path("#{path_prefix}Alt(A => B A .)[0, 1]")
 
           next_event(:visit, 'A => . B A | 0') # Event 35
           expected_curr_path('Phi[0, 4]/S[0, 4]/Alt(S => A T .)[0, 4]/A[0, 1]')
@@ -360,46 +360,46 @@ module Rley # Open this namespace to avoid module qualifier prefixes
           next_event(:revisit, '.Nominal | 3') # REVISIT Event 15
           expected_curr_path('S[0, 5]/VP[1, 5]/NP[2, 5]')
 
-          next_event(:visit, 'NP => Determiner . Nominal | 2') # Event 16 
+          next_event(:visit, 'NP => Determiner . Nominal | 2') # Event 16
           expected_curr_path('S[0, 5]/VP[1, 5]/NP[2, 5]')
           expected_first_child('Determiner[2, 3]')
 
-          next_event(:visit, 'NP => . Determiner Nominal | 2') # Event 17 
+          next_event(:visit, 'NP => . Determiner Nominal | 2') # Event 17
           expected_curr_path('S[0, 5]/VP[1, 5]/NP[2, 5]')
 
-          next_event(:visit, '.NP | 2') # Event 18 
+          next_event(:visit, '.NP | 2') # Event 18
           expected_curr_path('S[0, 5]/VP[1, 5]')
 
-          next_event(:visit, 'VP => Verb . NP | 1') # Event 19 
+          next_event(:visit, 'VP => Verb . NP | 1') # Event 19
           expected_curr_path('S[0, 5]/VP[1, 5]')
           expected_first_child('Verb[1, 2]')
 
-          next_event(:visit, 'VP => . Verb NP | 1') # Event 20 
+          next_event(:visit, 'VP => . Verb NP | 1') # Event 20
           expected_curr_path('S[0, 5]/VP[1, 5]')
 
-          next_event(:visit, '.VP | 1') # Event 21 
+          next_event(:visit, '.VP | 1') # Event 21
           expected_curr_path('S[0, 5]')
 
-          next_event(:visit, 'S => NP . VP | 0') # Event22 
+          next_event(:visit, 'S => NP . VP | 0') # Event22
           expected_curr_path('S[0, 5]')
 
-          next_event(:visit, 'NP. | 0') # Event 23 
+          next_event(:visit, 'NP. | 0') # Event 23
           expected_curr_path('S[0, 5]/NP[0, 1]')
 
-          next_event(:visit, 'NP => Pronoun . | 0') # Event 24 
+          next_event(:visit, 'NP => Pronoun . | 0') # Event 24
           expected_curr_path('S[0, 5]/NP[0, 1]')
           expected_first_child('Pronoun[0, 1]')
 
-          next_event(:visit, 'NP => . Pronoun | 0') # Event 25 
+          next_event(:visit, 'NP => . Pronoun | 0') # Event 25
           expected_curr_path('S[0, 5]/NP[0, 1]')
 
-          next_event(:visit, '.NP | 0') # Event 26 
+          next_event(:visit, '.NP | 0') # Event 26
           expected_curr_path('S[0, 5]')
 
-          next_event(:visit, 'S => . NP VP | 0') # Event 27 
+          next_event(:visit, 'S => . NP VP | 0') # Event 27
           expected_curr_path('S[0, 5]')
 
-          next_event(:visit, '.S | 0') # Event28 
+          next_event(:visit, '.S | 0') # Event28
           expected_curr_path('')
         end
       end # context