rley 0.7.03 → 0.7.08

data/lib/rley/parse_rep/parse_forest_factory.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'parse_rep_creator'
 require_relative 'parse_forest_builder'
 
@@ -13,13 +15,13 @@ module Rley # This module is used as a namespace
       def builder(aParseResult, _builder = nil)
         ParseForestBuilder.new(aParseResult.tokens)
       end
-      
+
       # When an end vertex is re-visited then jump
       # its corresponding start vertex. This behaviour
       # makes sense for sharing nodes.
-      def jump_to_start()
+      def jump_to_start
         true
-      end       
+      end
     end # class
   end # module
 end # module

data/lib/rley/parse_rep/parse_rep_creator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../parser/parse_walker_factory'
 
 module Rley # This module is used as a namespace
@@ -5,18 +7,18 @@ module Rley # This module is used as a namespace
     # Utility class that helps to create a representation of a parse from
     # a given Parsing object.
     class ParseRepCreator
-      # @return [Rley::Parser::GFGParsing] 
+      # @return [Rley::Parser::GFGParsing]
       #  Link to Parsing object (= results of recognizer)
       attr_reader(:parsing)
-      
+
       # Constructor. Creates and initialize a ParseRepCreator instance.
       # @return [ParseRepCreator]
       def initialize(aParsingResult)
         @parsing = aParsingResult
-      end      
-      
+      end
+
       # Factory method that produces the representation of the parse.
-      # @return [Rley::PTree::ParseTree, Rley::SPPF::ParseForest] 
+      # @return [Rley::PTree::ParseTree, Rley::SPPF::ParseForest]
       #   The parse representation.
       def create(aBuilder = nil)
         a_walker = walker(parsing)
@@ -30,15 +32,20 @@ module Rley # This module is used as a namespace
           end
         rescue StopIteration
           # Do nothing: gobble the exception
+        rescue StandardError => e
+          if e.message =~ /^Ambiguous/
+            $stderr.puts parsing
+          end
+          raise e
         end
-        
+
         a_builder.done!
 
-        return a_builder.result
+        a_builder.result
       end
-      
+
       private
-      
+
       # Create a Parsing walker, that is, an object
       # that will iterate over the relevant nodes (= parsing entries)
       # of a GFGParsing
@@ -51,13 +58,11 @@ module Rley # This module is used as a namespace
 
       # By default, when a end vertex is re-visited don't jump
       # its corresponding start vertex.
-      def jump_to_start()
+      def jump_to_start
         false
       end
-      
     end # class
   end # module
 end # module
 
-# End of file 
-   
+# End of file

data/lib/rley/parse_rep/parse_tree_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../lexical/token_range'
 require_relative '../syntax/terminal'
 require_relative '../syntax/non_terminal'
@@ -24,7 +26,7 @@ module Rley # This module is used as a namespace
     end # Struct
 
 
-    # The purpose of a ParseTreeBuilder is to build piece by piece 
+    # The purpose of a ParseTreeBuilder is to build piece by piece
     # a parse tree from a sequence of input tokens and
     # visit events produced by walking over a GFGParsing object.
     # Uses the Builder GoF pattern.
@@ -46,11 +48,11 @@ module Rley # This module is used as a namespace
         @stack = []
         @dummy_node = Object.new.freeze
       end
-      
+
       # Notify the builder that the parse tree construction is complete.
-      def done!()
+      def done!
         result.done!
-      end      
+      end
 
       # Receive events resulting from a visit of GFGParsing object.
       # These events are produced by a specialized Enumerator created
@@ -76,23 +78,21 @@ module Rley # This module is used as a namespace
       protected
 
       # Return the stack
-      def stack()
-        @stack
-      end
+      attr_reader(:stack)
 
       # Overriding method.
       # Create a parse tree object with given
       # node as root node.
       def create_tree(aRootNode)
         raise StandardError, 'Root node of parse tree is nil!' if aRootNode.nil?
-        
+
         return Rley::PTree::ParseTree.new(aRootNode)
-      end      
+      end
 
       private
 
       # Return the top of stack element.
-      def tos()
+      def tos
         @stack.last
       end
 
@@ -134,7 +134,7 @@ module Rley # This module is used as a namespace
         case anEvent
           when :visit, :revisit
             dot_pos = anEntry.vertex.dotted_item.position
-            if dot_pos.zero? || dot_pos < 0
+            if dot_pos.zero? || dot_pos.negative?
               # Check for pattern: N => alpha* .
               process_exit_entry(anEntry, anIndex) if anEntry.exit_entry?
 
@@ -207,7 +207,7 @@ module Rley # This module is used as a namespace
       # @param anEntry [ParseEntry] The entry being visited
       def terminal_before_dot?(anEntry)
         prev_symbol = anEntry.prev_symbol
-        return prev_symbol && prev_symbol.terminal?
+        prev_symbol&.terminal?
       end
 
       # A terminal symbol was detected at left of dot.
@@ -239,7 +239,7 @@ module Rley # This module is used as a namespace
       # array at that position.
       # If the position is nil, then the node will be placed at the position of
       # the rightmost nil element in children array.
-      def place_TOS_child(aNode, aRHSPos)       
+      def place_TOS_child(aNode, aRHSPos)
         if aRHSPos.nil?
           # Retrieve index of most rightmost nil child...
           pos = tos.children.rindex { |child| child == @dummy_node }
@@ -247,7 +247,7 @@ module Rley # This module is used as a namespace
         else
           pos = aRHSPos
         end
-        
+
         tos.children[pos] = aNode
       end
 
@@ -260,7 +260,7 @@ module Rley # This module is used as a namespace
             non_terminal = anEntry.vertex.lhs
         end
 
-        return non_terminal
+        non_terminal
       end
     end # class
   end # module

data/lib/rley/parse_rep/parse_tree_factory.rb

@@ -1,25 +1,27 @@
-require_relative 'parse_rep_creator'
-# require_relative 'parse_tree_builder' # TODO remove this line
-require_relative 'cst_builder'
-
-module Rley # This module is used as a namespace
-  module ParseRep # This module is used as a namespace
-    # Utility class that helps to create a ParseTree from
-    # a given Parsing object.
-    class ParseTreeFactory < ParseRepCreator
-      protected
-
-      # Create a Builder, that is, an object
-      # that will create piece by piece the forest
-      def builder(aParseResult, aBuilder = nil)
-        if aBuilder
-          aBuilder.new(aParseResult.tokens)
-        else
-          CSTBuilder.new(aParseResult.tokens)
-        end
-      end     
-    end # class
-  end # module
-end # module
-
-# End of file
+# frozen_string_literal: true
+
+require_relative 'parse_rep_creator'
+# require_relative 'parse_tree_builder' # TODO remove this line
+require_relative 'cst_builder'
+
+module Rley # This module is used as a namespace
+  module ParseRep # This module is used as a namespace
+    # Utility class that helps to create a ParseTree from
+    # a given Parsing object.
+    class ParseTreeFactory < ParseRepCreator
+      protected
+
+      # Create a Builder, that is, an object
+      # that will create piece by piece the forest
+      def builder(aParseResult, aBuilder = nil)
+        if aBuilder
+          aBuilder.new(aParseResult.tokens)
+        else
+          CSTBuilder.new(aParseResult.tokens)
+        end
+      end
+    end # class
+  end # module
+end # module
+
+# End of file

data/lib/rley/parse_tree_visitor.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Rley # This module is used as a namespace
   # A visitor class dedicated in the visit of a parse tree.
   # It combines the Visitor and Observer patterns.
@@ -35,7 +37,7 @@ module Rley # This module is used as a namespace
     end
 
     # The signal to begin the visit of the parse tree.
-    def start()
+    def start
       ptree.accept(self)
     end
 

data/lib/rley/parser/error_reason.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Rley # Module used as a namespace
   module Parser # This module is used as a namespace
     # Abstract class. An instance represents an explanation describing
@@ -15,7 +17,7 @@ module Rley # Module used as a namespace
       end
 
       # @return [String] the result of invoking reason.to_s
-      def message()
+      def message
         return to_s
       end
 
@@ -25,11 +27,10 @@ module Rley # Module used as a namespace
       end
     end # class
 
-
     # This parse error occurs when no input for parsing was provided
     # while the grammar requires some non-empty input.
     class NoInput < ErrorReason
-      def initialize()
+      def initialize
         super(0)
       end
 
@@ -59,7 +60,7 @@ module Rley # Module used as a namespace
 
       protected
 
-      def position()
+      def position
         return last_token.position if last_token.respond_to?(:position)
 
         rank + 1
@@ -68,13 +69,13 @@ module Rley # Module used as a namespace
       # Emit a text explaining the expected terminal symbols
       def expectations
         term_names = expected_terminals.map(&:name)
-        explain = 'Expected one '
+        explain = +'Expected one '
         explain << if expected_terminals.size > 1
                      "of: ['#{term_names.join("', '")}']"
                    else
                      "'#{term_names[0]}'"
                    end
-        return explain
+        explain
       end
     end # class
 
@@ -83,7 +84,7 @@ module Rley # Module used as a namespace
     class UnexpectedToken < ExpectationNotMet
       # Returns the reason's message.
       def to_s
-        err_msg = "Syntax error at or near token #{position} "
+        err_msg = +"Syntax error at or near token #{position} "
         err_msg << ">>>#{last_token.lexeme}<<<\n"
         err_msg << expectations
         err_msg << ", found a '#{last_token.terminal}' instead."
@@ -97,7 +98,7 @@ module Rley # Module used as a namespace
     class PrematureInputEnd < ExpectationNotMet
       # Returns the reason's message.
       def to_s
-        err_msg = "Premature end of input after '#{last_token.lexeme}'"
+        err_msg = +"Premature end of input after '#{last_token.lexeme}'"
         err_msg << " at position #{position}\n"
         err_msg << "#{expectations}."
 

data/lib/rley/parser/gfg_chart.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'parse_entry'
 require_relative 'parse_entry_set'
 
@@ -14,32 +16,30 @@ module Rley # This module is used as a namespace
 
       # @param aGFGraph [GFG::GrmFlowGraph] The GFG for the grammar in use.
       def initialize(aGFGraph)
-        @sets = [ ParseEntrySet.new ]
+        @sets = [ParseEntrySet.new]
         push_entry(aGFGraph.start_vertex, 0, 0, :start_rule)
       end
 
       # @return [Syntax::NonTerminal] the start symbol of the grammar.
-      def start_symbol()
-        return sets.first.entries[0].vertex.non_terminal
+      def start_symbol
+        sets.first.entries[0].vertex.non_terminal
       end
 
       # @param index [Integer]
       # @return [ParseEntrySet] Access the entry set at given position.
       def [](index)
-        return sets[index]
+        sets[index]
       end
 
       # Return the index value of the last non-empty entry set.
       # @return [Integer]
-      def last_index()
+      def last_index
         first_empty = sets.find_index(&:empty?)
-        index = if first_empty.nil?
-                  sets.size - 1
-                else
-                  first_empty.zero? ? 0 : first_empty - 1
-                end
-
-        return index
+        if first_empty.nil?
+          sets.size - 1
+        else
+          first_empty.zero? ? 0 : first_empty - 1
+        end
       end
 
       # Push a parse entry for the chart entry with given index
@@ -55,23 +55,21 @@ module Rley # This module is used as a namespace
         if anIndex == sets.size
           err_msg = "Internal error: unexpected push reason #{reason}"
           raise StandardError, err_msg if reason != :scan_rule
-          
-          add_entry_set 
-        end
-        pushed = self[anIndex].push_entry(new_entry)
 
-        return pushed
+          add_entry_set
+        end
+        self[anIndex].push_entry(new_entry)
       end
 
       # Retrieve the first parse entry added to this chart
       # @return [ParseEntry]
-      def initial_entry()
-        return sets[0].first
+      def initial_entry
+        sets[0].first
       end
 
       # Retrieve the entry that corresponds to a complete and successful parse
       # @return [ParseEntry]
-      def accepting_entry()
+      def accepting_entry
         # Success can be detected as follows:
         # The last chart entry set has at least one complete parse entry
         # for the start symbol with an origin == 0
@@ -91,12 +89,46 @@ module Rley # This module is used as a namespace
           entry.origin.zero? && entry.vertex.non_terminal == start_symbol
         end
 
-        return success_entries.first
+        success_entries.first
+      end
+
+      # @return [Integer] The number of states.
+      def count_states
+        sets.size
+      end
+
+      # @return [Integer] The total number of entries.
+      def count_entries
+        # rubocop: disable Lint/UselessAssignment
+        sets.reduce(0) do |sub_result, a_set|
+          sub_result += a_set.size
+        end
+      end
+
+      # @return [Integer] The total number of edges.
+      def count_edges
+        sets.reduce(0) do |sub_result, a_set|
+          sub_result += a_set.count_edges
+        end
+      end
+      # rubocop: enable Lint/UselessAssignment
+
+      # @ return [String] A human-readable representation of the chart.
+      def to_s
+        result = +''
+        sets.each_with_index do |a_set, i|
+          result << "State[#{i}]\n"
+          a_set.entries.each do |item|
+            result << "  #{item}\n"
+          end
+        end
+
+        result
       end
 
       private
 
-      def add_entry_set()
+      def add_entry_set
          @sets << ParseEntrySet.new
       end
     end # class