rkneufeld-fuzzy-realty 0.3.0 → 0.3.1

data/VERSION.yml

@@ -1,4 +1,4 @@
 --- 
 :major: 0
 :minor: 3
-:patch: 0
+:patch: 1

data/lib/fuzzy_realty.rb

@@ -4,6 +4,9 @@ require 'weights.rb'
 require 'rulebase.rb'
 require 'rulebase.rb'
 
+# If set this flag will turn on debugging printouts
+#$debug = true;
+
 module FuzzyRealty
   class ExpertSystem
     def self.scores(listings, query)

data/lib/rulebase.rb

@@ -9,14 +9,14 @@ module FuzzyRealty
     # reduced factor.
     :price => 
       lambda do |listing,param| 
-        puts "Called price"
+        puts "Called price" if $debug
         actual,desired = listing.price.to_f, param.desired
         result = if (desired*0.90..desired*1.05) === actual
           1.0
         else 
           1 - ((desired - actual) / actual).abs
         end
-        puts result
+        puts result if $debug
         result
       end,
   
@@ -24,15 +24,15 @@ module FuzzyRealty
     ## Currently just return 1 if exact, 0 otherwise
     :location => 
       lambda do |listing,param|
-        puts "Called location"
+        puts "Called location" if $debug
         # Perform a quick lookup (i.e. FuzzyRealty::LOCN[:A][:A] => 1.0)
-        puts FuzzyRealty::LOCN[param.desired.to_sym][listing.location.to_sym]
+        puts FuzzyRealty::LOCN[param.desired.to_sym][listing.location.to_sym] if $debug
         FuzzyRealty::LOCN[param.desired.to_sym][listing.location.to_sym]
       end,
       
     :sqft => 
       lambda do |listing,param|
-                puts "Called sqft"
+                puts "Called sqft" if $debug
         actual, desired = listing.sqft, param.desired
         result = if (actual + 50) >= desired
           1.0
@@ -43,17 +43,17 @@ module FuzzyRealty
         else
           0.0
         end
-        puts result
+        puts result if $debug
         result
       end,
     # Style's follow lookup table similar to Location
 
     :style => 
       lambda do |listing,param|
-                puts "Called style"
+                puts "Called style" if $debug
         desired = FuzzyRealty::STYLE[:Symbol][param.desired]
         actual  = FuzzyRealty::STYLE[:Symbol][listing.style]
-        puts FuzzyRealty::STYLE[desired][actual]
+        puts FuzzyRealty::STYLE[desired][actual] if $debug
         FuzzyRealty::STYLE[desired][actual]
       end
   }

data/test/fuzzy_realty_test.rb

@@ -10,6 +10,7 @@ class FuzzyRealtyTest < Test::Unit::TestCase
           :location => 'A',
           :style =>  'Condominium'
         })
+      @listing = [@listing]
     end
     
     should "score perfect for perfect house" do
@@ -21,10 +22,48 @@ class FuzzyRealtyTest < Test::Unit::TestCase
       params << FuzzyRealty::Parameter.new(:sqft,1575,true)
       query  = FuzzyRealty::Query.new(params)
 
-      scores = FuzzyRealty::ExpertSystem.scores([@listing],query)
-      puts "%.2f" % scores[0][:score] + "\t\t#{scores[0][:listing].inspect}"
+      scores = FuzzyRealty::ExpertSystem.scores(@listing,query)
+#      puts "%.2f" % scores[0][:score] + "\t\t#{scores[0][:listing].inspect}"
       assert_equal(scores[0][:score], FuzzyRealty.max_score)
     end
+    
+    should "score zero for no parameters" do
+      params = []
+      query = FuzzyRealty::Query.new(params)
+      scores = FuzzyRealty::ExpertSystem.scores(@listing,query)
+      assert_equal(scores[0][:score], 0)
+    end
+    
+    context "for individual parameters" do
+      should "score correctly for style" do
+        params = []
+        params << FuzzyRealty::Parameter.new(:style,"Condominium",true)
+        query = FuzzyRealty::Query.new(params)
+        scores = FuzzyRealty::ExpertSystem.scores(@listing,query)
+        assert_equal(scores[0][:score], FuzzyRealty::WEIGHTS[:style])
+      end
+      should "score correctly for sqft" do
+        params = []
+        params << FuzzyRealty::Parameter.new(:sqft,1575,true)
+        query = FuzzyRealty::Query.new(params)
+        scores = FuzzyRealty::ExpertSystem.scores(@listing,query)
+        assert_equal(scores[0][:score], FuzzyRealty::WEIGHTS[:sqft])
+      end
+      should "score correctly for price" do
+        params = []
+        params << FuzzyRealty::Parameter.new(:price,250_000,true)
+        query = FuzzyRealty::Query.new(params)
+        scores = FuzzyRealty::ExpertSystem.scores(@listing,query)
+        assert_equal(scores[0][:score], FuzzyRealty::WEIGHTS[:price])
+      end
+      should "score correctly for location" do
+        params = []
+        params << FuzzyRealty::Parameter.new(:location, 'A',true)
+        query = FuzzyRealty::Query.new(params)
+        scores = FuzzyRealty::ExpertSystem.scores(@listing,query)
+        assert_equal(scores[0][:score], FuzzyRealty::WEIGHTS[:location])
+      end
+    end
   end
   
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: rkneufeld-fuzzy-realty
 version: !ruby/object:Gem::Version 
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors: 
 - Ryan Neufeld