rkh-bundler 1.2.0.pre

data/man/index.txt

@@ -0,0 +1,6 @@
+Gemfile(5)         gemfile.5
+bundle-install     bundle-install.1
+bundle-update      bundle-update.1
+bundle-package     bundle-package.1
+bundle-exec        bundle-exec.1
+bundle-config      bundle-config.1

data/spec/bundler/dsl_spec.rb

@@ -0,0 +1,48 @@
+require 'spec_helper'
+
+describe Bundler::Dsl do
+  before do
+    @rubygems = mock("rubygems")
+    Bundler::Source::Rubygems.stub(:new){ @rubygems }
+  end
+
+  describe '#_normalize_options' do
+    it "should convert :github to :git" do
+      subject.gem("sparks", :github => "indirect/sparks")
+      github_uri = "git://github.com/indirect/sparks.git"
+      subject.dependencies.first.source.uri.should == github_uri
+    end
+
+    it "should convert 'rails' to 'rails/rails'" do
+      subject.gem("rails", :github => "rails")
+      github_uri = "git://github.com/rails/rails.git"
+      subject.dependencies.first.source.uri.should == github_uri
+    end
+  end
+
+  describe '#method_missing' do
+    it 'should raise an error for unknown DSL methods' do
+      Bundler.should_receive(:read_file).with("Gemfile").and_return("unknown")
+      error_msg = "Undefined local variable or method `unknown'" \
+        " for Gemfile\\s+from Gemfile:1"
+      lambda{ subject.eval_gemfile("Gemfile") }.
+        should raise_error(Bundler::GemfileError, Regexp.new(error_msg))
+    end
+  end
+
+  describe "#eval_gemfile" do
+    it "handles syntax errors with a useful message" do
+      Bundler.should_receive(:read_file).with("Gemfile").and_return("}")
+      lambda{ subject.eval_gemfile("Gemfile") }.
+        should raise_error(Bundler::GemfileError, /Gemfile syntax error/)
+    end
+  end
+
+  describe "syntax errors" do
+    it "should raise a Bundler::GemfileError" do
+      gemfile "gem 'foo', :path => /unquoted/string/syntax/error"
+      lambda { Bundler::Dsl.evaluate(bundled_app("Gemfile"), nil, true) }.
+        should raise_error(Bundler::GemfileError)
+    end
+  end
+end

data/spec/bundler/gem_helper_spec.rb

@@ -0,0 +1,174 @@
+require "spec_helper"
+require 'rake'
+require 'bundler/gem_helper'
+
+describe "Bundler::GemHelper tasks" do
+  context "determining gemspec" do
+    it "interpolates the name when there is only one gemspec" do
+      bundle 'gem test'
+      app = bundled_app("test")
+      helper = Bundler::GemHelper.new(app.to_s)
+      helper.gemspec.name.should == 'test'
+    end
+
+    it "interpolates the name for a hidden gemspec" do
+      bundle 'gem test'
+      app = bundled_app("test")
+      FileUtils.mv app.join('test.gemspec'), app.join('.gemspec')
+      helper = Bundler::GemHelper.new(app.to_s)
+      helper.gemspec.name.should == 'test'
+    end
+
+    it "should fail when there is no gemspec" do
+      bundle 'gem test'
+      app = bundled_app("test")
+      FileUtils.rm(File.join(app.to_s, 'test.gemspec'))
+      proc { Bundler::GemHelper.new(app.to_s) }.should raise_error(/Unable to determine name/)
+    end
+
+    it "should fail when there are two gemspecs and the name isn't specified" do
+      bundle 'gem test'
+      app = bundled_app("test")
+      File.open(File.join(app.to_s, 'test2.gemspec'), 'w') {|f| f << ''}
+      proc { Bundler::GemHelper.new(app.to_s) }.should raise_error(/Unable to determine name/)
+    end
+
+    it "handles namespaces and converting to CamelCase" do
+      bundle 'gem test-foo_bar'
+      lib = bundled_app('test-foo_bar').join('lib/test-foo_bar.rb').read
+      lib.should include("module Test")
+      lib.should include("module FooBar")
+    end
+  end
+
+  context "gem management" do
+    def mock_confirm_message(message)
+      Bundler.ui.should_receive(:confirm).with(message)
+    end
+
+    def mock_build_message
+      mock_confirm_message "test 0.0.1 built to pkg/test-0.0.1.gem"
+    end
+
+    before(:each) do
+      bundle 'gem test'
+      @app = bundled_app("test")
+      @gemspec = File.read("#{@app.to_s}/test.gemspec")
+      File.open("#{@app.to_s}/test.gemspec", 'w'){|f| f << @gemspec.gsub('TODO: ', '') }
+      @helper = Bundler::GemHelper.new(@app.to_s)
+    end
+
+    it "uses a shell UI for output" do
+      Bundler.ui.should be_a(Bundler::UI::Shell)
+    end
+
+    describe 'install_tasks' do
+      before(:each) do
+        @saved, Rake.application = Rake.application, Rake::Application.new
+      end
+
+      after(:each) do
+        Rake.application = @saved
+      end
+
+      it "defines Rake tasks" do
+        names = %w[build install release]
+
+        names.each { |name|
+          proc { Rake.application[name] }.should raise_error(/Don't know how to build task/)
+        }
+
+        @helper.install
+
+        names.each { |name|
+          proc { Rake.application[name] }.should_not raise_error
+          Rake.application[name].should be_instance_of Rake::Task
+        }
+      end
+
+      it "provides a way to access the gemspec object" do
+        @helper.install
+        Bundler::GemHelper.gemspec.name.should == 'test'
+      end
+    end
+
+    describe 'build' do
+      it "builds" do
+        mock_build_message
+        @helper.build_gem
+        bundled_app('test/pkg/test-0.0.1.gem').should exist
+      end
+
+      it "raises an appropriate error when the build fails" do
+        # break the gemspec by adding back the TODOs...
+        File.open("#{@app.to_s}/test.gemspec", 'w'){|f| f << @gemspec }
+        proc { @helper.build_gem }.should raise_error(/TODO/)
+      end
+    end
+
+    describe 'install' do
+      it "installs" do
+        mock_build_message
+        mock_confirm_message "test (0.0.1) installed"
+        @helper.install_gem
+        bundled_app('test/pkg/test-0.0.1.gem').should exist
+        %x{gem list}.should include("test (0.0.1)")
+      end
+
+      it "raises an appropriate error when the install fails" do
+        @helper.should_receive(:build_gem) do
+          # write an invalid gem file, so we can simulate install failure...
+          FileUtils.mkdir_p(File.join(@app.to_s, 'pkg'))
+          path = "#{@app.to_s}/pkg/test-0.0.1.gem"
+          File.open(path, 'w'){|f| f << "not actually a gem"}
+          path
+        end
+        proc { @helper.install_gem }.should raise_error
+      end
+    end
+
+    describe 'release' do
+      it "shouldn't push if there are uncommitted files" do
+        proc { @helper.release_gem }.should raise_error(/files that need to be committed/)
+      end
+
+      it 'raises an appropriate error if there is no git remote' do
+        Bundler.ui.stub(:confirm => nil, :error => nil) # silence messages
+
+        Dir.chdir(gem_repo1) {
+          `git init --bare`
+        }
+        Dir.chdir(@app) {
+          `git init`
+          `git config user.email "you@example.com"`
+          `git config user.name "name"`
+          `git commit -a -m "initial commit"`
+        }
+
+        proc { @helper.release_gem }.should raise_error
+      end
+
+      it "releases" do
+        mock_build_message
+        mock_confirm_message(/Tagged v0.0.1/)
+        mock_confirm_message("Pushed git commits and tags")
+
+        @helper.should_receive(:rubygem_push).with(bundled_app('test/pkg/test-0.0.1.gem').to_s)
+
+        Dir.chdir(gem_repo1) {
+          `git init --bare`
+        }
+        Dir.chdir(@app) {
+          `git init`
+          `git config user.email "you@example.com"`
+          `git config user.name "name"`
+          `git remote add origin file://#{gem_repo1}`
+          `git commit -a -m "initial commit"`
+          sys_exec("git push origin master", true)
+          `git commit -a -m "another commit"`
+        }
+        @helper.release_gem
+      end
+    end
+  end
+end

data/spec/bundler/source_spec.rb

@@ -0,0 +1,25 @@
+require 'spec_helper'
+
+describe Bundler::Source::Rubygems do
+  before do
+    Bundler.stub(:root){ Pathname.new("root") }
+  end
+
+  describe "caches" do
+    it "should include Bundler.app_cache" do
+      subject.caches.should include(Bundler.app_cache)
+    end
+
+    it "should include GEM_PATH entries" do
+      Gem.path.each do |path|
+        subject.caches.should include(File.expand_path("#{path}/cache"))
+      end
+    end
+
+    it "should be an array of strings or pathnames" do
+      subject.caches.each do |cache|
+        [String, Pathname].should include(cache.class)
+      end
+    end
+  end
+end

data/spec/cache/gems_spec.rb

@@ -0,0 +1,239 @@
+require "spec_helper"
+
+describe "bundle cache" do
+
+  describe "when there are only gemsources" do
+    before :each do
+      gemfile <<-G
+        gem 'rack'
+      G
+
+      system_gems "rack-1.0.0"
+      bundle :cache
+    end
+
+    it "copies the .gem file to vendor/cache" do
+      bundled_app("vendor/cache/rack-1.0.0.gem").should exist
+    end
+
+    it "uses the cache as a source when installing gems" do
+      build_gem "omg", :path => bundled_app('vendor/cache')
+
+      install_gemfile <<-G
+        source "file://#{gem_repo1}"
+        gem "omg"
+      G
+
+      should_be_installed "omg 1.0.0"
+    end
+
+    it "uses the cache as a source when installing gems with --local" do
+      system_gems []
+      bundle "install --local"
+
+      should_be_installed("rack 1.0.0")
+    end
+
+    it "does not reinstall gems from the cache if they exist on the system" do
+      build_gem "rack", "1.0.0", :path => bundled_app('vendor/cache') do |s|
+        s.write "lib/rack.rb", "RACK = 'FAIL'"
+      end
+
+      install_gemfile <<-G
+        gem "rack"
+      G
+
+      should_be_installed("rack 1.0.0")
+    end
+
+    it "does not reinstall gems from the cache if they exist in the bundle" do
+      system_gems "rack-1.0.0"
+
+      gemfile <<-G
+        gem "rack"
+      G
+
+      build_gem "rack", "1.0.0", :path => bundled_app('vendor/cache') do |s|
+        s.write "lib/rack.rb", "RACK = 'FAIL'"
+      end
+
+      bundle "install --local"
+      should_be_installed("rack 1.0.0")
+    end
+
+    it "creates a lockfile" do
+      cache_gems "rack-1.0.0"
+
+      gemfile <<-G
+        gem "rack"
+      G
+
+      bundle "cache"
+
+      bundled_app("Gemfile.lock").should exist
+    end
+  end
+
+  describe "when there are also git sources" do
+    before do
+      build_git "foo"
+      system_gems "rack-1.0.0"
+
+      install_gemfile <<-G
+        source "file://#{gem_repo1}"
+        git "#{lib_path("foo-1.0")}" do
+          gem 'foo'
+        end
+        gem 'rack'
+      G
+    end
+
+    it "still works" do
+      bundle :cache
+
+      system_gems []
+      bundle "install --local"
+
+      should_be_installed("rack 1.0.0", "foo 1.0")
+    end
+
+    it "should not explode if the lockfile is not present" do
+      FileUtils.rm(bundled_app("Gemfile.lock"))
+
+      bundle :cache
+
+      bundled_app("Gemfile.lock").should exist
+    end
+  end
+
+  describe "when previously cached" do
+    before :each do
+      build_repo2
+      install_gemfile <<-G
+        source "file://#{gem_repo2}"
+        gem "rack"
+        gem "actionpack"
+      G
+      bundle :cache
+      cached_gem("rack-1.0.0").should exist
+      cached_gem("actionpack-2.3.2").should exist
+      cached_gem("activesupport-2.3.2").should exist
+    end
+
+    it "re-caches during install" do
+      cached_gem("rack-1.0.0").rmtree
+      bundle :install
+      out.should include("Updating files in vendor/cache")
+      cached_gem("rack-1.0.0").should exist
+    end
+
+    it "adds and removes when gems are updated" do
+      update_repo2
+      bundle 'update'
+      cached_gem("rack-1.2").should exist
+      cached_gem("rack-1.0.0").should_not exist
+    end
+
+    it "adds new gems and dependencies" do
+      install_gemfile <<-G
+        source "file://#{gem_repo2}"
+        gem "rails"
+      G
+      cached_gem("rails-2.3.2").should exist
+      cached_gem("activerecord-2.3.2").should exist
+    end
+
+    it "removes .gems for removed gems and dependencies" do
+      install_gemfile <<-G
+        source "file://#{gem_repo2}"
+        gem "rack"
+      G
+      cached_gem("rack-1.0.0").should exist
+      cached_gem("actionpack-2.3.2").should_not exist
+      cached_gem("activesupport-2.3.2").should_not exist
+    end
+
+    it "removes .gems when gem changes to git source" do
+      build_git "rack"
+
+      install_gemfile <<-G
+        source "file://#{gem_repo2}"
+        gem "rack", :git => "#{lib_path("rack-1.0")}"
+        gem "actionpack"
+      G
+      cached_gem("rack-1.0.0").should_not exist
+      cached_gem("actionpack-2.3.2").should exist
+      cached_gem("activesupport-2.3.2").should exist
+    end
+
+
+    it "doesn't remove gems that are for another platform" do
+      simulate_platform "java" do
+        install_gemfile <<-G
+          source "file://#{gem_repo1}"
+          gem "platform_specific"
+        G
+
+        bundle :cache
+        cached_gem("platform_specific-1.0-java").should exist
+      end
+
+      simulate_new_machine
+      install_gemfile <<-G
+        source "file://#{gem_repo1}"
+        gem "platform_specific"
+      G
+
+      cached_gem("platform_specific-1.0-#{Gem::Platform.local}").should exist
+      cached_gem("platform_specific-1.0-java").should exist
+    end
+
+    it "doesn't remove gems with mismatched :rubygems_version or :date" do
+      cached_gem("rack-1.0.0").rmtree
+      build_gem "rack", "1.0.0",
+        :path => bundled_app('vendor/cache'),
+        :rubygems_version => "1.3.2"
+      simulate_new_machine
+
+      bundle :install
+      cached_gem("rack-1.0.0").should exist
+    end
+
+    it "handles directories and non .gem files in the cache" do
+      bundled_app("vendor/cache/foo").mkdir
+      File.open(bundled_app("vendor/cache/bar"), 'w'){|f| f.write("not a gem") }
+      bundle :cache
+    end
+
+    it "does not say that it is removing gems when it isn't actually doing so" do
+      install_gemfile <<-G
+        source "file://#{gem_repo1}"
+        gem "rack"
+      G
+      bundle "cache"
+      bundle "install"
+      out.should_not =~ /removing/i
+    end
+
+    it "does not warn about all if it doesn't have any git/path dependency" do
+      install_gemfile <<-G
+        source "file://#{gem_repo1}"
+        gem "rack"
+      G
+      bundle "cache"
+      out.should_not =~ /\-\-all/
+    end
+
+    it "should install gems with the name bundler in them (that aren't bundler)" do
+      build_gem "foo-bundler", "1.0",
+        :path => bundled_app('vendor/cache')
+
+      install_gemfile <<-G
+        gem "foo-bundler"
+      G
+
+      should_be_installed "foo-bundler 1.0"
+    end
+  end
+
+end