rkerberos 0.2.2 → 0.3.0

data/spec/config_spec.rb

@@ -1,19 +1,54 @@
 # spec/config_spec.rb
 # RSpec tests for Kerberos::Kadm5::Config
 
-require 'rkerberos'
+require 'spec_helper'
 
-RSpec.describe Kerberos::Kadm5::Config do
-  subject(:config) { described_class.new }
+RSpec.describe 'Kerberos::Kadm5::Config', :kadm5 do
+  subject(:klass){ Kerberos::Kadm5::Config }
+  let(:config) { klass.new }
 
   it 'is frozen' do
     expect(config).to be_frozen
   end
 
+  describe 'constructor' do
+    it 'can be called with no arguments' do
+      expect { klass.new }.not_to raise_error
+    end
+
+    it 'accepts a context option' do
+      ctx = Kerberos::Krb5::Context.new
+      expect { klass.new(context: ctx) }.not_to raise_error
+    end
+
+    it 'returns same realm with or without context' do
+      ctx = Kerberos::Krb5::Context.new
+      c1 = klass.new
+      c2 = klass.new(context: ctx)
+      expect(c2.realm).to eq(c1.realm)
+    end
+
+    it 'raises TypeError for non-Context context argument' do
+      expect { klass.new(context: "bad") }.to raise_error(TypeError)
+    end
+
+    it 'raises error for a closed context' do
+      ctx = Kerberos::Krb5::Context.new
+      ctx.close
+      expect { klass.new(context: ctx) }.to raise_error(Kerberos::Krb5::Exception)
+    end
+
+    it 'rejects positional option hashes and unknown keywords' do
+      expect { klass.new({context: nil}) }.to raise_error(ArgumentError)
+      expect { klass.new(unknown: true) }.to raise_error(ArgumentError, /unknown keyword/)
+    end
+  end
+
   describe 'realm' do
     it 'responds to realm' do
       expect(config).to respond_to(:realm)
     end
+
     it 'returns a String' do
       expect(config.realm).to be_a(String)
     end
@@ -23,6 +58,7 @@ RSpec.describe Kerberos::Kadm5::Config do
     it 'responds to kadmind_port' do
       expect(config).to respond_to(:kadmind_port)
     end
+
     it 'returns an Integer' do
       expect(config.kadmind_port).to be_a(Integer)
     end
@@ -32,6 +68,7 @@ RSpec.describe Kerberos::Kadm5::Config do
     it 'responds to kpasswd_port' do
       expect(config).to respond_to(:kpasswd_port)
     end
+
     it 'returns an Integer' do
       expect(config.kpasswd_port).to be_a(Integer)
     end
@@ -41,6 +78,7 @@ RSpec.describe Kerberos::Kadm5::Config do
     it 'responds to admin_server' do
       expect(config).to respond_to(:admin_server)
     end
+
     it 'returns a String' do
       expect(config.admin_server).to be_a(String)
     end
@@ -50,6 +88,7 @@ RSpec.describe Kerberos::Kadm5::Config do
     it 'responds to acl_file' do
       expect(config).to respond_to(:acl_file)
     end
+
     it 'returns a String' do
       expect(config.acl_file).to be_a(String)
     end
@@ -59,6 +98,7 @@ RSpec.describe Kerberos::Kadm5::Config do
     it 'responds to dict_file' do
       expect(config).to respond_to(:dict_file)
     end
+
     it 'returns a String or nil' do
       expect([String, NilClass]).to include(config.dict_file.class)
     end
@@ -68,6 +108,7 @@ RSpec.describe Kerberos::Kadm5::Config do
     it 'responds to stash_file' do
       expect(config).to respond_to(:stash_file)
     end
+
     it 'returns a String or nil' do
       expect([String, NilClass]).to include(config.stash_file.class)
     end
@@ -77,6 +118,7 @@ RSpec.describe Kerberos::Kadm5::Config do
     it 'responds to mkey_name' do
       expect(config).to respond_to(:mkey_name)
     end
+
     it 'returns a String or nil' do
       expect([String, NilClass]).to include(config.mkey_name.class)
     end
@@ -86,6 +128,7 @@ RSpec.describe Kerberos::Kadm5::Config do
     it 'responds to mkey_from_kbd' do
       expect(config).to respond_to(:mkey_from_kbd)
     end
+
     it 'returns an Integer or nil' do
       expect([Integer, NilClass]).to include(config.mkey_from_kbd.class)
     end
@@ -95,6 +138,7 @@ RSpec.describe Kerberos::Kadm5::Config do
     it 'responds to enctype' do
       expect(config).to respond_to(:enctype)
     end
+
     it 'returns an Integer' do
       expect(config.enctype).to be_a(Integer)
     end
@@ -104,6 +148,7 @@ RSpec.describe Kerberos::Kadm5::Config do
     it 'responds to max_life' do
       expect(config).to respond_to(:max_life)
     end
+
     it 'returns an Integer' do
       expect(config.max_life).to be_a(Integer)
     end
@@ -113,6 +158,7 @@ RSpec.describe Kerberos::Kadm5::Config do
     it 'responds to max_rlife' do
       expect(config).to respond_to(:max_rlife)
     end
+
     it 'returns an Integer' do
       expect(config.max_rlife).to be_a(Integer)
     end
@@ -122,6 +168,7 @@ RSpec.describe Kerberos::Kadm5::Config do
     it 'responds to expiration' do
       expect(config).to respond_to(:expiration)
     end
+
     it 'returns a Time or nil' do
       expect([Time, NilClass]).to include(config.expiration.class)
     end
@@ -131,6 +178,7 @@ RSpec.describe Kerberos::Kadm5::Config do
     it 'responds to kvno' do
       expect(config).to respond_to(:kvno)
     end
+
     it 'returns an Integer or nil' do
       expect([Integer, NilClass]).to include(config.kvno.class)
     end
@@ -140,6 +188,7 @@ RSpec.describe Kerberos::Kadm5::Config do
     it 'responds to iprop_enabled' do
       expect(config).to respond_to(:iprop_enabled)
     end
+
     it 'returns a boolean' do
       expect(!!config.iprop_enabled == config.iprop_enabled).to be true
     end
@@ -149,6 +198,7 @@ RSpec.describe Kerberos::Kadm5::Config do
     it 'responds to iprop_logfile' do
       expect(config).to respond_to(:iprop_logfile)
     end
+
     it 'returns a String' do
       expect(config.iprop_logfile).to be_a(String)
     end
@@ -158,6 +208,7 @@ RSpec.describe Kerberos::Kadm5::Config do
     it 'responds to iprop_poll_time' do
       expect(config).to respond_to(:iprop_poll_time)
     end
+
     it 'returns an Integer' do
       expect(config.iprop_poll_time).to be_a(Integer)
     end
@@ -167,6 +218,7 @@ RSpec.describe Kerberos::Kadm5::Config do
     it 'responds to iprop_port' do
       expect(config).to respond_to(:iprop_port)
     end
+
     it 'returns an Integer or nil' do
       expect([Integer, NilClass]).to include(config.iprop_port.class)
     end
@@ -176,6 +228,7 @@ RSpec.describe Kerberos::Kadm5::Config do
     it 'responds to num_keysalts' do
       expect(config).to respond_to(:num_keysalts)
     end
+
     it 'returns an Integer' do
       expect(config.num_keysalts).to be_a(Integer)
     end
@@ -185,9 +238,11 @@ RSpec.describe Kerberos::Kadm5::Config do
     it 'responds to keysalts' do
       expect(config).to respond_to(:keysalts)
     end
+
     it 'returns an Array' do
       expect(config.keysalts).to be_a(Array)
     end
+
     it 'contains KeySalt objects if not empty' do
       unless config.keysalts.empty?
         expect(config.keysalts.first).to be_a(Kerberos::Kadm5::KeySalt)

data/spec/context_spec.rb

@@ -1,7 +1,7 @@
 # spec/context_spec.rb
 # RSpec tests for Kerberos::Krb5::Context
 
-require 'rkerberos'
+require 'spec_helper'
 
 RSpec.describe Kerberos::Krb5::Context do
   subject(:context) { described_class.new }
@@ -19,17 +19,18 @@ RSpec.describe Kerberos::Krb5::Context do
   end
 
   describe 'constructor options' do
+    let(:profile_path){ RSpec.configuration.krb5_conf }
+
     it 'accepts secure: true to use a secure context' do
       expect { described_class.new(secure: true) }.not_to raise_error
     end
 
-    it 'accepts a profile path via :profile' do
-      profile_path = ENV['KRB5_CONFIG'] || '/etc/krb5.conf'
+    it 'accepts a profile path via :profile', :unix do
       expect(File).to exist(profile_path)
       expect { described_class.new(profile: profile_path) }.not_to raise_error
     end
 
-    it 'validates profile argument type' do
+    it 'validates profile argument type', :unix do
       expect { described_class.new(profile: 123) }.to raise_error(TypeError)
     end
 
@@ -43,15 +44,64 @@ RSpec.describe Kerberos::Krb5::Context do
       end
     end
 
-    it 'accepts secure: true together with profile' do
-      profile_path = ENV['KRB5_CONFIG'] || '/etc/krb5.conf'
+    it 'accepts secure: true together with profile', :unix do
       expect(File).to exist(profile_path)
-
       ctx = nil
       expect { ctx = described_class.new(secure: true, profile: profile_path) }.not_to raise_error
       expect(ctx).to be_a(described_class)
       expect { ctx.close }.not_to raise_error
     end
+
+    it 'rejects positional option hashes and unknown keywords' do
+      expect { described_class.new({secure: true}) }.to raise_error(ArgumentError)
+      expect { described_class.new(unknown: true) }.to raise_error(ArgumentError, /unknown keyword/)
+    end
+  end
+
+  describe '#default_realm' do
+    it 'responds to default_realm' do
+      expect(context).to respond_to(:default_realm)
+    end
+
+    it 'returns a string' do
+      expect(context.default_realm).to be_a(String)
+    end
+
+    it 'returns a non-empty realm' do
+      expect(context.default_realm.size).to be > 0
+    end
+
+    it 'raises when context is closed' do
+      context.close
+      expect { context.default_realm }.to raise_error(Kerberos::Krb5::Exception)
+    end
+  end
+
+  describe '#default_realm=' do
+    it 'responds to default_realm=' do
+      expect(context).to respond_to(:default_realm=)
+    end
+
+    it 'can set and read back a custom realm' do
+      context.default_realm = 'TEST.REALM'
+      expect(context.default_realm).to eq('TEST.REALM')
+    end
+
+    it 'accepts nil to reset to the default' do
+      original = context.default_realm
+      context.default_realm = 'TEMP.REALM'
+      context.default_realm = nil
+      expect(context.default_realm).to eq(original)
+    end
+
+    it 'raises TypeError for non-string argument' do
+      expect { context.default_realm = 123 }.to raise_error(TypeError)
+    end
+
+    it 'raises when context is closed' do
+      context.close
+      expect { context.default_realm = 'X' }.to raise_error(Kerberos::Krb5::Exception)
+    end
   end
 
   after(:each) do

data/spec/credentials_cache_spec.rb

@@ -1,71 +1,109 @@
 # spec/credentials_cache_spec.rb
 # RSpec tests for Kerberos::Krb5::CredentialsCache
 
-require 'rkerberos'
-require 'etc'
+require 'spec_helper'
 require 'open3'
-require 'tmpdir'
 
 RSpec.describe Kerberos::Krb5::CredentialsCache do
-  let(:login) do
-    Etc.getlogin || ENV['USER'] || (Etc.getpwuid(Process.uid).name rescue nil)
-  end
   let(:realm) { Kerberos::Krb5.new.default_realm }
-  let(:princ) { "#{login}@#{realm}" }
-  let(:cfile) { File.join(Dir.tmpdir, "krb5cc_#{Etc.getpwnam(login).uid}") }
+  let(:princ) { RSpec.configuration.login + '@' + realm }
+  let(:cfile) { RSpec.configuration.krb5_cc_name }
   let(:ccache) { described_class.new }
 
   def cache_found?
-    found = true
-    Open3.popen3('klist') { |_, _, stderr| found = false unless stderr.gets.nil? }
-    found
+    if File::ALT_SEPARATOR
+      File.exist?(cfile)
+    else
+      found = true
+      Open3.popen3('klist') { |_, _, stderr| found = false unless stderr.gets.nil? }
+      found
+    end
   end
 
   after(:each) do
-    Open3.popen3('kdestroy') { sleep 0.1 }
+    Open3.popen3('kdestroy -q') { sleep 0.1 } if cache_found?
   end
 
   describe 'constructor' do
     it 'can be called with no arguments' do
       expect { described_class.new }.not_to raise_error
     end
+
     it 'does not create a cache with no arguments' do
       described_class.new
       expect(File.exist?(cfile)).to be false
       expect(cache_found?).to be false
     end
+
     it 'creates a cache with a principal' do
-      expect { described_class.new(princ) }.not_to raise_error
+      expect { described_class.new(principal: princ) }.not_to raise_error
       expect(File.exist?(cfile)).to be true
       expect(cache_found?).to be true
     end
+
     it 'accepts an explicit cache name' do
-      expect { described_class.new(princ, cfile) }.not_to raise_error
-      expect { described_class.new(nil, cfile) }.not_to raise_error
+      expect { described_class.new(principal: princ, cache_name: cfile) }.not_to raise_error
+      expect { described_class.new(cache_name: cfile) }.not_to raise_error
+    end
+
+    it 'raises error for non-string principal' do
+      expect { described_class.new(principal: true) }.to raise_error(TypeError)
+    end
+
+    it 'accepts Principal objects (duck-typed as #principal)' do
+      obj = Kerberos::Krb5::Principal.new(name: princ)
+      expect { described_class.new(principal: obj) }.not_to raise_error
+      expect(described_class.new(principal: obj).primary_principal).to eq(princ)
     end
-    it 'raises error for non-string argument' do
-      expect { described_class.new(true) }.to raise_error(TypeError)
+
+    it 'raises error for positional arguments' do
+      expect { described_class.new(princ) }.to raise_error(ArgumentError)
+    end
+
+    it 'rejects unknown keywords' do
+      expect { described_class.new(unknown: true) }.to raise_error(ArgumentError, /unknown keyword/)
+    end
+
+    it 'accepts a context option' do
+      ctx = Kerberos::Krb5::Context.new
+      expect { described_class.new(principal: princ, context: ctx) }.not_to raise_error
+    end
+
+    it 'uses the context when provided' do
+      ctx = Kerberos::Krb5::Context.new
+      c = described_class.new(principal: princ, context: ctx)
+      expect(c.primary_principal).to eq(princ)
+    end
+
+    it 'raises TypeError for non-Context context argument' do
+      expect { described_class.new(context: "bad") }.to raise_error(TypeError)
     end
-    it 'accepts only up to two arguments' do
-      expect { described_class.new(princ, cfile, cfile) }.to raise_error(ArgumentError)
+
+    it 'raises error for a closed context' do
+      ctx = Kerberos::Krb5::Context.new
+      ctx.close
+      expect { described_class.new(context: ctx) }.to raise_error(Kerberos::Krb5::Exception)
     end
   end
 
   describe '#close' do
     it 'responds to close' do
-      expect(described_class.new(princ)).to respond_to(:close)
+      expect(described_class.new(principal: princ)).to respond_to(:close)
     end
+
     it 'does not delete credentials cache' do
-      c = described_class.new(princ)
+      c = described_class.new(principal: princ)
       expect { c.close }.not_to raise_error
       expect(cache_found?).to be true
     end
+
     it 'can be called multiple times without error' do
-      c = described_class.new(princ)
+      c = described_class.new(principal: princ)
       expect { 3.times { c.close } }.not_to raise_error
     end
+
     it 'raises error when calling method on closed object' do
-      c = described_class.new(princ)
+      c = described_class.new(principal: princ)
       c.close
       expect { c.default_name }.to raise_error(Kerberos::Krb5::Exception)
     end
@@ -73,19 +111,20 @@ RSpec.describe Kerberos::Krb5::CredentialsCache do
 
   describe '#default_name' do
     it 'responds to default_name' do
-      c = described_class.new(princ)
+      c = described_class.new(principal: princ)
       expect(c).to respond_to(:default_name)
       expect { c.default_name }.not_to raise_error
     end
+
     it 'returns a string' do
-      c = described_class.new(princ)
+      c = described_class.new(principal: princ)
       expect(c.default_name).to be_a(String)
     end
   end
 
   describe '#cache_name and #cache_type' do
     it 'returns the ccache name and type' do
-      c = described_class.new(princ)
+      c = described_class.new(principal: princ)
       expect(c).to respond_to(:cache_name)
       expect(c).to respond_to(:cache_type)
 
@@ -94,13 +133,13 @@ RSpec.describe Kerberos::Krb5::CredentialsCache do
 
       # cache_name returns the residual portion of the cache name; default_name
       # may include the type prefix (e.g. "FILE:"). ensure the suffix matches.
-      expect(c.cache_name).to eq(c.default_name.split(':').last)
+      expect(c.cache_name).to eq(c.default_name.split(/\w{2,}:/).last)
     end
   end
 
   describe '#principal' do
     it 'is an alias for primary_principal' do
-      c = described_class.new(princ)
+      c = described_class.new(principal: princ)
       expect(c).to respond_to(:principal)
       expect(c.principal).to eq(c.primary_principal)
     end
@@ -108,12 +147,13 @@ RSpec.describe Kerberos::Krb5::CredentialsCache do
 
   describe '#primary_principal' do
     it 'responds to primary_principal' do
-      c = described_class.new(princ)
+      c = described_class.new(principal: princ)
       expect(c).to respond_to(:primary_principal)
       expect { c.primary_principal }.not_to raise_error
     end
+
     it 'returns expected results' do
-      c = described_class.new(princ)
+      c = described_class.new(principal: princ)
       expect(c.primary_principal).to be_a(String)
       expect(c.primary_principal.size).to be > 0
       expect(c.primary_principal).to include('@')
@@ -122,37 +162,42 @@ RSpec.describe Kerberos::Krb5::CredentialsCache do
 
   describe '#destroy' do
     it 'responds to destroy' do
-      c = described_class.new(princ)
+      c = described_class.new(principal: princ)
       expect(c).to respond_to(:destroy)
     end
+
     it 'deletes credentials cache' do
-      c = described_class.new(princ)
+      c = described_class.new(principal: princ)
       expect { c.destroy }.not_to raise_error
       expect(cache_found?).to be false
     end
+
     it 'delete is an alias for destroy' do
-      c = described_class.new(princ)
+      c = described_class.new(principal: princ)
       expect(c).to respond_to(:delete)
       expect(c.method(:delete)).to eq(c.method(:destroy))
     end
+
     it 'returns false if no credentials cache' do
       c = described_class.new
       expect(c.destroy).to be false
     end
+
     it 'raises error when calling method on destroyed object' do
-      c = described_class.new(princ)
+      c = described_class.new(principal: princ)
       c.destroy
       expect { c.default_name }.to raise_error(Kerberos::Krb5::Exception)
     end
+
     it 'does not accept arguments' do
-      c = described_class.new(princ)
+      c = described_class.new(principal: princ)
       expect { c.destroy(true) }.to raise_error(ArgumentError)
     end
   end
 
   describe '#dup' do
     it 'returns a new cache object with the same properties' do
-      c = described_class.new(princ)
+      c = described_class.new(principal: princ)
       c2 = c.dup
       expect(c2).to be_a(described_class)
       expect(c2.default_name).to eq(c.default_name)
@@ -160,23 +205,45 @@ RSpec.describe Kerberos::Krb5::CredentialsCache do
     end
 
     it 'closing original does not affect duplicate' do
-      c = described_class.new(princ)
+      c = described_class.new(principal: princ)
       c2 = c.dup
       c.close
       expect { c2.default_name }.not_to raise_error
     end
 
     it 'closing duplicate does not affect original' do
-      c = described_class.new(princ)
+      c = described_class.new(principal: princ)
       c2 = c.dup
       c2.close
       expect { c.default_name }.not_to raise_error
     end
 
     it 'raises when duping closed cache' do
-      c = described_class.new(princ)
+      c = described_class.new(principal: princ)
       c.close
       expect { c.dup }.to raise_error(Kerberos::Krb5::Exception)
     end
   end
+
+  describe '#full_name' do
+    it 'returns a string including the type prefix' do
+      cc = described_class.new(principal: princ)
+      name = cc.full_name
+      expect(name).to be_a(String)
+      expect(name).to match(/\A\w+:/)
+      cc.close
+    end
+
+    it 'includes FILE: for a file-based cache' do
+      cc = described_class.new(principal: princ, cache_name: cfile)
+      expect(cc.full_name).to start_with('FILE:')
+      cc.close
+    end
+
+    it 'raises when the context is closed' do
+      cc = described_class.new(principal: princ)
+      cc.close
+      expect { cc.full_name }.to raise_error(Kerberos::Krb5::Exception)
+    end
+  end
 end