rjb 1.1.3 → 1.1.4

data/ChangeLog

@@ -1,3 +1,29 @@
+Thu Aug 14 arton
+ *ext/rjb.c, load.c, etc
+	change comment line // -> /* */ because AIX's compiler
+	add _AIX for load.c (this patch from Ittay Dror, thanks)
+ *ext/load.c
+	add ALT_JVM_TYPE for alternative jvm directory (by Kumar)
+Sun Jul 13 arton
+ *ext/rjb.c
+	display warning when Rjb load jvm implicitly if $DEBUG or $VERBOSE.
+Mon May 26 arton
+ *ext/rjb.c
+	correct char primitive conversion for Bigendian machine.
+	use macroes for loading classes
+ *ext/load.c
+	adjust OS X's directory
+ *ext/extconf.rb	
+	adjust OS X's directory if Home exists	
+Thu Mar 27 arton
+ *ext/rjb.c
+	mark version 1.1.4 for the next release.
+ *test/test.rb
+	remove unload, because it fails. 
+	It's more important to assert each functions.
+Thu Mar 27 arton
+ *ext/riconv.c
+	activate conv tables for getenv configuration.
 Tue Mar 5 Kuwashima
  *ext/rjb.c
  *ext/rjb.h

data/ext/extconf.h

@@ -5,5 +5,5 @@
 #define HAVE_NL_LANGINFO 1
 #define HAVE_SETLOCALE 1
 #define HAVE_GETENV 1
-#define RJB_RUBY_VERSION_CODE 186
+#define RJB_RUBY_VERSION_CODE 187
 #endif

data/ext/extconf.rb

@@ -33,6 +33,7 @@ if !javahome.nil?
   raise "JAVA_HOME is not directory." unless File.directory?(javahome)
   p = Path.new
   inc = p.include(javahome, 'include')
+  inc = p.include(javahome, 'Home/include') unless File.exists?(inc)
   Dir.open(inc).each do |d|
     next if d[0] == ?.
     if File.directory?(p.joint(inc, d))

data/ext/jniwrap.h

@@ -12,7 +12,7 @@
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Lesser General Public License for more details.
  *
- * $Id: jniwrap.h 4 2006-09-11 15:21:38Z arton $
+ * $Id: jniwrap.h 78 2008-08-14 10:47:31Z arton $
  */
 #ifndef _Included_jniwrap
 #define _Included_jniwrap

data/ext/load.c

@@ -12,7 +12,7 @@
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Lesser General Public License for more details.
  *
- * $Id: load.c 65 2008-03-26 13:19:29Z arton $
+ * $Id: load.c 77 2008-08-14 10:22:35Z arton $
  */
 
 #include <stdlib.h>
@@ -33,6 +33,7 @@
 #include "rjb.h"
 
 #define JVM_TYPE "client"
+#define ALT_JVM_TYPE "classic"
 
 #if defined(_WIN32) || defined(__CYGWIN__)
  #if defined(__CYGWIN__)
@@ -47,6 +48,12 @@
   #define JVMDLL "%s/Libraries/libjvm_compat.dylib"
   #define DIRSEPARATOR '/'
   #define CLASSPATH_SEP ':'
+  #define HOME_NAME "/Home"
+  #define HOME_NAME_LEN strlen(HOME_NAME)
+  #define DEFAULT_HOME "/System/Library/Frameworks/JavaVM.framework"
+#elif defined(_AIX)
+  #define ARCH "ppc"
+  #define JVM_TYPE "j9vm"
 #else /* defined(_WIN32) || defined(__CYGWIN__) */
  #if defined(__sparc_v9__)
    #define ARCH "sparcv9"
@@ -83,13 +90,23 @@ static int load_jvm(char* jvmtype)
     char* libpath;
     char* java_home;
     char* jh;
-    VALUE dl;
-    VALUE importer;
 
-#if defined(__APPLE__) && defined(__MACH__)
-    jh = "/System/Library/Frameworks/JavaVM.framework";
-#else
     jh = getenv("JAVA_HOME");
+#if defined(__APPLE__) && defined(__MACH__)
+    if (!jh)
+    {
+        jh = DEFAULT_HOME;
+    }
+    else
+    {
+        if (strlen(jh) > HOME_NAME_LEN 
+            && strcasecmp(jh + strlen(jh) - HOME_NAME_LEN, HOME_NAME) == 0)
+        {
+            char* p = ALLOCA_N(char, strlen(jh) + 8);
+            sprintf(p, "%s/..", jh);
+            jh = p;
+        }
+    }
 #endif
     if (!jh)
     {
@@ -136,7 +153,7 @@ static int load_jvm(char* jvmtype)
     
     jvmdll = rb_funcall(rb_const_get(rb_cObject, rb_intern("DL")), rb_intern("dlopen"), 1, rb_str_new2(libpath));
 
-    //get function pointers of JNI
+    /* get function pointers of JNI */
 #if RJB_RUBY_VERSION_CODE < 190
     getdefaultjavavminitargsfunc = rb_funcall(rb_funcall(rb_funcall(jvmdll, rb_intern("[]"), 2, rb_str_new2("JNI_GetDefaultJavaVMInitArgs"), rb_str_new2("IP")), rb_intern("to_ptr"), 0), rb_intern("to_i"), 0); 
     createjavavmfunc = rb_funcall(rb_funcall(rb_funcall(jvmdll, rb_intern("[]"), 2, rb_str_new2("JNI_CreateJavaVM"), rb_str_new2("IPPP")), rb_intern("to_ptr"), 0), rb_intern("to_i"), 0); 
@@ -211,7 +228,6 @@ int rjb_create_jvm(JNIEnv** pjenv, JavaVMInitArgs* vm_args, char* userpath, VALU
       { "DUMMY", NULL },   /* for classpath count */
     };
     char* newpath;
-    VALUE ptr;
     int len;
     int result;
     GETDEFAULTJAVAVMINITARGS initargs;
@@ -223,7 +239,7 @@ int rjb_create_jvm(JNIEnv** pjenv, JavaVMInitArgs* vm_args, char* userpath, VALU
 
     if (!RTEST(jvmdll))
     {
-	if (!load_jvm(JVM_TYPE))
+	if (!load_jvm(JVM_TYPE) && !load_jvm(ALT_JVM_TYPE))
 	{
 	    return -1;
 	}

data/ext/rjb.c

@@ -1,6 +1,6 @@
 /*
  * Rjb - Ruby <-> Java Bridge
- * Copyright(c) 2004,2005,2006,2007 arton
+ * Copyright(c) 2004,2005,2006,2007,2008 arton
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
@@ -12,10 +12,10 @@
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Lesser General Public License for more details.
  *
- * $Id: rjb.c 64 2008-03-05 14:24:22Z kuwa1 $
+ * $Id: rjb.c 77 2008-08-14 10:22:35Z arton $
  */
 
-#define RJB_VERSION "1.1.3"
+#define RJB_VERSION "1.1.4"
 
 #include "ruby.h"
 #include "extconf.h"
@@ -28,6 +28,7 @@
 #include "jp_co_infoseek_hp_arton_rjb_RBridge.h"
 #include "riconv.h"
 #include "rjb.h"
+#include "ctype.h"
 
 /*
  * Method Modifier Flag defined in
@@ -41,6 +42,20 @@
 #define ACC_VOLATILE  0x0040
 #define ACC_TRANSIENT  0x0080
 
+#define RJB_FIND_CLASS(var, name)              \
+    var = (*jenv)->FindClass(jenv, name); \
+    rjb_check_exception(jenv, 1)
+#define RJB_HOLD_CLASS(var, name)              \
+    var = (*jenv)->FindClass(jenv, name); \
+    rjb_check_exception(jenv, 1);               \
+    var = (*jenv)->NewGlobalRef(jenv, var)
+#define RJB_LOAD_METHOD(var, obj, name, sig) \
+    var = (*jenv)->GetMethodID(jenv, obj, name, sig); \
+    rjb_check_exception(jenv, 1)
+#define RJB_LOAD_STATIC_METHOD(var, obj, name, sig) \
+    var = (*jenv)->GetStaticMethodID(jenv, obj, name, sig); \
+    rjb_check_exception(jenv, 1)
+
 static void register_class(VALUE, VALUE);
 static VALUE import_class(JNIEnv* jenv, jclass, VALUE);
 static VALUE register_instance(JNIEnv* jenv, struct jvi_data*, jobject);
@@ -101,7 +116,7 @@ enum PrimitiveType {
     PRM_SHORT,
     PRM_BYTE,
     PRM_FLOAT,
-    //
+    /* */
     PRM_LAST
 };
 
@@ -145,6 +160,7 @@ static char* java2jniname(char* jnicls)
     return jnicls;
 }
 
+#if 0
 static char* jni2javaname(char* jnicls)
 {
     char* p;
@@ -157,6 +173,7 @@ static char* jni2javaname(char* jnicls)
     }
     return jnicls;
 }
+#endif
 
 static char* next_sig(char* p)
 {
@@ -239,7 +256,7 @@ static VALUE jv2rv_r(JNIEnv* jenv, jvalue val)
     VALUE clsname;
     VALUE v;
     struct jv_data* ptr;
-    // object to ruby
+    /* object to ruby */
     if (!val.l) return Qnil;
     klass = (*jenv)->GetObjectClass(jenv, val.l);
 
@@ -517,7 +534,7 @@ static jprimitive_table jpcvt[] = {
     { "java/lang/Double", "doubleValue", "()D", "(D)V", NULL, 0, 0, jdouble2rv, },
     { "java/lang/Boolean", "booleanValue", "()Z", "(Z)Ljava/lang/Boolean;",
       NULL, 0, 0, jboolean2rv, },
-    { "java/lang/Character", "charValue", "()C", NULL, NULL, 0, 0, jint2rv, },
+    { "java/lang/Character", "charValue", "()C", NULL, NULL, 0, 0, jchar2rv, },
     { "java/lang/Short", "intValue", "()I", NULL, NULL, 0, 0, jint2rv, },
     { "java/lang/Byte", "intValue", "()I", NULL, NULL, 0, 0, jint2rv, },
     { "java/lang/Float", "doubleValue", "()D", NULL, NULL, 0, 0, jdouble2rv, },        
@@ -701,7 +718,7 @@ static void rv2jstring(JNIEnv* jenv, VALUE val, jvalue* jv, const char* psig, in
 		Data_Get_Struct(val, struct jvi_data, ptr);
 		if ((*jenv)->IsInstanceOf(jenv, ptr->obj, j_string))
 		{
-		    return; // never delete at this time
+		    return; /* never delete at this time */
 		}
 	    }
 	}
@@ -725,7 +742,7 @@ static void rv2jobject(JNIEnv* jenv, VALUE val, jvalue* jv, const char* psig, in
 	}
 	else if (NIL_P(val))
 	{
-	    // no-op
+	    /* no-op */
 	}
 	else if (FIXNUM_P(val))
 	{
@@ -751,7 +768,7 @@ static void rv2jobject(JNIEnv* jenv, VALUE val, jvalue* jv, const char* psig, in
 	    case T_DATA:
 	        if (RBASIC(val)->klass == rjbi || RBASIC(val)->klass == rjb)
 		{
-		    // TODO: check instanceof (class (in psig) )
+		    /* TODO: check instanceof (class (in psig) ) */
 		    struct jvi_data* ptr;
 		    Data_Get_Struct(val, struct jvi_data, ptr);
 		    jv->l = ptr->obj;
@@ -812,7 +829,7 @@ static void check_fixnumarray(VALUE v)
     int i;
     int len = RARRAY_LEN(v);
     VALUE* p = RARRAY_PTR(v);
-    // check all fixnum (overflow is permit)
+    /* check all fixnum (overflow is permit) */
     for (i = 0; i < len; i++)
     {
 	if (!FIXNUM_P(*p++))
@@ -829,7 +846,7 @@ static jarray r2barray(JNIEnv* jenv, VALUE v, const char* cls)
     {
 	ary = (*jenv)->NewByteArray(jenv, RSTRING_LEN(v));
 	(*jenv)->SetByteArrayRegion(jenv, ary, 0, RSTRING_LEN(v),
-				    RSTRING_PTR(v));
+				    (const jbyte*)RSTRING_PTR(v));
     }
     else if (TYPE(v) == T_ARRAY)
     {
@@ -1079,7 +1096,7 @@ static void rv2jarray(JNIEnv* jenv, VALUE val, jvalue* jv, const char* psig, int
         jarray ja = NULL;
 	if (NIL_P(val))
 	{
-	    // no-op, null for an array
+	    /* no-op, null for an array */
 	}
         else if (*(psig + 1) == '[')
         {
@@ -1178,7 +1195,7 @@ static J2R get_arrayconv(const char* cname, char* pdepth)
             return jcvt[i].ja2r;
         }
     }
-    return jarray2rv;
+    return &jarray2rv;
 }
 
 static J2R get_j2r(JNIEnv* jenv, jobject cls, char* psig, char* pdepth, char* ppsig, off_t* piv, int static_method)
@@ -1333,7 +1350,6 @@ static void create_methodinfo(JNIEnv* jenv, st_table* tbl, jobject m, int static
 {
     struct cls_method* result;
     struct cls_method* pm;    
-    char* param = NULL;
     const char* jname;
     jstring nm;
     jobjectArray parama;
@@ -1362,7 +1378,7 @@ static void create_methodinfo(JNIEnv* jenv, st_table* tbl, jobject m, int static
     (*jenv)->DeleteLocalRef(jenv, cls);
     result->static_method = static_method;
     register_methodinfo(result, tbl);
-    // create method alias
+    /* create method alias */
     pm = NULL;
     if (strlen(rname) > 3
         && (*rname == 'g' || *rname == 's') && *(rname + 1) == 'e' && *(rname + 2) == 't')
@@ -1409,7 +1425,6 @@ static void create_fieldinfo(JNIEnv* jenv, st_table* tbl, jobject f, int readonl
     jobject cls;
     char sigs[256];
     off_t iv = 0;
-    char sig = 0;
 
     result = ALLOC(struct cls_field);
     memset(result, 0, sizeof(struct cls_field));
@@ -1525,7 +1540,7 @@ static void load_constants(JNIEnv* jenv, jclass klass, VALUE self, jobjectArray
 	    char sigs[256];
             char* pname;
 
-	    // constants make define directly in the ruby object
+	    /* constants make define directly in the ruby object */
 	    cls = (*jenv)->CallObjectMethod(jenv, f, field_getType);
 	    rjb_check_exception(jenv, 0);
 	    iv = 0;
@@ -1673,67 +1688,44 @@ static VALUE rjb_s_load(int argc, VALUE* argv, VALUE self)
         main_jenv = jenv;
     }
 
-    jconstructor = (*jenv)->FindClass(jenv, "java/lang/reflect/Constructor");
-    rjb_check_exception(jenv, 1);
-    ctrGetParameterTypes = (*jenv)->GetMethodID(jenv, jconstructor, "getParameterTypes", "()[Ljava/lang/Class;");
-    rjb_check_exception(jenv, 1);
-    jmethod = (*jenv)->FindClass(jenv, "java/lang/reflect/Method");
-    method_getModifiers = (*jenv)->GetMethodID(jenv, jmethod, "getModifiers", "()I");
-    rjb_check_exception(jenv, 1);
-    method_getName = (*jenv)->GetMethodID(jenv, jmethod, "getName", "()Ljava/lang/String;");
-    rjb_check_exception(jenv, 1);	
-    getParameterTypes = (*jenv)->GetMethodID(jenv, jmethod, "getParameterTypes", "()[Ljava/lang/Class;");
-    rjb_check_exception(jenv, 1);	
-    getReturnType = (*jenv)->GetMethodID(jenv, jmethod, "getReturnType", "()Ljava/lang/Class;");
-    rjb_check_exception(jenv, 1);
+    RJB_FIND_CLASS(jconstructor, "java/lang/reflect/Constructor");
+    RJB_LOAD_METHOD(ctrGetParameterTypes, jconstructor, "getParameterTypes", "()[Ljava/lang/Class;");
+    RJB_FIND_CLASS(jmethod, "java/lang/reflect/Method");
+    RJB_LOAD_METHOD(method_getModifiers, jmethod, "getModifiers", "()I");
+    RJB_LOAD_METHOD(method_getName, jmethod, "getName", "()Ljava/lang/String;");
+    RJB_LOAD_METHOD(getParameterTypes, jmethod, "getParameterTypes", "()[Ljava/lang/Class;");
+    RJB_LOAD_METHOD(getReturnType, jmethod, "getReturnType", "()Ljava/lang/Class;");
 
-    jfield = (*jenv)->FindClass(jenv, "java/lang/reflect/Field");
-    field_getModifiers = (*jenv)->GetMethodID(jenv, jfield, "getModifiers", "()I");
-    rjb_check_exception(jenv, 1);
-    field_getName = (*jenv)->GetMethodID(jenv, jfield, "getName", "()Ljava/lang/String;");
-    rjb_check_exception(jenv, 1);	
-    field_getType = (*jenv)->GetMethodID(jenv, jfield, "getType", "()Ljava/lang/Class;");
-    rjb_check_exception(jenv, 1);	
+    RJB_FIND_CLASS(jfield, "java/lang/reflect/Field");
+    RJB_LOAD_METHOD(field_getModifiers, jfield, "getModifiers", "()I");
+    RJB_LOAD_METHOD(field_getName, jfield, "getName", "()Ljava/lang/String;");
+    RJB_LOAD_METHOD(field_getType, jfield, "getType", "()Ljava/lang/Class;");
 
-    j_class = (*jenv)->FindClass(jenv, "java/lang/Class");
-    rjb_check_exception(jenv, 1);
-    rjb_class_getName = (*jenv)->GetMethodID(jenv, j_class, "getName", "()Ljava/lang/String;");
-    rjb_check_exception(jenv, 1);
-    j_class = (*jenv)->NewGlobalRef(jenv, j_class);
+    RJB_HOLD_CLASS(j_class, "java/lang/Class");
+    RJB_LOAD_METHOD(rjb_class_getName, j_class, "getName", "()Ljava/lang/String;");
 
-    rjb_j_throwable = (*jenv)->FindClass(jenv, "java/lang/Throwable");
-    rjb_check_exception(jenv, 1);
-    rjb_throwable_getMessage = (*jenv)->GetMethodID(jenv, rjb_j_throwable, "getMessage", "()Ljava/lang/String;");
-    rjb_check_exception(jenv, 1);
+    RJB_HOLD_CLASS(rjb_j_throwable, "java/lang/Throwable");
+    RJB_LOAD_METHOD(rjb_throwable_getMessage, rjb_j_throwable, "getMessage", "()Ljava/lang/String;");
 
-    j_string = (*jenv)->FindClass(jenv, "java/lang/String");
-    rjb_check_exception(jenv, 1);
-    str_tostring = (*jenv)->GetMethodID(jenv, j_string, "toString", "()Ljava/lang/String;");
-    rjb_check_exception(jenv, 1);
-    j_string = (*jenv)->NewGlobalRef(jenv, j_string);
+    RJB_HOLD_CLASS(j_string, "java/lang/String");
+    RJB_LOAD_METHOD(str_tostring, j_string, "toString", "()Ljava/lang/String;");
 
-    j_object = (*jenv)->FindClass(jenv, "java/lang/Object");
-    rjb_check_exception(jenv, 1);
-    j_object = (*jenv)->NewGlobalRef(jenv, j_object);
+    RJB_HOLD_CLASS(j_object, "java/lang/Object");
 
     for (i = PRM_INT; i < PRM_LAST; i++)
     {
 	jclass klass = (*jenv)->FindClass(jenv, jpcvt[i].classname);
 	if (i == PRM_BOOLEAN)
 	{
-	    jpcvt[i].ctr_id = (*jenv)->GetStaticMethodID(jenv,
-			 klass, "valueOf", jpcvt[i].ctrsig);
-	    rjb_check_exception(jenv, 1);
+            RJB_LOAD_STATIC_METHOD(jpcvt[i].ctr_id, klass, "valueOf", jpcvt[i].ctrsig);
 	}
 	else if (jpcvt[i].ctrsig)
 	{
-	    jpcvt[i].ctr_id = (*jenv)->GetMethodID(jenv, klass,
-						   "<init>", jpcvt[i].ctrsig);
-	    rjb_check_exception(jenv, 1);
+            RJB_LOAD_METHOD(jpcvt[i].ctr_id, klass, "<init>", jpcvt[i].ctrsig);
 	}
-	jpcvt[i].to_prim_id = (*jenv)->GetMethodID(jenv, klass,
+        RJB_LOAD_METHOD(jpcvt[i].to_prim_id, klass,
 				   jpcvt[i].to_prim_method, jpcvt[i].prmsig);
-	rjb_check_exception(jenv, 1);
+
         jpcvt[i].klass = (*jenv)->NewGlobalRef(jenv, klass);
     }
 
@@ -1749,6 +1741,9 @@ static VALUE rjb_s_load(int argc, VALUE* argv, VALUE self)
  */
 VALUE rjb_load_vm_default()
 {
+    if (rjb_jvm) return Qfalse;
+
+    rb_warning("Rjb::implicit jvm loading");
     return rjb_s_load(0, NULL, 0);
 }
 
@@ -1766,15 +1761,16 @@ static int clear_classes(VALUE key, VALUE val, VALUE dummy)
 }
 static VALUE rjb_s_unload(int argc, VALUE* argv, VALUE self)
 {
+    int result = 0;
     st_foreach(RHASH_TBL(rjb_loaded_classes), clear_classes, 0);
     if (rjb_jvm)
     {
         JNIEnv* jenv = rjb_attach_current_thread();
-	(*jenv)->ExceptionClear(jenv);
-	(*rjb_jvm)->DestroyJavaVM(rjb_jvm);
-	rjb_jvm = NULL;
+        (*jenv)->ExceptionClear(jenv);
+        result = (*rjb_jvm)->DestroyJavaVM(rjb_jvm);
+        rjb_jvm = NULL;
     }
-    return Qnil;
+    return INT2NUM(result);
 }
 
 /*
@@ -1808,6 +1804,7 @@ static VALUE rjb_s_get_pconversion(VALUE self)
 /*
  * free java class
  */
+#if 0
 static void free_constructor(struct cls_constructor* p)
 {
     free(p->arg_convert);
@@ -1821,6 +1818,7 @@ static int free_method_item(ID key, struct cls_method* pm, int dummy)
     }
     return ST_CONTINUE;
 }
+#endif
 
 /*
  * finalize Object instance
@@ -1996,7 +1994,7 @@ static int check_rtype(JNIEnv* jenv, VALUE v, char* p)
     case T_DATA:
         if (RBASIC(v)->klass == rjbi && pcls)
 	{
-	    // imported object
+	    /* imported object */
 	    jclass cls;
             struct jvi_data* ptr;
 	    int result = 0;
@@ -2010,9 +2008,9 @@ static int check_rtype(JNIEnv* jenv, VALUE v, char* p)
 	    }
 	    return result;
 	}
-	// fall down to the next case 
+	/* fall down to the next case */
     case T_OBJECT:
-	// fall down to the next case
+	/* fall down to the next case */
     default:
         if (pcls || *p == '[')
         {
@@ -2129,11 +2127,12 @@ static VALUE rjb_s_bind(VALUE self, VALUE rbobj, VALUE itfname)
 {
     VALUE result = Qnil;
     JNIEnv* jenv = NULL;
-
+    jclass itf;
+    
     rjb_load_vm_default();
     jenv = rjb_attach_current_thread();
     (*jenv)->ExceptionClear(jenv);
-    jclass itf = rjb_find_class(jenv, itfname); 
+    itf = rjb_find_class(jenv, itfname); 
     rjb_check_exception(jenv, 1);
     if (itf)
     {
@@ -2468,7 +2467,7 @@ static VALUE invoke(JNIEnv* jenv, struct cls_method* pm, struct jvi_data* ptr,
     }
     if (!found)
     {
-	char* tname = rb_id2name(orgpm->name);
+	const char* tname = rb_id2name(orgpm->name);
 	if (sig) 
 	{
 	    rb_raise(rb_eRuntimeError, "Fail: unknown method name `%s(\'%s\')'", tname, sig);
@@ -2557,7 +2556,7 @@ static VALUE invoke_by_instance(ID rmid, int argc, VALUE* argv,
     JNIEnv* jenv = rjb_attach_current_thread();
     struct cls_field* pf;
     struct cls_method* pm;
-    char* tname = rb_id2name(rmid);
+    const char* tname = rb_id2name(rmid);
     
     if (argc == 0 && st_lookup(ptr->fields, rmid, (st_data_t*)&pf))
     {
@@ -2575,7 +2574,7 @@ static VALUE invoke_by_instance(ID rmid, int argc, VALUE* argv,
                 setter(jenv, pf, ptr, *argv);
                 return ret;
             }
-            // fall through for the setter alias name
+            /* fall through for the setter alias name */
         }
         if (st_lookup(ptr->methods, rmid, (st_data_t*)&pm))
         {
@@ -2623,7 +2622,7 @@ static VALUE invoke_by_class(ID rmid, int argc, VALUE* argv,
     struct jv_data* clsptr;
     struct cls_field* pf;
     struct cls_method* pm;
-    char* tname = rb_id2name(rmid);
+    const char* tname = rb_id2name(rmid);
     JNIEnv* jenv = rjb_attach_current_thread();
 
     Data_Get_Struct(jklass, struct jv_data, clsptr);
@@ -2700,7 +2699,7 @@ static VALUE rjb_missing(int argc, VALUE* argv, VALUE self)
 {
     struct jv_data* ptr;
     ID rmid = rb_to_id(argv[0]);
-    char* rmname = rb_id2name(rmid);
+    const char* rmname = rb_id2name(rmid);
     if (isupper(*rmname))
     {
         VALUE r, args[2];
@@ -2832,7 +2831,7 @@ JNIEXPORT jobject JNICALL Java_jp_co_infoseek_hp_arton_rjb_RBridge_call
             *(argv + 2) = argc - 3;
             result = rb_protect(safe_funcall, (VALUE)argv, &sstat);
 	    rv2jobject(jenv, result, &j, NULL, 0);
-	    // I can't delete this object...
+	    /* I can't delete this object... */
             break;
 	}
     }

data/ext/rjbexception.c

@@ -12,7 +12,7 @@
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Lesser General Public License for more details.
  *
- * $Id: rjbexception.c 64 2008-03-05 14:24:22Z kuwa1 $
+ * $Id: rjbexception.c 75 2008-08-14 10:03:52Z arton $
  */
 
 #include "ruby.h"
@@ -109,7 +109,6 @@ void rjb_check_exception(JNIEnv* jenv, int t)
 	    (*jenv)->ExceptionDescribe(jenv);
 	}
 	(*jenv)->ExceptionClear(jenv);
-//        if (t)
         if(1)
 	{
  	    char* msg = "unknown exception";

data/test/test.rb

@@ -1,5 +1,5 @@
 #!/usr/local/env ruby
-# $Id: test.rb 63 2008-03-04 15:34:24Z kuwa1 $
+# $Id: test.rb 70 2008-05-26 12:31:35Z arton $
 
 begin
   require 'rjb'
@@ -27,8 +27,7 @@ class TestRjb < Test::Unit::TestCase
     @jChar = Rjb::import('java.lang.Character')
   end
 
-  def tearDown
-    unload
+  def teardown
   end
 
   def test_metaclass
@@ -616,5 +615,16 @@ class TestRjb < Test::Unit::TestCase
     assert_equal "\0\x1\x2\x3\x4", map.get('abc')
     assert_equal "\x5\x6\x7\x8\x9", map.get('def')
   end
+
+  def x_test_zzunload
+    # this test should run at the last
+    unload
+    begin
+      load('.')
+      fail 'no exception'
+    rescue
+      assert_equal "can't create Java VM", $!.message
+    end
+  end
 end
 

metadata

@@ -1,78 +1,71 @@
 --- !ruby/object:Gem::Specification 
+rubygems_version: 0.9.0
+specification_version: 1
 name: rjb
 version: !ruby/object:Gem::Version 
-  version: 1.1.3
+  version: 1.1.4
+date: 2008-08-14 00:00:00 +09:00
+summary: Ruby Java bridge
+require_paths: 
+- lib
+email: artonx@gmail.com
+homepage: http://rjb.rubyforge.org/
+rubyforge_project: 
+description: RJB is a bridge program that connect between Ruby and Java with Java Native Interface.
+autorequire: 
+default_executable: 
+bindir: bin
+has_rdoc: false
+required_ruby_version: !ruby/object:Gem::Version::Requirement 
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      version: 1.8.2
+  version: 
 platform: ruby
+signing_key: 
+cert_chain: 
+post_install_message: 
 authors: 
 - arton
-autorequire: 
-bindir: bin
-cert_chain: []
-
-date: 2008-03-26 00:00:00 +09:00
-default_executable: 
-dependencies: []
-
-description: RJB is a bridge program that connect between Ruby and Java with Java Native Interface.
-email: artonx@gmail.com
-executables: []
-
-extensions: 
-- ext/extconf.rb
-extra_rdoc_files: []
-
 files: 
 - ext/RBridge.java
 - ext/load.c
 - ext/riconv.c
-- ext/rjb.c
 - ext/rjbexception.c
-- ext/extconf.h
+- ext/rjb.c
 - ext/jniwrap.h
-- ext/jp_co_infoseek_hp_arton_rjb_RBridge.h
-- ext/riconv.h
 - ext/rjb.h
+- ext/riconv.h
+- ext/jp_co_infoseek_hp_arton_rjb_RBridge.h
+- ext/extconf.h
 - ext/depend
 - data/rjb/jp/co/infoseek/hp/arton/rjb/RBridge.class
 - lib/rjb.rb
 - samples/filechooser.rb
-- test/gctest.rb
 - test/test.rb
-- test/jp/co/infoseek/hp/arton/rjb/Base.class
+- test/gctest.rb
 - test/jp/co/infoseek/hp/arton/rjb/ExtBase.class
+- test/jp/co/infoseek/hp/arton/rjb/Test.class
 - test/jp/co/infoseek/hp/arton/rjb/IBase.class
 - test/jp/co/infoseek/hp/arton/rjb/Test$TestTypes.class
-- test/jp/co/infoseek/hp/arton/rjb/Test.class
+- test/jp/co/infoseek/hp/arton/rjb/Base.class
 - COPYING
 - ChangeLog
 - readme.sj
 - readme.txt
-has_rdoc: false
-homepage: http://rjb.rubyforge.org/
-post_install_message: 
+test_files: 
+- test/test.rb
 rdoc_options: []
 
-require_paths: 
-- lib
-required_ruby_version: !ruby/object:Gem::Requirement 
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      version: 1.8.2
-  version: 
-required_rubygems_version: !ruby/object:Gem::Requirement 
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      version: "0"
-  version: 
+extra_rdoc_files: []
+
+executables: []
+
+extensions: 
+- ext/extconf.rb
 requirements: 
 - none
 - JDK 5.0
-rubyforge_project: 
-rubygems_version: 1.0.1
-signing_key: 
-specification_version: 2
-summary: Ruby Java bridge
-test_files: 
-- test/test.rb
+dependencies: []
+