risbn 0.4.0 → 0.4.2

data/Rakefile

@@ -43,3 +43,22 @@ Rake::RDocTask.new do |rdoc|
   rdoc.rdoc_files.include('README*')
   rdoc.rdoc_files.include('lib/**/*.rb')
 end
+
+
+task :fixturize do
+  $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), 'lib'))
+  require 'risbn'
+  require 'risbn/gdata'
+
+  isbn = RISBN(ENV["ISBN"])
+
+  if isbn.valid?
+    fpath = File.join(File.dirname(__FILE__), "spec", "fixtures", "#{ENV["ISBN"]}.xml")
+
+    File.open(fpath, "w") do |f|
+      f << isbn.gdata.xml
+    end
+  else
+    puts "provide a valid ISBN as an env var."
+  end
+end

data/VERSION

@@ -1 +1 @@
-0.4.0
+0.4.2

data/lib/risbn/gdata.rb

@@ -21,14 +21,16 @@ class RISBN
 
     # performs a google search by isbn to retrieve the actual google book id.
     def entry_url
-      @info ||= ( Nokogiri(open(search_url).read) / "entry" / "id" ).inner_text
+      @info ||= ( Nokogiri(open(search_url).read) / "entry:first" / "id" ).first.inner_text
+    rescue => e
+      raise RuntimeError, "coult not open search url: #{search_url}  : \n#{e}"
     end
 
     # returns the original book xml from google.
     def xml
       @entry ||= open(entry_url).read
     rescue => e
-      raise RuntimeError, "coult not open url: #{entry_url}  : \n#{e}"
+      raise RuntimeError, "coult not open entry url: #{entry_url}  : \n#{e}"
     end
 
     # nokogiri nodes from the xml
@@ -44,28 +46,32 @@ class RISBN
     # returns an openstruct with a massaged version of the original xml data.
     def data
       return @data if @data
-      h, data = to_hash, BookData.new
-
-      data.creator       = h[:creator]
-      data.date          = h[:date]
-      data.description   = h[:description]
-      data.format        = h[:format]
-      data.id            = h[:id]
-      data.identifier    = h[:identifier]
-      data.language      = h[:language]
-      data.publisher     = h[:publisher]
-      data.rating        = h[:rating][:attributes][:average].to_f
-      data.rating_max    = h[:rating][:attributes][:max].to_f
-      data.rating_min    = h[:rating][:attributes][:min].to_f
-      data.subject       = h[:subject].map { |s| s.split(/ [\-\/] /) }.flatten.map(&:strip).uniq.sort
-      data.title         = h[:title].uniq.join(" ")
-      data.updated       = h[:updated]
-      data.category      = h[:category]
-      data.embeddability = h[:embeddability][:value]
-      data.open_access   = h[:openAccess][:value]
-      data.viewability   = h[:viewability][:value]
-
-      h[:link].each do |link|
+      google_hash, data = to_hash, BookData.new
+
+      data.creator       = google_hash[:creator]
+      data.date          = google_hash[:date]
+      data.description   = google_hash[:description]
+      data.format        = google_hash[:format]
+      data.id            = google_hash[:id]
+      data.identifier    = google_hash[:identifier]
+      data.language      = google_hash[:language]
+      data.publisher     = google_hash[:publisher]
+
+      if google_hash[:rating] && google_hash[:rating][:attributes]
+        data.rating        = google_hash[:rating][:attributes][:average].to_f
+        data.rating_max    = google_hash[:rating][:attributes][:max].to_f
+        data.rating_min    = google_hash[:rating][:attributes][:min].to_f
+      end
+
+      data.subject       = google_hash[:subject].map { |s| s.split(/ [\-\/] /) }.flatten.map(&:strip).uniq.sort
+      data.title         = google_hash[:title].uniq.join(" ")
+      data.updated       = google_hash[:updated]
+      data.category      = google_hash[:category]
+      data.embeddability = google_hash[:embeddability][:value]
+      data.open_access   = google_hash[:openAccess][:value]
+      data.viewability   = google_hash[:viewability][:value]
+
+      google_hash[:link].each do |link|
         href = link.is_a?(Hash) ? link[:attributes][:href] : link.last[:href]
         rel  = link.is_a?(Hash) ? link[:attributes][:rel]  : link.last[:rel]
         data.send("#{rel[/thumbnail|info|annotation|alternate|self/]}_url=", href)

data/lib/risbn/version.rb

@@ -1,3 +1,3 @@
 class RISBN
-  VERSION = "0.4.0"
+  VERSION = "0.4.2"
 end

data/risbn.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{risbn}
-  s.version = "0.4.0"
+  s.version = "0.4.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Emmanuel Oga"]
@@ -29,6 +29,7 @@ Gem::Specification.new do |s|
      "lib/risbn/scanner.rb",
      "lib/risbn/version.rb",
      "risbn.gemspec",
+     "spec/fixtures/0072253592.xml",
      "spec/fixtures/book.xml",
      "spec/gdata_spec.rb",
      "spec/risbn_spec.rb",

data/spec/fixtures/0072253592.xml

@@ -0,0 +1 @@
+<?xml version='1.0' encoding='UTF-8'?><entry xmlns='http://www.w3.org/2005/Atom' xmlns:gbs='http://schemas.google.com/books/2008' xmlns:dc='http://purl.org/dc/terms' xmlns:batch='http://schemas.google.com/gdata/batch' xmlns:gd='http://schemas.google.com/g/2005'><id>http://www.google.com/books/feeds/volumes/nbioljTdxSgC</id><updated>2010-04-19T19:50:16.000Z</updated><category scheme='http://schemas.google.com/g/2005#kind' term='http://schemas.google.com/books/2008#volume'/><title type='text'>Data structures demystified</title><link rel='http://schemas.google.com/books/2008/thumbnail' type='image/x-unknown' href='http://bks0.books.google.com/books?id=nbioljTdxSgC&amp;printsec=frontcover&amp;img=1&amp;zoom=5&amp;edge=curl&amp;sig=ACfU3U04iS8ZeFWNuSVKvnuMOC3g3dB0Kg&amp;source=gbs_gdata'/><link rel='http://schemas.google.com/books/2008/info' type='text/html' href='http://books.google.com/books?id=nbioljTdxSgC&amp;ie=ISO-8859-1&amp;source=gbs_gdata'/><link rel='http://schemas.google.com/books/2008/annotation' type='application/atom+xml' href='http://www.google.com/books/feeds/users/me/volumes'/><link rel='alternate' type='text/html' href='http://books.google.com/books?id=nbioljTdxSgC&amp;ie=ISO-8859-1'/><link rel='self' type='application/atom+xml' href='http://www.google.com/books/feeds/volumes/nbioljTdxSgC'/><gbs:embeddability value='http://schemas.google.com/books/2008#embeddable'/><gbs:openAccess value='http://schemas.google.com/books/2008#disabled'/><gbs:viewability value='http://schemas.google.com/books/2008#view_partial'/><dc:creator>James Edward Keogh</dc:creator><dc:creator>Ken Davidson</dc:creator><dc:date>2004-02-23</dc:date><dc:description>Whether you are an entry-level or seasoned designer or programmer, learn all about data structures in this easy-to-understand, self-teaching guide that can be directly applied to any programming language. From memory and addresses to hashtables, authors Keogh and Davidson, provide clear explanations that demystify this “algebra of programming.”</dc:description><dc:format>Dimensions 18.5x24.0x1.8 cm</dc:format><dc:format>291 pages</dc:format><dc:format>book</dc:format><dc:identifier>nbioljTdxSgC</dc:identifier><dc:identifier>ISBN:0072253592</dc:identifier><dc:identifier>ISBN:9780072253597</dc:identifier><dc:language>en</dc:language><dc:publisher>McGraw-Hill Professional</dc:publisher><dc:subject>Data structures (Computer science)</dc:subject><dc:subject>Computer programming</dc:subject><dc:subject>Data structures (Computer science)</dc:subject><dc:subject>File organization (Computer science)</dc:subject><dc:subject>File organization (Computer science)</dc:subject><dc:subject>Computers / Database Management / General</dc:subject><dc:subject>Computers / Programming / General</dc:subject><dc:subject>Computers / Programming / Algorithms</dc:subject><dc:title>Data structures demystified</dc:title></entry>

data/spec/gdata_spec.rb

@@ -18,7 +18,7 @@ describe RISBN::GData do
 
   context "#data" do
     let(:isbn) { RISBN("9780596101992") }
-    before     { isbn.gdata.stub!(:xml).and_return(File.read(GDATA_FIXTURE_PATH)) }
+    before     { isbn.gdata.stub!(:xml).and_return(FIXTURE["book.xml"]) }
 
     let(:required_keys) do
       more = [:open_access, :rating_max, :rating_min, :thumbnail_url,
@@ -27,7 +27,6 @@ describe RISBN::GData do
     end
 
     subject { isbn.gdata.data }
-
     it { should be_an_instance_of(RISBN::GData::BookData) }
 
     it "maps the attributes of the hash form of the google response to an struct" do
@@ -40,4 +39,13 @@ describe RISBN::GData do
       isbn.gdata.data.keys.should_not be_empty
     end
   end
+
+  context "specific cases" do
+    context "0072253592" do
+      let(:isbn) { RISBN("0072253592") }
+      before     { isbn.gdata.stub!(:xml).and_return(FIXTURE["#{isbn.to_s}.xml"]) }
+      subject    { isbn.gdata.data }
+      it         { should be_an_instance_of(RISBN::GData::BookData) }
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -6,7 +6,7 @@ require 'risbn/gdata'
 require 'spec'
 require 'spec/autorun'
 
-GDATA_FIXTURE_PATH = File.join(File.dirname(__FILE__), 'fixtures', 'book.xml')
+FIXTURE = lambda { |f| File.read File.join(File.dirname(__FILE__), 'fixtures', f) }
 
 Spec::Runner.configure do |config|
 end

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 4
-  - 0
-  version: 0.4.0
+  - 2
+  version: 0.4.2
 platform: ruby
 authors: 
 - Emmanuel Oga
@@ -65,6 +65,7 @@ files:
 - lib/risbn/scanner.rb
 - lib/risbn/version.rb
 - risbn.gemspec
+- spec/fixtures/0072253592.xml
 - spec/fixtures/book.xml
 - spec/gdata_spec.rb
 - spec/risbn_spec.rb