rippersnapper 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e4f4a7e8091b50527bdafa4c87972ede333f694f
-  data.tar.gz: 91cdf3585d3d3801e247a1999109ff0a48f8e2b5
+  metadata.gz: f532fc959d773f20cf0542ec71061e82a3d32808
+  data.tar.gz: a092b51bae916693b046b012816316d69f390179
 SHA512:
-  metadata.gz: b8cd9f500fef2b9aa50570f3a3e75933fc9995a5968f8a63c8b70fd7879c11ec39cd025f6e243e42e69d3dcfeb7a31b6201e99143d4b9fc1126337bec942c47c
-  data.tar.gz: c56fa40791c55fbd0544fb9a518b63316c2322585c0f7f5367de931f1678cec6d638e161641e0275304238e565914df576f90ab3b944b8c699fdae54da804963
+  metadata.gz: 49eaf5932ee7b4611f78c4083201bf7007984726445e5dbe7d37f26c84feb2156a1105924f59887bbc94c861c39d8de766e7eb16e27b2a2e8470c445302cbea5
+  data.tar.gz: 7df9d142edf0e98bae8d3db17045f2771d5a3510971937be8cf42d01a2824353f6e9ead1a701edc4e4769f5c3167a2d469572da3dc348263fda23c03c2acf3a7

data/lib/rippersnapper/domain_parser.rb

@@ -1,6 +1,5 @@
 module Rippersnapper
   class DomainParser
-    attr_reader :domain, :subdomain
 
     def initialize url
       @url = url
@@ -13,14 +12,14 @@ module Rippersnapper
           test = url_parts.last(iteration + 1).join(".")
           found = test if suffix_exists?(test)
         end
-        found
+        found.to_s
       end
     end
 
     def domain
       @domain ||= begin
         remaining = url_parts - suffix_parts
-        remaining.last
+        remaining.last.to_s
       end
     end
 

data/lib/rippersnapper/suffix_file_reader.rb

@@ -9,8 +9,6 @@ module Rippersnapper
 
     def initialize file = nil
       @file = file || File.open(File.dirname(__FILE__) + "/public_suffix.dat", 'r')
-      # Recursive hash of hashes http://stackoverflow.com/a/170240/973860
-      #@public_suffixes = Hash.new(&(p=lambda{|h,k| h[k] = Hash.new(&p)}))
       @public_suffixes = Hash.new { false }
       parse_file
     end
@@ -26,6 +24,8 @@ module Rippersnapper
 
     private
 
+    # NOTE: This could be extracted into an object if something more robust is
+    # needed in the future
     def parse_file
       file.each_line do |line|
         line = line.strip
@@ -34,7 +34,5 @@ module Rippersnapper
         end
       end
     end
-
   end
-
 end

data/lib/rippersnapper/url.rb

@@ -2,10 +2,9 @@ require 'URI'
 
 module Rippersnapper
   class Url
-    attr_accessor :subdomain, :domain
 
     def initialize url
-      @url = url
+      @url = url.to_s
     end
 
     def uri
@@ -13,7 +12,7 @@ module Rippersnapper
     end
 
     def url
-      return @url if @url =~ /:\/\//
+      return @url if @url =~ /:\/\// || @url.empty?
       "http://#{@url}"
     end
 
@@ -30,11 +29,11 @@ module Rippersnapper
     end
 
     def scheme
-      uri.scheme
+      uri.scheme || ""
     end
 
     def host
-      uri.host
+      uri.host || ""
     end
 
     def path

data/lib/rippersnapper/version.rb

@@ -1,3 +1,3 @@
 module Rippersnapper
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/spec/rippersnapper/domain_parser_spec.rb

@@ -17,5 +17,13 @@ module Rippersnapper
       its(:domain) { should eq "google" }
       its(:suffix) { should eq "whatever.sapporo.jp" }
     end
+
+    context "empty url" do
+      subject { DomainParser.new "" }
+      its(:subdomain) { should eq "" }
+      its(:domain) { should eq "" }
+      its(:suffix) { should eq "" }
+    end
+
   end
 end

data/spec/rippersnapper/url_spec.rb

@@ -42,5 +42,16 @@ module Rippersnapper
       its(:suffix) { should eq "com" }
       its(:domain) { should eq "google" }
     end
+
+    context "when url is nil" do
+      subject {Url.new nil}
+      its(:url) { should eq "" }
+      its(:path) { should eq "" }
+      its(:scheme) { should eq "" }
+      its(:host) { should eq "" }
+      its(:suffix) { should eq "" }
+      its(:domain) { should eq "" }
+      its(:subdomain) { should eq "" }
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rippersnapper
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Micah Woods
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-12 00:00:00.000000000 Z
+date: 2013-04-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler