ring_sig 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a9a8ff4b8548f802c19f9529c15034fc4c1329ab
-  data.tar.gz: 56e3a1befb6c39b8c8205e49f167598fd3fc0bfa
+  metadata.gz: e795d6a45bee9ade9568ff3585a5571860ee23a4
+  data.tar.gz: 226ad82f45cd1c0037c7e0b91b7c0704308433a8
 SHA512:
-  metadata.gz: d07e37c8ea67cceb18a6eca210cb03ce3c29381a3fe627ed24994a83e3b1093107521cc2b9588f76d26c4469aad9cd9eb266f80e34edfadb80b999d986fb1434
-  data.tar.gz: 594217e061216f7e336827112e9ed01bb35772ba6b6547173eb673d3d79dd385bdd920a6c38231b21134a2e4333a8375440130d6e28b044aa95a3f4d32867305
+  metadata.gz: 20d0ea38c3d96edc5cb36675ebf32e7319a24bbac4c97667c52fc0ebfcb6c5c7deef20a5079ba92f84f002bc95404d27dcb94f064d1e1eef03fa12317542a58c
+  data.tar.gz: a8b6ece0da50a41ebee70fd6d4405f1c7a48347d0a235c76efbd008fcaf26bae16333b02b8d4f4c03c55741c9bf1efd374368db0deeae2aa76f68119a65ce42b

data/CHANGELOG.md

@@ -5,6 +5,27 @@ This gem follows [Semantic Versioning 2.0.0](http://semver.org/spec/v2.0.0.html)
 All classes and public methods are part of the public API, unless explicitly
 noted otherwise in their documentation.
 
+0.4.0
+----
+Release on 2014-09-18
+
+This release maintains API compatibility with version 0.3.0, except for the two
+constants that were removed.
+
+Signatures produced with prior versions may be incompatible with signatures from
+this version.
+
+- Change the `Hasher#hash_string` method so that it can handle ECDSA groups
+  that have a much smaller order than the number of bits they have (such as
+  Curve25519).
+- `Hasher` now validates that its group's byte-length is equal to its hash
+  algorithm's byte-length.
+- Remove support for ECDSA groups that have an order larger than the number of
+  bits they have. Secp160k1 and Secp160r1 fall into this category because their
+  order is larger than 2^160.
+- Remove the `Secp160k1_Ripemd160` and `Secp160r1_Ripemd160` constants, since
+  their groups are no longer supported.
+
 0.3.0
 ----
 Released on 2014-09-15

data/lib/ring_sig/hasher.rb

@@ -18,20 +18,32 @@ module RingSig
     def initialize(group, algorithm)
       @group = group
       @algorithm = algorithm
+
+      algorithm_byte_length = algorithm.digest('a').size
+      if group.byte_length != algorithm_byte_length
+        raise ArgumentError, "Group's byte length (#{group.byte_length}), does not match hash algorithm's byte length (#{algorithm_byte_length})"
+      end
+
+      digest_max = 2 ** (algorithm_byte_length * 8) - 1
+      if digest_max < group.order
+        raise ArgumentError, "Invalid ECDSA group. Group's order must be less than the hash algorithm's maximum value"
+      end
+
+      @hash_cieling = digest_max - digest_max % group.order
     end
 
-    # Continuously hashes until a value less than the group's order is found.
+    # Uniformly hashes a string to a number between 0 and the group's order.
     #
-    # @param s (String) The value to be hashed.
+    # @param s (String) The string to be hashed.
     # @return (Integer) A number between 0 and the group's order.
     def hash_string(s)
       n = nil
       loop do
         s = algorithm.digest(s)
         n = s.unpack('H*').first.to_i(16)
-        break if n < @group.order
+        break if n < @hash_cieling
       end
-      n
+      n % group.order
     end
 
     # Hashes an array. Converts the Array to an OpenSSL::ASN1::Sequence der
@@ -59,7 +71,8 @@ module RingSig
     # Hashes a point to another point.
     #
     # @param point [ECDSA::Point] The point to be hashed.
-    # @return [ECDSA::Point] A new point, deterministically computed from the input point.
+    # @return [ECDSA::Point] A new point, deterministically computed from the
+    #   input point.
     def hash_point(point)
       @group.generator * hash_array(point.coords)
     end
@@ -67,7 +80,8 @@ module RingSig
     # Shuffles an array in a deterministic manner.
     #
     # @param array (Array) The array to be shuffled.
-    # @param seed (Integer) A random seed which determines the outcome of the suffle.
+    # @param seed (Integer) A random seed which determines the outcome of the
+    #   shuffle.
     # @return (Array) The shuffled array.
     def shuffle(array, seed)
       seed_array = [seed, 0]
@@ -102,7 +116,5 @@ module RingSig
     Secp256k1_Sha256 = new(ECDSA::Group::Secp256k1, OpenSSL::Digest::SHA256)
     Secp256r1_Sha256 = new(ECDSA::Group::Secp256r1, OpenSSL::Digest::SHA256)
     Secp384r1_Sha384 = new(ECDSA::Group::Secp384r1, OpenSSL::Digest::SHA384)
-    Secp160k1_Ripemd160 = new(ECDSA::Group::Secp160k1, OpenSSL::Digest::RIPEMD160)
-    Secp160r1_Ripemd160 = new(ECDSA::Group::Secp160r1, OpenSSL::Digest::RIPEMD160)
   end
 end

data/lib/ring_sig/version.rb

@@ -1,4 +1,4 @@
 module RingSig
   # This gem's version.
-  VERSION = '0.3.0'
+  VERSION = '0.4.0'
 end

data/spec/hasher_spec.rb

@@ -50,10 +50,10 @@ describe RingSig::Hasher do
     end
   end
 
-  context 'Simple hasher, simple group' do
+  context 'Simple hash algorithm, simple group' do
     let(:group) do
-      # A simple group with order equal to 200
-      ECDSA::Group.new(name: 'simple', p: 1, a: 1, b: 1, g: [0, 1], n: 200, h: 1)
+      # A simple 8-bit group with order equal to 200
+      ECDSA::Group.new(name: 'simple', p: 211, a: 1, b: 1, g: [0, 1], n: 200, h: 1)
     end
 
     let(:hash_algorithm) do
@@ -61,7 +61,7 @@ describe RingSig::Hasher do
       stub_const 'SimpleHashAlgorithm', Class.new
       SimpleHashAlgorithm.class_eval do
         def self.digest(s)
-          [(OpenSSL::Digest::SHA256.hexdigest(s).to_i(16) % 256).to_s(16)].pack('H*')
+          [OpenSSL::Digest::SHA256.hexdigest(s)[-2,2]].pack('H*')
         end
       end
       SimpleHashAlgorithm
@@ -77,17 +77,51 @@ describe RingSig::Hasher do
     end
     it_behaves_like 'hash algorithm', 'a',    "\xBB" # 187
     it_behaves_like 'hash algorithm', '0',    "\xE9" # 233
-    it_behaves_like 'hash algorithm', "\xE9", "\xD0" # 208
-    it_behaves_like 'hash algorithm', "\xD0", "\x15" # 21
+    it_behaves_like 'hash algorithm', "\xE9", "\r"   # 13
 
     describe '#hash_string' do
       it 'hashes "a" to 187' do
         expect(hasher.hash_string('a')).to eq 187
       end
 
-      it 'hashes "0" to 21' do
-        expect(hasher.hash_string('0')).to eq 21
+      it 'hashes "0" to 13' do
+        expect(hasher.hash_string('0')).to eq 13
       end
     end
   end
+
+  context 'Curve25519-like group' do
+    # This gem is not yet compatible with Curve25519, but we still test the
+    # hasher against it. Curve25519 has a distinct characteristic: its
+    # order is much smaller than its prime.
+    let(:group) do
+      ECDSA::Group.new(name: 'Curve25519-like', p: 2**255-19, a: 1, b: 1, g: [0, 1], n: 2**252+27742317777372353535851937790883648493, h: 1)
+    end
+
+    let(:hasher) { RingSig::Hasher.new(group, OpenSSL::Digest::SHA256) }
+
+    describe '#hash_string' do
+      it 'hashes "a"' do
+        expect(hasher.hash_string('a')).to eq 4790813224456470967164382530524007151295684942355166730955189790754105481631
+      end
+
+      it 'hashes "0"' do
+        expect(hasher.hash_string('0')).to eq 7203293323279838689554303289673273753938185156274697627287051646710131340360
+      end
+    end
+
+  end
+
+  context 'Non-matching byte-lengths' do
+    it 'raises an ArgumentError if group byte length does not match the hash algorithm byte length' do
+      expect { RingSig::Hasher.new(ECDSA::Group::Secp256k1, OpenSSL::Digest::SHA224) }.to raise_error(ArgumentError)
+    end
+  end
+
+  context 'ECDSA group with an order larger than the maximum digest size' do
+    it 'raises an ArgumentError' do
+      expect { RingSig::Hasher.new(ECDSA::Group::Secp160k1, OpenSSL::Digest::RIPEMD160) }.to raise_error(ArgumentError)
+    end
+  end
+
 end

data/spec/private_key_spec.rb

@@ -106,12 +106,12 @@ describe RingSig::PrivateKey do
     end
   end
 
-  context 'alternate hasher' do
+  context 'Secp384r1_Sha384 hasher' do
     before(:all) do
-      @key = RingSig::PrivateKey.new(1, RingSig::Hasher::Secp160k1_Ripemd160)
+      @key = RingSig::PrivateKey.new(1, RingSig::Hasher::Secp384r1_Sha384)
       @foreign_keys = [
-          RingSig::PrivateKey.new(2, RingSig::Hasher::Secp160k1_Ripemd160).public_key,
-          RingSig::PrivateKey.new(3, RingSig::Hasher::Secp160k1_Ripemd160).public_key,
+          RingSig::PrivateKey.new(2, RingSig::Hasher::Secp384r1_Sha384).public_key,
+          RingSig::PrivateKey.new(3, RingSig::Hasher::Secp384r1_Sha384).public_key,
         ]
     end
 
@@ -119,9 +119,9 @@ describe RingSig::PrivateKey do
       it 'signs and verifies' do
         sig, public_keys = @key.sign(message, @foreign_keys)
 
-        expect(sig.to_hex).to eq '3081a004150335d6eb01d7c658c2aae34e1e910e1b44c993069d30430214685baa33eacec37ff3530d710ca852731e1ac7b0021500881bf1e9c67d05c7a8a6ef93552a7852466034360214211b72b5e3a934d0e096441c5208b4322a83b7a130420214098d90e6e0a5e08186815be4a20a41480d55d7c202141cd9f8cc0df48519ecd6ad6e354ca634c8b604c2021415019f51cc2480ef6148dcd35a4be28037bf8899'
+        expect(sig.to_hex).to eq '3082016904310303c438f3cfc6d9b4d3da7ee4f23429387a3e9da42f87ac611ee390c007a81662e146a865f288111b758231917ce94436308197023100811608759c6a1a0afb245ffa6f15bcea8e6e02e6364371a232f74afbec60874770f66c2f87ad9dd9c851b80d38809bbe023063f90482db5f68dae8c8a45354189103ba3ff6c96d2114f1591300e17845e81e859dfb6996ae6ba9a011a20f820522b102307cb090c3788667d0bbf612853b2fb80856af833a26197a16df9b14a02e734a7bd8539e7d21e4ffd355a39dd9286e4898308199023100a803ebf9a67eb5fa91907d70bb53d93b192a206961e920afc99d8f3e3bbb8a8a2ece89c5a3dcd24dbc9a08a8f61c40bf02310097f561a1c60e7692a50c6e5be6a1ce8b52d88e228de552492351c845bc96180d9ac1578e0dc3b2a775a33d87b58f6155023100f670b730d0b719f1aced4dfbeeb027299f2b58b3297563b50dfb7e0e0fa67b04ce5a8c15b163227b7bdcd42bf8b6f572'
 
-        expected_public_keys = [2, 1, 0].map{|i| ([@key] + @foreign_keys)[i].public_key}
+        expected_public_keys = [2, 0, 1].map{|i| ([@key] + @foreign_keys)[i].public_key}
         expect(public_keys).to eq expected_public_keys
 
         expect(sig.verify(message, public_keys)).to be true

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ring_sig
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Stephen McCarthy
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-15 00:00:00.000000000 Z
+date: 2014-09-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler