ring_cache 1.0 → 1.0.1

data/.gitignore

@@ -20,3 +20,4 @@ tmp
 *.o
 *.a
 mkmf.log
+ring_cache.sublime-*

data/lib/ring_cache.rb

@@ -99,11 +99,14 @@ class RingCache
   end
 
   def write(key, data)
-    evict_oldest if must_evict?
+    unless evict(key)
+      evict_oldest if must_evict?
+    end
     data = data.dup if @duplicate_on_store and !data.nil?
     access_time = Time.now
     @cache[key] = { last_accessed_at: access_time, data: data }
     @access_time_index << [access_time, key]
+    true
   end
 
   private

data/lib/ring_cache/version.rb

@@ -1,3 +1,3 @@
 class RingCache
-  VERSION = '1.0'
+  VERSION = '1.0.1'
 end

data/test/test_ring_cache.rb

@@ -127,16 +127,17 @@ class TestRingCache < Minitest::Test
   end
 
   def test_random_data
-    cache = RingCache.new(capacity: 1_000)
+    cache = RingCache.new(capacity: 1_000, target_hit_rate: 0.4)
     data = random_data(2_000, 10)
 
-    data.each do |element|
+    10_000.times do
+      element = data.sample
       cache.fetch(element[:key]) do
         element[:content]
       end
     end
 
-    assert_equal 1_000, cache.size
+    assert cache.size <= 1_000
     access_time_index = cache.instance_variable_get(:@access_time_index)
     cache_contents = cache.instance_variable_get(:@cache)
     assert_equal cache_contents.size, access_time_index.size

data/test/test_ring_cache_issues.rb

@@ -0,0 +1,16 @@
+#!/usr/bin/env ruby
+
+require File.expand_path('test_helper', File.dirname(__FILE__))
+
+class TestRingCacheIssues < Minitest::Test
+  def test_records_one_index_per_entry
+    c = RingCache.new
+
+    c.write(:a, 1)
+    c.write(:a, 2)
+
+    assert_equal 1, c.size
+    access_time_index = c.instance_variable_get(:@access_time_index)
+    assert_equal 1, access_time_index.size
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ring_cache
 version: !ruby/object:Gem::Version
-  version: '1.0'
+  version: 1.0.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-18 00:00:00.000000000 Z
+date: 2014-10-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -62,6 +62,7 @@ files:
 - test/random_data_generator.rb
 - test/test_helper.rb
 - test/test_ring_cache.rb
+- test/test_ring_cache_issues.rb
 - test/test_ring_cache_performance.rb
 homepage: https://github.com/aredondo/ring_cache
 licenses:
@@ -92,4 +93,5 @@ test_files:
 - test/random_data_generator.rb
 - test/test_helper.rb
 - test/test_ring_cache.rb
+- test/test_ring_cache_issues.rb
 - test/test_ring_cache_performance.rb