riiif 0.3.0 → 0.4.0

metadata

@@ -1,15 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: riiif
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Justin Coyne
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-14 00:00:00.000000000 Z
+date: 2016-07-11 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">"
+      - !ruby/object:Gem::Version
+        version: 3.2.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">"
+      - !ruby/object:Gem::Version
+        version: 3.2.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -81,19 +95,33 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rails
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.2.0
-  type: :runtime
+        version: 0.41.2
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.2.0
+        version: 0.41.2
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.5'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.5'
 description: A IIIF image server
 email:
 - justin@curationexperts.com
@@ -103,6 +131,8 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
 - ".travis.yml"
 - CHANGELOG
 - Gemfile
@@ -114,6 +144,7 @@ files:
 - app/models/riiif/image.rb
 - config/routes.rb
 - lib/riiif.rb
+- lib/riiif/abstract_file_system_resolver.rb
 - lib/riiif/akubra_system_file_resolver.rb
 - lib/riiif/engine.rb
 - lib/riiif/file_system_file_resolver.rb
@@ -123,11 +154,11 @@ files:
 - lib/riiif/routes.rb
 - lib/riiif/version.rb
 - riiif.gemspec
-- spec/controllers/images_controller_spec.rb
-- spec/models/akubra_system_file_resolver_spec.rb
-- spec/models/file_system_file_resolver_spec.rb
-- spec/models/http_file_resolver_spec.rb
-- spec/models/image_spec.rb
+- spec/controllers/riiif/images_controller_spec.rb
+- spec/models/riiif/akubra_system_file_resolver_spec.rb
+- spec/models/riiif/file_system_file_resolver_spec.rb
+- spec/models/riiif/http_file_resolver_spec.rb
+- spec/models/riiif/image_spec.rb
 - spec/routing/redirect_spec.rb
 - spec/routing/resize_routes_spec.rb
 - spec/spec_helper.rb
@@ -158,11 +189,11 @@ signing_key:
 specification_version: 4
 summary: A rails engine that support IIIF requests
 test_files:
-- spec/controllers/images_controller_spec.rb
-- spec/models/akubra_system_file_resolver_spec.rb
-- spec/models/file_system_file_resolver_spec.rb
-- spec/models/http_file_resolver_spec.rb
-- spec/models/image_spec.rb
+- spec/controllers/riiif/images_controller_spec.rb
+- spec/models/riiif/akubra_system_file_resolver_spec.rb
+- spec/models/riiif/file_system_file_resolver_spec.rb
+- spec/models/riiif/http_file_resolver_spec.rb
+- spec/models/riiif/image_spec.rb
 - spec/routing/redirect_spec.rb
 - spec/routing/resize_routes_spec.rb
 - spec/spec_helper.rb

data/spec/controllers/images_controller_spec.rb

@@ -1,138 +0,0 @@
-require 'spec_helper'
-require 'open-uri'
-
-describe Riiif::ImagesController do
-  let(:filename) { File.expand_path('spec/samples/world.jp2') }
-  routes { Riiif::Engine.routes }
-
-  describe "#show" do
-    it "sends images to the service" do
-      image = double
-      expect(Riiif::Image).to receive(:new).with('abcd1234').and_return(image)
-      expect(image).to receive(:render).with("region" => 'full', "size" => 'full',
-                                "rotation" => '0', "quality" => 'default',
-                                "format" => 'jpg').and_return("IMAGEDATA")
-      get :show, id: 'abcd1234', action: "show", region: 'full', size: 'full',
-                 rotation: '0', quality: 'default', format: 'jpg'
-      expect(response).to be_successful
-      expect(response.body).to eq 'IMAGEDATA'
-      expect(response.headers['Link']).to eq '<http://iiif.io/api/image/2/level1.json>;rel="profile"'
-      expect(response.headers['Access-Control-Allow-Origin']).to eq '*'
-    end
-
-    context "with an unauthorized image" do
-      let(:auth) { double("no auth service", can?: false) }
-      let(:not_found_image) { double("not_found_image", render: 'test data') }
-      before do
-        allow(controller).to receive(:authorization_service).and_return(auth)
-        allow(controller).to receive(:not_found_image).and_return(not_found_image)
-      end
-      it "renders 401" do
-        get :show, id: 'abcd1234', action: "show", region: 'full', size: 'full',
-                   rotation: '0', quality: 'default', format: 'jpg'
-        expect(response.body).to eq "test data"
-        expect(response.code).to eq "401"
-      end
-    end
-
-    context "with a invalid region" do
-      it "renders 400" do
-        image = double("an image")
-        allow(image).to receive(:render).and_raise Riiif::InvalidAttributeError
-        allow(Riiif::Image).to receive(:new).with('abcd1234').and_return(image)
-        get :show, id: 'abcd1234', action: "show", region: '`szoW0', size: 'full',
-                   rotation: '0', quality: 'default', format: 'jpg'
-        expect(response.code).to eq "400"
-      end
-    end
-
-    context "with a nonexistent image" do
-      it "should error when a default image isn't sent" do
-        expect(Riiif::Image).to receive(:new).with('bad_id').and_raise(OpenURI::HTTPError.new("fail", StringIO.new))
-        expect do
-          get :show, id: 'bad_id', action: "show", region: 'full', size: 'full',
-                     rotation: '0', quality: 'default', format: 'jpg'
-        end.to raise_error(StandardError)
-      end
-
-      context "with a default image set" do
-        around do |example|
-          old_value = Riiif.not_found_image
-          Riiif.not_found_image = filename
-          example.run
-          Riiif.not_found_image = old_value
-        end
-
-        it "should send the default 'not found' image for failed http files" do
-          not_found_image = double
-          expect(Riiif::Image).to receive(:new) do |id, file|
-            if file.present?
-              not_found_image
-            else
-              raise Riiif::ImageNotFoundError
-            end
-          end.twice
-          expect(not_found_image).to receive(:render).with("region" => 'full', "size" => 'full',
-                                    "rotation" => '0', "quality" => 'default',
-                                    "format" => 'jpg').and_return("default-image-data")
-
-          get :show, id: 'bad_id', action: "show", region: 'full', size: 'full',
-                     rotation: '0', quality: 'default', format: 'jpg'
-          expect(response).to be_not_found
-          expect(response.body).to eq 'default-image-data'
-        end
-
-        it "should send the default 'not found' image for failed files on the filesystem" do
-          not_found_image = double
-          expect(Riiif::Image).to receive(:new) do |id, file|
-            if file.present?
-              not_found_image
-            else
-              raise Riiif::ImageNotFoundError
-            end
-          end.twice
-          expect(not_found_image).to receive(:render).with("region" => 'full', "size" => 'full',
-                                    "rotation" => '0', "quality" => 'default',
-                                    "format" => 'jpg').and_return("default-image-data")
-
-          get :show, id: 'bad_id', action: "show", region: 'full', size: 'full',
-                     rotation: '0', quality: 'default', format: 'jpg'
-          expect(response).to be_not_found
-          expect(response.body).to eq 'default-image-data'
-        end
-      end
-    end
-  end
-
-  describe "info" do
-    it "returns info" do
-      image = double
-      expect(Riiif::Image).to receive(:new).with('abcd1234').and_return(image)
-      expect(image).to receive(:info).and_return({width: 6000, height: 4000 })
-      get :info, id: 'abcd1234', format: 'json'
-      expect(response).to be_successful
-      json = JSON.parse(response.body)
-      expect(json).to eq "@context" => "http://iiif.io/api/image/2/context.json",
-        "@id" =>"http://test.host/images/abcd1234",
-        "width" =>6000,
-        "height" =>4000,
-        "profile" => ["http://iiif.io/api/image/2/level1.json", "formats" => ["jpg", "png"]],
-        'protocol' => 'http://iiif.io/api/image'
-      expect(response.headers['Link']).to eq '<http://iiif.io/api/image/2/level1.json>;rel="profile"'
-      expect(response.headers['Content-Type']).to eq 'application/ld+json; charset=utf-8'
-      expect(response.headers['Access-Control-Allow-Origin']).to eq '*'
-    end
-
-    context "with an unauthorized image" do
-      let(:auth) { double("no auth service", can?: false) }
-      before do
-        allow(controller).to receive(:authorization_service).and_return(auth)
-      end
-      it "renders 401" do
-        get :info, id: 'abcd1234', format: 'json'
-        expect(response.body).to eq "{\"error\":\"unauthorized\"}"
-        expect(response.code).to eq "401"
-      end
-    end
-  end
-end

data/spec/models/akubra_system_file_resolver_spec.rb

@@ -1,13 +0,0 @@
-require 'spec_helper'
-
-describe Riiif::AkubraSystemFileResolver do
-  subject { Riiif::AkubraSystemFileResolver.new(Rails.root.join('../spec/samples/'),'jp2',[[0,2],[2,2],[4,1]]) }
-  it "should raise an error when the file isn't found" do
-    expect{subject.find('demo:2')}.to raise_error Riiif::ImageNotFoundError
-  end
-
-  it "should get the jpeg2000 file" do
-    expect(subject.find('demo:1').path).to eq Riiif::File.new(Dir.glob(subject.pathroot + '22/7e/9/info%3Afedora%2Fdemo%3A1%2Fjp2%2Fjp2.0').first).path
-  end
-
-end

data/spec/models/file_system_file_resolver_spec.rb

@@ -1,19 +0,0 @@
-require 'spec_helper'
-
-describe Riiif::FileSystemFileResolver do
-  subject { Riiif::FileSystemFileResolver.new }
-  it "should raise an error when the file isn't found" do
-    expect{subject.find('1234')}.to raise_error Riiif::ImageNotFoundError
-  end
-
-  it "should get the jpeg2000 file" do
-    expect(subject.find('world').path).to eq subject.root + '/spec/samples/world.jp2'
-  end
-
-  it "should accept ids with dashes" do
-    subject.pattern('foo-bar-baz')
-  end
-  it "should accept ids with colins" do
-    subject.pattern('fo:baz')
-  end
-end