rigortype 0.4.5 → 0.4.6

data/lib/rigor/inference/self_call_ivar_writes.rb

@@ -2,6 +2,7 @@
 
 require "prism"
 
+require_relative "../analysis/dependency_recorder"
 require_relative "../source/node_children"
 require_relative "../source/parameter_envelope"
 require_relative "../type"
@@ -186,7 +187,16 @@ module Rigor
 
         # Whether a `refine` block anywhere in the project defines `name`, on any class: a `using` in effect where the
         # read code sits may route the call to it (`refine Kernel do def warn …`), whatever the receiver.
+        #
+        # Issue #2163 — the answer reads every file's refinements whole, and a refined class off the chain (`Kernel`,
+        # `IO`, `String`) is no `mark:` the chain read files, so it records `refinement:<name>` and `refinement:*`
+        # whichever way it answers, as `InEffectRefinements` consumers do: a file that starts or stops refining the
+        # name re-checks the reader.
         def refined?(name)
+          if Analysis::DependencyRecorder.active?
+            Analysis::DependencyRecorder.read_name(:refinement, name)
+            Analysis::DependencyRecorder.read_name(:refinement, Scope::DiscoveryIndex::REFINEMENT_WILDCARD)
+          end
           @scope.discovered_refinements.any? { |_refined, methods| methods.key?(name) }
         end
 
@@ -240,12 +250,11 @@ module Rigor
         # one file, with one `def` of the name there (a reopening or a `class_eval` body in the same file is a second
         # one), and no `define_method`, `attr_*` or alias of it, nor a rewrite no literal names (`T.define_method`,
         # `T.send(:define_method, …)`, `T.class_eval` with a computed name), nor a definition the walk could not prove
-        # runs (a possible or contested one, as `DefinerResolution` reads them). The class edge files every declaring
-        # file.
+        # runs (a possible or contested one, as `DefinerResolution` reads them). `Scope#parameter_envelopes_of` files
+        # the class edge to every declaring file and, issue #2137, the `mark:` edge for a file that only marks it.
         def single_definition(owner, name)
-          Scope::ResolutionChain.record_class(@scope, owner) if Analysis::DependencyRecorder.active?
+          bucket = @scope.parameter_envelopes_of(owner)
           unprovable! if possible_definition?(owner, name)
-          bucket = @scope.discovered_parameter_envelopes[owner] || {}
           unprovable! if bucket[[:instance, name]] == Source::ParameterEnvelope::OPAQUE
           unprovable! if (@scope.discovered_class_sources[owner]&.size || 0) > 1
           unprovable! if definition_count(owner, name) > 1
@@ -279,9 +288,12 @@ module Rigor
         end
 
         # Whether the project rewrites `class_name`'s method table beyond the names it spells, or refines it.
+        #
+        # Issue #2137 — read through `Scope#parameter_envelopes_of`, which files the `mark:` edge: a `refine` of the
+        # class from a file whose declared classes do not change fires no class key, and adding or removing it must
+        # re-check the reader.
         def rewritten?(class_name)
-          bucket = @scope.discovered_parameter_envelopes[class_name]
-          !bucket.nil? && Scope::DiscoveryIndex.rewritten_surface?(bucket)
+          Scope::DiscoveryIndex.rewritten_surface?(@scope.parameter_envelopes_of(class_name))
         end
 
         # The first project class or module on `class_name`'s settled instance chain that defines `name`, stopping