rigortype 0.4.3 → 0.4.5

data/lib/rigor/lens/file_reader.rb

@@ -8,6 +8,7 @@ require_relative "parameters"
 require_relative "../inference/def_return_typer"
 require_relative "../inference/origin_lookup"
 require_relative "../sig_gen/type_elaborator"
+require_relative "../source/alias_names"
 
 module Rigor
   module Lens
@@ -22,7 +23,10 @@ module Rigor
       # walk cannot place (under an `if`, a `begin`, a block) leaves that default unknown.
       # A `detached` body stands for code that is not the class body (a block, a method body, a superclass
       # expression, an omitted class): its toggles and named calls stay local and change no site.
-      Body = Struct.new(:current, :uncertain, :detached)
+      # `kind` is :module, :class or :singleton. `module_function` is :off, :on (a bare `module_function` written
+      # directly in a module body covers the later direct defs) or :unknown (the reading Ruby gives and the one
+      # `check`'s tables give could differ, so the later defs are omissions).
+      Body = Struct.new(:current, :uncertain, :detached, :kind, :module_function)
 
       ATTRIBUTE_CALLS = { attr_reader: "reader", attr_writer: "writer", attr_accessor: "accessor" }.freeze
       OMITTED_CALLS = {
@@ -30,6 +34,8 @@ module Rigor
         refine: "refine"
       }.freeze
       VISIBILITY_CALLS = %i[private protected public].freeze
+      # Instance methods Ruby makes private whatever the visibility they are defined or aliased with.
+      FORCED_PRIVATE = %w[initialize initialize_copy initialize_clone initialize_dup respond_to_missing?].freeze
       CLASS_VISIBILITY_CALLS = { private_class_method: "private", public_class_method: "public" }.freeze
       BLOCK_NODES = [Prism::BlockNode, Prism::LambdaNode].freeze
       CONSTANT_WRITES = [
@@ -66,10 +72,11 @@ module Rigor
         when Prism::SingletonClassNode then walk_singleton_class(node, nesting, singleton, in_block)
         when Prism::DefNode then read_def(node, nesting, singleton, in_block)
         when Prism::CallNode then walk_call(node, nesting, singleton, in_block)
-        when Prism::AliasMethodNode
-          omit("alias", node.new_name.slice.delete_prefix(":"), node, owner: nesting.last, singleton: singleton)
+        when Prism::AliasMethodNode then read_alias(node, nesting, singleton, in_block)
         when Prism::MultiWriteNode then walk_multi_write(node, nesting, singleton, in_block)
-        when *CONSTANT_WRITES then walk_constant(node, nesting)
+        when Prism::ForNode then walk_assigning(node, node.index, nesting, singleton, in_block)
+        when Prism::RescueNode then walk_assigning(node, node.reference, nesting, singleton, in_block)
+        when *CONSTANT_WRITES then walk_constant(node, nesting, in_block)
         else walk_children(node, nesting, singleton, in_block)
         end
       end
@@ -85,7 +92,7 @@ module Rigor
       end
 
       def detached
-        @bodies.push(Body.new("public", false, true))
+        @bodies.push(Body.new("public", false, true, :detached, :off))
         yield
       ensure
         @bodies.pop
@@ -97,16 +104,16 @@ module Rigor
         if node.is_a?(Prism::ClassNode) && node.superclass
           detached { walk(node.superclass, nesting, singleton: false, in_block: true) }
         end
-        if in_block || name.nil?
-          omit(kind, name || node.constant_path.slice, node)
+        if in_block || name.nil? || constant_scope_unknown?
+          omit(kind, constant_scope_unknown? ? node.constant_path.slice : (name || node.constant_path.slice), node)
           detached { walk(node.body, nesting, singleton: false, in_block: true) } if node.body
           return
         end
 
         add_site(node, { "kind" => kind, "name" => name, "owner" => nil, "scope" => nil, "attribute" => nil,
-                         "members" => [], "visibility" => nil, "params" => nil, "block" => nil,
-                         "body_return" => nil })
-        walk_body(node.body, nesting + [name], singleton: false)
+                         "members" => [], "module_function" => false, "visibility" => nil, "params" => nil,
+                         "block" => nil, "body_return" => nil })
+        walk_body(node.body, nesting + [name], singleton: false, kind: kind.to_sym)
       end
 
       # `class << self` directly in a class or module body opens its singleton class. Any other `class << x`, one
@@ -117,33 +124,79 @@ module Rigor
           return detached { walk(node.body, nesting, singleton: singleton, in_block: true) } if node.body
         end
 
-        walk_body(node.body, nesting, singleton: true)
+        walk_body(node.body, nesting, singleton: true, kind: :singleton)
       end
 
-      # A class body's statements, tracking the running visibility and `module_function`. A bare `module_function`
-      # makes every later `def` of the body a method on both sides: one site, two members, which revision 1 does
-      # not model.
-      def walk_body(body, nesting, singleton:)
+      # A class body's statements, tracking the running visibility and `module_function`.
+      def walk_body(body, nesting, singleton:, kind:)
         return if body.nil?
 
-        @bodies.push(Body.new("public", false, false))
+        @bodies.push(Body.new("public", false, false, kind, :off))
         statements = body.is_a?(Prism::StatementsNode) ? body.body : [body]
-        module_function_on = false
-        statements.each do |child|
-          if module_function_on && child.is_a?(Prism::DefNode)
-            omit("module_function", child.name.to_s, child, owner: nesting.last, singleton: singleton)
-            next
-          end
-          module_function_on = true if bare_call?(child, :module_function)
-          next if toggle_visibility?(child)
-
-          visibility_call(child, nesting, singleton, direct: true) if visibility_call?(child)
-          walk(child, nesting, singleton: singleton, in_block: false)
-        end
+        statements.each { |child| walk_body_statement(child, nesting, singleton) }
       ensure
         @bodies.pop if body
       end
 
+      def walk_body_statement(child, nesting, singleton)
+        return bare_module_function if bare_call?(child, :module_function)
+        return end_module_function if toggle_visibility?(child)
+        return named_module_function(child, nesting, singleton) if named_module_function?(child)
+        return constant_visibility(child, nesting, direct: true) if constant_visibility_call?(child)
+
+        visibility_call(child, nesting, singleton, direct: true) if visibility_call?(child)
+        @direct_statement = child
+        walk(child, nesting, singleton: singleton, in_block: false)
+      ensure
+        @direct_statement = nil
+      end
+
+      # A bare `module_function` directly in a module body turns the mode on for the later direct defs. In a class
+      # (where Ruby raises) or after the mode was left unknown, the later defs stay omissions. A second bare call
+      # after a toggle also stays unknown, though Ruby turns the mode on again: the safe side.
+      def bare_module_function
+        body = @bodies.last
+        body.module_function = body.kind == :module && body.module_function != :unknown ? :on : :unknown
+      end
+
+      # A bare `private` / `public` / `protected` ends the mode in Ruby, but `check`'s tables keep it on. The two
+      # readings differ for the later defs, so they are left as omissions.
+      def end_module_function
+        body = @bodies.last
+        body.module_function = :unknown if body.module_function == :on
+      end
+
+      def named_module_function?(child)
+        child.is_a?(Prism::CallNode) && child.receiver.nil? && child.name == :module_function && child.arguments
+      end
+
+      # A named `module_function` (`module_function :a`, `module_function %i[a]`, `module_function def a`) is an
+      # omission: `check`'s singleton table reads it differently from Ruby (a def nested in the body, a reopened
+      # module, a redefinition after the call, a wrapped def). The instance methods it names turn private in Ruby,
+      # so their visibility reads unknown, and the omission makes each named member contested.
+      def named_module_function(node, nesting, singleton)
+        owner = nesting.last
+        node.arguments.arguments.each do |argument|
+          # The copy replaces any `def self.x` already there, so the singleton side is contested as well.
+          names = argument.is_a?(Prism::DefNode) ? [argument.name.to_s] : argument_names(argument)
+          if names.nil?
+            [false, true].each do |side|
+              unknown_visibility(owner, scope_name(side), default_too: false)
+              omit("module_function", nil, argument, owner: owner, singleton: side, any_member: true)
+            end
+          else
+            names.product([false, true]).each do |name, side|
+              name_visibility(owner, scope_name(side), name, nil)
+              omit("module_function", name, argument.is_a?(Prism::DefNode) ? argument : node, owner: owner,
+                                                                                              singleton: side)
+            end
+          end
+          if argument.is_a?(Prism::DefNode) && argument.body
+            detached { walk(argument.body, nesting, singleton: singleton, in_block: true) }
+          end
+        end
+      end
+
       # A bare `private` / `protected` / `public` written directly in the body sets the default for later defs.
       def toggle_visibility?(child)
         return false unless VISIBILITY_CALLS.any? { |name| bare_call?(child, name) }
@@ -157,20 +210,32 @@ module Rigor
         if node.receiver.nil? && ATTRIBUTE_CALLS.key?(node.name)
           read_attribute(node, nesting, singleton, in_block)
         elsif node.receiver.nil? && OMITTED_CALLS.key?(node.name)
-          return if bare_call?(node, :module_function)
-
-          omit(OMITTED_CALLS.fetch(node.name), first_argument_name(node), node,
-               owner: node.name == :refine ? nil : nesting.last, singleton: singleton)
-          walk_children(node, nesting, singleton, true) unless node.name == :refine
+          omitted_call(node, nesting, singleton, in_block)
+        elsif constant_visibility_call?(node)
+          constant_visibility(node, nesting, direct: false)
         else
-          @visited_visibility_calls ||= {}.compare_by_identity
-          if visibility_call?(node) && !@visited_visibility_calls.key?(node)
-            visibility_call(node, nesting, singleton, direct: false)
-          end
+          unplaced_visibility_call(node, nesting, singleton)
           walk_children(node, nesting, singleton, in_block)
         end
       end
 
+      # A visibility call the body walk did not already read directly.
+      def unplaced_visibility_call(node, nesting, singleton)
+        @visited_visibility_calls ||= {}.compare_by_identity
+        return unless visibility_call?(node) && !@visited_visibility_calls.key?(node)
+
+        visibility_call(node, nesting, singleton, direct: false)
+      end
+
+      def omitted_call(node, nesting, singleton, in_block)
+        return unplaced_module_function if bare_call?(node, :module_function)
+        return read_alias(node, nesting, singleton, in_block) if node.name == :alias_method
+
+        omit(OMITTED_CALLS.fetch(node.name), first_argument_name(node), node,
+             owner: node.name == :refine ? nil : nesting.last, singleton: singleton)
+        walk_children(node, nesting, singleton, true) unless node.name == :refine
+      end
+
       def visibility_call?(node)
         node.is_a?(Prism::CallNode) && node.receiver.nil? &&
           (VISIBILITY_CALLS.include?(node.name) || CLASS_VISIBILITY_CALLS.key?(node.name))
@@ -235,63 +300,364 @@ module Rigor
         end
       end
 
-      def unknown_visibility(owner, scope)
+      # `default_too: false` leaves the body's running default alone: `module_function(*NAMES)` changes only the
+      # members it names, while `private *NAMES` is read as making the default unknown too, the safe side.
+      def unknown_visibility(owner, scope, default_too: true)
         @sites.each do |site|
-          site.data["visibility"] = nil if site.data["owner"] == owner && site.data["scope"] == scope
+          data = site.data
+          next unless data["owner"] == owner
+
+          data["visibility"] = nil if data["scope"] == scope
+          data["singleton_visibility"] = nil if scope == "singleton" && data["module_function"]
         end
-        mark_uncertain
+        mark_uncertain if default_too
       end
 
       # `private :x` changes the visibility of the members already defined under that name in this file.
       def name_visibility(owner, scope, name, visibility)
         @sites.each do |site|
           data = site.data
-          next unless data["owner"] == owner && data["scope"] == scope && data["members"].include?(name)
+          next unless data["owner"] == owner && data["members"].include?(name)
 
-          data["visibility"] = data["members"] == [name] ? visibility : nil
+          if data["scope"] == scope
+            data["visibility"] = data["members"] == [name] ? visibility : nil
+          elsif scope == "singleton" && data["module_function"]
+            # `private_class_method :x` reaches a module function's singleton copy.
+            data["singleton_visibility"] = visibility
+          end
         end
       end
 
+      # `a, B = …`: each constant target is an omission. The targets are walked too, since an index or call target
+      # (`a[expr], b = …`) or a constant path's parent can hold a declaration; the value is walked last.
       def walk_multi_write(node, nesting, singleton, in_block)
-        (node.lefts + [node.rest&.expression].compact + node.rights).each do |target|
-          next unless target.is_a?(Prism::ConstantTargetNode) || target.is_a?(Prism::ConstantPathTargetNode)
+        omit_constant_targets(node, nesting)
+        targets_of(node).each { |target| walk(target, nesting, singleton: singleton, in_block: in_block) }
+        walk(node.value, nesting, singleton: singleton, in_block: in_block)
+      end
+
+      # A `for A in …` index or a `rescue => E` reference assigns the constants it names, like a multiple
+      # assignment does.
+      def walk_assigning(node, target, nesting, singleton, in_block)
+        omit_constant_targets(target, nesting) if target
+        walk_children(node, nesting, singleton, in_block)
+      end
 
-          omit("constant", qualify(nesting, target) || target.slice, target)
+      def omit_constant_targets(target, nesting)
+        constant_targets(target).each do |constant|
+          omit("constant", qualify(nesting, constant) || constant.slice, constant)
+        end
+      end
+
+      # The constants a target assigns: itself when it is one, and those inside a nested `(a, B)` group or a
+      # `*Rest` splat. A group's rest slot is a `SplatNode` (`a, *B = …`, or a bare `*`) or an `ImplicitRestNode`
+      # (the trailing comma of `a, = …`), which names nothing.
+      def constant_targets(target)
+        case target
+        when Prism::ConstantTargetNode, Prism::ConstantPathTargetNode then [target]
+        when Prism::MultiWriteNode, Prism::MultiTargetNode then targets_of(target).flat_map { |t| constant_targets(t) }
+        when Prism::SplatNode then target.expression ? constant_targets(target.expression) : []
+        else []
         end
-        walk(node.value, nesting, singleton: singleton, in_block: in_block)
       end
 
-      def walk_constant(node, nesting)
+      def targets_of(node)
+        node.lefts + [node.rest].compact + node.rights
+      end
+
+      def walk_constant(node, nesting, in_block)
         target = node.respond_to?(:target) ? node.target : node
         name = node.respond_to?(:target) ? qualify(nesting, node.target) : qualify_name(nesting, node.name.to_s)
-        kind = case data_or_struct(node.value)
-               when :data then "data_class"
-               when :struct then "struct_class"
-               else "constant"
-               end
-        omit(kind, name || target.slice, node)
+        builder = data_or_struct(node.value)
+        if modelled_write?(node, name, in_block)
+          fields = builder && builder_fields(node.value, builder)
+          return read_builder_class(node, name, nesting, builder, fields) if fields
+          # A path write (`Foo::BAR = 1`, `::BAR = 1`) lands on the path's namespace, which `check` resolves
+          # through the nesting and Rigor does not name the way it does: an omission.
+          return read_constant(node, name, nesting) if builder.nil? && node.is_a?(Prism::ConstantWriteNode)
+        end
+
+        kind = { data: "data_class", struct: "struct_class" }.fetch(builder, "constant")
+        # Under a builder block or `class << self` the nesting does not name where the constant lands: as written.
+        written = node.respond_to?(:target) ? target.slice : node.name.to_s
+        omit(kind, constant_scope_unknown? ? written : (name || written), node)
+        walk(node.value, nesting, singleton: false, in_block: true)
+      end
+
+      # `X = value` written directly in a namespace body (or at the top level): a `constant` site (capability
+      # `constant`). Its `value` slot is filled from the run's tables ({Run#read_constant_value}). A declaration
+      # inside the value (a lambda body, a `Class.new` block) is an omission, as anywhere in a block.
+      def read_constant(node, name, nesting)
+        owner = nesting.last || "Object"
+        add_site(node, { "kind" => "constant", "name" => name, "owner" => owner, "scope" => nil,
+                         "attribute" => nil, "members" => [], "module_function" => false,
+                         "visibility" => reassigned_visibility(name, owner), "params" => nil, "block" => nil,
+                         "body_return" => nil, "value" => Slot.unavailable("not_computed") })
         walk(node.value, nesting, singleton: false, in_block: true)
       end
 
-      def read_def(node, nesting, singleton, in_block)
+      # Reassigning a constant keeps its visibility in Ruby: a `private_constant` above still holds.
+      def reassigned_visibility(name, owner)
+        earlier = @sites.rfind do |site|
+          site.data["kind"] == "constant" && site.data["owner"] == owner && site.data["name"] == name
+        end
+        earlier ? earlier.data["visibility"] : "public"
+      end
+
+      # `Foo = Data.define(:a, :b) do … end` and `Foo = Struct.new(:a, keyword_init: true) do … end`: a class site
+      # with `builder` set, an attribute site per field (a reader for `Data`, an accessor for `Struct`), and the block
+      # read as the class body, which Ruby `class_eval`s on the new class. `check`'s discovery keys the block's defs
+      # and the fields under the same constant name.
+      def read_builder_class(node, name, nesting, builder, fields)
+        add_site(node, { "kind" => "class", "name" => name, "owner" => nil, "scope" => nil, "attribute" => nil,
+                         "members" => [], "module_function" => false, "builder" => builder.to_s,
+                         "visibility" => nil, "params" => nil, "block" => nil, "body_return" => nil })
+        attribute = builder == :data ? "reader" : "accessor"
+        start_line = node.location.start_line
+        fields.each do |field, field_node|
+          # rbs-inline reads a `#:` trailing a field on its own line of a multi-line call as that field's type.
+          trailing = field_node.location.start_line != start_line
+          members = attribute_members(field, attribute)
+          visibility = builder_field_visibility(members)
+          add_site(field_node, { "kind" => "attribute", "name" => field, "owner" => name, "scope" => "instance",
+                                 "attribute" => attribute, "members" => members,
+                                 "module_function" => false, "visibility" => visibility, "params" => nil,
+                                 "block" => nil, "body_return" => nil }, contracts: trailing ? :trailing : false)
+        end
+        block = node.value.block
+        walk_body(block.body, nesting + [name], singleton: false, kind: :builder) if block&.body
+      end
+
+      # Ruby forces a field reader named `initialize_copy` (say) private, but not its `Struct` writer: a `Data`
+      # field reads `private`, a `Struct` one, whose site covers both, `null`.
+      def builder_field_visibility(members)
+        return "public" unless members.intersect?(FORCED_PRIVATE)
+
+        members.all? { |member| FORCED_PRIVATE.include?(member) } ? "private" : nil
+      end
+
+      # Whether a constant, class or module written here lands somewhere the nesting does not name: a builder
+      # block, which Ruby `class_eval`s (defs go to the new class, but constants stay with the lexical scope), or a
+      # `class << self` body (constants go to the singleton class). Such a declaration is an omission.
+      def constant_scope_unknown?
+        @bodies.any? { |body| %i[builder singleton].include?(body.kind) }
+      end
+
+      def constant_visibility_call?(node)
+        node.is_a?(Prism::CallNode) && node.receiver.nil? && %i[private_constant public_constant].include?(node.name) &&
+          node.arguments
+      end
+
+      # `private_constant :X` written directly in a namespace body makes the constants it names, already assigned
+      # above it in this body's namespace, private. Written anywhere else (an `if`, a block, a method) it runs at a
+      # time Rigor does not know, so those constants read unknown; a non-literal argument leaves every constant of
+      # the namespace unknown. Under a builder block or `class << self` it targets the new class or the singleton
+      # class, which hold none of the constants listed here.
+      def constant_visibility(node, nesting, direct:)
+        return if constant_scope_unknown?
+
+        direct &&= !@bodies.last&.detached
+        visibility = node.name == :private_constant ? "private" : "public"
+        node.arguments.arguments.each do |argument|
+          names = argument_names(argument)
+          named_constants(nesting, names).each { |site| site.data["visibility"] = names && direct ? visibility : nil }
+        end
+      end
+
+      # The namespace's constant sites so far that `names` names, or all of them when `names` is nil.
+      def named_constants(nesting, names)
+        owner = nesting.last || "Object"
+        qualified = names&.map { |name| qualify_name(nesting, name) }
+        @sites.select do |site|
+          site.data["kind"] == "constant" && site.data["owner"] == owner &&
+            (qualified.nil? || qualified.include?(site.data["name"]))
+        end
+      end
+
+      # A plain constant assignment whose name Rigor can qualify, outside any block or a body whose constants land
+      # somewhere the nesting does not name.
+      def modelled_write?(node, name, in_block)
+        name && !in_block && plain_write?(node) && !constant_scope_unknown?
+      end
+
+      def plain_write?(node)
+        node.is_a?(Prism::ConstantWriteNode) || node.is_a?(Prism::ConstantPathWriteNode)
+      end
+
+      # `[[name, node], …]` for a builder call whose fields are all symbols, or nil. `Struct.new` may end with
+      # `keyword_init:` alone. Not modelled: a string field (`check`'s discovery reads only symbols, and
+      # `Struct.new("Name", …)` defines `Struct::Name`), a `&block` argument, and a duplicate field or a writer-like
+      # name (`a=`), which Ruby rejects at load time.
+      def builder_fields(call, builder)
+        return nil if call.block.is_a?(Prism::BlockArgumentNode)
+
+        arguments = call.arguments&.arguments || []
+        arguments = arguments[0...-1] if builder == :struct && keyword_init_only?(arguments.last)
+        return nil unless arguments.all?(Prism::SymbolNode)
+
+        names = arguments.map(&:unescaped)
+        return nil if names.uniq.size != names.size || names.any? { |name| name.end_with?("=") }
+
+        names.zip(arguments)
+      end
+
+      def keyword_init_only?(argument)
+        return false unless argument.is_a?(Prism::KeywordHashNode)
+
+        argument.elements.all? do |element|
+          element.is_a?(Prism::AssocNode) && element.key.is_a?(Prism::SymbolNode) &&
+            element.key.unescaped == "keyword_init"
+        end
+      end
+
+      # A bare `module_function` the walk cannot place in the body's statement list (under an `if`, say) leaves the
+      # mode unknown for the body's later defs.
+      def unplaced_module_function
+        body = @bodies.last
+        body.module_function = :unknown if body && !body.detached
+      end
+
+      def read_def(node, nesting, singleton, in_block, module_function: false)
         scope = def_scope(node, nesting, singleton)
+        module_function ||= module_function_state(node, singleton)
         if in_block || scope.nil?
           omit("method", node.name.to_s, node)
+        elsif module_function.nil?
+          omit("module_function", node.name.to_s, node, owner: nesting.last, singleton: singleton)
         else
-          owner = nesting.last || "Object"
-          data = { "kind" => "method", "name" => node.name.to_s, "owner" => owner, "scope" => scope.to_s,
-                   "attribute" => nil, "members" => [node.name.to_s],
-                   "visibility" => visibility(node, nesting, scope) }
-          params, block, = Parameters.read(node.parameters, yields: Parameters.yields?(node.body))
-          shape_params, shape_block = Parameters.shape(params, block)
-          data.merge!("params" => shape_params, "block" => shape_block,
-                      "body_return" => body_return(node, owner, scope))
-          add_site(node, data)
+          add_site(node, method_site(node, nesting, scope, module_function))
         end
         # A declaration inside a method body runs only when the method does: not modelled.
         detached { walk(node.body, nesting, singleton: singleton, in_block: true) } if node.body
       end
 
+      def method_site(node, nesting, scope, module_function)
+        owner = nesting.last || "Object"
+        params, block, = Parameters.read(node.parameters, yields: Parameters.yields?(node.body))
+        shape_params, shape_block = Parameters.shape(params, block)
+        returns = body_return(node, owner, scope)
+        data = { "kind" => "method", "name" => node.name.to_s, "owner" => owner, "scope" => scope.to_s,
+                 "attribute" => nil, "members" => [node.name.to_s], "module_function" => module_function,
+                 "visibility" => module_function ? "private" : visibility(node, nesting, scope),
+                 "params" => shape_params, "block" => shape_block, "body_return" => returns }
+        return data unless module_function
+
+        # Internal to the member pass: the singleton copy is public until `private_class_method` says otherwise,
+        # and its body runs with the module as `self`. The instance-scope typing read `self` as an instance of the
+        # owner, so a return that may depend on `self` is not the copy's.
+        copy = self_dependent?(node.body, returns, owner) ? Slot.unavailable("not_computed") : returns
+        data.merge("singleton_visibility" => "public", "singleton_body_return" => copy)
+      end
+
+      # Whether the instance-scope return may differ from the singleton copy's: the body reads `self`, instance or
+      # class state, or `super` (nested defs excluded, blocks included, which over-declines safely), or the return
+      # names the owner's type, which is where a `self` that flowed through `itself`, `tap` or another module
+      # function shows up.
+      def self_dependent?(body, returns, owner)
+        instance_state?(body) || names_owner?(returns, owner)
+      end
+
+      def instance_state?(node)
+        return false if node.nil?
+        if node.is_a?(Prism::SelfNode) || node.is_a?(Prism::SuperNode) || node.is_a?(Prism::ForwardingSuperNode)
+          return true
+        end
+        return true if node.type.to_s.start_with?("instance_variable_", "class_variable_")
+        return false if node.is_a?(Prism::DefNode)
+
+        node.compact_child_nodes.any? { |child| instance_state?(child) }
+      end
+
+      # Whether a spelled type mentions the owner, by its qualified name or its last segment. A heuristic, not a proof:
+      # a self-dependent body whose instance-scope type folds to something that names no owner slips through.
+      def names_owner?(slot, owner)
+        type = slot["type"]
+        return false unless type
+
+        [owner, owner.split("::").last].uniq.any? do |name|
+          type.match?(/(?<![\w:])(?:::)?#{Regexp.escape(name)}(?!\w)/)
+        end
+      end
+
+      # Whether a receiverless instance `def` is a module function: true when the body's mode is on and the def is
+      # one of the body's direct statements, nil when the mode is on or unknown but Rigor cannot say (a def nested
+      # in the body, or after the mode became unknown), false otherwise.
+      def module_function_state(node, singleton)
+        body = @bodies.last
+        return false if body.nil? || body.detached || singleton || node.receiver
+        return false if body.module_function == :off
+
+        body.module_function == :on && node.equal?(@direct_statement) ? true : nil
+      end
+
+      # `alias new old` or `alias_method :new, :old` (literal names) written as a statement of a class, module or
+      # builder body: a `method` site named `new` with `alias_of` set (capability `alias`). Ruby copies the method
+      # `old` names at that moment, visibility included, so the site takes the visibility of the last `old` site of
+      # the owner above it, and its parameters and body return when that is the only `old` site above it and a
+      # `def`. Whether that is the `def` `check` reads (the final one) is the member pass's question. Anywhere else
+      # (a block, a method, `class << self`, the top level, wrapped in a visibility call or nested under an `if`),
+      # with a computed name, or while `module_function` is on, it is an omission.
+      def read_alias(node, nesting, singleton, in_block)
+        names = alias_names(node)
+        if names && modelled_alias?(node, nesting, singleton, in_block)
+          return add_site(node, alias_site(names.map(&:to_s), nesting.last))
+        end
+
+        omit("alias", names&.first&.to_s || alias_written_name(node), node, owner: nesting.last, singleton: singleton)
+        walk_children(node, nesting, singleton, true) if node.is_a?(Prism::CallNode)
+      end
+
+      def alias_names(node)
+        if node.is_a?(Prism::AliasMethodNode)
+          Source::AliasNames.keyword_names(node)
+        else
+          node.block.nil? ? Source::AliasNames.alias_method_call_names(node) : nil
+        end
+      end
+
+      def modelled_alias?(node, nesting, singleton, in_block)
+        body = @bodies.last
+        !in_block && !singleton && !nesting.empty? && body && !body.detached &&
+          body.module_function == :off && node.equal?(@direct_statement)
+      end
+
+      def alias_written_name(node)
+        node.is_a?(Prism::AliasMethodNode) ? node.new_name.slice.delete_prefix(":") : first_argument_name(node)
+      end
+
+      def alias_site(names, owner)
+        new_name, old_name = names
+        last, copy = alias_original(owner, old_name)
+        visibility = FORCED_PRIVATE.include?(new_name) ? "private" : last&.data&.fetch("visibility")
+        # `initialize` reads `void` by its name, which neither side of an alias across it keeps.
+        returns = copy && ![new_name, old_name].include?("initialize") ? copy.data["body_return"] : nil
+        { "kind" => "method", "name" => new_name, "owner" => owner, "scope" => "instance", "attribute" => nil,
+          "members" => [new_name], "module_function" => false, "visibility" => visibility,
+          "params" => copy&.data&.fetch("params"), "block" => copy&.data&.fetch("block"),
+          "body_return" => returns || Slot.unavailable("not_computed"),
+          "alias_of" => old_name, "aliased_node" => copy && aliased_node(copy) }
+      end
+
+      # `[last, copy]`: the last site of the owner above the alias defining `old` (nil when an omission names
+      # `old` too), and that site when it is the file's only one and a `def`.
+      def alias_original(owner, old_name)
+        olds = @sites.select do |site|
+          site.data["owner"] == owner && site.data["scope"] == "instance" && site.data["members"].include?(old_name)
+        end
+        unplaced = @omissions.any? do |omission|
+          [omission["owner"], omission["scope"]] == [owner, "instance"] && [old_name, nil].include?(omission["name"])
+        end
+        return [nil, nil] if unplaced
+
+        last = olds.last
+        [last, olds.size == 1 && last.data["kind"] == "method" ? last : nil]
+      end
+
+      # The `def` a method site reads: its own, or for an alias the one it copied.
+      def aliased_node(site)
+        site.data["alias_of"] ? site.data["aliased_node"] : site.node
+      end
+
       def read_attribute(node, nesting, singleton, in_block)
         arguments = node.arguments&.arguments || []
         names = arguments.map { |arg| arg.is_a?(Prism::SymbolNode) || arg.is_a?(Prism::StringNode) ? arg.unescaped : nil }
@@ -303,28 +669,40 @@ module Rigor
         scope = singleton ? :singleton : :instance
         attribute = ATTRIBUTE_CALLS.fetch(node.name)
         names.each_with_index do |name, ordinal|
+          members = attribute_members(name, attribute)
           add_site(node, { "kind" => "attribute", "name" => name, "owner" => owner, "scope" => scope.to_s,
-                           "attribute" => attribute, "members" => attribute_members(name, attribute),
-                           "visibility" => visibility(node, nesting, scope),
+                           "attribute" => attribute, "members" => members,
+                           "module_function" => false,
+                           "visibility" => attribute_visibility(node, nesting, scope, members),
                            "params" => nil, "block" => nil, "body_return" => nil }, ordinal: ordinal)
         end
       end
 
-      def add_site(node, data, ordinal: 0)
+      # `attr_reader :initialize` is forced private while its writer is not: not modelled.
+      def attribute_visibility(node, nesting, scope, members)
+        return nil if scope == :instance && members.intersect?(FORCED_PRIVATE)
+
+        visibility(node, nesting, scope)
+      end
+
+      # A builder's field reads no leading contract comments, which belong to the constant: `contracts: :trailing`
+      # reads only a `#:` trailing it (rbs-inline's per-field form on its own line), and `false` reads none.
+      def add_site(node, data, ordinal: 0, contracts: true)
         location = node.location
-        anchor = @anchor.for_span(location.start_offset, location.end_offset, location.start_line,
-                                  location.end_line)
+        anchor = @anchor.for_span(location.start_offset, location.end_offset, location.start_line, location.end_line,
+                                  leading: contracts == true, trailing: contracts != false)
         key = "#{@path}:#{location.start_offset}-#{location.end_offset}:#{ordinal}"
         tail = { "ordinal" => ordinal, "span" => Lens.span(location),
                  "contract_span" => Lens.contract_span(anchor.contract_comments), "anchor" => anchor.token,
                  "contract" => nil }
-        @sites << Site.new(data: { "key" => key }.merge(data).merge(tail), node: node,
-                           contract_comments: anchor.contract_comments)
+        head = { "key" => key, "builder" => nil, "value" => nil, "alias_of" => nil }
+        @sites << Site.new(data: head.merge(data).merge(tail), node: node, contract_comments: anchor.contract_comments)
       end
 
-      # `owner` / `singleton` name the member the declaration would define, when Rigor can tell.
-      def omit(kind, name, node, owner: nil, singleton: false)
-        member = owner && name
+      # `owner` / `singleton` name the member the declaration would define, when Rigor can tell. `any_member` keeps
+      # them with a null name: the declaration may define any member of that owner and scope.
+      def omit(kind, name, node, owner: nil, singleton: false, any_member: false)
+        member = owner && (name || any_member)
         @omissions << { "kind" => kind, "owner" => member ? owner : nil,
                         "scope" => member ? scope_name(singleton) : nil, "name" => name,
                         "span" => Lens.span(node.location), "reason" => "unsupported_kind" }
@@ -349,6 +727,7 @@ module Rigor
       def visibility(node, nesting, scope)
         return "private" if nesting.empty?
         return @node_visibility[node] if @node_visibility.key?(node)
+        return "private" if scope == :instance && node.is_a?(Prism::DefNode) && FORCED_PRIVATE.include?(node.name.to_s)
         return "public" if scope == :singleton && node.is_a?(Prism::DefNode) && node.receiver
 
         body = @bodies.last