rigortype 0.3.8 → 0.3.9

data/lib/rigor/analysis/runner.rb

@@ -9,6 +9,7 @@ require_relative "../scope"
 require_relative "../cache/store"
 require_relative "../cache/rbs_descriptor"
 require_relative "../cache/file_digest"
+require_relative "../cache/incremental_snapshot"
 require_relative "run_cache_key"
 require_relative "path_expansion"
 require_relative "../plugin"
@@ -74,6 +75,18 @@ module Rigor
                   # file-positioned ones (`effect.annotations-unchecked`, `source-rbs-*`).
                   :per_file_diagnostics
 
+      # Issues #796 / #794 — the two run-level rows a NARROWED run cannot re-derive from the files it
+      # analyses: the `definition-build-failed` set (whose producer is the analysis's own demand, and #696
+      # forbids Rigor demanding in its place) and the HKT-scan outcome (whose producer is an environment a
+      # nothing-changed recheck otherwise has no reason to build). {IncrementalSession} persists what a full
+      # run answers here and hands it back to the next narrowed run.
+      def run_level_rows
+        Cache::IncrementalSnapshot::RunLevelRows.new(
+          definition_build_failures: @snapshots.definition_build_failures,
+          hkt_scan_failure: @snapshots.hkt_scan_failure
+        )
+      end
+
       # ADR-46 — the per-file cross-file read records this run captured (empty unless
       # `record_dependencies: true`). Sequential analysis records into `@file_dependencies` via
       # {#analyze_file}; the fork pool records per-worker and marshals the records into the coordinator, so a
@@ -214,41 +227,40 @@ module Rigor
         end
       end
 
-      # @param configuration [Rigor::Configuration]
-      # @param explain [Boolean] surface fail-soft fallback events as `:info` diagnostics.
-      # @param cache_store [Rigor::Cache::Store, nil] the persistent cache the runner exposes to producers
+      # @param explain — surface fail-soft fallback events as `:info` diagnostics.
+      # @param cache_store — the persistent cache the runner exposes to producers
       #   (`RbsConstantTable` and successors). Pass `nil` to disable caching for this run; the CLI's
       #   `--no-cache` flag wires `nil` through. v0.0.9 group A slice 1 introduces the surface; later
       #   slices route real producers through it.
-      # @param workers [Integer] ADR-15 Phase 4b — when greater than zero, per-file analysis dispatches
+      # @param workers — ADR-15 Phase 4b — when greater than zero, per-file analysis dispatches
       #   across a pool of N workers. Default `0` keeps the sequential code path bit-for-bit unchanged.
       #   Controlled via the `RIGOR_RACTOR_WORKERS` env var or `.rigor.yml` `parallel.workers:` (Phase 4c,
       #   fully wired).
-      # @param collect_stats [Boolean] when true (default), `#run` builds a {RunStats} summary exposed via
+      # @param collect_stats — when true (default), `#run` builds a {RunStats} summary exposed via
       #   `result.stats` — this forces the RBS env build at end-of-run so the `class_decl_paths` snapshot
       #   has real source attribution. Set to false to skip the stats summary entirely; the CLI's
       #   `--no-stats` threads `false` through to keep trivial-fixture runs from warming `.rigor/cache`.
-      # @param prebuilt [Rigor::Analysis::ProjectScan, nil] when supplied, the runner adopts the pre-built
+      # @param prebuilt — when supplied, the runner adopts the pre-built
       #   plugin registry / dependency-source index / scanner outputs from the snapshot and skips the
       #   per-call pre-passes that produce them. Used by long-lived integrations
       #   (`Rigor::LanguageServer::ProjectContext`) to keep per-buffer requests fast — scanners walk the
       #   project once per generation rather than once per request, and plugin `#prepare` runs once per
       #   generation rather than once per request. Watched-file invalidation is the owner's responsibility;
       #   the runner trusts the snapshot it was given.
-      # @param environment [Rigor::Environment, nil] opt-in Environment override. When supplied, sequential
+      # @param environment — opt-in Environment override. When supplied, sequential
       #   mode uses the provided env instance in `#analyze_files` instead of building a fresh one via
       #   `Environment.for_project`, and attaches the runner's per-run reporter pair onto the env's mutable
       #   `Reporters` slot via `Environment#attach_reporters!`. Long-lived consumers (LSP `ProjectContext`)
       #   pass a shared env so per-publish work doesn't repeat the `Environment.for_project` build (bundler
       #   / lockfile / collection discovery, RbsLoader construction). Pool mode ignores the override — each
       #   worker continues to build its own Environment.
-      # @param discovery_seed [Hash, nil] issue #260 — opt-in cross-file discovery tables, keyed by
+      # @param discovery_seed — issue #260 — opt-in cross-file discovery tables, keyed by
       #   {Scope::DiscoveryIndex} slot name, seeded onto every per-file scope through
       #   `project_scope_seed_tables`. The ONE deliberate exception to "a `prebuilt:` runner carries no
       #   discovery tables": {Protection::DiagnosticOracle} threads the table set Tier 2's site filter already
       #   judges anchors against, so a site admitted because a sibling-file class resolved is also a site the
       #   oracle can kill at. nil (the default) leaves the prebuilt/LSP contract byte-identical.
-      # @param no_tolerated_effects [Boolean] ADR-103 WD1 / #385 — `rigor check --no-tolerated-effects`.
+      # @param no_tolerated_effects — ADR-103 WD1 / #385 — `rigor check --no-tolerated-effects`.
       #   Judges effect envelopes as if `effects.tolerated:` were empty. A judgment-time switch only: the
       #   run, its collection and its cache identity are unchanged.
       def initialize(configuration:, explain: false, # rubocop:disable Metrics/ParameterLists,Metrics/AbcSize,Metrics/MethodLength
@@ -257,8 +269,12 @@ module Rigor
                      buffer: nil, prebuilt: nil, environment: nil,
                      record_dependencies: false, record_self_calls: false, analyze_only: nil,
                      seed_bundles: nil, collect_seed_bundles: false, param_inferred_types: nil,
-                     discovery_seed: nil, no_tolerated_effects: false)
+                     discovery_seed: nil, no_tolerated_effects: false,
+                     restored_run_level_rows: nil)
         @configuration = configuration
+        # Issues #796 / #794 — the previous full run's run-level rows, supplied only by
+        # {IncrementalSession} on a narrowed run; see {PoolCoordinator#replay_restored_run_level_rows}.
+        @restored_run_level_rows = restored_run_level_rows
         @explain = explain
         @cache_store = enforce_read_only_cache(cache_store, buffer)
         @plugin_requirer = plugin_requirer
@@ -362,6 +378,8 @@ module Rigor
         # Issue #682 — the `Module.nesting` each class / module declaration HEADER is written in.
         @project_discovered_header_nestings = {}.freeze
         @project_discovered_includes = {}.freeze
+        # Issue #898 — the singleton-side twin of the include table (`extend M` / `extend self`).
+        @project_discovered_extends = {}.freeze
         @project_discovered_class_sources = {}.freeze
         # Issue #644 — the cross-file VALUE-constant publication table (`{qualified name => Type::Constant}`,
         # literal writes only) and its per-name write attribution. The first seeds `in_source_constants` on
@@ -388,6 +406,9 @@ module Rigor
         # (sequential + fork-worker) through `project_scope_seed_tables`. Empty unless the project lists
         # `pre_eval:` files that declare publishable constants, so a project without one is byte-identical.
         @project_pre_eval_constants = {}.freeze
+        # Issue #663 — the listed set {#publishable_pre_eval_constants} asks "is this writer one of ours?"
+        # against; a function of the configuration alone, so it outlives every discovery rebuild.
+        @pre_eval_path_set = nil
         # ADR-84 WD2 — per-run identity token for the user-method return memo's bucket (see
         # Scope::DiscoveryIndex#run_generation). Minted fresh in `run_analysis` so the memo never serves an
         # entry across a run boundary (LSP re-check, ADR-62 warm loop); nil until the first run so
@@ -479,9 +500,8 @@ module Rigor
       # so the result matches a one-file disk run; only the cross-file project pre-pass is empty (there is
       # one file, and the per-file indexer self-discovers its own classes / defs).
       #
-      # @param source [String] Ruby source to analyze.
-      # @param path [String] logical path for diagnostic locations.
-      # @return [Result]
+      # @param source — Ruby source to analyze.
+      # @param path — logical path for diagnostic locations.
       def run_source(source:, path: "(source).rb")
         @in_memory_sources = { path => source }
         run([path])
@@ -607,7 +627,7 @@ module Rigor
       # arg-flooring surface). Only meaningful right after a run populated the memo (baseline / recheck),
       # before the bucket rolls. Keys are held live here; the session Marshals them for the snapshot.
       #
-      # @return [Hash] `{ [path, "Class#method" | "Class.method"] => { keys:, returns:, effects: } }`.
+      # @return `{ [path, "Class#method" | "Class.method"] => { keys:, returns:, effects: } }`.
       def return_summaries
         memo = Inference::ExpressionTyper.harvest_return_memo
         return {} if memo.empty?
@@ -665,9 +685,9 @@ module Rigor
       # store) exactly as a real run's setup does, then re-drives each spec's def through the ADR-84 return
       # memo. Off any hot path — invoked only when declaration-stable changed pairs carry a persisted summary.
       #
-      # @param paths [Array<String>, nil] analysis roots (nil → the configuration's `paths:`).
-      # @param specs [Array<Hash>] each `{ class_name:, method_name:, singleton:, keys: [[receiver, args], …] }`.
-      # @return [Hash] `{ [class_name, method_name, singleton] => [return_descriptor_or_nil, …] }`.
+      # @param paths — analysis roots (nil → the configuration's `paths:`).
+      # @param specs — each `{ class_name:, method_name:, singleton:, keys: [[receiver, args], …] }`.
+      # @return `{ [class_name, method_name, singleton] => [return_descriptor_or_nil, …] }`.
       def evaluate_return_types(paths, specs)
         return {} if specs.empty?
 
@@ -795,7 +815,7 @@ module Rigor
       # fixpoint over them, which is the pre-split behaviour and the retry the fail-soft posture wants.
       # Only when neither entry answers does the run re-analyse.
       #
-      # @return [Boolean] whether this run was served.
+      # @return whether this run was served.
       def served_from_effect_entries?(descriptor)
         summary = peek_effect_summary(descriptor)
         if summary
@@ -1030,7 +1050,17 @@ module Rigor
         # contributes NO diagnostics and its result leaves through `#effect_table`, never through the
         # stream. Skipped entirely when collection did not run.
         close_effect_graph
-        diagnostics += @diagnostic_aggregator.rbs_quarantined_signature_diagnostics
+        diagnostics + post_analysis_diagnostic_streams
+      end
+
+      # The rbs-coverage build-failure ladder plus every remaining post-analysis stream
+      # `#assemble_run_diagnostics` appends, in their fixed contract order (see the comments at each call
+      # below and at the streams' own definitions). Split out of `#assemble_run_diagnostics` so that
+      # method's `Metrics/AbcSize` stays under budget — every stream here is a plain `DiagnosticAggregator`
+      # reader with no branching of its own, so the split changes nothing about WHEN or in WHAT order they
+      # run.
+      def post_analysis_diagnostic_streams
+        diagnostics = @diagnostic_aggregator.rbs_quarantined_signature_diagnostics
         diagnostics += @diagnostic_aggregator.rbs_environment_build_failed_diagnostics
         # Issue #696 — after its env-wide twin and before the synthesized-namespace notice: the four
         # `rbs.coverage.*` build conditions surface widest-consequence first, and their relative order is
@@ -1040,12 +1070,20 @@ module Rigor
         # `type` alias would have contributed, never a class's own declared method surface, so it is the
         # narrowest-consequence rung on the same ladder.
         diagnostics += @diagnostic_aggregator.rbs_hkt_scan_failed_diagnostics
-        diagnostics += @diagnostic_aggregator.rbs_synthesized_namespace_diagnostics
+        # The synthesized-namespace notice, then (#610) the plugin-signature stand-down: the outcome that
+        # AVOIDED a definition-build failure, so the quietest row on that ladder.
+        diagnostics += @diagnostic_aggregator.rbs_coverage_notice_diagnostics
         diagnostics += @diagnostic_aggregator.conforms_to_diagnostics
         diagnostics += @diagnostic_aggregator.rbs_extended_reporter_diagnostics
         diagnostics += @diagnostic_aggregator.boundary_cross_diagnostics
-        diagnostics + @diagnostic_aggregator.source_rbs_synthesis_diagnostics
+        diagnostics += @diagnostic_aggregator.source_rbs_synthesis_diagnostics
+        # Issue #959 — read LAST (after `analyze_targets`, which already ran before this method is called),
+        # so every per-file plugin call has had its chance to record a refusal on its (per-plugin-instance
+        # memoised) `IoBoundary`, alongside the prepare-time refusals the same boundary instance may
+        # already carry.
+        diagnostics + @diagnostic_aggregator.plugin_trust_refusal_diagnostics
       end
+      private :post_analysis_diagnostic_streams
 
       # #788 round 7 — runs per-file analysis over `targets` and exposes what it produced as
       # `#per_file_diagnostics`: the `analyze_files` return, stamped with the same severity profile the run's
@@ -1179,13 +1217,22 @@ module Rigor
       def build_run_dependency_descriptor(expansion, rbs_descriptor)
         entries = analyzed_file_entries(expansion) + discovery_file_entries(expansion) +
                   pre_eval_file_entries + rbs_descriptor.files
-        globs = []
+        # #979 — the signature ROOTS' listings, one glob row each. `rbs_descriptor.files` covers only the
+        # `.rbs` files that existed while the run read them, so without these a signature file written after
+        # the run left the slot validating fresh and the warm run answered without it.
+        globs = rbs_descriptor.globs.dup
         @plugin_registry.plugins.each do |plugin|
           # Read the boundary WITHOUT triggering its lazy `@io_boundary ||=` initializer: plugin instances
           # are frozen after the run, and a plugin that never built a boundary read no files through it,
           # so it contributes no dependencies.
           boundary = plugin.instance_variable_get(:@io_boundary)
-          entries.concat(boundary.cache_descriptor.files) if boundary
+          if boundary
+            # #629 — a boundary carries GlobEntry listing rows too (`IoBoundary#list_directory`), and they
+            # are the only edge back to a file the run decided was ABSENT from a directory it consulted.
+            boundary_descriptor = boundary.cache_descriptor
+            entries.concat(boundary_descriptor.files)
+            globs.concat(boundary_descriptor.globs)
+          end
           plugin.class.producers.each_value do |prod|
             globs.concat(plugin.send(:watch_glob_entries, prod[:watch])) if prod[:watch]
           end
@@ -1306,6 +1353,7 @@ module Rigor
         @project_discovered_superclasses = discovery.discovered_superclasses
         @project_discovered_header_nestings = discovery.discovered_header_nestings
         @project_discovered_includes = discovery.discovered_includes
+        @project_discovered_extends = discovery.discovered_extends
         @project_discovered_class_sources = discovery.discovered_class_sources
         @project_constant_values = discovery.constant_values
         @published_constant_name_set = nil
@@ -1399,7 +1447,7 @@ module Rigor
         3.0.0 3.1.0 3.2.0 3.3.0 3.4.0 3.5.0 4.0.0 4.1.0 4.2.0
       ].freeze
 
-      # @return [String, nil] the lowest `target_ruby` this Prism build accepts, or nil if none of the
+      # @return the lowest `target_ruby` this Prism build accepts, or nil if none of the
       #   ladder parses. Memoised per process (the value is constant for a given Prism).
       def self.prism_supported_floor
         @prism_supported_floor ||= PRISM_VERSION_LADDER.find do |candidate|
@@ -1504,7 +1552,8 @@ module Rigor
           synthetic_method_index: -> { @synthetic_method_index },
           project_patched_methods: -> { @project_patched_methods },
           project_scope_seed: -> { project_scope_seed_tables },
-          analyze_file: ->(path, environment) { analyze_file(path, environment) }
+          analyze_file: ->(path, environment) { analyze_file(path, environment) },
+          restored_run_level_rows: @restored_run_level_rows
         )
         @diagnostic_aggregator = DiagnosticAggregator.new(
           configuration: @configuration,
@@ -1518,6 +1567,7 @@ module Rigor
           pre_eval_diagnostics_from_scanner: -> { @pre_eval_diagnostics_from_scanner },
           synthesized_namespaces_snapshot: -> { @snapshots.synthesized_namespaces },
           quarantined_signatures_snapshot: -> { @snapshots.quarantined_signatures },
+          signature_standdowns_snapshot: -> { @snapshots.signature_standdowns },
           env_build_failure_snapshot: -> { @snapshots.env_build_failure },
           definition_build_failures_snapshot: -> { @snapshots.definition_build_failures },
           hkt_scan_failure_snapshot: -> { @snapshots.hkt_scan_failure },
@@ -1752,7 +1802,7 @@ module Rigor
         unless @project_discovered_header_nestings.empty?
           tables[:discovered_header_nestings] = @project_discovered_header_nestings
         end
-        tables[:discovered_includes] = @project_discovered_includes unless @project_discovered_includes.empty?
+        seed_mixin_tables(tables)
         unless @project_discovered_method_visibilities.empty?
           tables[:discovered_method_visibilities] = @project_discovered_method_visibilities
         end
@@ -1763,6 +1813,14 @@ module Rigor
         tables
       end
 
+      # The two mixin tables: the ADR-24 instance-side `include` / `prepend` map and its #898 singleton-side
+      # `extend` twin. Paired here because they are read as one picture of a class's ancestry, and split out
+      # of {#project_scope_seed_tables} to keep it under the complexity budget.
+      def seed_mixin_tables(tables)
+        tables[:discovered_includes] = @project_discovered_includes unless @project_discovered_includes.empty?
+        tables[:discovered_extends] = @project_discovered_extends unless @project_discovered_extends.empty?
+      end
+
       # ADR-46 slice 1 / issue #644 — the two SOURCE-ATTRIBUTION tables, read only by the recording accessors
       # (`Scope#record_class_dependency` for the class-declaration map, `Scope#record_constant_dependency`
       # for the constant-write map). A normal run carries neither. Extracted to keep
@@ -1802,12 +1860,6 @@ module Rigor
         tables[:published_constant_names] = names unless names.empty?
       end
 
-      # Issue #644 — the seeded `in_source_constants` table, joining the two cross-file constant producers.
-      # The whole-project literal table wins over a `pre_eval:` publication of the same name: both describe
-      # the same assignment, the literal table pins the value the write actually carries while ADR-17's
-      # widener erases it to the class, and listing a file under `pre_eval:` must never LOSE precision. The
-      # per-file table still wins over both (`ScopeIndexer.index`'s merge) — same-file stays the most
-      # specific authority.
       # Issue #644 — the LAST SEGMENTS of the published table, the run-wide half of
       # `Scope#published_constant?`. Seeded on EVERY run (unlike `constant_sources`, which only a recording
       # run needs) because {CheckRules::PublishedConstantGuard} asks the question on every `if` / `unless`.
@@ -1816,11 +1868,57 @@ module Rigor
           @project_constant_values.keys.to_set { |name| name.split("::").last }.freeze
       end
 
+      # Issue #644 — the seeded `in_source_constants` table, joining the two cross-file constant producers.
+      # The whole-project literal table wins over a `pre_eval:` publication of the same name: both describe
+      # the same assignment, the literal table pins the value the write actually carries while ADR-17's
+      # widener erases it to the class, and listing a file under `pre_eval:` must never LOSE precision. The
+      # per-file table still wins over both (`ScopeIndexer.index`'s merge) — same-file stays the most
+      # specific authority.
       def merged_seed_constants
-        return @project_constant_values if @project_pre_eval_constants.empty?
-        return @project_pre_eval_constants if @project_constant_values.empty?
+        pre_eval = publishable_pre_eval_constants
+        return @project_constant_values if pre_eval.empty?
+        return pre_eval if @project_constant_values.empty?
+
+        pre_eval.merge(@project_constant_values).freeze
+      end
+
+      # Issue #663 — the `pre_eval:` publication with every name an UNLISTED file also assigns retracted.
+      # Without this a listed `X = :a` answered `Symbol` at every reader while a sibling `X = "str"` decided
+      # the runtime value half the time: a confident wrong type, not lost precision, and the one asymmetry
+      # #644's precedence work left standing. The retraction costs the opt-in nothing where it earns its
+      # keep — a name only listed files write is untouched, and where the literal table also publishes it
+      # already won (above).
+      #
+      # Conflict is read off #644's write attribution, which censuses every assigning form, so a name the
+      # listed file's own typed walk widened is retracted by an unlisted `X += 1` or `A, X = 1, 2` as
+      # readily as by a plain reassignment. Among LISTED files the rule is unchanged: `PreEvalConstants`
+      # widens first and drops only on disagreement, so two listed files writing `1` and `2` still publish
+      # `Integer` rather than being retracted for being two.
+      def publishable_pre_eval_constants
+        return @project_pre_eval_constants if @project_pre_eval_constants.empty?
+
+        listed = pre_eval_path_set
+        kept = @project_pre_eval_constants.reject { |name, _| unlisted_constant_writer?(name, listed) }
+        kept.size == @project_pre_eval_constants.size ? @project_pre_eval_constants : kept.freeze
+      end
+
+      # True when some file outside `listed` assigns `name`. The wildcard key is consulted alongside the
+      # name's own attribution ([#668](https://github.com/rigortype/rigor/issues/668)): a `k::X = 7` names
+      # no target, and a listed file kept out of `paths:` (ADR-17 WD5 permits it) contributes no censused
+      # name of its own for the wildcard's paths to have been folded into.
+      def unlisted_constant_writer?(name, listed)
+        segment = name.split("::").last
+        writers = @project_constant_sources[name]
+        wildcard = @project_constant_sources["#{Inference::ScopeIndexer::DYNAMIC_TARGET_PREFIX}#{segment}"]
+        [writers, wildcard].any? do |paths|
+          paths&.any? { |path| !listed.include?(File.expand_path(path)) }
+        end
+      end
 
-        @project_pre_eval_constants.merge(@project_constant_values).freeze
+      # The listed `pre_eval:` files, expanded so a census path and a configured one compare as the same
+      # file whichever spelling each arrived in.
+      def pre_eval_path_set
+        @pre_eval_path_set ||= @configuration.pre_eval.to_set { |path| File.expand_path(path) }
       end
 
       # ADR-46 — seed the instance + singleton `"path:line"` def-source tables (each only when non-empty).

data/lib/rigor/analysis/worker_session.rb

@@ -3,6 +3,7 @@
 require "prism"
 
 require_relative "../environment"
+require_relative "../project_environment"
 require_relative "../scope"
 require_relative "../cache/store"
 require_relative "../plugin"
@@ -73,12 +74,11 @@ module Rigor
                   :rbs_extended_reporter, :boundary_cross_reporter,
                   :prepare_diagnostics
 
-      # @param configuration [Rigor::Configuration]
-      # @param cache_store [Rigor::Cache::Store, nil] persistent cache the session exposes to plugin-side
+      # @param cache_store — persistent cache the session exposes to plugin-side
       #   producers and the RBS loader. Pass `nil` to disable caching.
-      # @param plugin_blueprints [Array<Rigor::Plugin::Blueprint>] replay descriptors. Empty array yields a
+      # @param plugin_blueprints — replay descriptors. Empty array yields a
       #   session with no plugin contributions.
-      # @param explain [Boolean] when true, `#analyze` additionally emits one `:info` `fallback` diagnostic
+      # @param explain — when true, `#analyze` additionally emits one `:info` `fallback` diagnostic
       #   per directly-unrecognised node, mirroring {Rigor::Analysis::Runner#explain_diagnostics}.
       def initialize(configuration:, cache_store: nil, # rubocop:disable Metrics/MethodLength,Metrics/ParameterLists
                      plugin_blueprints: [], explain: false, buffer: nil,
@@ -137,11 +137,7 @@ module Rigor
           rbs_extended_reporter: @rbs_extended_reporter,
           boundary_cross_reporter: @boundary_cross_reporter,
           source_rbs_synthesis_reporter: @source_rbs_synthesis_reporter,
-          bundler_bundle_path: configuration.bundler_bundle_path,
-          bundler_auto_detect: configuration.bundler_auto_detect,
-          bundler_lockfile: configuration.bundler_lockfile,
-          rbs_collection_lockfile: configuration.rbs_collection_lockfile,
-          rbs_collection_auto_detect: configuration.rbs_collection_auto_detect,
+          **ProjectEnvironment.dependency_discovery_options(configuration),
           synthetic_method_index: @synthetic_method_index,
           project_patched_methods: @project_patched_methods,
           source_files: @source_files
@@ -271,7 +267,10 @@ module Rigor
             # `hkt_scan_failure` does: the directives are read by the registry scan, and under the pool the
             # PARENT never demands that scan, so a diagnostic wired off the parent's reporter would appear
             # at `--workers=0` and vanish at `--workers=N`. The demand above is what fills this.
-            hkt_directive_errors: @rbs_extended_reporter.hkt_directive_errors
+            hkt_directive_errors: @rbs_extended_reporter.hkt_directive_errors,
+            # ADR-109 WD3 — the deprecated-form stream rides the same channel: the payload is read where
+            # the annotated method is dispatched, which under the pool is only ever inside a worker.
+            deprecated_forms: @rbs_extended_reporter.deprecated_forms
           },
           boundary_cross: @boundary_cross_reporter.entries,
           source_rbs_synthesis: @source_rbs_synthesis_reporter.entries,

data/lib/rigor/bleeding_edge.rb

@@ -51,14 +51,14 @@ module Rigor
     # migration note and a user's `bleeding_edge:` list both key on.
     #
     # @!attribute id
-    #   @return [String] the stable feature id (contract vocabulary).
+    #   @return the stable feature id (contract vocabulary).
     # @!attribute summary
-    #   @return [String] a one-line description of what it changes. For a `:behaviour`
+    #   @return a one-line description of what it changes. For a `:behaviour`
     #     feature this is the *whole* explanation — there is no severity diff to read.
     # @!attribute kind
-    #   @return [Symbol] one of {KINDS}.
+    #   @return one of {KINDS}.
     # @!attribute severity_overrides
-    #   @return [Hash{String => Symbol}] canonical rule id → the severity this feature
+    #   @return canonical rule id → the severity this feature
     #     imposes. Composed *below* the user's own `severity_overrides:` and *above* the
     #     active `severity_profile` (see {Configuration::SeverityProfile.resolve}). Empty for
     #     a `:behaviour` feature.
@@ -76,12 +76,10 @@ module Rigor
         super
       end
 
-      # @return [Boolean]
       def severity?
         kind == :severity
       end
 
-      # @return [Boolean]
       def behaviour?
         kind == :behaviour
       end
@@ -193,36 +191,30 @@ module Rigor
     # cleanup can lag graduation by as many releases as it takes. The id also stays in the
     # contract vocabulary the CHANGELOG migration note keys on. Entries are removed only once
     # no call site names them.
-    #
-    # @return [Array<String>]
     GRADUATED = [].freeze
 
     module_function
 
-    # @return [Array<Feature>] the whole overlay.
+    # @return the whole overlay.
     def features
       FEATURES
     end
 
-    # @return [Array<String>] every feature id in the overlay.
+    # @return every feature id in the overlay.
     def feature_ids
       FEATURES.map(&:id)
     end
 
-    # @param id [String]
-    # @return [Feature, nil]
     def feature(id)
       FEATURES.find { |f| f.id == id }
     end
 
-    # @param id [String]
-    # @return [Boolean] whether the id has graduated to default-on ({GRADUATED}).
+    # @return whether the id has graduated to default-on ({GRADUATED}).
     def graduated?(id)
       GRADUATED.include?(id)
     end
 
-    # @param id [String]
-    # @return [Boolean] whether the id names a feature this gem knows at all — queued or
+    # @return whether the id names a feature this gem knows at all — queued or
     #   graduated. Distinct from "adopted"; see {Configuration#bleeding_edge_active?}.
     def known_id?(id)
       graduated?(id) || FEATURES.any? { |f| f.id == id }
@@ -234,10 +226,9 @@ module Rigor
     # `severity_overrides:` keeps an unknown rule id inert until it lands (robust across gem
     # versions).
     #
-    # @param selector [Hash] `{ "mode" => "none" }`,
+    # @param selector — `{ "mode" => "none" }`,
     #   `{ "mode" => "all" }`, `{ "mode" => "all", "except" => [ids] }`,
     #   or `{ "mode" => "list", "ids" => [ids] }`.
-    # @return [Array<Feature>]
     def active_features(selector)
       case selector["mode"]
       when "all"
@@ -254,8 +245,7 @@ module Rigor
     # The merged severity-override map the active features impose for a selector. Frozen so
     # the result is `Ractor.shareable?`.
     #
-    # @param selector [Hash] see {#active_features}.
-    # @return [Hash{String => Symbol}]
+    # @param selector — see {#active_features}.
     def severity_overrides_for(selector)
       active_features(selector).each_with_object({}) do |feature, acc|
         acc.merge!(feature.severity_overrides)
@@ -267,8 +257,7 @@ module Rigor
     # Precomputed once per Configuration; frozen (with frozen members) so the carrier stays
     # `Ractor.shareable?` across the worker boundary.
     #
-    # @param selector [Hash] see {#active_features}.
-    # @return [Set<String>]
+    # @param selector — see {#active_features}.
     def active_ids_for(selector)
       Set.new(active_features(selector).map(&:id)).freeze
     end
@@ -276,8 +265,7 @@ module Rigor
     # Feature ids named by a selector that are NOT in the overlay (typo / graduated / from a
     # newer gem). Surfaced by `rigor show-bleedingedge` as a hint; never an error.
     #
-    # @param selector [Hash] see {#active_features}.
-    # @return [Array<String>]
+    # @param selector — see {#active_features}.
     def unknown_selected_ids(selector)
       named =
         case selector["mode"]

data/lib/rigor/builtins/hkt_builtins.rb

@@ -118,7 +118,7 @@ module Rigor
         )
       end
 
-      # @return [Rigor::Inference::HktRegistry] frozen registry
+      # @return frozen registry
       #   pre-seeded with all bundled HKT registrations +
       #   bodies. Allocated fresh each call rather than
       #   memoised — memoisation through a module-level
@@ -242,7 +242,7 @@ module Rigor
         ["CSV", :parse_line, :singleton] => CSV_ROW_SPEC
       }.freeze
 
-      # @return [Rigor::Type, nil] the reduced HKT type for
+      # @return the reduced HKT type for
       #   the given (class_name, method_name, kind) triple,
       #   or `nil` when no built-in override is registered.
       #   When `arg_types` is supplied AND the entry carries a