rigortype 0.2.7 → 0.2.8

data/lib/rigor/environment/reflection.rb

@@ -3,53 +3,34 @@
 module Rigor
   class Environment
     # Frozen, `Ractor.shareable?` read-only RBS query facade.
-    # [ADR-15](../../../docs/adr/15-ractor-concurrency.md)
-    # Phase 2b extracts the read-only surface of {RbsLoader}
-    # into this carrier so future Ractor-isolated workers
-    # can share one Reflection across the pool while keeping
-    # the per-Ractor mutable accelerator state (per-process
-    # memo Hashes) where it belongs.
+    # [ADR-15](../../../docs/adr/15-ractor-concurrency.md) Phase 2b extracts the read-only surface of
+    # {RbsLoader} into this carrier so future Ractor-isolated workers can share one Reflection across the
+    # pool while keeping the per-Ractor mutable accelerator state (per-process memo Hashes) where it belongs.
     #
     # Backing tables (all frozen at construction):
     #
-    # - `known_class_names` — `Set<String>` of every
-    #   class / module / alias name in the loaded RBS
-    #   environment. Top-level prefixed (`"::Hash"`); plain
-    #   queries normalise via {#normalise}.
-    # - `instance_definitions` —
-    #   `Hash<String, RBS::Definition>` keyed on
-    #   `RBS::TypeName#to_s` (top-level prefixed).
+    # - `known_class_names` — `Set<String>` of every class / module / alias name in the loaded RBS
+    #   environment. Top-level prefixed (`"::Hash"`); plain queries normalise via {#normalise}.
+    # - `instance_definitions` — `Hash<String, RBS::Definition>` keyed on `RBS::TypeName#to_s` (top-level
+    #   prefixed).
     # - `singleton_definitions` — same shape, singleton side.
-    # - `type_param_names` —
-    #   `Hash<String, Array<Symbol>>` of declared type
-    #   parameters per class.
-    # - `constant_types` — `Hash<String, Rigor::Type>` of
-    #   translated constant declarations.
-    # - `ancestor_names` — `Hash<String, Array<String>>` of
-    #   normalised ancestor chains per class.
+    # - `type_param_names` — `Hash<String, Array<Symbol>>` of declared type parameters per class.
+    # - `constant_types` — `Hash<String, Rigor::Type>` of translated constant declarations.
+    # - `ancestor_names` — `Hash<String, Array<String>>` of normalised ancestor chains per class.
     #
-    # Each `Reflection` instance is `frozen?` at construction
-    # — every cached table is frozen, `self` is frozen.
-    # **NOT** `Ractor.shareable?`: the `instance_definitions`
-    # / `singleton_definitions` tables hold upstream
-    # `RBS::Definition` objects that transitively reference
-    # `RBS::Location` (C-extension state that
+    # Each `Reflection` instance is `frozen?` at construction — every cached table is frozen, `self` is
+    # frozen. **NOT** `Ractor.shareable?`: the `instance_definitions` / `singleton_definitions` tables hold
+    # upstream `RBS::Definition` objects that transitively reference `RBS::Location` (C-extension state that
     # `Ractor.make_shareable` rejects).
     #
-    # The Ractor worker pool (ADR-15 Phase 4) sidesteps this
-    # by having each worker build ITS OWN `Reflection` from
-    # the shared `Cache::Store`. The cross-Ractor sharing
-    # point is the Store's on-disk + in-process memo layer,
-    # NOT the Reflection itself. Each Reflection is a per-
-    # Ractor immutable read-side view; this carrier exists
-    # to GUARANTEE the per-worker view never mutates after
-    # construction.
+    # The Ractor worker pool (ADR-15 Phase 4) sidesteps this by having each worker build ITS OWN `Reflection`
+    # from the shared `Cache::Store`. The cross-Ractor sharing point is the Store's on-disk + in-process memo
+    # layer, NOT the Reflection itself. Each Reflection is a per- Ractor immutable read-side view; this
+    # carrier exists to GUARANTEE the per-worker view never mutates after construction.
     #
-    # If a future RBS release makes `RBS::Location`
-    # Ractor-shareable, swapping the `freeze` call below for
-    # `Ractor.make_shareable(self)` makes the whole carrier
-    # cross-Ractor-shareable in one line. Until then, the
-    # frozen-read-only contract is the deliverable.
+    # If a future RBS release makes `RBS::Location` Ractor-shareable, swapping the `freeze` call below for
+    # `Ractor.make_shareable(self)` makes the whole carrier cross-Ractor-shareable in one line. Until then,
+    # the frozen-read-only contract is the deliverable.
     class Reflection
       attr_reader :known_class_names, :instance_definitions, :singleton_definitions,
                   :type_param_names, :constant_types, :ancestor_names
@@ -85,12 +66,9 @@ module Rigor
         @constant_types[rooted(name)]
       end
 
-      # Three-valued `(lhs, rhs)` relation:
-      # `:equal` / `:subclass` / `:superclass` / `:disjoint` /
-      # `:unknown`. Mirrors {RbsHierarchy#class_ordering}'s
-      # contract; the Reflection's frozen ancestor table
-      # supports the same queries without any in-process
-      # mutation.
+      # Three-valued `(lhs, rhs)` relation: `:equal` / `:subclass` / `:superclass` / `:disjoint` / `:unknown`.
+      # Mirrors {RbsHierarchy#class_ordering}'s contract; the Reflection's frozen ancestor table supports the
+      # same queries without any in-process mutation.
       def class_ordering(lhs, rhs)
         lhs = unrooted(lhs)
         rhs = unrooted(rhs)
@@ -109,20 +87,17 @@ module Rigor
         end
       end
 
-      # Yields every known class / module / alias name in
-      # the loader's canonical rooted form (`"::Hash"`).
+      # Yields every known class / module / alias name in the loader's canonical rooted form (`"::Hash"`).
       def each_known_class_name(&)
         @known_class_names.each(&)
       end
 
       private
 
-      # The cached tables use mixed key conventions inherited
-      # from the underlying RBS::TypeName surface: the
-      # name-set / definition tables / constant table store
-      # rooted `"::Foo"` keys; the type-param / ancestor
-      # tables store unrooted `"Foo"`. Reflection's queries
-      # normalise per-lookup so callers can pass either form.
+      # The cached tables use mixed key conventions inherited from the underlying RBS::TypeName surface: the
+      # name-set / definition tables / constant table store rooted `"::Foo"` keys; the type-param / ancestor
+      # tables store unrooted `"Foo"`. Reflection's queries normalise per-lookup so callers can pass either
+      # form.
       def rooted(name)
         s = name.to_s
         s.start_with?("::") ? s : "::#{s}"

data/lib/rigor/environment/reporters.rb

@@ -2,32 +2,21 @@
 
 module Rigor
   class Environment
-    # Mutable container for the per-run analysis reporters
-    # ({Rigor::RbsExtended::Reporter} and
-    # {Rigor::Analysis::DependencySourceInference::BoundaryCrossReporter}).
-    # Held by {Environment} as a single attr; the reporters can be
-    # swapped through {Environment#attach_reporters!} so long-lived
-    # integrations (the LSP `ProjectContext`, future editor-mode
-    # daemons) can share one Environment across many `Runner.run`
-    # calls without each call's diagnostic events accumulating into
-    # a single reporter pair.
+    # Mutable container for the per-run analysis reporters ({Rigor::RbsExtended::Reporter} and
+    # {Rigor::Analysis::DependencySourceInference::BoundaryCrossReporter}). Held by {Environment} as a single
+    # attr; the reporters can be swapped through {Environment#attach_reporters!} so long-lived integrations
+    # (the LSP `ProjectContext`, future editor-mode daemons) can share one Environment across many
+    # `Runner.run` calls without each call's diagnostic events accumulating into a single reporter pair.
     #
-    # Per-publish reset is the contract: at the start of every
-    # `Runner.run` in sequential mode, the runner stamps the
-    # environment's `Reporters` slot with the runner's own
-    # freshly-built reporter pair. Dispatchers / `RbsExtended`
-    # consumers continue to write through
-    # `environment.rbs_extended_reporter` /
-    # `environment.boundary_cross_reporter` — the lookup just hops
-    # through the `Reporters` slot rather than reading a frozen
-    # ivar.
+    # Per-publish reset is the contract: at the start of every `Runner.run` in sequential mode, the runner
+    # stamps the environment's `Reporters` slot with the runner's own freshly-built reporter pair.
+    # Dispatchers / `RbsExtended` consumers continue to write through `environment.rbs_extended_reporter` /
+    # `environment.boundary_cross_reporter` — the lookup just hops through the `Reporters` slot rather than
+    # reading a frozen ivar.
     #
-    # Construction default is `nil` on both slots so existing
-    # callers that don't care about reporters (project-default
-    # `Environment.default`, test scopes that don't drive
-    # dispatch) keep their current behaviour: reporter lookups
-    # return nil, and the consumer sites short-circuit on
-    # `reporter.nil?`.
+    # Construction default is `nil` on both slots so existing callers that don't care about reporters
+    # (project-default `Environment.default`, test scopes that don't drive dispatch) keep their current
+    # behaviour: reporter lookups return nil, and the consumer sites short-circuit on `reporter.nil?`.
     class Reporters
       attr_accessor :rbs_extended, :boundary_cross, :source_rbs_synthesis