rigortype 0.2.6 → 0.2.8

data/plugins/rigor-activerecord/lib/rigor/plugin/activerecord.rb

@@ -10,34 +10,26 @@ require_relative "activerecord/analyzer"
 
 module Rigor
   module Plugin
-    # rigor-activerecord — types ActiveRecord finder + relation
-    # calls against the project's `db/schema.rb` and discovered
-    # AR model classes.
+    # rigor-activerecord — types ActiveRecord finder + relation calls against the project's `db/schema.rb`
+    # and discovered AR model classes.
     #
     # ## Architecture
     #
     # Two cached producers per plugin run:
     #
-    # 1. `:schema_table` reads `db/schema.rb` via the `IoBoundary`
-    #    and parses it through {SchemaParser} into a
-    #    {SchemaTable} mapping `table_name → { column_name →
-    #    Column }`.
-    # 2. `:model_index` walks every `.rb` file under the
-    #    configured `model_search_paths`, finds class declarations
-    #    whose direct superclass is in `model_base_classes`, and
-    #    composes them with the schema table into a {ModelIndex}.
+    # 1. `:schema_table` reads `db/schema.rb` via the `IoBoundary` and parses it through {SchemaParser} into
+    #    a {SchemaTable} mapping `table_name → { column_name → Column }`.
+    # 2. `:model_index` walks every `.rb` file under the configured `model_search_paths`, finds class
+    #    declarations whose direct superclass is in `model_base_classes`, and composes them with the schema
+    #    table into a {ModelIndex}.
     #
-    # Both producers ride `Plugin::Base#cache_for` (ADR-60 WD3
-    # record-and-validate): each producer's in-block boundary reads
-    # are captured into its dependency descriptor after the block
-    # runs, and `model_index`'s `watch:` covers model-file additions,
-    # so editing `db/schema.rb`, editing any model, or adding a new
-    # model file invalidates exactly the right cache entry.
+    # Both producers ride `Plugin::Base#cache_for` (ADR-60 WD3 record-and-validate): each producer's
+    # in-block boundary reads are captured into its dependency descriptor after the block runs, and
+    # `model_index`'s `watch:` covers model-file additions, so editing `db/schema.rb`, editing any model, or
+    # adding a new model file invalidates exactly the right cache entry.
     #
-    # The per-file `#diagnostics_for_file` hook delegates to
-    # {Analyzer}, which walks Prism and emits diagnostics for
-    # `Model.find` / `Model.find_by` / `Model.where` calls
-    # against the index.
+    # The per-file `#diagnostics_for_file` hook delegates to {Analyzer}, which walks Prism and emits
+    # diagnostics for `Model.find` / `Model.find_by` / `Model.where` calls against the index.
     #
     # ## Configuration
     #
@@ -48,25 +40,19 @@ module Rigor
     #           model_search_paths: ["app/models"]
     #           model_base_classes: ["ApplicationRecord", "ActiveRecord::Base"]
     #
-    # All three keys default to the values shown above. The class
-    # name `Rigor::Plugin::Activerecord` (single capital R) is
-    # intentional — keeps the constant lookup distinct from
-    # `::ActiveRecord` even though the gem name is hyphenated.
+    # All three keys default to the values shown above. The class name `Rigor::Plugin::Activerecord` (single
+    # capital R) is intentional — keeps the constant lookup distinct from `::ActiveRecord` even though the
+    # gem name is hyphenated.
     #
-    # Note: this plugin is the seventh worked example. It does NOT
-    # require `active_record` at runtime — it only reads project
-    # source, the same way the other examples do. Rigor stays
-    # decoupled from Rails.
+    # Note: this plugin is the seventh worked example. It does NOT require `active_record` at runtime — it
+    # only reads project source, the same way the other examples do. Rigor stays decoupled from Rails.
     class Activerecord < Rigor::Plugin::Base
       manifest(
         id: "activerecord",
-        # Bumped 2026-05-28 — implicit-self class-side AR call
-        # resolution: `select(:uri).group(:uri)` inside a scope
-        # lambda body / class-method body now contributes
-        # `Relation[Model]` via `scope.self_type` instead of
-        # falling through to `Kernel#select` (the IO multiplexer,
-        # `Array[String]` return). Plus `:select` added to the
-        # relation-entry-point list.
+        # Bumped 2026-05-28 — implicit-self class-side AR call resolution: `select(:uri).group(:uri)` inside
+        # a scope lambda body / class-method body now contributes `Relation[Model]` via `scope.self_type`
+        # instead of falling through to `Kernel#select` (the IO multiplexer, `Array[String]` return). Plus
+        # `:select` added to the relation-entry-point list.
         version: "0.5.0",
         description: "Types ActiveRecord finders against the project's db/schema.rb and AR models.",
         config_schema: {
@@ -75,37 +61,30 @@ module Rigor
           "model_base_classes" => { kind: :array, default: %w[ApplicationRecord ActiveRecord::Base] }
         },
         produces: [:model_index],
-        # ADR-25 — the bundled `ActiveRecord::Relation` RBS that
-        # relation-typed call sites (`has_many` accessors,
-        # `Model.where`, scopes) dispatch against.
+        # ADR-25 — the bundled `ActiveRecord::Relation` RBS that relation-typed call sites (`has_many`
+        # accessors, `Model.where`, scopes) dispatch against.
         signature_paths: ["sig"],
-        # ADR-26 — `ActiveRecord::Relation` is an "open" receiver:
-        # it delegates an unbounded set of user-defined scopes /
-        # class methods to its model, so `call.undefined-method`
-        # must not fire for it. `CheckRules` reads this manifest
-        # field and skips the rule for the class.
+        # ADR-26 — `ActiveRecord::Relation` is an "open" receiver: it delegates an unbounded set of
+        # user-defined scopes / class methods to its model, so `call.undefined-method` must not fire for
+        # it. `CheckRules` reads this manifest field and skips the rule for the class.
         open_receivers: ["ActiveRecord::Relation"]
       )
 
-      # The class the bundled `sig/active_record/relation.rbs`
-      # describes; `dynamic_return` contributes
-      # `ActiveRecord::Relation[Model]` for relation-returning
-      # call sites (`has_many` accessors, `Model.where`, scopes).
+      # The class the bundled `sig/active_record/relation.rbs` describes; `dynamic_return` contributes
+      # `ActiveRecord::Relation[Model]` for relation-returning call sites (`has_many` accessors,
+      # `Model.where`, scopes).
       RELATION_CLASS_NAME = "ActiveRecord::Relation"
 
-      # Cached: parsed schema table. The producer reads `@schema_file`
-      # via `io_boundary.read_file` so the descriptor picks up the
-      # digest, then parses through {SchemaParser}.
+      # Cached: parsed schema table. The producer reads `@schema_file` via `io_boundary.read_file` so the
+      # descriptor picks up the digest, then parses through {SchemaParser}.
       producer :schema_table do |_params|
         contents = io_boundary.read_file(@schema_file)
         SchemaParser.parse(contents)
       end
 
-      # Cached: model index. Walks every model file, then composes
-      # the rows with the cached schema table. `watch:` (ADR-60 WD3)
-      # covers model-file additions; the discoverer's in-block reads
-      # are captured into the record-and-validate dependency
-      # descriptor after the block runs.
+      # Cached: model index. Walks every model file, then composes the rows with the cached schema table.
+      # `watch:` (ADR-60 WD3) covers model-file additions; the discoverer's in-block reads are captured
+      # into the record-and-validate dependency descriptor after the block runs.
       producer :model_index, watch: -> { [[@model_search_paths, "**/*.rb"]] } do |_params|
         rows = ModelDiscoverer.new(
           io_boundary: io_boundary,
@@ -125,15 +104,11 @@ module Rigor
         @load_errors = []
       end
 
-      # ADR-9 cross-plugin publication. Builds the model index
-      # eagerly during the per-run `prepare(services)` pass and
-      # publishes a flat Hash form to the shared fact store so
-      # downstream Tier-2 consumers (rigor-actionpack Phase 1
-      # strong-parameter validation, rigor-factorybot Phase 1
-      # (c) attribute → column cross-check, future plugins
-      # that need to know "what columns does class `User`
-      # expose?") can read it without coupling to this
-      # plugin's carrier classes.
+      # ADR-9 cross-plugin publication. Builds the model index eagerly during the per-run
+      # `prepare(services)` pass and publishes a flat Hash form to the shared fact store so downstream
+      # Tier-2 consumers (rigor-actionpack Phase 1 strong-parameter validation, rigor-factorybot Phase 1
+      # (c) attribute → column cross-check, future plugins that need to know "what columns does class
+      # `User` expose?") can read it without coupling to this plugin's carrier classes.
       #
       # The published shape:
       #
@@ -143,11 +118,9 @@ module Rigor
       #       ...
       #     }
       #
-      # Consumers do `services.fact_store.read(plugin_id:
-      # "activerecord", name: :model_index)` and look up by
-      # class name. Discovery failures (missing schema,
-      # unparseable models) leave the fact unpublished — the
-      # consumer's own degrade path runs (typically a no-op).
+      # Consumers do `services.fact_store.read(plugin_id: "activerecord", name: :model_index)` and look up
+      # by class name. Discovery failures (missing schema, unparseable models) leave the fact unpublished —
+      # the consumer's own degrade path runs (typically a no-op).
       def prepare(services)
         index = model_index
         return if index.nil? || index.empty?
@@ -162,12 +135,10 @@ module Rigor
       def diagnostics_for_file(path:, scope:, root:) # rubocop:disable Lint/UnusedMethodArgument
         index = model_index
         if index.nil?
-          # Project-global error (missing `db/schema.rb`, parse
-          # failure, etc.) — emit once per run rather than once
-          # per analyzed file. On a Redmine-shape project that
-          # uses migrations only (no `schema.rb`), the old path
-          # produced 346 identical load-errors; on a Solidus
-          # monorepo (no top-level `schema.rb`), 999.
+          # Project-global error (missing `db/schema.rb`, parse failure, etc.) — emit once per run rather
+          # than once per analyzed file. On a Redmine-shape project that uses migrations only (no
+          # `schema.rb`), the old path produced 346 identical load-errors; on a Solidus monorepo (no
+          # top-level `schema.rb`), 999.
           return [] if @load_errors_emitted
 
           @load_errors_emitted = true
@@ -179,15 +150,11 @@ module Rigor
         Analyzer.new(path: path, model_index: index).analyze(root).diagnostics
       end
 
-      # Rails migration files (`db/migrate/<timestamp>_*.rb`)
-      # and post-migration files (`db/post_migrate/`) reference
-      # the EVOLVING schema at the time the migration was
-      # written — `User.where(admin: ...)` is valid when the
-      # migration ran on a schema that still had the `admin`
-      # column, even though the current `db/schema.rb` no
-      # longer carries it. Validating these files against the
-      # CURRENT schema is a category error; the column
-      # diagnostics MUST stay silent.
+      # Rails migration files (`db/migrate/<timestamp>_*.rb`) and post-migration files
+      # (`db/post_migrate/`) reference the EVOLVING schema at the time the migration was written —
+      # `User.where(admin: ...)` is valid when the migration ran on a schema that still had the `admin`
+      # column, even though the current `db/schema.rb` no longer carries it. Validating these files
+      # against the CURRENT schema is a category error; the column diagnostics MUST stay silent.
       MIGRATION_PATH_PATTERNS = [
         %r{(\A|/)db/migrate/},
         %r{(\A|/)db/post_migrate/}
@@ -201,49 +168,36 @@ module Rigor
         MIGRATION_PATH_PATTERNS.any? { |pattern| path_s.match?(pattern) }
       end
 
-      # The class-side finder / relation entry-point names
-      # `finder_return_type` recognises. Static half of the
-      # `dynamic_return` name gate; the run-time half comes from
-      # the model index (scopes, associations, columns).
+      # The class-side finder / relation entry-point names `finder_return_type` recognises. Static half of
+      # the `dynamic_return` name gate; the run-time half comes from the model index (scopes,
+      # associations, columns).
       FINDER_METHOD_NAMES = %i[find find_by! find_by where all order limit none select].freeze
       private_constant :FINDER_METHOD_NAMES
 
-      # v0.1.2 — return-type contribution; ADR-52 slice 5b —
-      # migrated off `flow_contribution_for` onto the run-time
-      # `methods:` name gate. `Model.find(id)` narrows the call
-      # site's return type to `Nominal[Model]`, so chained calls
-      # (`User.find(1).name`) resolve through the analyzer's
-      # normal dispatch instead of the RBS-level untyped
-      # fall-back; scopes, association accessors, and column
-      # readers narrow per the paths below.
+      # Return-type contribution via the run-time `methods:` name gate (ADR-52 slice 5b). `Model.find(id)`
+      # narrows the call site's return type to `Nominal[Model]`, so chained calls (`User.find(1).name`)
+      # resolve through the analyzer's normal dispatch instead of the RBS-level untyped fall-back; scopes,
+      # association accessors, and column readers narrow per the paths below.
       #
-      # WHY a method-name gate and not `receivers:` — the ADR-52
-      # "rigor-activerecord blocker": a project model not in RBS
-      # types its constant as `Dynamic[top]`, so a receiver-type
-      # gate declines exactly the calls this plugin exists for. A
-      # *name* gate never reads the receiver type; the block keeps
-      # the plugin's own AST-constant / `self_type` / `type_of`
-      # resolution, so the Dynamic-constant case still reaches it
-      # (the same shape as rigor-sorbet's catalog path). The set —
-      # the static finder names ∪ every scope, association, and
-      # column name (plus `column?` predicate forms) the model
-      # index discovered — is exactly the union of names the four
-      # resolution paths below can return a type for, so gating on
-      # it is byte-identical to the old ungated hook. It is broad
-      # (`name`, `id`, …), but membership is one Set probe and the
-      # expensive block runs only on candidate hits.
+      # WHY a method-name gate and not `receivers:` — the ADR-52 "rigor-activerecord blocker": a project
+      # model not in RBS types its constant as `Dynamic[top]`, so a receiver-type gate declines exactly the
+      # calls this plugin exists for. A *name* gate never reads the receiver type; the block keeps the
+      # plugin's own AST-constant / `self_type` / `type_of` resolution, so the Dynamic-constant case still
+      # reaches it (the same shape as rigor-sorbet's catalog path). The set — the static finder names ∪
+      # every scope, association, and column name (plus `column?` predicate forms) the model index
+      # discovered — is exactly the union of names the four resolution paths below can return a type for,
+      # so gating on it is byte-identical to the old ungated hook. It is broad (`name`, `id`, …), but
+      # membership is one Set probe and the expensive block runs only on candidate hits.
       dynamic_return methods: -> { recognised_method_names } do |call_node, scope|
         contribution_return_type(call_node, scope)
       end
 
       private
 
-      # The run-time name gate: finders ∪ scopes ∪ associations ∪
-      # column readers (+ `?` predicates). Resolved lazily on first
-      # dispatch (after `#prepare` built the index), memoised by the
-      # engine. Returns [] when discovery found nothing — the gate
-      # then declines every call, matching the old hook's
-      # `index.nil? || index.empty?` early return.
+      # The run-time name gate: finders ∪ scopes ∪ associations ∪ column readers (+ `?` predicates).
+      # Resolved lazily on first dispatch (after `#prepare` built the index), memoised by the engine.
+      # Returns [] when discovery found nothing — the gate then declines every call, matching the old
+      # hook's `index.nil? || index.empty?` early return.
       def recognised_method_names
         index = model_index
         return [] if index.nil? || index.empty?
@@ -260,8 +214,8 @@ module Rigor
         names
       end
 
-      # Resolution body for `dynamic_return` — same four-path
-      # order, returning the bare type the contract expects.
+      # Resolution body for `dynamic_return` — same four-path order, returning the bare type the contract
+      # expects.
       def contribution_return_type(call_node, scope)
         return nil unless call_node.is_a?(Prism::CallNode)
 
@@ -288,24 +242,19 @@ module Rigor
           class_scope_return_type(call_node, entry)
       end
 
-      # Implicit-self class-side call: `select(:uri)` /
-      # `where(active: true)` inside a `def self.<method>` body,
-      # a class body, or a scope lambda body (`scope :x, -> { ... }`).
-      # The surrounding `self_type` is `Singleton[Model]` in all
-      # three cases, so the same finder / scope / relation entry-
-      # point resolution that handles `Model.where(...)` applies.
+      # Implicit-self class-side call: `select(:uri)` / `where(active: true)` inside a `def
+      # self.<method>` body, a class body, or a scope lambda body (`scope :x, -> { ... }`). The
+      # surrounding `self_type` is `Singleton[Model]` in all three cases, so the same finder / scope /
+      # relation entry-point resolution that handles `Model.where(...)` applies.
       #
-      # Without this, `select(:uri)` inside a class body falls
-      # through to RBS dispatch on `Singleton[Account]`, which
-      # finds `Kernel#select` (the IO multiplexer) at
-      # `core/kernel.rbs` — its `Array[String]` return masks the
-      # AR class-side `select`'s relation return type, so the
-      # canonical scope-body idiom
+      # Without this, `select(:uri)` inside a class body falls through to RBS dispatch on
+      # `Singleton[Account]`, which finds `Kernel#select` (the IO multiplexer) at `core/kernel.rbs` — its
+      # `Array[String]` return masks the AR class-side `select`'s relation return type, so the canonical
+      # scope-body idiom
       #
       #   scope :duplicate_uris, -> { select(:uri).group(:uri) }
       #
-      # types `select(:uri)` as `Array[String]` and the chained
-      # `.group` as `undefined-method`.
+      # types `select(:uri)` as `Array[String]` and the chained `.group` as `undefined-method`.
       def implicit_self_class_call_return_type(call_node, scope, index)
         return nil if scope.nil?
 
@@ -319,12 +268,10 @@ module Rigor
           class_scope_return_type(call_node, entry)
       end
 
-      # Class-side finders + the class-side relation entry points.
-      # `find` / `find_by!` return the model; `find_by` adds the
-      # `nil` arm; `where` / `all` / `order` / `limit` / `none`
-      # open a relation. The relation then carries its element
-      # type through any further chained query method via the
-      # bundled `ActiveRecord::Relation` RBS.
+      # Class-side finders + the class-side relation entry points. `find` / `find_by!` return the model;
+      # `find_by` adds the `nil` arm; `where` / `all` / `order` / `limit` / `none` open a relation. The
+      # relation then carries its element type through any further chained query method via the bundled
+      # `ActiveRecord::Relation` RBS.
       def finder_return_type(call_node, entry)
         case call_node.name
         when :find
@@ -332,8 +279,8 @@ module Rigor
 
           Rigor::Type::Combinator.nominal_of(entry.class_name)
         when :find_by!
-          # The bang variant raises `RecordNotFound` instead of
-          # returning `nil`, so the result is non-nullable.
+          # The bang variant raises `RecordNotFound` instead of returning `nil`, so the result is
+          # non-nullable.
           Rigor::Type::Combinator.nominal_of(entry.class_name)
         when :find_by
           Rigor::Type::Combinator.union(
@@ -342,31 +289,26 @@ module Rigor
           )
         when :where, :all, :order, :limit, :none, :select
           # `:select` was added to close Mastodon's
-          # `scope :duplicate_uris, -> { select(:uri).group(:uri).having(...) }`
-          # shape: the implicit-self `select(:uri)` inside the
-          # scope lambda body had been resolving to `Kernel#select`
-          # (IO multiplexer, return `Array[String]`), masking the
-          # AR class-side relation entry point. The rest of the
-          # query DSL chains through the bundled `ActiveRecord::Relation`
-          # RBS once a relation is open.
+          # `scope :duplicate_uris, -> { select(:uri).group(:uri).having(...) }` shape: the implicit-self
+          # `select(:uri)` inside the scope lambda body had been resolving to `Kernel#select` (IO
+          # multiplexer, return `Array[String]`), masking the AR class-side relation entry point. The rest
+          # of the query DSL chains through the bundled `ActiveRecord::Relation` RBS once a relation is
+          # open.
           relation_of(entry.class_name)
         end
       end
 
-      # `Post.published` / `Post.recent(5)` — a user-declared
-      # `scope` returns a relation of the model regardless of the
-      # arguments it takes.
+      # `Post.published` / `Post.recent(5)` — a user-declared `scope` returns a relation of the model
+      # regardless of the arguments it takes.
       def class_scope_return_type(call_node, entry)
         return nil unless entry.scope?(call_node.name)
 
         relation_of(entry.class_name)
       end
 
-      # `ActiveRecord::Relation[Model]` — the type the bundled
-      # `sig/active_record/relation.rbs` describes. The class is
-      # declared `open_receivers` in the manifest, so a chained
-      # scope call the bundled RBS cannot enumerate does not
-      # surface as `call.undefined-method` (ADR-26).
+      # `ActiveRecord::Relation[Model]` — the type the bundled `sig/active_record/relation.rbs` describes.
+      # The class is declared `open_receivers` in the manifest, so a chained scope call the bundled RBS
+      # cannot enumerate does not surface as `call.undefined-method` (ADR-26).
       def relation_of(model_class_name)
         Rigor::Type::Combinator.nominal_of(
           RELATION_CLASS_NAME,
@@ -374,24 +316,17 @@ module Rigor
         )
       end
 
-      # A scope invoked on an already-typed relation
-      # (`User.where(active: true).published`) keeps the relation
-      # type through the chain. The bundled `ActiveRecord::Relation`
-      # RBS cannot enumerate user-defined scopes, so without this
-      # the chain would lose its element type after the first
-      # scope call. Non-scope methods decline — the RBS tier
-      # resolves `where` / `order` / `each` / `first` precisely.
-      # Scopes may take arguments (`relation.recent(5)`), so —
-      # unlike `instance_call_return_type` — argument calls are
-      # not skipped.
+      # A scope invoked on an already-typed relation (`User.where(active: true).published`) keeps the
+      # relation type through the chain. The bundled `ActiveRecord::Relation` RBS cannot enumerate
+      # user-defined scopes, so without this the chain would lose its element type after the first scope
+      # call. Non-scope methods decline — the RBS tier resolves `where` / `order` / `each` / `first`
+      # precisely. Scopes may take arguments (`relation.recent(5)`), so — unlike `instance_call_return_type`
+      # — argument calls are not skipped.
       #
-      # The cheap `scope_name?` pre-check is load-bearing: it
-      # gates the `scope.type_of(receiver)` call so the receiver
-      # type is computed ONLY when the method name could be a
-      # scope. `type_of` on a call receiver re-enters dispatch,
-      # and calling it for every call node in a long method chain
-      # is pathologically expensive — the pre-check keeps the
-      # cost off the hot path.
+      # The cheap `scope_name?` pre-check is load-bearing: it gates the `scope.type_of(receiver)` call so
+      # the receiver type is computed ONLY when the method name could be a scope. `type_of` on a call
+      # receiver re-enters dispatch, and calling it for every call node in a long method chain is
+      # pathologically expensive — the pre-check keeps the cost off the hot path.
       def relation_call_return_type(call_node, scope, index)
         return nil if call_node.receiver.nil?
         return nil unless scope_name?(call_node.name, index)
@@ -406,16 +341,15 @@ module Rigor
         relation_of(model_name)
       end
 
-      # Whether `name` is a declared `scope` on ANY model in the
-      # index. A run-lifetime memoised Set so the per-call check
-      # in `relation_call_return_type` stays O(1).
+      # Whether `name` is a declared `scope` on ANY model in the index. A run-lifetime memoised Set so the
+      # per-call check in `relation_call_return_type` stays O(1).
       def scope_name?(name, index)
         @all_scope_names ||= index.entries.each_value.flat_map(&:scopes).to_set
         @all_scope_names.include?(name.to_s)
       end
 
-      # When `type` is `ActiveRecord::Relation[Nominal[Model]]`,
-      # returns the model class name; nil for any other type.
+      # When `type` is `ActiveRecord::Relation[Nominal[Model]]`, returns the model class name; nil for
+      # any other type.
       def relation_element_class_name(type)
         return nil unless type.is_a?(Rigor::Type::Nominal)
         return nil unless type.class_name == RELATION_CLASS_NAME
@@ -424,13 +358,10 @@ module Rigor
         element.class_name if element.is_a?(Rigor::Type::Nominal)
       end
 
-      # Instance-side navigation: when the call's receiver
-      # resolves to `Nominal[Model]` and the method name matches
-      # a discovered association OR a table column, the call site
-      # gets a precise return type. Calls with arguments are
-      # skipped — accessor / association calls take no args, and
-      # argument forms (`user.posts(limit: 10)`, `user.name = x`)
-      # route through Rails APIs this slice does not model.
+      # Instance-side navigation: when the call's receiver resolves to `Nominal[Model]` and the method name
+      # matches a discovered association OR a table column, the call site gets a precise return type.
+      # Calls with arguments are skipped — accessor / association calls take no args, and argument forms
+      # (`user.posts(limit: 10)`, `user.name = x`) route through Rails APIs this slice does not model.
       def instance_call_return_type(call_node, scope, index)
         return nil unless call_node.arguments.nil?
 
@@ -445,16 +376,12 @@ module Rigor
           column_return_type(entry, call_node.name)
       end
 
-      # The return type for an association accessor. A `belongs_to`
-      # / `has_one` singular association narrows to the target
-      # model — `belongs_to` is required (non-`nil`) by default
-      # since Rails 5 so it is `Nominal[Target]`, while `has_one`
-      # (and an `optional: true` / `required: false` `belongs_to`)
-      # adds the `nil` arm. A `has_many` / `has_and_belongs_to_many`
-      # collection narrows to `ActiveRecord::Relation[Target]` so
-      # chained query / iteration calls resolve. A polymorphic
-      # association has no single static target and declines
-      # rather than inventing a wrong type.
+      # The return type for an association accessor. A `belongs_to` / `has_one` singular association
+      # narrows to the target model — `belongs_to` is required (non-`nil`) by default since Rails 5 so it
+      # is `Nominal[Target]`, while `has_one` (and an `optional: true` / `required: false` `belongs_to`)
+      # adds the `nil` arm. A `has_many` / `has_and_belongs_to_many` collection narrows to
+      # `ActiveRecord::Relation[Target]` so chained query / iteration calls resolve. A polymorphic
+      # association has no single static target and declines rather than inventing a wrong type.
       def association_return_type(entry, method_name)
         association = entry.association(method_name)
         return nil if association.nil?
@@ -471,19 +398,14 @@ module Rigor
         end
       end
 
-      # Instance-side column access. `user.name` on a
-      # `Nominal[User]` receiver narrows to the column's value
-      # type; `user.name?` (the ActiveRecord-generated predicate)
-      # narrows to `bool`.
+      # Instance-side column access. `user.name` on a `Nominal[User]` receiver narrows to the column's
+      # value type; `user.name?` (the ActiveRecord-generated predicate) narrows to `bool`.
       #
-      # The contributed type is deliberately NON-nullable even
-      # though the DB column may permit `NULL`: Rails code calls
-      # column accessors directly (`user.email.downcase`) as a
-      # matter of course, and contributing `T | nil` would light
-      # up that idiom with `possible-nil-receiver` across an
-      # entire codebase. Under-reporting a nil column is a false
-      # negative; over-reporting it is a false positive — and the
-      # project ranks the latter as the worse failure.
+      # The contributed type is deliberately NON-nullable even though the DB column may permit `NULL`:
+      # Rails code calls column accessors directly (`user.email.downcase`) as a matter of course, and
+      # contributing `T | nil` would light up that idiom with `possible-nil-receiver` across an entire
+      # codebase. Under-reporting a nil column is a false negative; over-reporting it is a false positive
+      # — and the project ranks the latter as the worse failure.
       def column_return_type(entry, method_name)
         name = method_name.to_s
         predicate = name.end_with?("?")
@@ -499,12 +421,10 @@ module Rigor
         column.array? ? Rigor::Type::Combinator.nominal_of("Array", type_args: [inner]) : inner
       end
 
-      # Maps a `SchemaTable::Column#ruby_type` string to a Rigor
-      # type. `"Object"` (json / jsonb / unrecognised column
-      # types) declines — `Nominal[Object]` would be NARROWER
-      # than the RBS-erased envelope and could surface false
-      # `call.undefined-method` on a value whose real shape the
-      # plugin cannot model.
+      # Maps a `SchemaTable::Column#ruby_type` string to a Rigor type. `"Object"` (json / jsonb /
+      # unrecognised column types) declines — `Nominal[Object]` would be NARROWER than the RBS-erased
+      # envelope and could surface false `call.undefined-method` on a value whose real shape the plugin
+      # cannot model.
       def ruby_type_to_type(ruby_type)
         case ruby_type
         when "bool" then bool_type
@@ -547,12 +467,9 @@ module Rigor
         node.arguments.arguments.size
       end
 
-      # Marshal-clean Hash form for the cross-plugin fact
-      # store. Consumers (rigor-actionpack Phase 1,
-      # rigor-factorybot Phase 1 (c), ...) get a flat
-      # `class_name → { table:, columns: }` map without
-      # depending on this plugin's `ModelIndex` /
-      # `SchemaTable::Column` carrier classes.
+      # Marshal-clean Hash form for the cross-plugin fact store. Consumers (rigor-actionpack Phase 1,
+      # rigor-factorybot Phase 1 (c), ...) get a flat `class_name → { table:, columns: }` map without
+      # depending on this plugin's `ModelIndex` / `SchemaTable::Column` carrier classes.
       def index_to_published_hash(index)
         index.entries.transform_values do |entry|
           {
@@ -574,11 +491,9 @@ module Rigor
         table = schema_table_or_nil
         return nil if table.nil?
 
-        # ADR-60 WD3 record-and-validate: the producer's own in-block
-        # `ModelDiscoverer` reads are captured into the dependency
-        # descriptor after the block runs, and the producer's `watch:`
-        # covers model-file additions — so no priming walk is needed
-        # (it used to run the discover twice).
+        # ADR-60 WD3 record-and-validate: the producer's own in-block `ModelDiscoverer` reads are
+        # captured into the dependency descriptor after the block runs, and the producer's `watch:` covers
+        # model-file additions — so no priming walk is needed (it used to run the discover twice).
         @model_index = cache_for(:model_index, params: {}).call
       rescue StandardError => e
         @load_errors << "model index build failed: #{e.class}: #{e.message}"
@@ -587,20 +502,17 @@ module Rigor
 
       def schema_table_or_nil
         return @schema_table if @schema_table
-        # Memoize the *failure*, not just the success: `model_index`
-        # (and thus this method) is invoked per AR call site, so a
-        # missing / unreadable schema file would otherwise re-attempt
-        # the read and append a fresh interpolated error string to
-        # `@load_errors` on every call. On a large Rails app that grew
-        # `@load_errors` to millions of retained strings (measured: 4.2 M
-        # strings / ~1.5 GB on Redmine). One attempt is enough.
+        # Memoize the *failure*, not just the success: `model_index` (and thus this method) is invoked per
+        # AR call site, so a missing / unreadable schema file would otherwise re-attempt the read and
+        # append a fresh interpolated error string to `@load_errors` on every call. On a large Rails app
+        # that grew `@load_errors` to millions of retained strings (measured: 4.2 M strings / ~1.5 GB on
+        # Redmine). One attempt is enough.
         return nil if @schema_load_attempted
 
         @schema_load_attempted = true
-        # ADR-60 WD3 record-and-validate: the producer reads
-        # `@schema_file` in-block, and that read is captured into the
-        # dependency descriptor after the block runs — so no priming
-        # read is needed here.
+        # ADR-60 WD3 record-and-validate: the producer reads `@schema_file` in-block, and that read is
+        # captured into the dependency descriptor after the block runs — so no priming read is needed
+        # here.
         @schema_table = cache_for(:schema_table, params: {}).call
       rescue Plugin::AccessDeniedError => e
         @load_errors << "rigor-activerecord: #{e.message}"

data/plugins/rigor-activerecord/lib/rigor-activerecord.rb

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
-# Gem entry point. Required by Rigor's plugin loader when
-# `.rigor.yml` lists `rigor-activerecord` under `plugins:`. The
-# loader expects this `require` to side-effect a call to
-# `Rigor::Plugin.register`, which the body of
-# `lib/rigor/plugin/activerecord.rb` performs at load time.
+# Gem entry point. Required by Rigor's plugin loader when `.rigor.yml` lists `rigor-activerecord` under
+# `plugins:`. The loader expects this `require` to side-effect a call to `Rigor::Plugin.register`, which
+# the body of `lib/rigor/plugin/activerecord.rb` performs at load time.
 require_relative "rigor/plugin/activerecord"