rigortype 0.1.7 → 0.1.9

data/lib/rigor/triage.rb

@@ -0,0 +1,89 @@
+# frozen_string_literal: true
+
+require_relative "triage/hint"
+require_relative "triage/catalogue"
+
+module Rigor
+  # ADR-23 — diagnostic triage. Aggregates a `rigor check`
+  # diagnostic stream into the data behind the `rigor triage`
+  # report: a rule-ID distribution, per-file hotspots, and the
+  # heuristic hint catalogue ({Triage::Catalogue}).
+  #
+  # Pure over the diagnostic stream — no second analysis pass, no
+  # analyzer internals. `Triage.analyze` is the single entry point;
+  # rendering is {CLI::TriageRenderer}'s job.
+  module Triage
+    UNCATEGORISED = "(uncategorised)"
+
+    Summary = Data.define(:total, :error, :warning, :info)
+    RuleCount = Data.define(:rule, :count)
+    Hotspot = Data.define(:file, :count, :by_rule)
+    Report = Data.define(:summary, :distribution, :hotspots, :hints)
+
+    module_function
+
+    # @param diagnostics [Array<Analysis::Diagnostic>]
+    # @param top [Integer] hotspot-file cap
+    # @param hints [Boolean] run the heuristic catalogue
+    # @return [Report]
+    def analyze(diagnostics, top: 10, hints: true)
+      Report.new(
+        summary: build_summary(diagnostics),
+        distribution: build_distribution(diagnostics),
+        hotspots: build_hotspots(diagnostics, top),
+        hints: hints ? Catalogue.recognise(diagnostics) : []
+      )
+    end
+
+    # Diagnostics without a `rule` (parse errors, internal-analyzer
+    # errors) bucket under a single sentinel rather than vanishing.
+    def rule_key(diagnostic)
+      diagnostic.qualified_rule || UNCATEGORISED
+    end
+
+    def build_summary(diagnostics)
+      by_severity = diagnostics.group_by(&:severity).transform_values(&:size)
+      Summary.new(
+        total: diagnostics.size,
+        error: by_severity.fetch(:error, 0),
+        warning: by_severity.fetch(:warning, 0),
+        info: by_severity.fetch(:info, 0)
+      )
+    end
+
+    def build_distribution(diagnostics)
+      diagnostics.group_by { |d| rule_key(d) }
+                 .map { |rule, group| RuleCount.new(rule: rule, count: group.size) }
+                 .sort_by { |row| [-row.count, row.rule] }
+    end
+
+    def build_hotspots(diagnostics, top)
+      diagnostics.group_by(&:path)
+                 .map { |path, group| hotspot_for(path, group) }
+                 .sort_by { |spot| [-spot.count, spot.file] }
+                 .first(top)
+    end
+
+    def hotspot_for(path, group)
+      by_rule = group.group_by { |d| rule_key(d) }
+                     .transform_values(&:size)
+                     .sort_by { |rule, count| [-count, rule] }
+                     .to_h
+      Hotspot.new(file: path, count: group.size, by_rule: by_rule)
+    end
+
+    def report_to_h(report)
+      {
+        "summary" => {
+          "total" => report.summary.total, "error" => report.summary.error,
+          "warning" => report.summary.warning, "info" => report.summary.info
+        },
+        "distribution" => report.distribution.map { |r| { "rule" => r.rule, "count" => r.count } },
+        "hotspots" => report.hotspots.map do |h|
+          { "file" => h.file, "count" => h.count, "by_rule" => h.by_rule }
+        end,
+        "hints" => report.hints.map(&:to_h)
+      }
+    end
+  end
+end

data/lib/rigor/type/constant.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require "date"
 require_relative "../trinary"
 
 module Rigor
@@ -24,6 +25,13 @@ module Rigor
         Complex,
         Regexp,
         Pathname,
+        ::Set,
+        # `Date` covers `DateTime` (a subclass). `Time` is core.
+        # Both arise only from deterministic constructor folding
+        # (`Date.new` / `Time.utc`) — there is no Date / Time
+        # literal node — so a `Constant` carrier is always sound.
+        Date,
+        Time,
         TrueClass,
         FalseClass,
         NilClass
@@ -42,12 +50,31 @@ module Rigor
           raise ArgumentError, "Rigor::Type::Constant only carries scalar literals; got #{value.class}"
         end
 
-        @value = value.is_a?(String) ? value.dup.freeze : value
+        @value = freezable_carrier?(value) ? value.dup.freeze : value
         freeze
       end
 
+      # Mutable-ish carriers are stored as a frozen copy so a later
+      # in-place mutation cannot rewrite the literal under us. `Time`
+      # joins `String` / `Set` here: `Time#localtime` mutates the
+      # receiver's zone in place, so the carrier holds a frozen copy
+      # (the catalog also blocklists the mutators). `Date` is already
+      # immutable, but is duped-and-frozen for symmetry.
+      def freezable_carrier?(value)
+        value.is_a?(String) || value.is_a?(::Set) ||
+          value.is_a?(Date) || value.is_a?(Time)
+      end
+
+      # `Date#inspect` / `DateTime#inspect` spell out the internal
+      # astronomical-Julian-day representation, which is unreadable
+      # in a diagnostic. ISO-8601 is the compact, deterministic
+      # form. `Time#inspect` is already compact (`2026-01-01
+      # 00:00:00 UTC`), so it keeps the default.
       def describe(_verbosity = :short)
-        value.inspect
+        case value
+        when Date then value.iso8601
+        else value.inspect
+        end
       end
 
       # RBS supports `Literal` types for booleans, nil, integer

data/lib/rigor/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Rigor
-  VERSION = "0.1.7"
+  VERSION = "0.1.9"
 end

data/sig/rigor/inference.rbs

@@ -135,6 +135,7 @@ module Rigor
       def self?.build_declaration_overrides: (untyped root) -> Hash[untyped, Type::t]
       def self?.record_declarations: (untyped node, Array[String] qualified_prefix, Hash[untyped, Type::t] identity_table, Hash[String, Type::t] discovered) -> void
       def self?.discovered_classes_for_paths: (Array[String] paths, ?buffer: untyped) -> Hash[String, Type::t]
+      def self?.discovered_def_index_for_paths: (Array[String] paths, ?buffer: untyped) -> Hash[Symbol, untyped]
       def self?.collect_class_decls: (untyped node, Array[String] qualified_prefix, Hash[String, Type::t] accumulator) -> void
       def self?.qualified_name_for: (untyped constant_path_node) -> String?
       def self?.render_constant_path: (untyped node) -> String

data/sig/rigor/scope.rbs

@@ -16,6 +16,8 @@ module Rigor
     attr_reader discovered_methods: Hash[String, Hash[Symbol, Symbol]]
     attr_reader discovered_def_nodes: Hash[String, Hash[Symbol, untyped]]
     attr_reader discovered_method_visibilities: Hash[String, Hash[Symbol, Symbol]]
+    attr_reader discovered_superclasses: Hash[String, String]
+    attr_reader discovered_includes: Hash[String, Array[String]]
     attr_reader source_path: String?
 
     def self.empty: (?environment: Environment, ?source_path: String?) -> Scope
@@ -44,6 +46,10 @@ module Rigor
     def top_level_def_for: (String | Symbol method_name) -> untyped?
     def with_discovered_method_visibilities: (Hash[String, Hash[Symbol, Symbol]] table) -> Scope
     def discovered_method_visibility: (String | Symbol class_name, String | Symbol method_name) -> Symbol?
+    def superclass_of: (String | Symbol class_name) -> String?
+    def with_discovered_superclasses: (Hash[String, String] table) -> Scope
+    def includes_of: (String | Symbol class_name) -> Array[String]
+    def with_discovered_includes: (Hash[String, Array[String]] table) -> Scope
     def with_fact: (Analysis::FactStore::Fact fact) -> Scope
     def with_self_type: (Type::t? type) -> Scope
     def with_declared_types: (Hash[untyped, Type::t] table) -> Scope

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rigortype
 version: !ruby/object:Gem::Version
-  version: 0.1.7
+  version: 0.1.9
 platform: ruby
 authors:
 - Rigor contributors
@@ -261,11 +261,15 @@ files:
 - lib/rigor/cache/rbs_known_class_names.rb
 - lib/rigor/cache/store.rb
 - lib/rigor/cli.rb
+- lib/rigor/cli/annotate_command.rb
 - lib/rigor/cli/baseline_command.rb
 - lib/rigor/cli/diff_command.rb
 - lib/rigor/cli/explain_command.rb
 - lib/rigor/cli/lsp_command.rb
+- lib/rigor/cli/prism_colorizer.rb
 - lib/rigor/cli/sig_gen_command.rb
+- lib/rigor/cli/triage_command.rb
+- lib/rigor/cli/triage_renderer.rb
 - lib/rigor/cli/type_of_command.rb
 - lib/rigor/cli/type_of_renderer.rb
 - lib/rigor/cli/type_scan_command.rb
@@ -325,16 +329,23 @@ files:
 - lib/rigor/inference/macro_block_self_type.rb
 - lib/rigor/inference/method_dispatcher.rb
 - lib/rigor/inference/method_dispatcher/block_folding.rb
+- lib/rigor/inference/method_dispatcher/cgi_folding.rb
 - lib/rigor/inference/method_dispatcher/constant_folding.rb
 - lib/rigor/inference/method_dispatcher/file_folding.rb
 - lib/rigor/inference/method_dispatcher/iterator_dispatch.rb
 - lib/rigor/inference/method_dispatcher/kernel_dispatch.rb
 - lib/rigor/inference/method_dispatcher/literal_string_folding.rb
+- lib/rigor/inference/method_dispatcher/math_folding.rb
 - lib/rigor/inference/method_dispatcher/method_folding.rb
 - lib/rigor/inference/method_dispatcher/overload_selector.rb
 - lib/rigor/inference/method_dispatcher/rbs_dispatch.rb
 - lib/rigor/inference/method_dispatcher/receiver_affinity.rb
+- lib/rigor/inference/method_dispatcher/regexp_folding.rb
+- lib/rigor/inference/method_dispatcher/set_folding.rb
 - lib/rigor/inference/method_dispatcher/shape_dispatch.rb
+- lib/rigor/inference/method_dispatcher/shellwords_folding.rb
+- lib/rigor/inference/method_dispatcher/time_folding.rb
+- lib/rigor/inference/method_dispatcher/uri_folding.rb
 - lib/rigor/inference/method_parameter_binder.rb
 - lib/rigor/inference/multi_target_binder.rb
 - lib/rigor/inference/narrowing.rb
@@ -376,6 +387,7 @@ files:
 - lib/rigor/plugin/macro/heredoc_template.rb
 - lib/rigor/plugin/macro/trait_registry.rb
 - lib/rigor/plugin/manifest.rb
+- lib/rigor/plugin/protocol_contract.rb
 - lib/rigor/plugin/registry.rb
 - lib/rigor/plugin/services.rb
 - lib/rigor/plugin/trust_policy.rb
@@ -401,6 +413,9 @@ files:
 - lib/rigor/source/node_locator.rb
 - lib/rigor/source/node_walker.rb
 - lib/rigor/testing.rb
+- lib/rigor/triage.rb
+- lib/rigor/triage/catalogue.rb
+- lib/rigor/triage/hint.rb
 - lib/rigor/trinary.rb
 - lib/rigor/type.rb
 - lib/rigor/type/accepts_result.rb