rigortype 0.1.5 → 0.1.7

data/lib/rigor/cli.rb

@@ -25,7 +25,9 @@ module Rigor
       "type-scan" => :run_type_scan,
       "explain" => :run_explain,
       "diff" => :run_diff,
-      "sig-gen" => :run_sig_gen
+      "sig-gen" => :run_sig_gen,
+      "lsp" => :run_lsp,
+      "baseline" => :run_baseline
     }.freeze
 
     def self.start(argv = ARGV, out: $stdout, err: $stderr)
@@ -69,24 +71,24 @@ module Rigor
 
     def run_check
       require_relative "analysis/runner"
+      require_relative "analysis/buffer_binding"
+      require_relative "analysis/baseline"
       require_relative "cache/store"
 
       options = parse_check_options
+      buffer = resolve_buffer_binding(options)
+      return EXIT_USAGE if buffer == :usage_error
 
       configuration = Configuration.load(options.fetch(:config))
       cache_root = configuration.cache_path
       handle_clear_cache(cache_root) if options.fetch(:clear_cache)
-      cache_store = options.fetch(:no_cache) ? nil : Cache::Store.new(root: cache_root)
 
-      paths = @argv.empty? ? configuration.paths : @argv
-      runner = Analysis::Runner.new(
-        configuration: configuration,
-        explain: options.fetch(:explain),
-        cache_store: cache_store,
-        collect_stats: options.fetch(:stats),
-        workers: resolve_workers(options, configuration)
+      runner = build_check_runner(
+        configuration: configuration, options: options,
+        buffer: buffer, cache_root: cache_root
       )
-      result = runner.run(paths)
+      result = runner.run(@argv.empty? ? configuration.paths : @argv)
+      result = apply_baseline_filter(result, configuration, options)
 
       write_result(result, options.fetch(:format))
       write_run_stats(result.stats) if result.stats
@@ -94,6 +96,94 @@ module Rigor
       result.success? ? 0 : 1
     end
 
+    # ADR-22 — apply the baseline filter as the LAST step of
+    # the diagnostic pipeline (after `# rigor:disable`,
+    # `severity_profile`, etc. — WD6). Resolution order
+    # follows WD2 (b):
+    #
+    #   1. --no-baseline on the CLI → no baseline.
+    #   2. --baseline=PATH on the CLI → load that path.
+    #   3. .rigor.yml's `baseline: <path>` → load that path.
+    #   4. otherwise → no baseline.
+    #
+    # When the path resolves and loads successfully, the filter
+    # replaces `result.diagnostics` with the surfaced set and
+    # writes a one-line summary to stderr (WD7) when any
+    # diagnostics were silenced. Load failures emit a warning
+    # to stderr and fall through to "no baseline" (graceful
+    # degradation).
+    def apply_baseline_filter(result, configuration, options)
+      path = resolve_baseline_path(configuration, options)
+      return result if path.nil?
+
+      baseline = Analysis::Baseline.load(path)
+      return result if baseline.nil?
+
+      surfaced, silenced_count = baseline.filter(result.diagnostics)
+      report_baseline_summary(silenced_count, path) if silenced_count.positive?
+      Analysis::Result.new(diagnostics: surfaced, stats: result.stats)
+    rescue Analysis::Baseline::LoadError => e
+      @err.puts("rigor: baseline load failed: #{e.message} (continuing without baseline)")
+      result
+    end
+
+    # WD2 (b) — resolve effective baseline path.
+    def resolve_baseline_path(configuration, options)
+      cli_value = options.fetch(:baseline)
+      case cli_value
+      when false then nil # --no-baseline
+      when :unset then configuration.baseline_path # fall through to config
+      else cli_value # --baseline=PATH
+      end
+    end
+
+    def report_baseline_summary(silenced_count, baseline_path)
+      @err.puts("rigor: #{silenced_count} diagnostic(s) silenced by baseline #{baseline_path}")
+    end
+
+    def build_check_runner(configuration:, options:, buffer:, cache_root:)
+      cache_store = options.fetch(:no_cache) ? nil : Cache::Store.new(root: cache_root)
+      Analysis::Runner.new(
+        configuration: configuration,
+        explain: options.fetch(:explain),
+        cache_store: cache_store,
+        collect_stats: options.fetch(:stats),
+        workers: resolve_workers(options, configuration),
+        buffer: buffer
+      )
+    end
+
+    # Editor-mode CLI envelope. The `--tmp-file=PATH` /
+    # `--instead-of=PATH` pair binds an in-flight buffer file to
+    # the logical project path it represents (see
+    # `docs/design/20260516-editor-mode.md`). Both flags must
+    # appear together; either alone is a usage error. The
+    # physical file must be readable; missing-file is a usage
+    # error too so editors get one consistent failure shape.
+    #
+    # Returns:
+    # - `nil` when neither flag was supplied (legacy path).
+    # - `Rigor::Analysis::BufferBinding` when the pair is valid.
+    # - `:usage_error` after writing one diagnostic to stderr;
+    #   the caller MUST translate this to `EXIT_USAGE`.
+    def resolve_buffer_binding(options)
+      tmp = options[:tmp_file]
+      instead = options[:instead_of]
+      return nil if tmp.nil? && instead.nil?
+
+      if tmp.nil? || instead.nil?
+        @err.puts("--tmp-file and --instead-of must appear together")
+        return :usage_error
+      end
+
+      unless File.file?(tmp)
+        @err.puts("--tmp-file #{tmp.inspect}: no such file or not readable")
+        return :usage_error
+      end
+
+      Analysis::BufferBinding.new(logical_path: instead, physical_path: tmp)
+    end
+
     # ADR-15 Phase 4c — resolves the worker count by
     # precedence: CLI `--workers=N` (most explicit) > env
     # `RIGOR_RACTOR_WORKERS` > config `.rigor.yml`
@@ -112,7 +202,7 @@ module Rigor
       configuration.parallel_workers
     end
 
-    def parse_check_options
+    def parse_check_options # rubocop:disable Metrics/AbcSize,Metrics/MethodLength
       options = {
         # `nil` triggers `Configuration.discover` (`.rigor.yml` then
         # `.rigor.dist.yml`); an explicit `--config=PATH` overrides.
@@ -133,9 +223,19 @@ module Rigor
         # `RIGOR_RACTOR_WORKERS` then `.rigor.yml`
         # `parallel.workers:` then 0 (sequential). See
         # `resolve_workers` for the precedence chain.
-        workers: nil
+        workers: nil,
+        # Editor mode (`docs/design/20260516-editor-mode.md`).
+        # Both must appear together; the runner uses the pair
+        # to bind an in-flight buffer file to its logical path.
+        tmp_file: nil,
+        instead_of: nil,
+        # ADR-22 — baseline filter. `:unset` means "fall through
+        # to `.rigor.yml`'s `baseline:` key"; a String overrides
+        # the config; `false` (from `--no-baseline`) suppresses
+        # any baseline that the config might name.
+        baseline: :unset
       }
-      parser = OptionParser.new do |opts|
+      parser = OptionParser.new do |opts| # rubocop:disable Metrics/BlockLength
         opts.banner = "Usage: rigor check [options] [paths]"
         opts.on("--config=PATH", "Path to the Rigor configuration file") { |value| options[:config] = value }
         opts.on("--format=FORMAT", "Output format: text or json") { |value| options[:format] = value }
@@ -151,6 +251,22 @@ module Rigor
                 "Dispatch per-file analysis across N Ractor workers (default: 0; sequential)") do |value|
           options[:workers] = value
         end
+        opts.on("--tmp-file=PATH",
+                "Editor mode: read source bytes from PATH instead of --instead-of (paired)") do |value|
+          options[:tmp_file] = value
+        end
+        opts.on("--instead-of=PATH",
+                "Editor mode: the logical project path the buffer represents (paired with --tmp-file)") do |value|
+          options[:instead_of] = value
+        end
+        opts.on("--baseline=PATH",
+                "ADR-22: load baseline from PATH (overrides .rigor.yml `baseline:`)") do |value|
+          options[:baseline] = value
+        end
+        opts.on("--no-baseline",
+                "ADR-22: ignore any configured baseline for this run") do
+          options[:baseline] = false
+        end
       end
       parser.parse!(@argv)
       options
@@ -336,6 +452,18 @@ module Rigor
       SigGenCommand.new(argv: @argv, out: @out, err: @err).run
     end
 
+    def run_lsp
+      require_relative "cli/lsp_command"
+
+      LspCommand.new(argv: @argv, out: @out, err: @err).run
+    end
+
+    def run_baseline
+      require_relative "cli/baseline_command"
+
+      BaselineCommand.new(argv: @argv, out: @out, err: @err).run
+    end
+
     def write_result(result, format)
       case format
       when "json"
@@ -376,6 +504,7 @@ module Rigor
           explain    Print the description of one or all CheckRules
           diff       Compare current diagnostics to a saved baseline JSON
           sig-gen    Emit RBS skeletons inferred from .rb sources (ADR-14)
+          lsp        Run the Rigor Language Server (LSP) over stdio
           version    Print the Rigor version
           help       Print this help
       HELP

data/lib/rigor/configuration.rb

@@ -49,6 +49,24 @@ module Rigor
       "disable" => [],
       "libraries" => [],
       "signature_paths" => nil,
+      # ADR-17 — project-side monkey-patch pre-evaluation.
+      # Empty by default; users opt in by listing explicit files
+      # that the analyzer walks before per-file inference so
+      # patched-method declarations are visible across the
+      # project (e.g. `lib/core_ext/string_extensions.rb`). Slice 1
+      # plumbing only — listed files are validated at config-load
+      # time (`pre-eval.file-not-found` on a missing path), but
+      # the dispatcher tier consuming the registry lands in
+      # slice 2.
+      "pre_eval" => [],
+      # ADR-22 — baseline file path. nil (default) means no
+      # baseline is loaded; the `false` literal is treated as
+      # the explicit-disable form for `.rigor.yml`-side override
+      # of an upstream `.rigor.dist.yml` `baseline:` declaration.
+      # The presence of `.rigor-baseline.yml` on disk alone does
+      # NOT activate filtering — the path must be named here
+      # (WD2 (b) of ADR-22).
+      "baseline" => nil,
       "fold_platform_specific_paths" => false,
       "cache" => {
         "path" => ".rigor/cache"
@@ -145,7 +163,7 @@ module Rigor
     # MUST be resolved relative to the config file's directory.
     # `exclude:` is intentionally NOT in this list — its entries
     # are glob patterns (`**/vendor/**`), not paths.
-    PATH_KEYS = %w[paths signature_paths].freeze
+    PATH_KEYS = %w[paths signature_paths pre_eval].freeze
     private_constant :PATH_KEYS
 
     attr_reader :target_ruby, :paths, :exclude_patterns, :plugins, :cache_path, :disabled_rules,
@@ -155,7 +173,8 @@ module Rigor
                 :severity_profile, :severity_overrides,
                 :dependencies, :parallel_workers,
                 :bundler_bundle_path, :bundler_auto_detect, :bundler_lockfile,
-                :rbs_collection_lockfile, :rbs_collection_auto_detect
+                :rbs_collection_lockfile, :rbs_collection_auto_detect,
+                :pre_eval, :baseline_path
 
     # Loads a configuration file.
     #
@@ -307,6 +326,10 @@ module Rigor
       @libraries = Array(data.fetch("libraries", DEFAULTS.fetch("libraries"))).map(&:to_s).freeze
       sig_paths = data.fetch("signature_paths", DEFAULTS.fetch("signature_paths"))
       @signature_paths = sig_paths.nil? ? nil : Array(sig_paths).map(&:to_s).freeze
+      @pre_eval = expand_pre_eval_entries(
+        Array(data.fetch("pre_eval", DEFAULTS.fetch("pre_eval"))).map(&:to_s)
+      )
+      @baseline_path = coerce_baseline_path(data.fetch("baseline", DEFAULTS.fetch("baseline")))
       @fold_platform_specific_paths = data.fetch(
         "fold_platform_specific_paths", DEFAULTS.fetch("fold_platform_specific_paths")
       ) == true
@@ -357,6 +380,7 @@ module Rigor
         "disable" => disabled_rules,
         "libraries" => libraries,
         "signature_paths" => signature_paths,
+        "pre_eval" => pre_eval,
         "fold_platform_specific_paths" => fold_platform_specific_paths,
         "cache" => {
           "path" => cache_path
@@ -386,6 +410,27 @@ module Rigor
 
     private
 
+    # ADR-17 slice 4 — `pre_eval:` glob expansion. Each entry is
+    # accepted as either a literal path (slice 1 contract) OR a
+    # `File.fnmatch?`-shaped glob pattern (`lib/core_ext/**/*.rb`).
+    # Glob meta characters (`*`, `?`, `[`) trigger `Dir.glob`
+    # expansion; the resulting file list is folded into the
+    # `pre_eval:` set with `uniq`. Literal entries that don't
+    # exist on disk continue to surface as `pre-eval.file-not-found`
+    # `:error` (slice 1 behaviour); glob entries that match
+    # nothing degrade silently to "no contribution from this
+    # entry" so a templated `**` pattern in a fresh project
+    # doesn't generate an error per match-less pattern.
+    def expand_pre_eval_entries(entries)
+      entries.flat_map do |entry|
+        glob_pattern?(entry) ? Dir.glob(entry, sort: true) : [entry]
+      end.uniq.freeze
+    end
+
+    def glob_pattern?(path)
+      path.include?("*") || path.include?("?") || path.include?("[")
+    end
+
     # Accepts either `"rigor-foo"` (gem-name shorthand) or
     # `{ "gem" => "rigor-foo", "id" => "foo", "config" => {...} }`
     # (full form). Returns the canonical hash form so the loader
@@ -452,6 +497,17 @@ module Rigor
       raise ArgumentError, "parallel.workers must be a non-negative Integer, got #{value.inspect} (#{e.message})"
     end
 
+    # ADR-22 WD2 (b) — `baseline: <path>` activates the file;
+    # `baseline: false` is the explicit-disable form (useful in
+    # `.rigor.yml` to override an upstream `.rigor.dist.yml`
+    # that names a baseline). `nil` (default / absent key) is
+    # also "no baseline".
+    def coerce_baseline_path(value)
+      return nil if value.nil? || value == false
+
+      value.to_s
+    end
+
     def coerce_network_policy(value)
       sym = value.to_sym
       unless VALID_NETWORK_POLICIES.include?(sym)

data/lib/rigor/environment/hkt_registry_holder.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+module Rigor
+  class Environment
+    # ADR-20 slice 2e — mutable single-slot memoization
+    # container for the per-Environment HKT registry. Held by
+    # {Environment} so the otherwise-frozen instance can
+    # still cache a computed value on first access.
+    #
+    # Concurrent {#fetch} calls from multiple threads against
+    # one Environment are NOT serialised here — the LSP
+    # single-publish-at-a-time discipline and the Ractor
+    # pool's per-worker Environment shape already prevent
+    # cross-thread races. If a future caller introduces a
+    # multi-threaded reader path against a shared
+    # Environment, the synchronisation belongs at that
+    # caller's seam, not here.
+    class HktRegistryHolder
+      def initialize
+        @loaded = false
+        @value = nil
+      end
+
+      def fetch
+        return @value if @loaded
+
+        @value = yield
+        @loaded = true
+        @value
+      end
+    end
+  end
+end

data/lib/rigor/environment/rbs_coverage_report.rb

@@ -42,7 +42,7 @@ module Rigor
       # enough that hard-coding is acceptable; a directory walk
       # at every call would add stat-cost to no benefit.)
       VENDORED_GEM_NAMES = Set[
-        "bcrypt", "idn-ruby", "mysql2", "nokogiri", "pg", "redis"
+        "bcrypt", "bundler", "cgi", "did_you_mean", "idn-ruby", "mysql2", "nokogiri", "pg", "prism", "redis", "rubygems"
       ].freeze
 
       # @param locked_gems [Hash{String => LockfileResolver::LockedGem}]

data/lib/rigor/environment/rbs_loader.rb

@@ -83,7 +83,7 @@ module Rigor
         VENDORED_GEM_SIGS_ROOT = File.expand_path(
           "../../../data/vendored_gem_sigs",
           __dir__
-        )
+        ).freeze
         private_constant :VENDORED_GEM_SIGS_ROOT
 
         def vendored_gem_sig_paths
@@ -118,7 +118,20 @@ module Rigor
         @libraries = libraries.map(&:to_s).freeze
         @signature_paths = signature_paths.map { |p| Pathname(p) }.freeze
         @cache_store = cache_store
-        @state = { env: nil, builder: nil }
+        # Per-loader memoization bucket. Held as a single
+        # mutable Hash so the loader instance itself can be
+        # `.freeze`d (per ADR-15 reflection-facade contract)
+        # without losing the lazy-memo behaviour. Slot names
+        # currently consulted: `:env`, `:env_loaded`,
+        # `:env_build_warned`, `:builder`, `:reflection`,
+        # `:instance_definitions_table`,
+        # `:singleton_definitions_table`. Constructed via
+        # `Hash.new` (NOT a `{ ... }` literal) so Rigor's
+        # `HashShape` narrowing doesn't infer a fixed key set
+        # from the initial state and fold post-initial slot
+        # reads (e.g. `@state[:env_loaded]`) to a constant
+        # `nil`.
+        @state = Hash.new # rubocop:disable Style/EmptyLiteral
         @instance_definition_cache = {}
         @singleton_definition_cache = {}
         @class_known_cache = {}
@@ -147,6 +160,28 @@ module Rigor
                                   end
       end
 
+      # Returns true when the named RBS declaration is a Module
+      # (`RBS::AST::Declarations::Module`) rather than a Class. The
+      # `user_class_fallback_receiver` tier consults this to route
+      # `Nominal[M].some_kernel_method` (where M is a module mixin
+      # like `PP::ObjectMixin`) through the `Nominal[Object]`
+      # fallback, because every concrete includer of M sees Kernel
+      # / Object instance methods as part of its own ancestor chain.
+      #
+      # Returns false for classes, for unknown names, and when the
+      # RBS environment failed to build (fail-soft).
+      def rbs_module?(name)
+        return false if env.nil?
+
+        rbs_name = parse_type_name(name)
+        return false if rbs_name.nil?
+
+        entry = env.class_decls[rbs_name]
+        entry.is_a?(::RBS::Environment::ModuleEntry)
+      rescue ::RBS::BaseError
+        false
+      end
+
       # Yields every known class / module / alias name (top-level
       # prefixed) currently loaded into the environment. The cache
       # producer that materialises the known-name set uses this so
@@ -165,6 +200,36 @@ module Rigor
         # v0.0.9 cache `Cache::Descriptor` regression did.
       end
 
+      # ADR-20 slice 2e — iterates over every `%a{...}`
+      # annotation attached to a class- or module-level
+      # declaration in the loaded RBS environment, yielding
+      # `(annotation_string, source_location)` pairs. Used by
+      # {Rigor::Inference::HktRegistry.scan_rbs_loader} to
+      # find `rigor:v1:hkt_register` / `rigor:v1:hkt_define`
+      # directives in user-authored overlays and merge them
+      # into the per-`Environment` HKT registry. Yields nothing
+      # when the env failed to build (fail-soft, same shape as
+      # {#each_known_class_name}).
+      def each_class_decl_annotation
+        return enum_for(:each_class_decl_annotation) unless block_given?
+        return if env.nil?
+
+        env.class_decls.each_value do |entry|
+          entry.each_decl do |decl|
+            next unless decl.respond_to?(:annotations)
+
+            decl.annotations.each { |a| yield a.string, a.location }
+          end
+        end
+      rescue ::RBS::BaseError, ::Ractor::IsolationError
+        # fail-soft: matches each_known_class_name's policy.
+        # Ractor::IsolationError surfaces when the scan is
+        # invoked from a non-main Ractor pool worker before
+        # ADR-15's full deep-freeze migration completes — the
+        # worker falls back to the base (builtins-only)
+        # registry rather than crashing.
+      end
+
       # Returns a frozen `Hash<String, String>` mapping each loaded
       # class / module name (top-level prefixed) to the file path of
       # its FIRST declaration's RBS source. Used by

data/lib/rigor/environment/reporters.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+
+module Rigor
+  class Environment
+    # Mutable container for the per-run analysis reporters
+    # ({Rigor::RbsExtended::Reporter} and
+    # {Rigor::Analysis::DependencySourceInference::BoundaryCrossReporter}).
+    # Held by {Environment} as a single attr; the reporters can be
+    # swapped through {Environment#attach_reporters!} so long-lived
+    # integrations (the LSP `ProjectContext`, future editor-mode
+    # daemons) can share one Environment across many `Runner.run`
+    # calls without each call's diagnostic events accumulating into
+    # a single reporter pair.
+    #
+    # Per-publish reset is the contract: at the start of every
+    # `Runner.run` in sequential mode, the runner stamps the
+    # environment's `Reporters` slot with the runner's own
+    # freshly-built reporter pair. Dispatchers / `RbsExtended`
+    # consumers continue to write through
+    # `environment.rbs_extended_reporter` /
+    # `environment.boundary_cross_reporter` — the lookup just hops
+    # through the `Reporters` slot rather than reading a frozen
+    # ivar.
+    #
+    # Construction default is `nil` on both slots so existing
+    # callers that don't care about reporters (project-default
+    # `Environment.default`, test scopes that don't drive
+    # dispatch) keep their current behaviour: reporter lookups
+    # return nil, and the consumer sites short-circuit on
+    # `reporter.nil?`.
+    class Reporters
+      attr_accessor :rbs_extended, :boundary_cross
+
+      def initialize(rbs_extended: nil, boundary_cross: nil)
+        @rbs_extended = rbs_extended
+        @boundary_cross = boundary_cross
+      end
+    end
+  end
+end