rigortype 0.1.19 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6e2fede9ea7407238b1f9c8f5784cc43f22724ee86decdf81f4a148c4ddff763
-  data.tar.gz: 57e9757b838f29185d9b936ddff586d372126540afe12cefb1e98dbc7e0a6109
+  metadata.gz: e5c87db4b1ce8d734a2c7f8d7f0b7af6a7d643612f011c08676a5bca123ae4cb
+  data.tar.gz: b9340fe30f78245443d61d82965e08f2833e4787b938886f8f42890981a88cff
 SHA512:
-  metadata.gz: 33b889562fefed7516dec175b7d85cc9f725ebcc7d94df30b5a58a436322709517a02bda2a0de10d746004c8c2d198aaa673f12577ddfe3ffeb37405508e1d9c
-  data.tar.gz: f5773b727c0fb718df1ab1163add87f0dd7e94913fefd0599e7465e5a40afbfa201b2b14a09eb524b2e98dc6e30bd84ab0424355802ded977386f5a706d84837
+  metadata.gz: 94cafd68574caa752869465bcbf8a8e646bf302f4c540f9eb3dee122b6d455c193a21dd2debbf2c481f1676fb4c83aca131a3ba73508fef65c3dd1f2a3debaaa
+  data.tar.gz: f762d58ad77bd3e819f346b6de84408769320d6025030737b3611ce918db4c5e7943e0371b9b0603c27c2be8b8d2064975ff1e2bb113b4e3af8443bb2723fd05

data/lib/rigor/analysis/check_rules/ivar_write_collector.rb

@@ -2,6 +2,8 @@
 
 require "prism"
 
+require_relative "../../source/constant_path"
+
 module Rigor
   module Analysis
     module CheckRules
@@ -80,7 +82,7 @@ module Rigor
 
           case node
           when Prism::ClassNode, Prism::ModuleNode
-            name = qualified_name_for(node.constant_path)
+            name = Source::ConstantPath.qualified_name(node.constant_path)
             if name
               walk(node.body, qualified_prefix + [name]) if node.body
               return
@@ -119,28 +121,6 @@ module Rigor
           @accumulator[class_name][node.name] ||= []
           @accumulator[class_name][node.name] << { node: node, type: rvalue_type }
         end
-
-        # Same shape resolution as `ScopeIndexer.qualified_name_for`
-        # (single-segment ConstantReadNode and dotted
-        # ConstantPathNode). Inlined here to keep the collector
-        # self-contained — the rule lives outside the indexer's
-        # private surface.
-        def qualified_name_for(constant_path_node)
-          case constant_path_node
-          when Prism::ConstantReadNode then constant_path_node.name.to_s
-          when Prism::ConstantPathNode then render_constant_path(constant_path_node)
-          end
-        end
-
-        def render_constant_path(node)
-          prefix =
-            case node.parent
-            when Prism::ConstantReadNode then "#{node.parent.name}::"
-            when Prism::ConstantPathNode then "#{render_constant_path(node.parent)}::"
-            else ""
-            end
-          "#{prefix}#{node.name}"
-        end
       end
     end
   end

data/lib/rigor/analysis/check_rules/rule_walk.rb

@@ -2,6 +2,8 @@
 
 require "prism"
 
+require_relative "../../source/constant_path"
+
 module Rigor
   module Analysis
     module CheckRules
@@ -183,29 +185,9 @@ module Rigor
           def extend_prefix(node, prefix)
             return prefix unless CLASS_OR_MODULE_NODE_CLASSES.any? { |klass| node.is_a?(klass) }
 
-            name = qualified_name_for(node.constant_path)
+            name = Source::ConstantPath.qualified_name(node.constant_path)
             name ? prefix + [name] : prefix
           end
-
-          # Same shape resolution as `IvarWriteCollector#qualified_name_for`
-          # and `ScopeIndexer.qualified_name_for` (single-segment
-          # ConstantReadNode and dotted ConstantPathNode).
-          def qualified_name_for(constant_path_node)
-            case constant_path_node
-            when Prism::ConstantReadNode then constant_path_node.name.to_s
-            when Prism::ConstantPathNode then render_constant_path(constant_path_node)
-            end
-          end
-
-          def render_constant_path(node)
-            prefix =
-              case node.parent
-              when Prism::ConstantReadNode then "#{node.parent.name}::"
-              when Prism::ConstantPathNode then "#{render_constant_path(node.parent)}::"
-              else ""
-              end
-            "#{prefix}#{node.name}"
-          end
         end
       end
     end

data/lib/rigor/analysis/check_rules/self_closedness_scanner.rb

@@ -2,6 +2,8 @@
 
 require "prism"
 
+require_relative "../../source/constant_path"
+
 module Rigor
   module Analysis
     module CheckRules
@@ -45,20 +47,27 @@ module Rigor
 
           case node
           when Prism::ModuleNode
-            name = constant_path_name(node.constant_path)
+            name = Source::ConstantPath.qualified_name_or_nil(node.constant_path)
             child_prefix = name ? prefix + [name] : prefix
             names << child_prefix.join("::") if name
             walk(node.body, child_prefix, names) if node.body
           when Prism::ClassNode
-            name = constant_path_name(node.constant_path)
+            name = Source::ConstantPath.qualified_name_or_nil(node.constant_path)
             child_prefix = name ? prefix + [name] : prefix
-            names << child_prefix.join("::") if name && dynamic_attr_class?(node)
+            names << child_prefix.join("::") if name && class_surface_open?(node)
             walk(node.body, child_prefix, names) if node.body
           else
             node.compact_child_nodes.each { |child| walk(child, prefix, names) }
           end
         end
 
+        # A class whose source-declared surface cannot be fully enumerated:
+        # a dynamic `attr_*` accessor, or a non-constant (dynamically produced)
+        # superclass.
+        def class_surface_open?(class_node)
+          dynamic_attr_class?(class_node) || dynamic_superclass?(class_node)
+        end
+
         # True when the class body directly invokes an `attr_*` macro with a
         # non-literal argument (a splat, a constant, a method call) — the
         # synthesized accessor names are then not statically knowable.
@@ -81,18 +90,18 @@ module Rigor
           args.any? { |arg| !arg.is_a?(Prism::SymbolNode) && !arg.is_a?(Prism::StringNode) }
         end
 
-        # Renders a class/module path node to its source-qualified name
-        # (`Foo`, `Foo::Bar`, leading `::` stripped); nil for a dynamic
-        # constant path the scanner cannot name statically.
-        def constant_path_name(node)
-          case node
-          when Prism::ConstantReadNode
-            node.name.to_s
-          when Prism::ConstantPathNode
-            parent = node.parent ? constant_path_name(node.parent) : nil
-            child = node.name.to_s
-            node.parent.nil? ? child : (parent && "#{parent}::#{child}")
-          end
+        # True when the class declares a superclass that is not a static
+        # constant — `class X < DelegateClass(Array)` / `< Struct.new(...)` /
+        # `< Data.define(...)`. The inherited surface is then a dynamically
+        # produced class the engine cannot enumerate from a constant name (the
+        # superclass is a method call, so `discovered_superclasses` never
+        # records it and the closed-class gate would wrongly treat the class as
+        # standalone), so a missed self-call is not provably a typo.
+        def dynamic_superclass?(class_node)
+          superclass = class_node.superclass
+          return false if superclass.nil?
+
+          !superclass.is_a?(Prism::ConstantReadNode) && !superclass.is_a?(Prism::ConstantPathNode)
         end
       end
     end