rigortype 0.1.11 → 0.1.12

data/plugins/rigor-rails-routes/lib/rigor/plugin/rails_routes.rb

@@ -4,6 +4,7 @@ require "rigor/plugin"
 
 require_relative "rails_routes/helper_table"
 require_relative "rails_routes/routes_parser"
+require_relative "rails_routes/helper_discoverer"
 require_relative "rails_routes/analyzer"
 
 module Rigor
@@ -52,32 +53,104 @@ module Rigor
     class RailsRoutes < Rigor::Plugin::Base
       manifest(
         id: "rails-routes",
-        version: "0.1.0",
+        # Bumped 2026-05-28 — GitLab FOSS sweep adds: (a)
+        # `draw_all :name` support (action_dispatch-draw_all
+        # gem; single-file load semantics matching `draw :name`);
+        # (b) keyword-style `scope(path: ':project_id',
+        # as: :project)` — path read from the `:path` keyword,
+        # not only from the positional first arg; (c) detection
+        # of iterative `direct(name.sub(FROM, TO)) do ... end`
+        # alias-generation idiom — generates `<TO>_*` aliases
+        # for every registered `<FROM>_*` helper. GitLab uses
+        # this to shorten `namespace_project_*` → `project_*`.
+        version: "0.27.0",
         description: "Validates Rails route-helper calls against `config/routes.rb`.",
         config_schema: {
-          "routes_file" => :string
+          "routes_file" => :string,
+          "helper_paths" => :array
         },
         produces: [:helper_table]
       )
 
       DEFAULT_ROUTES_FILE = "config/routes.rb"
 
+      # The directories `HelperDiscoverer` walks for project-
+      # defined `*_path` / `*_url` methods. Default to the whole
+      # `app/` tree — the suffix filter inside the discoverer
+      # keeps the registered set tight, and real-world Rails
+      # apps routinely keep URL builders under `app/controllers`
+      # (private `def page_url`, `def callback_url` shapes),
+      # `app/lib` (Mastodon's `TranslationService::DeepL#base_url`),
+      # `app/services` (`SoftwareUpdateCheckService#api_url`),
+      # `app/serializers`, `app/presenters`, `app/decorators`,
+      # not only `app/helpers/`. Walking the whole tree is the
+      # honest answer to "does this `_path` / `_url` name exist
+      # anywhere in the project?"; the cost is a one-time Prism
+      # parse per file at startup, which is bounded.
+      DEFAULT_HELPER_PATHS = ["app"].freeze
+
       # Cached producer — reads `config/routes.rb` through
       # the trusted `IoBoundary` and parses through
       # {RoutesParser}. The descriptor's auto-collected
       # `FileEntry` digest invalidates the cache on routes-
       # file edits.
+      #
+      # Passes a `file_reader` lambda so the parser can follow
+      # `draw(:admin)` → `config/routes/admin.rb` partials.
       producer :helper_table do |_params|
+        routes_dir = "#{File.dirname(@routes_file)}/routes"
+        file_reader = lambda do |name|
+          io_boundary.read_file("#{routes_dir}/#{name}")
+        rescue StandardError
+          nil
+        end
         contents = io_boundary.read_file(@routes_file)
-        RoutesParser.parse(contents)
+        custom_helpers = discover_custom_helpers
+        RoutesParser.parse(contents, file_reader: file_reader, custom_helpers: custom_helpers)
       end
 
       def init(_services)
         @routes_file = config.fetch("routes_file", DEFAULT_ROUTES_FILE)
+        @helper_paths = Array(config.fetch("helper_paths", DEFAULT_HELPER_PATHS)).map(&:to_s)
         @helper_table = nil
         @load_error = nil
       end
 
+      # Walks every configured `helper_paths:` directory
+      # through the trusted `IoBoundary` and returns the set
+      # of project-defined `*_path` / `*_url` method names
+      # for {HelperDiscoverer}. Each file digest is captured
+      # by the boundary so editing a helper file invalidates
+      # the `:helper_table` cache automatically. Returns the
+      # empty set when nothing under `helper_paths:` exists —
+      # the routes table still works.
+      def discover_custom_helpers
+        contents_per_path = {}
+        each_helper_file do |path|
+          contents_per_path[path] = io_boundary.read_file(path)
+        rescue Plugin::AccessDeniedError, Errno::ENOENT
+          next
+        end
+        HelperDiscoverer.discover(contents_per_path)
+      end
+
+      def pre_read_helper_files
+        each_helper_file do |path|
+          io_boundary.read_file(path)
+        rescue Plugin::AccessDeniedError, Errno::ENOENT
+          next
+        end
+      end
+
+      def each_helper_file(&)
+        @helper_paths.each do |dir|
+          absolute = File.expand_path(dir)
+          next unless File.directory?(absolute)
+
+          Dir.glob(File.join(absolute, "**", "*.rb")).each(&)
+        end
+      end
+
       # Publishes the parsed table to the cross-plugin fact
       # store so future Tier 2 plugins (rigor-actionpack
       # Phase 4) can read it via `services.fact_store.read`.
@@ -122,8 +195,12 @@ module Rigor
         # Read first so the IoBoundary's FileEntry digest
         # captures into the descriptor before `cache_for`
         # snapshots it (the same pattern documented in
-        # rigor-routes / rigor-activerecord).
+        # rigor-routes / rigor-activerecord). Helper files are
+        # pre-read for the same reason — editing a file under
+        # `app/helpers/` MUST invalidate the helper_table cache
+        # so the new custom-helper set is picked up.
         io_boundary.read_file(@routes_file)
+        pre_read_helper_files
         @helper_table = cache_for(:helper_table, params: {}).call
       rescue Plugin::AccessDeniedError => e
         @load_error = "rigor-rails-routes: #{e.message}"

data/sig/rigor/scope.rbs

@@ -18,8 +18,22 @@ module Rigor
     attr_reader discovered_method_visibilities: Hash[String, Hash[Symbol, Symbol]]
     attr_reader discovered_superclasses: Hash[String, String]
     attr_reader discovered_includes: Hash[String, Array[String]]
+    attr_reader indexed_narrowings: Hash[IndexedKey, Type::t]
+    attr_reader method_chain_narrowings: Hash[ChainKey, Type::t]
     attr_reader source_path: String?
 
+    class IndexedKey
+      attr_reader receiver_kind: Symbol
+      attr_reader receiver_name: Symbol
+      attr_reader key: untyped
+    end
+
+    class ChainKey
+      attr_reader receiver_kind: Symbol
+      attr_reader receiver_name: Symbol
+      attr_reader method_name: Symbol
+    end
+
     def self.empty: (?environment: Environment, ?source_path: String?) -> Scope
 
     def initialize: (environment: Environment, locals: Hash[Symbol, Type::t], ?fact_store: Analysis::FactStore, ?self_type: Type::t?, ?declared_types: Hash[untyped, Type::t], ?ivars: Hash[Symbol, Type::t], ?cvars: Hash[Symbol, Type::t], ?globals: Hash[Symbol, Type::t], ?source_path: String?) -> void
@@ -50,6 +64,14 @@ module Rigor
     def with_discovered_superclasses: (Hash[String, String] table) -> Scope
     def includes_of: (String | Symbol class_name) -> Array[String]
     def with_discovered_includes: (Hash[String, Array[String]] table) -> Scope
+    def indexed_narrowing: (Symbol receiver_kind, String | Symbol receiver_name, untyped key) -> Type::t?
+    def with_indexed_narrowing: (Symbol receiver_kind, String | Symbol receiver_name, untyped key, Type::t type) -> Scope
+    def without_indexed_narrowing: (Symbol receiver_kind, String | Symbol receiver_name, untyped key) -> Scope
+    def without_indexed_narrowings_for: (Symbol receiver_kind, String | Symbol receiver_name) -> Scope
+    def method_chain_narrowing: (Symbol receiver_kind, String | Symbol receiver_name, String | Symbol method_name) -> Type::t?
+    def with_method_chain_narrowing: (Symbol receiver_kind, String | Symbol receiver_name, String | Symbol method_name, Type::t type) -> Scope
+    def without_method_chain_narrowing: (Symbol receiver_kind, String | Symbol receiver_name, String | Symbol method_name) -> Scope
+    def without_method_chain_narrowings_for: (Symbol receiver_kind, String | Symbol receiver_name) -> Scope
     def with_fact: (Analysis::FactStore::Fact fact) -> Scope
     def with_self_type: (Type::t? type) -> Scope
     def with_declared_types: (Hash[untyped, Type::t] table) -> Scope

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rigortype
 version: !ruby/object:Gem::Version
-  version: 0.1.11
+  version: 0.1.12
 platform: ruby
 authors:
 - Rigor contributors
@@ -257,6 +257,7 @@ files:
 - lib/rigor/analysis/dependency_source_inference/return_type_heuristic.rb
 - lib/rigor/analysis/dependency_source_inference/walker.rb
 - lib/rigor/analysis/diagnostic.rb
+- lib/rigor/analysis/erb_template_detector.rb
 - lib/rigor/analysis/fact_store.rb
 - lib/rigor/analysis/project_scan.rb
 - lib/rigor/analysis/result.rb
@@ -290,6 +291,8 @@ files:
 - lib/rigor/cli/explain_command.rb
 - lib/rigor/cli/lsp_command.rb
 - lib/rigor/cli/mcp_command.rb
+- lib/rigor/cli/plugins_command.rb
+- lib/rigor/cli/plugins_renderer.rb
 - lib/rigor/cli/prism_colorizer.rb
 - lib/rigor/cli/sig_gen_command.rb
 - lib/rigor/cli/triage_command.rb
@@ -351,6 +354,7 @@ files:
 - lib/rigor/inference/hkt_body_parser.rb
 - lib/rigor/inference/hkt_reducer.rb
 - lib/rigor/inference/hkt_registry.rb
+- lib/rigor/inference/indexed_narrowing.rb
 - lib/rigor/inference/macro_block_self_type.rb
 - lib/rigor/inference/method_dispatcher.rb
 - lib/rigor/inference/method_dispatcher/block_folding.rb
@@ -373,6 +377,7 @@ files:
 - lib/rigor/inference/method_dispatcher/uri_folding.rb
 - lib/rigor/inference/method_parameter_binder.rb
 - lib/rigor/inference/multi_target_binder.rb
+- lib/rigor/inference/mutation_widening.rb
 - lib/rigor/inference/narrowing.rb
 - lib/rigor/inference/precision_scanner.rb
 - lib/rigor/inference/project_patched_methods.rb
@@ -555,6 +560,9 @@ files:
 - plugins/rigor-rails-routes/lib/rigor-rails-routes.rb
 - plugins/rigor-rails-routes/lib/rigor/plugin/rails_routes.rb
 - plugins/rigor-rails-routes/lib/rigor/plugin/rails_routes/analyzer.rb
+- plugins/rigor-rails-routes/lib/rigor/plugin/rails_routes/devise_routes.rb
+- plugins/rigor-rails-routes/lib/rigor/plugin/rails_routes/doorkeeper_routes.rb
+- plugins/rigor-rails-routes/lib/rigor/plugin/rails_routes/helper_discoverer.rb
 - plugins/rigor-rails-routes/lib/rigor/plugin/rails_routes/helper_table.rb
 - plugins/rigor-rails-routes/lib/rigor/plugin/rails_routes/routes_parser.rb
 - plugins/rigor-rails/lib/rigor-rails.rb