righter 0.0.1

data/test/righter_test.rb

@@ -0,0 +1,9 @@
+require 'test_helper'
+
+class RighterTest < ActiveSupport::TestCase
+  test 'truth' do
+    assert_kind_of Module, Righter
+    assert_kind_of Class, RighterError
+    assert_kind_of Class, RighterNoUserError
+  end
+end

data/test/test_helper.rb

@@ -0,0 +1,54 @@
+require 'codeclimate-test-reporter'
+require 'coveralls'
+
+CodeClimate::TestReporter.start
+
+Coveralls.wear!
+# Configure Rails Environment
+ENV['RAILS_ENV'] = 'test'
+
+require File.expand_path('../../test/dummy/config/environment.rb', __FILE__)
+ActiveRecord::Migrator.migrations_paths = [File.expand_path('../../test/dummy/db/migrate', __FILE__)]
+
+ActiveRecord::Migrator.migrate File.expand_path('../../db/migrate/', __FILE__)
+ActiveRecord::Migrator.migrate File.expand_path('../dummy/db/migrate/', __FILE__)
+
+require 'rails/test_help'
+require 'factory_girl_rails'
+
+FactoryGirl.definition_file_paths << File.join(File.dirname(__FILE__), 'factories')
+FactoryGirl.find_definitions
+# Filter out Minitest backtrace while allowing backtrace from other libraries
+# to be shown.
+
+Minitest.backtrace_filter = Minitest::BacktraceFilter.new
+
+# Load support files
+Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
+
+# Load fixtures from the engine
+if ActiveSupport::TestCase.respond_to?(:fixture_path=)
+  ActiveSupport::TestCase.fixture_path = File.expand_path('../fixtures', __FILE__)
+  ActionDispatch::IntegrationTest.fixture_path = ActiveSupport::TestCase.fixture_path
+  ActiveSupport::TestCase.fixtures :all
+end
+
+def sign_in(user)
+  User.current_user = user
+end
+
+def sign_out
+  User.current_user = nil
+end
+
+def count_queries(&block)
+  count = 0
+
+  counter_f = ->(_name, _started, _finished, _unique_id, payload) {
+    count += 1 unless payload[:name].in? %w( CACHE SCHEMA )
+  }
+
+  ActiveSupport::Notifications.subscribed(counter_f, 'sql.active_record', &block)
+
+  count
+end

data/test/unit/righter_for_resource_test.rb

@@ -0,0 +1,137 @@
+require 'test_helper'
+
+class RighterForResourceTest < ActiveSupport::TestCase
+  class TestNonARResource
+    include RighterForResource
+
+    def initialize(id)
+      @id = id
+    end
+
+    def righter_right_resource_id
+      @id
+    end
+  end
+
+  test 'methods are defined' do
+    instance = TestNonARResource.new(1)
+    door = Door.new
+
+    assert TestNonARResource.respond_to?(:create_righter_right)
+    assert TestNonARResource.respond_to?(:destroy_righter_right)
+    assert TestNonARResource.respond_to?(:righter_right)
+    assert !TestNonARResource.respond_to?(:auto_manage_righter_right)
+
+    assert instance.respond_to?(:create_righter_right)
+    assert instance.respond_to?(:destroy_righter_right)
+    assert instance.respond_to?(:righter_right)
+    assert !instance.respond_to?(:auto_manage_righter_right)
+
+    assert Door.respond_to?(:create_righter_right)
+    assert Door.respond_to?(:destroy_righter_right)
+    assert Door.respond_to?(:righter_right)
+    assert Door.respond_to?(:auto_manage_righter_right)
+
+    assert door.respond_to?(:create_righter_right)
+    assert door.respond_to?(:destroy_righter_right)
+    assert door.respond_to?(:righter_right)
+    assert !door.respond_to?(:auto_manage_righter_right)
+  end
+
+  test 'role creation with non AR object' do
+    role = FactoryGirl.create(:righter_role, name: 'admin')
+
+    assert_no_difference('RighterRight.count') do
+      TestNonARResource.new(1)
+    end
+
+    assert_difference('RighterRight.count', 1) do
+      assert_no_difference('RighterRightsRighterRole.count') do
+        right = TestNonARResource.new(1).create_righter_right :manage
+        assert_equal 'manage_RighterForResourceTest::TestNonARResource_1', right.name
+        assert_equal 'RighterForResourceTest::TestNonARResource', right.resource_class
+        assert_equal 1, right.resource_id
+      end
+    end
+
+    assert_difference('RighterRight.count', -1) do
+      TestNonARResource.new(1).destroy_righter_right :manage
+    end
+
+    assert_difference('RighterRight.count', 1) do
+      assert_difference('RighterRightsRighterRole.count', 1) do
+        assert_equal 0, role.reload.righter_rights.size
+        right = TestNonARResource.new(1).create_righter_right :manage, auto_associate_roles: [:admin]
+        assert_equal 1, role.reload.righter_rights.size
+      end
+    end
+
+    assert_difference('RighterRight.count', -1) do
+      assert_difference('RighterRightsRighterRole.count', -1) do
+        TestNonARResource.new(1).destroy_righter_right :manage
+      end
+    end
+  end
+
+  test 'role creation with automanaged AR object' do
+    admin_role = FactoryGirl.create(:righter_role, name: 'admin')
+    user_role  = FactoryGirl.create(:righter_role, name: 'user')
+
+    assert_no_difference('RighterRight.count') do
+      FactoryGirl.create(:player)
+    end
+
+    door = nil
+    assert_difference('RighterRight.count', 5) do
+      assert_difference('RighterRightsRighterRole.count', 3) do
+        assert RighterRight.where('name like ?', 'paint_Door_%').empty?
+        assert RighterRight.where('name like ?', 'change_Door_%').empty?
+        assert RighterRight.where('name like ?', 'open_Door_%').empty?
+        assert_equal 0, admin_role.righter_rights.count
+        assert_equal 0, user_role.righter_rights.count
+        door = FactoryGirl.create(:door)
+        assert RighterRight.find_by_name("paint_Door_#{door.id}").present?
+        assert RighterRight.find_by_name("change_Door_#{door.id}").present?
+        assert RighterRight.find_by_name("open_Door_#{door.id}").present?
+        puts admin_role.id
+        puts
+        RighterRightsRighterRole.all.each do |r|
+          puts r.inspect
+        end
+        # assert_equal 2, admin_role.righter_rights.size
+        assert_equal 1, user_role.righter_rights.size
+      end
+    end
+
+    assert_difference('RighterRight.count', -4) do
+      assert_difference('RighterRightsRighterRole.count', -3) do
+        door.destroy
+      end
+    end
+  end
+
+  test 'class methods do create class rights' do
+    r = Door.create_righter_right(:manage)
+    assert_equal 'manage_Door', r.name
+    assert_equal 'Door', r.resource_class
+    assert_nil r.resource_id
+
+    assert_equal r, Door.righter_right(:manage)
+  end
+
+  test '.auto_manage_righter_right accepts proc as parent right option' do
+    FactoryGirl.create(:righter_role, name: 'admin')
+    FactoryGirl.create(:righter_role, name: 'user')
+
+    house = FactoryGirl.create :house
+    door = FactoryGirl.create :door, house: house
+
+    assert house.righter_right(:build).present?
+    assert door.righter_right(:close).present?
+    assert_equal house.righter_right(:build), door.righter_right(:close).parent
+
+    door.destroy
+
+    refute door.righter_right(:close).present?
+  end
+end

data/test/unit/righter_right_test.rb

@@ -0,0 +1,74 @@
+require 'test_helper'
+
+class RighterRightTest < ActiveSupport::TestCase
+  fixtures :righter_rights
+
+  test 'add_access_to controller/actions raises error if actions is not array or controller is nil' do
+    r = righter_rights :kill
+    assert_raise RighterError do
+      r.add_access_to actions: :smth
+    end
+
+    assert_raise RighterError do
+      r.add_access_to actions: [:smth]
+    end
+
+    assert_raise RighterError do
+      r.add_access_to {}
+    end
+
+    assert_nothing_raised do
+      r.add_access_to controller: :james, actions: [:bond]
+      r2 = RighterRight.find_by_name :kill
+      assert_equal :james, r2.controller.to_sym
+      assert_equal [:bond], r2.actions
+    end
+  end
+
+  test 'hierarchical browsing is based in parent_id' do
+    r1 = RighterRight.create! name: '1'
+    r11 = RighterRight.create! name: '11', parent_id: r1.id
+    r12 = RighterRight.create! name: '12', parent_id: r1.id
+    r121 = RighterRight.create! name: '121', parent_id: r12.id
+
+    r2 = RighterRight.create! name: '2'
+
+    r3 = RighterRight.create! name: '3'
+    RighterRight.create! name: '31', parent_id: r3.id
+    r32 = RighterRight.create! name: '32', parent_id: r3.id
+    RighterRight.create! name: '321', parent_id: r32.id
+
+    assert_equal [], ([r12, r11] - r1.children)
+    assert_equal [], r11.children
+    assert_equal [r121], r12.children
+    assert_equal [], r121.children
+
+    assert_equal [], r2.children
+  end
+
+  test 'raise ActiveRecord::RecordInvalid on attempt to create cycle in hierarchy of righter rights' do
+    r1 = RighterRight.create! name: '1'
+    r2 = RighterRight.create! name: '2', parent_id: r1.id
+    r3 = RighterRight.create! name: '3', parent_id: r2.id
+
+    assert_raise ActiveRecord::RecordInvalid do
+      r1.parent_id = r3.id
+      r1.save!
+    end
+  end
+
+  test 'cached_find_by_name load the data only once' do
+    RighterRight.clear_cache
+    count_sql = count_queries do
+      RighterRight.cached_find_by_name :kill
+    end
+
+    assert 1, count_sql
+
+    count_no_sql = count_queries do
+      RighterRight.cached_find_by_name :kill
+    end
+
+    assert 0, count_no_sql
+  end
+end

data/test/unit/righter_role_test.rb

@@ -0,0 +1,197 @@
+require 'test_helper'
+
+class RighterRoleTest < ActiveSupport::TestCase
+  fixtures :righter_rights, :righter_roles
+
+  def setup
+    RighterRightsRighterRole.delete_all
+    RighterRoleGrant.delete_all
+  end
+
+  test 'add_right to role creates new entry in RighterRolesRighterRights table' do
+    r = righter_rights :kill
+    r1 = righter_roles :secret_agent
+    assert_difference 'r1.reload.righter_rights.size', 1 do
+      r1.add_right r
+    end
+
+    assert_no_difference 'r1.righter_rights.size' do
+      r1.add_right r
+    end
+  end
+
+  test 'add_self_and_children_rights to role creates according entries in RighterRolesRighterRights table' do
+    role = FactoryGirl.create :righter_role
+    r1 = FactoryGirl.create :righter_right, name: 'Parent right'
+    FactoryGirl.create :righter_right, name: 'Child right one', parent_id: r1.id
+    FactoryGirl.create :righter_right, name: 'Child right two', parent_id: r1.id
+
+    assert_difference 'role.reload.righter_rights.size', 3 do
+      role.add_self_and_child_rights r1
+    end
+  end
+
+  test 'remove_right removes association between role and right but keep the right itself' do
+    ro1 = righter_roles :secret_agent
+    r1 = righter_rights :kill
+
+    ro1.add_right r1
+    assert ro1.righter_rights.include?(r1)
+
+    ro1.remove_right r1
+    assert !ro1.reload.righter_rights.include?(r1)
+
+    assert r1.reload
+  end
+
+  test 'unique role name is enforced' do
+    ro1 = righter_roles :secret_agent
+    assert_raise ActiveRecord::RecordInvalid do
+      RighterRole.create! name: :secret_agent
+    end
+  end
+
+  test 'add_right and remove_right will raise error for bad input' do
+    ro1 = righter_roles :secret_agent
+    assert_raise RighterError do
+      ro1.add_right 'smth'
+    end
+    assert_raise RighterError do
+      ro1.remove_right 'smth2'
+    end
+  end
+
+  test 'right-role association is removed when right is deleted' do
+    ro1 = righter_roles :secret_agent
+    r1 = righter_rights :kill
+    assert !RighterRightsRighterRole.exists?(righter_role_id: ro1.id, righter_right_id: r1.id)
+
+    assert_difference 'RighterRightsRighterRole.count', 1 do
+      ro1.add_right r1
+    end
+    assert_difference 'RighterRightsRighterRole.count', -1 do
+      r1.destroy
+    end
+  end
+
+  test 'right-role association is removed when role is deleted' do
+    ro1 = righter_roles :secret_agent
+    r1 = righter_rights :kill
+    assert !RighterRightsRighterRole.exists?(righter_role_id: ro1.id, righter_right_id: r1.id)
+    ro1.add_right r1
+
+    assert_difference 'RighterRightsRighterRole.count', -1 do
+      ro1.destroy
+    end
+  end
+
+  test 'parent right is assigned automatically if any of children rights is assigned to role' do
+    r1 = RighterRight.create! name: '1'
+    r11 = RighterRight.create! name: '11', parent_id: r1.id
+
+    roleA = RighterRole.create! name: 'A', human_name: 'hmmm'
+    assert !roleA.righter_rights.include?(r1)
+    roleA.add_right r11
+    assert roleA.reload.righter_rights.include?(r1)
+  end
+
+  test 'all children rights are deassigned if parent right is deassigned from role' do
+    r1 = RighterRight.create! name: '1'
+    r11 = RighterRight.create! name: '11', parent_id: r1.id
+    r12 = RighterRight.create! name: '12', parent_id: r1.id
+    r121 = RighterRight.create! name: '121', parent_id: r12.id
+
+    roleA = RighterRole.create! name: 'A', human_name: 'b'
+    roleA.add_right r1
+    roleA.add_right r11
+    roleA.add_right r121
+
+    assert roleA.reload.righter_rights.include?(r1)
+    assert roleA.reload.righter_rights.include?(r11)
+    assert roleA.reload.righter_rights.include?(r121)
+
+    roleA.remove_right r1
+
+    assert !roleA.reload.righter_rights.include?(r1)
+    assert !roleA.reload.righter_rights.include?(r11)
+    assert !roleA.reload.righter_rights.include?(r121)
+  end
+
+  test 'righter_role.allow_to_grant_role will add only unique entry to RighterRoleGrant' do
+    r1 = righter_roles :one
+    r2 = righter_roles :two
+
+    assert_difference 'RighterRoleGrant.count', 1 do
+      r1.allow_to_grant_role r2
+    end
+    assert_no_difference 'RighterRoleGrant.count' do
+      r1.allow_to_grant_role r2
+    end
+    assert_difference 'RighterRoleGrant.count', -1 do
+      r1.destroy
+    end
+    assert_difference 'RighterRoleGrant.count', 4 do # FIXME: no difference shall be here
+      RighterRoleGrant.create(righter_role_id: r1.id, grantable_righter_role_id: r2.id)
+      RighterRoleGrant.create(righter_role_id: r1.id, grantable_righter_role_id: r2.id)
+      RighterRoleGrant.create(righter_role_id: r1.id, grantable_righter_role_id: r2.id)
+      RighterRoleGrant.create(righter_role_id: r1.id, grantable_righter_role_id: r2.id)
+    end
+  end
+
+  test 'righter_role.disallow_to_grant_role is silent when removing ungranted role' do
+    r1 = righter_roles :one
+    r2 = righter_roles :two
+
+    r1.allow_to_grant_role r2
+
+    assert_difference 'RighterRoleGrant.count', -1 do
+      r1.disallow_to_grant_role r2
+    end
+
+    assert_no_difference 'RighterRoleGrant.count', 0 do
+      r1.disallow_to_grant_role r2
+    end
+  end
+
+  test 'righter_role.grantable_roles reflects the state in RighterRoleGrant table' do
+    r1 = righter_roles :one
+    r2 = righter_roles :two
+    assert !r1.grantable_roles.include?(r2)
+    r1.allow_to_grant_role r2
+    assert r1.reload.grantable_roles.include?(r2)
+    r1.disallow_to_grant_role r2
+    assert !r1.grantable_roles.include?(r2)
+    assert !r1.reload.grantable_roles.include?(r2)
+  end
+
+  test 'disallow_all_granted_roles removes all granted roles associated to role' do
+    r1 = righter_roles :one
+    r2 = righter_roles :two
+    r1.allow_to_grant_role r2
+    assert r1.grantable_roles.include?(r2), 'grantable role added'
+    assert r1.reload.grantable_roles.include?(r2), 'grantable role added and saved'
+    r1.disallow_all_granted_roles
+    assert !r1.reload.grantable_roles.include?(r2), 'and it is saved'
+  end
+
+  test 'all associated entries in role_grants are deleted on role destroy' do
+    r1 = righter_roles :one
+    r2 = righter_roles :two
+    r3 = righter_roles :three
+    r1.allow_to_grant_role r2
+    r2.allow_to_grant_role r3
+
+    assert_difference 'RighterRoleGrant.count', -2 do
+      r2.destroy
+    end
+  end
+
+  test 'unique names' do
+    r1 = righter_roles :one
+    ri = righter_rights :kill
+
+    assert_difference 'RighterRightsRighterRole.count' do
+      r1.add_right ri
+    end
+  end
+end