right_support 2.9.4 → 2.9.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f8cb5d377a3622ac5ba6240f5fb6e3554596f664
-  data.tar.gz: 4c77349b228d4a892a956d5afcd4284ff4865bd9
+  metadata.gz: 4ac847f015800780b7756c78dc5fdd714758aa83
+  data.tar.gz: 3bdeecf991d8e3284406b0e921d1d0a78fabaccc
 SHA512:
-  metadata.gz: d32d8853b71c7579647a687237187925fe12e3e0942d51e827751b8adb24500e53107aa0ec5f7fc2fb28fbec6b2a91591ac0bacf5cd48d555edd179d3ddbf1d5
-  data.tar.gz: 917e614a451fa81bea1ae1203168650be8bd392cfe44082d28580bce1ed3eab6cdeeb4498bc9767b75466fda4413255766d385300941960260418b8127944b2b
+  metadata.gz: 88e1bcf8bddd85d7142e621a50db1cc4c1721cd67788ab156561ab1d85436287a832d578378d9fe7a82b4c2f1e4b9b49cdde786cad501eebb2c61ea9270749ae
+  data.tar.gz: e23752f713f25827b49b51a9981e79d5c1adb1cff40e441d86cde7b9177075960209bafbfcffed2472dfc9872dbd9a08db8d72708ef1a108008c06d3c7238c5d

data/VERSION

@@ -1 +1 @@
-2.9.4
+2.9.5

data/lib/right_support/log/syslog/remote.rb

@@ -93,6 +93,7 @@ module RightSupport::Log::Syslog
       attempts = 0
       begin
         @socket = opener.call
+        @socket.sync = true
       rescue => e
         # do not repeat backoff/retry when already in error mode.
         raise if @error_mode
@@ -151,57 +152,69 @@ module RightSupport::Log::Syslog
     end
 
     def log(facility, severity, message)
+      # Normally, use a mutex to ensure threadsafe logging
+      @mutex.synchronize do
+        log_without_thread_safety(facility, severity, message)
+      end
+      true
+    rescue ThreadError => e
+      # Sometimes the mutex can't be acquired (e.g. when servicing a trap);
+      #
+      log_without_thread_safety(facility, severity, message)
+      true
+    end
+
+    private
+
+    def log_without_thread_safety(facility, severity, message)
+      last_error = nil
+
       protocol_message = "<#{(facility & 0xf8) | (severity & 0x07)}> "\
         "#{::Time.now.strftime('%b %d %H:%M:%S')} " \
         "#{@hostname} " \
         "#{@identity}" \
         ": " \
         "#{message.gsub("\n", '#012')}\n"
-      @mutex.synchronize do
-        last_error = nil
-        begin
-          @socket.write(protocol_message)
-        rescue => e
-          if reconnect
-            begin
-              @socket.write(protocol_message)
-            rescue => e
-              last_error = e
-            end
-          else
+
+      begin
+        @socket.write(protocol_message)
+      rescue => e
+        if reconnect
+          begin
+            @socket.write(protocol_message)
+          rescue => e
             last_error = e
           end
+        else
+          last_error = e
         end
-        if last_error
-          # we are only here if reconnection attempts have timed out at least
-          # once. the timeout is skipped when we are already in error mode.
-          if @error_mode
-            # no need to repeat the warning or invoke callback for each
-            # failure to write.
-            ::STDERR.puts(protocol_message)
-          else
-            @error_mode = true
-            msg = <<EOF
+      end
+      if last_error
+        # we are only here if reconnection attempts have timed out at least
+        # once. the timeout is skipped when we are already in error mode.
+        if @error_mode
+          # no need to repeat the warning or invoke callback for each
+          # failure to write.
+          ::STDERR.puts(protocol_message)
+        else
+          @error_mode = true
+          msg = <<EOF
 WARNING: Failed writing to syslog: #{last_error.message}
-Dumping raw messages to stderr until rsyslog connection is restored.
+Dumping raw messages to stderr until syslog connection is restored.
 EOF
-            ::STDERR.puts(msg)
-            ::STDERR.puts(protocol_message)
+          ::STDERR.puts(msg)
+          ::STDERR.puts(protocol_message)
 
-            # the caller may want to gracefully shutdown, etc. graceful shutdown
-            # will trigger alerts whereas silently ignoring failure to write to
-            # syslog can lead to other problems.
-            @error_handler.call(last_error) if @error_handler
-          end
-        else
-          @error_mode = false
+          # the caller may want to gracefully shutdown, etc. graceful shutdown
+          # will trigger alerts whereas silently ignoring failure to write to
+          # syslog can lead to other problems.
+          @error_handler.call(last_error) if @error_handler
         end
+      else
+        @error_mode = false
       end
-      true
     end
 
-    private
-
     def reconnect
       connect
       true

data/right_support.gemspec

@@ -2,19 +2,20 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: right_support 2.9.4 ruby lib
+# stub: right_support 2.9.5 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "right_support"
-  s.version = "2.9.4"
+  s.version = "2.9.5"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
   s.authors = ["Tony Spataro", "Sergey Sergyenko", "Ryan Williamson", "Lee Kirchhoff", "Alexey Karpik", "Scott Messier"]
-  s.date = "2016-03-16"
+  s.date = "2016-03-21"
   s.description = "A toolkit of useful, reusable foundation code created by RightScale."
   s.email = "support@rightscale.com"
   s.extra_rdoc_files = [
+    "CHANGELOG.rdoc",
     "LICENSE",
     "README.md"
   ]
@@ -149,7 +150,7 @@ Gem::Specification.new do |s|
   ]
   s.homepage = "https://github.com/rightscale/right_support"
   s.licenses = ["MIT"]
-  s.rubygems_version = "2.5.1"
+  s.rubygems_version = "2.4.5"
   s.summary = "Reusable foundation code."
 
   if s.respond_to? :specification_version then

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: right_support
 version: !ruby/object:Gem::Version
-  version: 2.9.4
+  version: 2.9.5
 platform: ruby
 authors:
 - Tony Spataro
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-16 00:00:00.000000000 Z
+date: 2016-03-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -90,6 +90,7 @@ email: support@rightscale.com
 executables: []
 extensions: []
 extra_rdoc_files:
+- CHANGELOG.rdoc
 - LICENSE
 - README.md
 files:
@@ -240,7 +241,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Reusable foundation code.