right_support 2.9.1 → 2.9.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c00cbfd4e07ebbe5552f5ad98a567c61b66cc3f8
-  data.tar.gz: 10a8a64f785328beee4becbc12a9ccce43c42807
+  metadata.gz: e2215ed9e7706511edfcd6ea56abf45486749d9d
+  data.tar.gz: 15fac74e4fcb14b20b32f4de9a6087388bf3310b
 SHA512:
-  metadata.gz: fbf3db59b98e9b18274aceec2790a9513953e25128f33b264b7ab95966a16772d6529291913dbeeeb2a79964246b7e665fecc8702186531cf8b1ed787b5ce063
-  data.tar.gz: 3c56b3ffcba5b0425be7772a15c2680f2918d2a102dfd99b1d3259c5d4fe53ad847648eb2a7aaae245e5f6c741e6cd03b17b3c7ca38f38c556e9899f92ac4aef
+  metadata.gz: 0bae6ef9d208192d1a73104c5f1178895ea3b27b09cbc09f84f017d2849c0f66a8b2c81959c52a3d7f0988575b77be9cd2065b2a3ab4d770852da45c9229de29
+  data.tar.gz: 4de8efb3cfd6d0c76c16875749fb681a3909c6ee6f6bf5fb1d3f7399c02039bdccfa547ea2460cbf824bc26ba6a99be51288ac609c7e2177e5ffa37590a70eea

data/Gemfile.lock

@@ -93,7 +93,7 @@ GEM
     right_git (1.0.1)
       right_support (>= 2.8.10)
     right_http_connection (1.5.0)
-    right_support (2.8.32)
+    right_support (2.9.1)
     rspec (2.13.0)
       rspec-core (~> 2.13.0)
       rspec-expectations (~> 2.13.0)
@@ -148,3 +148,6 @@ DEPENDENCIES
   simple_uuid (~> 0.2)
   uuid (~> 2.3)
   uuidtools (~> 2.0)
+
+BUNDLED WITH
+   1.10.6

data/VERSION

@@ -1 +1 @@
-2.9.1
+2.9.2

data/lib/right_support/log/system_logger.rb

@@ -137,25 +137,26 @@ module RightSupport::Log
               end
             end
 
-            case @options[:connection]
-            when :local
-              @@syslog = ::Syslog.open(program_name, nil, facility)
-            else
-              require ::File.expand_path('../syslog/remote', __FILE__)
-              syslogger = ::RightSupport::Log::Syslog::Remote.new(
-                @options[:connection],
-                program_name,
-                facility,
-                :error_handler => @options[:error_handler])
-              syslogger.connect
-              @@syslog = syslogger
-            end
+            # connect
+            @@program_name = program_name
+            @@facility = facility
+            establish_connection
           end
-          @@program_name = program_name
         end
         @@syslog.info("Connected to syslog: #{@options[:connection].inspect}")
       end
 
+      # Reconnects using the established connection details. This is useful to
+      # ensure the rainbows child processes show their own PID, etc.
+      #
+      # @return [TrueClass] always true
+      def reconnect
+        @@mutex.synchronize do
+          establish_connection
+        end
+        true
+      end
+
       # Log a message if the given severity is high enough.  This is the generic
       # logging method.  Users will be more inclined to use #debug, #info, #warn,
       # #error, and #fatal.
@@ -217,6 +218,29 @@ module RightSupport::Log
 
       private
 
+      # (re)establishes connection and sets the class constant for logger.
+      def establish_connection
+        case @options[:connection]
+        when :local
+          if @@syslog
+            @@syslog.reopen(@@program_name, nil, @@facility)
+          else
+            @@syslog = ::Syslog.open(@@program_name, nil, @@facility)
+          end
+        else
+          require ::File.expand_path('../syslog/remote', __FILE__)
+          syslogger = ::RightSupport::Log::Syslog::Remote.new(
+            @options[:connection],
+            @@program_name,
+            @@facility,
+            :error_handler => @options[:error_handler])
+          syslogger.connect
+          @@syslog.close if @@syslog
+          @@syslog = syslogger
+        end
+        true
+      end
+
       # Call the syslog function to emit a syslog entry.
       #
       # === Parameters

data/right_support.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: right_support 2.9.1 ruby lib
+# stub: right_support 2.9.2 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "right_support"
-  s.version = "2.9.1"
+  s.version = "2.9.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
   s.authors = ["Tony Spataro", "Sergey Sergyenko", "Ryan Williamson", "Lee Kirchhoff", "Alexey Karpik", "Scott Messier"]
-  s.date = "2015-09-23"
+  s.date = "2015-10-09"
   s.description = "A toolkit of useful, reusable foundation code created by RightScale."
   s.email = "support@rightscale.com"
   s.extra_rdoc_files = [

data/spec/log/system_logger_spec.rb

@@ -139,6 +139,33 @@ describe 'RightSupport::Log::SystemLogger' do
       # example: "<134> Sep 23 13:45:42 ubuntu spec[3891]: Connected to syslog: \"tcp://localhost:2345\"\n"
       regex = /^<134> \w+ \d+ \d+:\d+:\d+ .+ spec\[\d+\]: Connected to syslog: \"tcp:\/\/localhost:2345\"$/
       data.chomp.should match(regex)
+
+      # attempt to reconnect to closed server.
+      server.close
+      server = nil
+      data = nil
+      ::Thread.start do
+        sleep 1  # should cause 1-2 reconnect error(s) to appear in STDERR
+        server = ::TCPServer.new(2345)
+        client = server.accept
+        data = client.readline
+        client.close
+        server.close
+        server = nil
+      end
+
+      # explicitly reconnect and send with delayed server restart. reconnection
+      # happens automagically (only for remote) but explicit reconnection will
+      # reestablish the PID, etc., which is useful for forking.
+      logger.reconnect
+      logger.debug("Hello syslog")
+      stop_time = ::Time.now + 3
+      while data.nil?
+        sleep(0.1)
+        fail 'Did not receive expected data' if ::Time.now >= stop_time
+      end
+      regex = /^<135> \w+ \d+ \d+:\d+:\d+ .+ spec\[\d+\]: Hello syslog$/
+      data.chomp.should match(regex)
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: right_support
 version: !ruby/object:Gem::Version
-  version: 2.9.1
+  version: 2.9.2
 platform: ruby
 authors:
 - Tony Spataro
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-23 00:00:00.000000000 Z
+date: 2015-10-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake