right_support 2.8.45 → 2.8.46

checksums.yaml

@@ -0,0 +1,15 @@
+---
+!binary "U0hBMQ==":
+  metadata.gz: !binary |-
+    YzdhYjdiNTQ4MDUxMGEzNGQxZTJiMjIxNWZiMjQ1MDBkN2U2MmM4Yw==
+  data.tar.gz: !binary |-
+    Njc1MTJlMzVjOTBmZmRkNTQxNTVlYWFiMmUyNDE3Nzc0ZWZkMDVmNg==
+SHA512:
+  metadata.gz: !binary |-
+    MmY2Y2RmNThkZTFlODRjYzExMDVlZmMzYzIwY2E1ZDg3MDBlYzg3YWZiNDMy
+    ZjlhNzA4ODg4ZGZlYjc0YTQ1NjA0ZjlkNDhhZTU0NGExNGNmZGViMzBjMTlj
+    MDkxMTEyZTUzYmUzZDRlNjE2NjU1YjcyMjcxYzVjYmI4ZjIxYjA=
+  data.tar.gz: !binary |-
+    ZDY0MDM0NjkwYzJmNjA5NDY1ZTA1NDgzNTZjZGEyZDRlYTNhZWQ0YTg1N2Fi
+    YWQ4ZDIwMzZiMzdlN2RlOTNlYTk4ZmYzZjJjNjY1NzZhNjZiNmRkZmQ1YjIw
+    ZmQzMDIwMGE5YmRiM2I0ZDU2OTY3ZWU1NGQxYjJmOTJkNjRjYjk=

data/VERSION

@@ -1 +1 @@
-2.8.45
+2.8.46

data/lib/right_support/log/filter_logger.rb

@@ -66,7 +66,7 @@ module RightSupport::Log
     #
     # See #info for more information.
     def debug(message = nil, &block)
-      severity, message = filter(DEBUG, message)
+      severity, message = filter(DEBUG, message_to_string(message))
       meth = SEVERITY_TO_METHOD[severity]
       raise ArgumentError, "Filter emitted unknown severity #{severity.inspect}" unless meth
       @actual_logger.__send__(meth, message, &block)
@@ -77,7 +77,7 @@ module RightSupport::Log
     #
     # See #info for more information.
     def info(message = nil, &block)
-      severity, message = filter(INFO, message)
+      severity, message = filter(INFO, message_to_string(message))
       meth = SEVERITY_TO_METHOD[severity]
       raise ArgumentError, "Filter emitted unknown severity #{severity.inspect}" unless meth
       @actual_logger.__send__(meth, message, &block)
@@ -88,7 +88,7 @@ module RightSupport::Log
     #
     # See #info for more information.
     def warn(message = nil, &block)
-      severity, message = filter(WARN, message)
+      severity, message = filter(WARN, message_to_string(message))
       meth = SEVERITY_TO_METHOD[severity]
       raise ArgumentError, "Filter emitted unknown severity #{severity.inspect}" unless meth
       @actual_logger.__send__(meth, message, &block)
@@ -99,7 +99,7 @@ module RightSupport::Log
     #
     # See #info for more information.
     def error(message = nil, &block)
-      severity, message = filter(ERROR, message)
+      severity, message = filter(ERROR, message_to_string(message))
       meth = SEVERITY_TO_METHOD[severity]
       raise ArgumentError, "Filter emitted unknown severity #{severity.inspect}" unless meth
       @actual_logger.__send__(meth, message, &block)
@@ -110,7 +110,7 @@ module RightSupport::Log
     #
     # See #info for more information.
     def fatal(message = nil, &block)
-      severity, message = filter(FATAL, message)
+      severity, message = filter(FATAL, message_to_string(message))
       meth = SEVERITY_TO_METHOD[severity]
       raise ArgumentError, "Filter emitted unknown severity #{severity.inspect}" unless meth
       @actual_logger.__send__(meth, message, &block)
@@ -143,7 +143,7 @@ module RightSupport::Log
         end
       end
 
-      severity, message = filter(severity, message)
+      severity, message = filter(severity, message_to_string(message))
       return @actual_logger.add(severity, message) if message
     end
 
@@ -189,12 +189,36 @@ module RightSupport::Log
     #
     # === Parameters
     # severity(Integer):: one of the severity constants defined by Logger
-    # messgae(String):: the log message
+    # message(String):: the log message
     #
     # === Return
     # Returns a pair consisting of the filtered [severity, message].
     def filter(severity, message)
       return [severity, message]
     end
+
+    private
+
+    # Convert a log message to a string. If this is a string, do nothing. If it
+    # is an Exception, format in the same way as Ruby's Logger object. If it is
+    # any other kind of object, call its `inspect` method. See:
+    # https://github.com/ruby/ruby/blob/trunk/lib/logger.rb#L516
+    #
+    # === Parameters
+    # message(String):: the object to be converted
+    #
+    # === Return
+    # The object converted to a string.
+    def message_to_string(message)
+      case message
+      when ::String
+        message
+      when ::Exception
+        "#{message.message} (#{message.class})\n" <<
+          (message.backtrace || []).join("\n")
+      else
+        message.inspect
+      end
+    end
   end
 end

data/right_support.gemspec

@@ -2,14 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
+# stub: right_support 2.8.46 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "right_support"
-  s.version = "2.8.45"
+  s.version = "2.8.46"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
+  s.require_paths = ["lib"]
   s.authors = ["Tony Spataro", "Sergey Sergyenko", "Ryan Williamson", "Lee Kirchhoff", "Alexey Karpik", "Scott Messier"]
-  s.date = "2015-04-15"
+  s.date = "2015-05-29"
   s.description = "A toolkit of useful, reusable foundation code created by RightScale."
   s.email = "support@rightscale.com"
   s.extra_rdoc_files = [
@@ -146,12 +148,11 @@ Gem::Specification.new do |s|
   ]
   s.homepage = "https://github.com/rightscale/right_support"
   s.licenses = ["MIT"]
-  s.require_paths = ["lib"]
-  s.rubygems_version = "1.8.23"
+  s.rubygems_version = "2.2.2"
   s.summary = "Reusable foundation code."
 
   if s.respond_to? :specification_version then
-    s.specification_version = 3
+    s.specification_version = 4
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
       s.add_development_dependency(%q<rake>, ["~> 10.0"])

data/spec/log/filter_logger_spec.rb

@@ -38,4 +38,29 @@ describe RightSupport::Log::FilterLogger do
     @logger.info("")
   end
 
+  context 'filtering log messages' do
+    let(:logger) { flexmock(@logger) }
+    let(:info) { RightSupport::Log::FilterLogger::INFO }
+
+    context 'when the log message is a string' do
+      it 'passes the filter method the string' do
+        logger.should_receive(:filter).with(info, 'foo').once.pass_thru
+        logger.info('foo')
+      end
+    end
+
+    context 'when the log message is an exception' do
+      it 'passes the filter method a string' do
+        logger.should_receive(:filter).with(info, String).once.pass_thru
+        logger.info(StandardError.new)
+      end
+    end
+
+    context 'when the log message is any other object' do
+      it 'passes the filter method a string' do
+        logger.should_receive(:filter).with(info, String).once.pass_thru
+        logger.info(Object.new)
+      end
+    end
+  end
 end

metadata

@@ -1,8 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: right_support
 version: !ruby/object:Gem::Version
-  version: 2.8.45
-  prerelease: 
+  version: 2.8.46
 platform: ruby
 authors:
 - Tony Spataro
@@ -14,12 +13,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-15 00:00:00.000000000 Z
+date: 2015-05-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -27,7 +25,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -35,7 +32,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: jeweler
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -43,7 +39,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -51,7 +46,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: ruby-debug
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -59,7 +53,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -67,7 +60,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -75,7 +67,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -83,7 +74,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -91,7 +81,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -233,29 +222,25 @@ files:
 homepage: https://github.com/rightscale/right_support
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -4527019187317914262
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.2.2
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Reusable foundation code.
 test_files: []