right_support 2.8.43 → 2.8.44

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    NGQzNzdhMjM4MmVhM2NmZWFkNjYwYzMxYjU3Y2U1NjllMTVhOTBkNA==
-  data.tar.gz: !binary |-
-    ZjZkZmExZWIzZDMzYmViY2RiMjY1N2YwZDdkMmMxNDVmM2Y0NjEyMA==
+SHA1:
+  metadata.gz: 1ccf49df438e59a3e68687d16f2d02c3d4c3b063
+  data.tar.gz: a1b49f1bbd8c6636b7486c3ed80ef59098d46143
 SHA512:
-  metadata.gz: !binary |-
-    YjY4MGJlMmVhNDdmMzFiNjA5OGI2NjZhZjNhY2ExNDJkYjE5NGE5YWZhZGFj
-    ZTllMzAxNDYxMjFiOWQ0N2JhMzVhYTZlNmY0ZmEwYWE0OWY4MDQ4ZDNhZWZk
-    OThkMTFhZTY1ZDAxOWQ3Yjg2NDMwNmRjOTUzNTg2MmViYTBlNzY=
-  data.tar.gz: !binary |-
-    MmJmNGRkZWQxYWU0NWNlNjE1Njc5OWY2MjYyZTBmNjYxZmJlMmNjMWM1ODAx
-    MGJjYjYwZWE5YWU2Mjg5NWI3ZTc0Y2QxMWYxZGRlMTAxYjkwZjFlZDY5OGRj
-    ZjQ1NDNhMDQ3Mjg1YmMxMDcxYzNiZjgzZjFkMDU0YTk1MTJiMDg=
+  metadata.gz: 619e4d070d39eb4b6c0ccfd1b1320414c91a3b761879e6fd42c0965aab2f57b4626f0af2832029664e7856fb52ba226ada85c2dd1016c2be32375fd109b657e1
+  data.tar.gz: d8eefa6e0c4b6b3240c26cd77e7000f1a5847f7cff5d629647bf4d60ad4160165f998f71ad74ad15186c6b36cdb6d1cb426f83cc5e69aba6b82056423990db69

data/VERSION

@@ -1 +1 @@
-2.8.43
+2.8.44

data/lib/right_support/rack/request_logger.rb

@@ -94,9 +94,20 @@ module RightSupport::Rack
     # @return [Boolean] enabled or not
     def logging_enabled?(logger, env)
       path = env["PATH_INFO"]
-      env["HTTP_X_DEBUG"] || [Logger::DEBUG, :debug].include?(logger.level) ||
-          @only.any? { |o| o.is_a?(Regexp) ? (path =~ o) : (path == o) } ||
-          @except.none? { |e| e.is_a?(Regexp) ? (path =~ e) : (path == e) }
+
+      # the request can always ask for debugging
+      if env["HTTP_X_DEBUG"]
+        true
+      # some apps have a blacklist of boring requests (e.g. health checks)
+      elsif @except.any? { |e| e.is_a?(Regexp) ? (path =~ e) : (path == e) }
+        false
+      # some apps have a whitelist of interesting requests
+      elsif @only.any? { |o| o.is_a?(Regexp) ? (path =~ o) : (path == o) }
+        true
+      # last chance: if whitelist is empty, then we log everything
+      else
+        @only.empty?
+      end
     end
 
     # Log beginning of request

data/right_support.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: right_support 2.8.40 ruby lib
+# stub: right_support 2.8.44 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "right_support"
-  s.version = "2.8.43"
+  s.version = "2.8.44"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
   s.authors = ["Tony Spataro", "Sergey Sergyenko", "Ryan Williamson", "Lee Kirchhoff", "Alexey Karpik", "Scott Messier"]
-  s.date = "2015-02-02"
+  s.date = "2015-04-02"
   s.description = "A toolkit of useful, reusable foundation code created by RightScale."
   s.email = "support@rightscale.com"
   s.extra_rdoc_files = [
@@ -175,3 +175,4 @@ Gem::Specification.new do |s|
     s.add_dependency(%q<pry-byebug>, [">= 0"])
   end
 end
+

data/spec/rack/request_logger_spec.rb

@@ -54,7 +54,7 @@ describe RightSupport::Rack::RequestLogger do
       end
     end
 
-    context 'when limit logging extent' do
+    context 'given limiting options' do
       before(:each) do
         @options = {:except => [/bar/]}
         @env.merge!('PATH_INFO' => '/foo/bar')
@@ -62,9 +62,9 @@ describe RightSupport::Rack::RequestLogger do
         @logger.should_receive(:level).and_return(Logger::INFO).by_default
       end
 
-      it 'does not limit if logger in debug mode' do
+      it 'limits if logger in debug mode' do
         @logger.should_receive(:level).and_return(Logger::DEBUG)
-        @logger.should_receive(:info).at_least.once
+        @logger.should_receive(:info).never
         @middleware.call(@env)
       end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: right_support
 version: !ruby/object:Gem::Version
-  version: 2.8.43
+  version: 2.8.44
 platform: ruby
 authors:
 - Tony Spataro
@@ -13,76 +13,76 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-02 00:00:00.000000000 Z
+date: 2015-04-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '10.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '10.0'
 - !ruby/object:Gem::Dependency
   name: jeweler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
 - !ruby/object:Gem::Dependency
   name: ruby-debug
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: A toolkit of useful, reusable foundation code created by RightScale.
@@ -93,10 +93,10 @@ extra_rdoc_files:
 - LICENSE
 - README.md
 files:
-- .coveralls.yml
-- .rspec
-- .simplecov
-- .travis.yml
+- ".coveralls.yml"
+- ".rspec"
+- ".simplecov"
+- ".travis.yml"
 - CHANGELOG.rdoc
 - Gemfile
 - Gemfile.lock
@@ -229,12 +229,12 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []