right_scraper 1.0.26 → 3.0.0

data/spec/repository_spec.rb

@@ -1,18 +1,18 @@
 #--
-# Copyright: Copyright (c) 2010 RightScale, Inc.
+# Copyright: Copyright (c) 2010-2011 RightScale, Inc.
 #
 # Permission is hereby granted, free of charge, to any person obtaining
 # a copy of this software and associated documentation files (the
 # 'Software'), to deal in the Software without restriction, including
 # without limitation the rights to use, copy, modify, merge, publish,
-# distribute, sublicense, and/or sell copies of the Software, and to 
+# distribute, sublicense, and/or sell copies of the Software, and to
 # permit persons to whom the Software is furnished to do so, subject to
 # the following conditions:
 #
 # The above copyright notice and this permission notice shall be
 # included in all copies or substantial portions of the Software.
 #
-# THE SOFTWARE IS PROVIDED 'AS IS', WITHOUT WARRANTY OF ANY KIND, 
+# THE SOFTWARE IS PROVIDED 'AS IS', WITHOUT WARRANTY OF ANY KIND,
 # EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
 # MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
 # IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
@@ -21,25 +21,91 @@
 # SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 #++
 
-require File.join(File.dirname(__FILE__), 'spec_helper')
-require 'repository'
-
-describe RightScale::Repository do
-
-  it 'should be initializable from a hash' do
-    repo = RightScale::Repository.from_hash(:display_name      => 'display_name',
-                                            :repo_type         => 'repo_type',
-                                            :url               => 'url',
-                                            :tag               => 'tag',
-                                            :first_credential  => 'first_credential',
-                                            :second_credential => 'second_credential')
-    repo.should be_kind_of(RightScale::Repository)
-    repo.display_name.should      == 'display_name'
-    repo.repo_type.should         == 'repo_type'
-    repo.url.should               == 'url'
-    repo.tag.should               == 'tag'
-    repo.first_credential.should  == 'first_credential'
-    repo.second_credential.should == 'second_credential'
+require File.expand_path(File.join(File.dirname(__FILE__), 'spec_helper'))
+require File.expand_path(File.join(File.dirname(__FILE__), '..', 'lib', 'right_scraper', 'repositories', 'mock'))
+
+describe RightScraper::Repositories::Base do
+  include RightScraper::SpecHelpers::DevelopmentModeEnvironment
+
+  context 'with a repository type that doesn\'t exist' do
+    it 'should throw a comprehensible error when you try to create it' do
+      lambda {
+        RightScraper::Repositories::Base.from_hash(:display_name      => 'display_name',
+                                           :repo_type         => :nonexistent,
+                                           :url               => 'url',
+                                           :tag               => 'tag',
+                                           :first_credential  => 'first_credential',
+                                           :second_credential => 'second_credential')
+      }.should raise_error(/Can't understand how to make nonexistent repos/)
+    end
+  end
+
+  context 'with a mock repository' do
+    before(:each) do
+      @repo = RightScraper::Repositories::Base.from_hash(:display_name      => 'display_name',
+                                                 :repo_type         => :mock,
+                                                 :url               => 'url',
+                                                 :tag               => 'tag',
+                                                 :first_credential  => 'first_credential',
+                                                 :second_credential => 'second_credential')
+    end
+
+    it 'should be initializable from a hash' do
+      @repo.should be_kind_of(RightScraper::Repositories::Base)
+      @repo.display_name.should      == 'display_name'
+      @repo.repo_type.should         == :mock
+      @repo.url.should               == 'url'
+      @repo.tag.should               == 'tag'
+      @repo.first_credential.should  == 'first_credential'
+      @repo.second_credential.should == 'second_credential'
+    end
+
+    it 'should know the SHA-1 of its root location' do
+      @repo.repository_hash.should ==
+        Digest::SHA1.hexdigest("1\000mock\000url")
+    end
+
+    it 'should know the SHA-1 of the identifier for this specific checkout' do
+      @repo.checkout_hash.should ==
+        Digest::SHA1.hexdigest("1\000mock\000url")
+    end
+  end
+end
+
+describe RightScraper::Repositories::Download do
+  include RightScraper::SpecHelpers::DevelopmentModeEnvironment
+
+  before(:each) do
+    @repo = RightScraper::Repositories::Base.from_hash(:display_name => 'test repo',
+                                               :repo_type => :download,
+                                               :url => "http://foo.bar.baz.quux/%20CBLAH",
+                                               :tag => "412530982323",
+                                               :first_credential => "foo:b/ar",
+                                               :second_credential => "foo@bar")
+  end
+
+  it 'should have a tag' do
+    @repo.tag.should == '412530982323'
+  end
+
+  it 'should include the tag in the checkout hash' do
+    @repo.checkout_hash.should_not == @repo.repository_hash
+    oldhash = @repo.checkout_hash
+    @repo.tag = "42398"
+    @repo.checkout_hash.should_not == oldhash
+  end
+
+  it 'should have the same repository hash with or without credentials' do
+    initial_hash = @repo.repository_hash
+    @repo.first_credential = nil
+    @repo.second_credential = nil
+    @repo.repository_hash.should == initial_hash
+  end
+
+  it 'should have the same checkout hash with or without credentials' do
+    initial_hash = @repo.checkout_hash
+    @repo.first_credential = nil
+    @repo.second_credential = nil
+    @repo.checkout_hash.should == initial_hash
   end
-    
 end

data/spec/{scraper_spec_helper_base.rb → retriever_spec_helper.rb}

@@ -1,5 +1,5 @@
 #--
-# Copyright: Copyright (c) 2010 RightScale, Inc.
+# Copyright: Copyright (c) 2010-2011 RightScale, Inc.
 #
 # Permission is hereby granted, free of charge, to any person obtaining
 # a copy of this software and associated documentation files (the
@@ -21,33 +21,67 @@
 # SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 #++
 
+require 'digest/sha1'
 require File.expand_path(File.join(File.dirname(__FILE__), 'spec_helper'))
+require 'tmpdir'
 
-module RightScale
+module RightScraper
 
   # Base class for all scrapers spec helpers
   # Define helper methods used to manage repositories using each
   # source control software
-  class ScraperSpecHelperBase
+  class RetrieverSpecHelper
 
     include SpecHelpers
 
+    def initialize
+      @tmpdir = Dir.mktmpdir
+      FileUtils.mkdir(repo_path)
+      @repo_content = [ { 'folder1' => [ 'file2', 'file3' ] },
+                        { 'folder2' => [ { 'folder3' => [ 'file4' ] } ] },
+                        'file1' ]
+    end
+
+    def close
+      FileUtils.remove_entry_secure @tmpdir
+    end
+
     # Path to test repository
     #
     # === Return
     # repo_path(String):: Path to test repository
     def repo_path
-      repo_path = File.join(File.dirname(__FILE__), '__repo')
+      File.join(@tmpdir, "repository")
     end
 
     # Default test repo content
     #
     # === Return
     # content(String):: Default test repo content
-    def repo_content
-      content = [ { 'folder1' => [ 'file2', 'file3' ] }, { 'folder2' => [ { 'folder3' => [ 'file4' ] } ] }, 'file1' ]
+    attr_reader :repo_content
+
+    def manifest
+      hash = {}
+      scan(@repo_content, hash, nil)
+      hash['metadata.json'] = Digest::SHA1.hexdigest(@repo_content.to_json + "\n")
+      hash
     end
 
+    def scan(contents, hash, position)
+      contents.each do |object|
+        if object.instance_of?(Hash)
+          object.each do |key, value|
+            relative_position = position ? File.join(position, key) : key
+            scan(value, hash, relative_position)
+          end
+        else
+          relative_position = position ? File.join(position, object) : object
+          hash[relative_position] = Digest::SHA1.hexdigest(object + "\n")
+        end
+      end
+    end
+    private :scan
+
     # Test branch content
     #
     # === Return
@@ -64,26 +98,6 @@ module RightScale
       content = [ { 'additional_folder' => [ 'afile1', 'afile2' ] }, 'afile3' ]
     end
 
-    # Create test repository following given layout
-    # Delete any previously created repo
-    #
-    # === Return
-    # repo_path(String):: Path to created repositoy
-    #
-    # === Raise
-    # Exception:: If repository initialization fails
-    def setup_test_repo
-      raise 'Not supported'
-    end
-
-    # Delete test repository
-    #
-    # === Return
-    # true:: Always return true
-    def delete_test_repo
-      FileUtils.rm_rf(repo_path)
-    end
-
     # Commit any non-commited changes of given directory
     #
     # === Parameters
@@ -129,4 +143,4 @@ module RightScale
       raise 'Not implemented'
     end
   end
-end
+end

data/spec/scanner_spec.rb

@@ -0,0 +1,61 @@
+#--
+# Copyright: Copyright (c) 2010-2011 RightScale, Inc.
+#
+# Permission is hereby granted, free of charge, to any person obtaining
+# a copy of this software and associated documentation files (the
+# 'Software'), to deal in the Software without restriction, including
+# without limitation the rights to use, copy, modify, merge, publish,
+# distribute, sublicense, and/or sell copies of the Software, and to
+# permit persons to whom the Software is furnished to do so, subject to
+# the following conditions:
+#
+# The above copyright notice and this permission notice shall be
+# included in all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED 'AS IS', WITHOUT WARRANTY OF ANY KIND,
+# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
+# IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
+# CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
+# TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
+# SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+#++
+
+require File.expand_path(File.join(File.dirname(__FILE__), 'spec_helper'))
+require File.expand_path(File.join(File.dirname(__FILE__), 'download', 'download_retriever_spec_helper'))
+
+describe RightScraper::Scanners::Base do
+  include RightScraper::SpecHelpers::DevelopmentModeEnvironment
+
+  before(:each) do
+    @helper = RightScraper::DownloadRetrieverSpecHelper.new
+    @repo = @helper.repo
+  end
+
+  after(:each) do
+    @helper.close
+  end
+
+  it 'should be called correctly' do
+    scanner = flexmock("scanner")
+    scanner.should_receive(:new).with(Hash).once.and_return(scanner)
+    scanner.should_receive(:begin).with(RightScraper::Resources::Cookbook).once
+    scanner.should_receive(:notice_dir).with(nil).once.and_return(true)
+    scanner.should_receive(:notice).with("file1", Proc).once
+    scanner.should_receive(:notice_dir).with("folder1").once.and_return(true)
+    scanner.should_receive(:notice).with("folder1/file2", Proc).once
+    scanner.should_receive(:notice).with("folder1/file3", Proc).once
+    scanner.should_receive(:notice_dir).with("folder2").once.and_return(false)
+    scanner.should_receive(:notice).with("metadata.json", Proc).once
+    scanner.should_receive(:end).with(RightScraper::Resources::Cookbook).once
+    scanner.should_receive(:finish).with().once
+
+    @scraper = RightScraper::Scrapers::Base.scraper(:repo_dir   => @helper.download_repo_path,
+                                                    :kind       => :cookbook,
+                                                    :scanners   => [scanner],
+                                                    :repository => @repo)
+    @scraper.next_resource.should_not be_nil
+    @scraper.next_resource.should be_nil
+    @scraper.close
+  end
+end

data/spec/scraper_helper.rb

@@ -0,0 +1,96 @@
+#--
+# Copyright: Copyright (c) 2010-2011 RightScale, Inc.
+#
+# Permission is hereby granted, free of charge, to any person obtaining
+# a copy of this software and associated documentation files (the
+# 'Software'), to deal in the Software without restriction, including
+# without limitation the rights to use, copy, modify, merge, publish,
+# distribute, sublicense, and/or sell copies of the Software, and to
+# permit persons to whom the Software is furnished to do so, subject to
+# the following conditions:
+#
+# The above copyright notice and this permission notice shall be
+# included in all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED 'AS IS', WITHOUT WARRANTY OF ANY KIND,
+# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
+# IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
+# CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
+# TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
+# SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+#++
+
+require File.expand_path(File.join(File.dirname(__FILE__), 'spec_helper'))
+require 'tmpdir'
+
+module RightScraper
+  module SpecHelpers
+    module FromScratchScraping
+      def FromScratchScraping.included(mod)
+        mod.module_eval do
+          before(:each) do
+            @basedir = Dir.mktmpdir
+            @retriever = @retriever_class.new(@repo,
+                                         :basedir => @basedir,
+                                         :max_bytes => 1024**2,
+                                         :max_seconds => 20)
+            @retriever.retrieve
+          end
+
+          after(:each) do
+            FileUtils.remove_entry_secure(@basedir)
+            @scraper = nil
+          end
+        end
+      end
+    end
+
+    module CookbookScraping
+      def CookbookScraping.included(mod)
+        mod.module_eval do
+          before(:each) do
+            @scraper = RightScraper::Scrapers::Base.scraper(:repo_dir        => @retriever.repo_dir,
+                                                            :kind            => :cookbook,
+                                                            :repository      => @retriever.repository,
+                                                            :ignorable_paths => @retriever.ignorable_paths)
+          end
+        end
+      end
+    end
+
+    module WorkflowScraping
+      def WorkflowScraping.included(mod)
+        mod.module_eval do
+          before(:each) do
+            @scraper = RightScraper::Scrapers::Base.scraper(:repo_dir        => @retriever.repo_dir,
+                                                            :kind            => :workflow,
+                                                            :repository      => @retriever.repository,
+                                                            :ignorable_paths => @retriever.ignorable_paths)
+          end
+        end
+      end
+    end
+
+  end
+  module ScraperHelper
+    def archive_skeleton(archive)
+      files = Set.new
+      Archive.read_open_memory(archive) do |ar|
+        while entry = ar.next_header
+          files << [entry.pathname, ar.read_data]
+        end
+      end
+      files
+    end
+
+    def check_resource(resource, params={})
+      position = params[:position] || "."
+      resource.should_not == nil
+      resource.repository.should be_an_equal_repo @repo
+      resource.pos.should == position
+      resource.metadata.should == (params[:metadata] || @helper.repo_content)
+      resource.manifest.should == (params[:manifest] || @helper.manifest)
+    end
+  end
+end

data/spec/scraper_spec.rb

@@ -1,18 +1,18 @@
 #--
-# Copyright: Copyright (c) 2010 RightScale, Inc.
+# Copyright: Copyright (c) 2010-2011 RightScale, Inc.
 #
 # Permission is hereby granted, free of charge, to any person obtaining
 # a copy of this software and associated documentation files (the
 # 'Software'), to deal in the Software without restriction, including
 # without limitation the rights to use, copy, modify, merge, publish,
-# distribute, sublicense, and/or sell copies of the Software, and to 
+# distribute, sublicense, and/or sell copies of the Software, and to
 # permit persons to whom the Software is furnished to do so, subject to
 # the following conditions:
 #
 # The above copyright notice and this permission notice shall be
 # included in all copies or substantial portions of the Software.
 #
-# THE SOFTWARE IS PROVIDED 'AS IS', WITHOUT WARRANTY OF ANY KIND, 
+# THE SOFTWARE IS PROVIDED 'AS IS', WITHOUT WARRANTY OF ANY KIND,
 # EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
 # MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
 # IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
@@ -21,49 +21,127 @@
 # SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 #++
 
-require File.join(File.dirname(__FILE__), 'spec_helper')
-require File.join(File.dirname(__FILE__), '..', 'lib', 'right_scraper', 'scraper_base')
-require File.join(File.dirname(__FILE__), '..', 'lib', 'right_scraper', 'scrapers', 'git_scraper')
-require File.join(File.dirname(__FILE__), '..', 'lib', 'right_scraper', 'scrapers', 'svn_scraper')
-require File.join(File.dirname(__FILE__), '..', 'lib', 'right_scraper', 'scrapers', 'download_scraper')
-require File.join(File.dirname(__FILE__), '..', 'lib', 'right_scraper', 'repository')
-require File.join(File.dirname(__FILE__), '..', 'lib', 'right_scraper', 'scraper')
-
-describe RightScale::Scraper do
-
-  before(:each) do
-    @scraper = RightScale::Scraper.new('/tmp')
-    @mock_scraper = flexmock('MockScraper')
-    mock_scraper_klass = flexmock('MockScraperClass', :new => @mock_scraper)
-    RightScale::SCRAPERS.merge!('mock' => mock_scraper_klass)
-  end
-  
-  after(:all) do
-    RightScale::SCRAPERS.delete('mock')
-  end
-  
-  it 'should scrape' do
-    repo = RightScale::Repository.new
-    repo.repo_type = :mock
-    @mock_scraper.should_receive(:scrape).with(repo, true, Proc).and_return(true)
-    @mock_scraper.should_receive(:succeeded?).and_return(true)
-    @mock_scraper.should_receive(:current_repo_dir).and_return('42')
-    @scraper.scrape(repo) { }.should be_true
-    @scraper.last_repo_dir.should == '42'
+require File.expand_path(File.join(File.dirname(__FILE__), 'spec_helper'))
+require File.expand_path(File.join(File.dirname(__FILE__), 'download', 'download_retriever_spec_helper'))
+require 'tmpdir'
+require 'flexmock'
+
+describe RightScraper::Scraper do
+  include RightScraper::SpecHelpers::DevelopmentModeEnvironment
+
+  include RightScraper::SharedExamples
+
+  shared_examples_for 'scrapes to given base dir' do
+    before(:each) do
+      @scraper = RightScraper::Scraper.new(:basedir => @tmpdir, :kind => :cookbook)
+    end
+
+    after(:each) do
+      FileUtils.remove_entry_secure @tmpdir unless @tmpdir.nil?
+    end
+
+    it 'starts out successful' do
+      @scraper.succeeded?.should be_true
+      @scraper.errors.should == []
+    end
+
+    context 'given a legal download repository' do
+      before(:each) do
+        @helper = RightScraper::DownloadRetrieverSpecHelper.new
+        @repo = @helper.repo
+      end
+
+      after(:each) do
+        @helper.close
+      end
+
+      it_should_behave_like "a normal repository"
+
+      it 'should log correctly as it scrapes' do
+        callback = flexmock("callback")
+        callback.should_receive(:call).with(:begin, :retrieving, "from #{@repo}", nil).once.ordered
+        callback.should_receive(:call).with(:begin, :initialize, String, nil).once.ordered
+        callback.should_receive(:call).with(:commit, :initialize, String, nil).once.ordered
+        callback.should_receive(:call).with(:begin, :downloading, "", nil).once.ordered
+        callback.should_receive(:call).with(:begin, :running_command, String, nil).once.ordered
+        callback.should_receive(:call).with(:commit, :running_command, String, nil).once.ordered
+        callback.should_receive(:call).with(:commit, :downloading, "", nil).once.ordered
+        callback.should_receive(:call).with(:begin, :unpacking, "", nil).once.ordered
+        callback.should_receive(:call).with(:begin, :running_command, String, nil).once.ordered
+        callback.should_receive(:call).with(:commit, :running_command, String, nil).once.ordered
+        callback.should_receive(:call).with(:commit, :unpacking, "", nil).once.ordered
+        callback.should_receive(:call).with(:commit, :retrieving, "from #{@repo}", nil).once.ordered
+        callback.should_receive(:call).with(:begin, :scraping, String, nil).once.ordered
+        callback.should_receive(:call).with(:begin, :finding_next_cookbook, String, nil).once.ordered
+        callback.should_receive(:call).with(:begin, :reading_cookbook, String, nil).once.ordered
+        callback.should_receive(:call).with(:begin, :scanning_filesystem, String, nil).once.ordered
+        callback.should_receive(:call).with(:begin, :metadata_parsing, "", nil).once.ordered
+        callback.should_receive(:call).with(:commit, :metadata_parsing, "", nil).once.ordered
+        callback.should_receive(:call).with(:commit, :scanning_filesystem, String, nil).once.ordered
+        callback.should_receive(:call).with(:commit, :reading_cookbook, String, nil).once.ordered
+        callback.should_receive(:call).with(:commit, :finding_next_cookbook, String, nil).once.ordered
+        callback.should_receive(:call).with(:begin, :next, "", nil).once.ordered
+        callback.should_receive(:call).with(:begin, :searching, "", nil).once.ordered
+        callback.should_receive(:call).with(:commit, :searching, "", nil).once.ordered
+        callback.should_receive(:call).with(:commit, :next, "", nil).once.ordered
+        callback.should_receive(:call).with(:begin, :next, "", nil).once.ordered
+        callback.should_receive(:call).with(:commit, :next, "", nil).once.ordered
+        callback.should_receive(:call).with(:commit, :scraping, String, nil).once.ordered
+        @scraper.scrape(@repo) do |phase, operation, explanation, exception|
+          callback.call(phase, operation, explanation, exception)
+        end
+        @scraper.errors.should == []
+        @scraper.succeeded?.should be_true
+        @scraper.resources.size.should == 1
+      end
+    end
+
+    context 'given several repositories' do
+      it 'should continue to scrape even if errors occur' do
+        GC.start
+        repo = RightScraper::Repositories::Base.from_hash(:display_name => 'illegal repo',
+                                                          :repo_type    => :download,
+                                                          :url          => "http://example.com/foo")
+        @scraper.scrape(repo)
+        helpers = [RightScraper::DownloadRetrieverSpecHelper,
+                   RightScraper::DownloadRetrieverSpecHelper,
+                   RightScraper::DownloadRetrieverSpecHelper]
+        helpers.each do |klass|
+          helper = klass.new
+          @scraper.scrape(helper.repo)
+          helper.close
+        end
+        @scraper.succeeded?.should be_false
+        @scraper.resources.size.should == 3
+        @scraper.errors.size.should == 1
+      end
+    end
+
+    it 'catches normal logging behavior' do
+      logger = @scraper.instance_variable_get(:@logger)
+      logger.should_not be_nil
+      logger.info("foo")
+      logger.error("foo")
+      @scraper.succeeded?.should be_false
+      @scraper.errors.should == [[nil, :log, {:severity => Logger::ERROR,
+                                       :message => "foo",
+                                       :progname => nil}]]
+    end
   end
-  
-  it 'should scrape from a hash' do
-    @mock_scraper.should_receive(:scrape).with(RightScale::Repository, true, Proc).and_return(true)
-    @mock_scraper.should_receive(:succeeded?).and_return(true)
-    @mock_scraper.should_receive(:current_repo_dir).and_return('42')
-    @scraper.scrape({:repo_type => :mock}) { }.should be_true
+
+  context 'when base dir is not provided' do
+    before(:each) do
+      @tmpdir = nil
+    end
+
+    it_should_behave_like 'scrapes to given base dir'
   end
-  
-  it 'should report failures' do
-    @mock_scraper.should_receive(:scrape).with(RightScale::Repository, true, Proc).and_return(true)
-    @mock_scraper.should_receive(:succeeded?).and_return(false)
-    @mock_scraper.should_receive(:current_repo_dir).and_return('42')
-    @scraper.scrape({:repo_type => :mock}) { }.should be_false
+
+  context 'when base dir is provided' do
+    before(:each) do
+      @tmpdir = Dir.mktmpdir
+    end
+
+    it_should_behave_like 'scrapes to given base dir'
   end
-    
 end