right_link 5.9.2 → 5.9.5

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2009-2012 RightScale, Inc.
+Copyright (c) 2009-2013 RightScale, Inc.
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.rdoc

@@ -10,6 +10,15 @@ to monitor the stdout and stderr streams of scripted processes. Servers running
 the RightLink agent configures themselves on startup an register with the 
 mapper so that operational recipes and scripts can be run at a later time.
 
+Supported cloud types:
+* azure
+* cloudstack
+* ec2
+* google
+* openstack
+* rackspace (Open Cloud)
+* softlayer
+
 Refer to the wiki (https://github.com/rightscale/right_link/wikis) for up-to-date
 documentation.
 
@@ -82,7 +91,7 @@ See INSTALL.rdoc for more information
 
 <b>RightLink</b>
 
-Copyright:: Copyright (c) 2009-2011 RightScale, Inc.
+Copyright:: Copyright (c) 2009-2013 RightScale, Inc.
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/RELEASES.rdoc

@@ -1,3 +1,50 @@
+= 5.9.5 (RightLink 5.9 release candidate 3)
+
+Released 2013-11-27
+
+== Bug Fixes
+
+* Added ruby as a package dependency.
+* Removed unnecessary warning about rightscale user during package install.
+* Fixed regression in patching mechanism.
+
+= 5.9.4 (RightLink 5.9 release candidate 2)
+
+Released 2013-11-20
+
+== Changes to Existing Functionality
+
+* Revert rs_tag query TAG_LIST param to split tags by space. No spaces allowed in a tag.
+
+== Bug Fixes
+
+* Redundant rs_state output when executed.
+* Fix RightLink failure to run RightScripts that contain a single or double quote.
+
+= 5.9.3 (RightLink 5.9 release candidate 1)
+
+Released 2013-10-17
+
+== New Features
+ * rs_state utility that lets users interrogate the run-state (rs_state --type run) or
+   agent state (rs_state --type agent)
+
+== Changes to Existing Functionality
+
+* RightLink changes the audit summary when waiting for missing inputs on boot. It also strands if
+  inputs are still missing after 45 minutes. ("Missing" means inputs that are set to a value that
+  cannot yet be computed, such as the IP address of a non-running server.)
+* RS_DECOM_REASON is not populated anymore
+* The cloud-support package for Rackspace Classic cloud suffixed as "rackspace-first-gen" has been removed.
+* The cloud-support package for Rackspace OpenCloud is suffixed with "rackspace".
+
+== Bug Fixes
+
+* RightLink sets correct permissions on users' home directories (using OS defaults)
+  for users that have been created on login.
+* RightLink CLI tools will no longer crash when executed without arguments.
+* RightLink will no longer give a warning about missing tty name when boot scripts complete.
+
 = 5.9.2 (RightLink 5.9 beta 3)
 
 Released 2013-09-06.
@@ -118,7 +165,7 @@ Released 2013-07-13.
 
 == Bug Fixes
 
-* Managed login always displays MOTD, works with older versions of sudo, 
+* Managed login always displays MOTD, works with older versions of sudo,
 * Cookbook download is more reliable in fail-and-retry scenarios
 
 = 5.8.8 (General Availability release in conjunction with ServerTemplates v12.11 LTS)

data/actors/instance_setup.rb

@@ -51,6 +51,9 @@ class InstanceSetup
   # Maximum time between nag audits for missing inputs.
   MISSING_INPUT_AUDIT_DELAY_SECS = 2 * 60
 
+  # Maximum time that instances will wait for missing inputs before stranding
+  MISSING_INPUT_TIMEOUT = 45 * 60
+
   # Tag set on instances that are part of an array
   AUTO_LAUNCH_TAG ='rs_launch:type=auto'
 
@@ -135,9 +138,10 @@ class InstanceSetup
   # true:: Always return true
   def init_boot
     RightScale::Sender.instance.initialize_offline_queue
-    payload = {:agent_identity => @agent_identity,
-               :r_s_version    => RightScale::AgentConfig.protocol_version,
-               :resource_uid   => RightScale::InstanceState.resource_uid}
+    payload = {:agent_identity     => @agent_identity,
+               :right_link_version => RightLink.version,
+               :r_s_version        => RightScale::AgentConfig.protocol_version,
+               :resource_uid       => RightScale::InstanceState.resource_uid}
     req = RightScale::IdempotentRequest.new('/booter/declare', payload, :retry_on_error => true)
     req.callback do |res|
       RightScale::Sender.instance.start_offline_queue
@@ -403,6 +407,7 @@ class InstanceSetup
 
     req.callback do |bundle|
       if bundle.executables.any? { |e| !e.ready }
+        @audit.create_new_section("Waiting for missing inputs")
         retrieve_missing_inputs(bundle) { cb.call(success_result(bundle)) }
       else
         yield success_result(bundle)
@@ -461,7 +466,7 @@ class InstanceSetup
         yield
       else
         # keep state to provide fewer but more meaningful audits.
-        last_missing_inputs ||= {}
+        last_missing_inputs ||= {:started_at => Time.now}
         last_missing_inputs[:executables] ||= {}
 
         # don't need to audit on each attempt to resolve missing inputs, but nag
@@ -477,9 +482,11 @@ class InstanceSetup
           missing_input_names = []
 
           e.input_flags.each {|k,v| missing_input_names << k if  v.member?("unready")}
-          @audit.append_info("Waiting for the following missing inputs which are used by '#{e.nickname}': #{missing_input_names.join(", ")}")
+          if audit_missing_inputs
+            @audit.append_info("Waiting for the following missing inputs which are used by '#{e.nickname}': #{missing_input_names.join(", ")}")
+            sent_audit = true
+          end
 
-          sent_audit = true
           missing_inputs_executables[e.nickname] = missing_input_names
         end
 
@@ -488,14 +495,17 @@ class InstanceSetup
           unless missing_inputs_executables[nickname]
             title = RightScale::RightScriptsCookbook.recipe_title(nickname)
             @audit.append_info("The inputs used by #{title} which had been missing have now been resolved.")
-            sent_audit = true
           end
         end
         last_missing_inputs[:executables] = missing_inputs_executables
         last_missing_inputs[:last_audit_time] = Time.now if sent_audit
 
-        # schedule retry to retrieve missing inputs.
-        EM.add_timer(MISSING_INPUT_RETRY_DELAY_SECS) { retrieve_missing_inputs(bundle, last_missing_inputs, &cb) }
+        if Time.now - last_missing_inputs[:started_at] < MISSING_INPUT_TIMEOUT
+          # schedule retry to retrieve missing inputs.
+          EM.add_timer(MISSING_INPUT_RETRY_DELAY_SECS) { retrieve_missing_inputs(bundle, last_missing_inputs, &cb) }
+        else
+          strand("Failed to retrieve missing inputs after #{MISSING_INPUT_TIMEOUT / 60} minutes")
+        end
       end
     end
 

data/bin/rs_state

@@ -0,0 +1,31 @@
+# Copyright (c) 2013 RightScale Inc
+#
+# Permission is hereby granted, free of charge, to any person obtaining
+# a copy of this software and associated documentation files (the
+# "Software"), to deal in the Software without restriction, including
+# without limitation the rights to use, copy, modify, merge, publish,
+# distribute, sublicense, and/or sell copies of the Software, and to
+# permit persons to whom the Software is furnished to do so, subject to
+# the following conditions:
+#
+# The above copyright notice and this permission notice shall be
+# included in all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+# NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+# LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+# OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+# WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+
+# rs_state --help for usage information
+#
+# See scripts/state_controller.rb for additional information.
+
+require File.expand_path(File.join(File.dirname(__FILE__), '..', 'lib', 'gem_dependencies'))
+
+$:.push(File.join(File.dirname(__FILE__), '..', 'scripts'))
+require 'state_controller'
+
+RightScale::RightLinkStateController::run

data/lib/chef/providers/right_link_tag_provider.rb

@@ -59,7 +59,7 @@ class Chef
       # true:: Always return true
       def action_load
         tags = RightScale::Cook.instance.load_tags(@new_resource.timeout)
-        node[:right_link_tags] = tags
+        node.set[:right_link_tags] = tags
         true
       end
 

data/lib/chef/providers/server_collection_provider.rb

@@ -46,13 +46,13 @@ class Chef
       # === Return
       # true:: Always return true
       def action_load
-        node[:server_collection] ||= {}
-        node[:server_collection][@new_resource.name] = {}
+        node.set[:server_collection] ||= {}
+        node.set[:server_collection][@new_resource.name] = {}
         return unless @new_resource.tags && !@new_resource.tags.empty?
 
         result = RightScale::Cook.instance.query_tags(@new_resource.tags, @new_resource.agent_ids, @new_resource.timeout)
         collection = result.inject({}) { |res, (k, v)| res[k] = v['tags']; res }
-        node[:server_collection][@new_resource.name] = collection
+        node.set[:server_collection][@new_resource.name] = collection
         true
       end
 

data/lib/clouds/clouds/rackspace.rb

@@ -45,7 +45,7 @@ end
 
 # defaults.
 default_option([:user_metadata, :metadata_tree_climber, :create_leaf_override], method(:create_user_metadata_leaf))
-default_option([:metadata_source, :user_metadata_source_file_path], File.join(RightScale::Platform.filesystem.spool_dir, name.to_s, 'user-data.txt'))
+default_option([:metadata_source, :user_metadata_source_file_path], File.join(RightScale::Platform.filesystem.spool_dir, 'rackspace', 'user-data.txt'))
 
 # Determines if the current instance is running on rackspace.
 #
@@ -74,5 +74,14 @@ def update_details
       details[:private_ip] = ::RightScale::CloudUtilities.ip_for_interface(ohai, :eth1)
     end
   end
+
+  # rack_connect (and managed?) instances may not have network interfaces for
+  # public ip, so attempt the "what's my ip?" method in these cases.
+  unless details[:public_ip]
+    if public_ip = ::RightScale::CloudUtilities.query_whats_my_ip(:logger=>logger)
+      details[:public_ip] = public_ip
+    end
+  end
+
   return details
 end

data/lib/instance/agent_config.rb

@@ -29,7 +29,10 @@ module RightScale
 
     # Path to RightScale files in parent directory of right_link
     def self.parent_dir
-      File.dirname(File.normalize_path(File.join(File.dirname(__FILE__), '..', '..', '..', 'right_link')))
+      # NOTE:
+      # RightScale is missing right_link home dir for Linux Platform
+      # will be fixed for v6.0, - ticket #16947
+      RightScale::Platform.windows? ? RightScale::Platform.filesystem.right_link_home_dir : '/opt/rightscale'
     end
 
      # @return [Array] an appropriate sequence of root directories for configuring the RightLink agent

data/lib/instance/cook/repose_downloader.rb

@@ -112,7 +112,7 @@ module RightScale
             # Previously we accessed RestClient directly and used it's wrapper method to instantiate
             # a RestClient::Request object.  This wrapper was not passing all options down the stack
             # so now we invoke the RestClient::Request object directly, passing it our desired options
-            client.execute(:method => :get, :url => "https://#{endpoint}:443#{resource}", :timeout => calculate_timeout(attempts), :verify_ssl => OpenSSL::SSL::VERIFY_PEER, :ssl_ca_file => get_ca_file, :headers => {:user_agent => "RightLink v#{AgentConfig.protocol_version}", 'X-RightLink-Version' => RightLink::VERSION }) do |response, request, result|
+            client.execute(:method => :get, :url => "https://#{endpoint}:443#{resource}", :timeout => calculate_timeout(attempts), :verify_ssl => OpenSSL::SSL::VERIFY_PEER, :ssl_ca_file => get_ca_file, :headers => {:user_agent => "RightLink v#{AgentConfig.protocol_version}", 'X-RightLink-Version' => RightLink.version }) do |response, request, result|
               if result.kind_of?(Net::HTTPSuccess)
                 @size = result.content_length || response.size || 0
                 @speed = @size / (Time.now - t0)

data/lib/instance/executable_sequence_proxy.rb

@@ -149,9 +149,6 @@ module RightScale
             ::RightScale::OptionsBag::OPTIONS_ENV =>
               ::ENV[::RightScale::OptionsBag::OPTIONS_ENV]
           }
-          if @context.decommission?
-            environment['RS_DECOM_REASON'] = @context.decommission_type
-          end
 
           # spawn
           RightScale::RightPopen.popen3_async(

data/lib/instance/instance_state.rb

@@ -32,10 +32,10 @@ module RightScale
 
     CONFIG=\
       if File.exists?(CONFIG_YAML_FILE)
-        RightSupport::Config.features(CONFIG_YAML_FILE)                           
+        RightSupport::Config.features(CONFIG_YAML_FILE)
       else
         RightSupport::Config.features({})
-      end    
+      end
 
     # States that are recorded in a standard fashion and audited when transitioned to
     RECORDED_STATES = %w{ booting operational stranded decommissioning }
@@ -120,7 +120,7 @@ module RightScale
 
     # (String) Type of decommission currently in progress or nil
     def self.decommission_type
-      if @value == 'decommissioning'
+      if @value == 'decommissioning' || @value == 'decommissioned'
         @decommission_type
       else
         raise RightScale::Exceptions::WrongState.new("Unexpected call to InstanceState.decommission_type for current state #{@value.inspect}")
@@ -175,7 +175,7 @@ module RightScale
         #  3) bundled boot       -- Agent already ran; agent ID changed: transition back to booting
         #  4) decommission/crash -- Agent exited anyway; ID not changed; no reboot; keep old state entirely
         #  5) ec2 restart        -- Agent already ran; agent ID changed; instance ID is the same; transition back to booting
-        if state['identity'] && state['identity'] != identity
+        if state['identity'] && state['identity'] != identity && !@read_only
           @last_recorded_value = state['last_recorded_value']
           self.value = 'booting'
           # if the current resource_uid is the same as the last
@@ -190,7 +190,7 @@ module RightScale
             # CASE 3 -- identity has changed; bundled boot
             Log.debug("Bundle detected; transitioning state to booting")
           end
-        elsif state['reboot']
+        elsif state['reboot'] && !@read_only
           # CASE 2 -- rebooting flagged by rightboot script in linux or by shutdown notification in windows
           Log.debug("Reboot detected; transitioning state to booting")
           @last_recorded_value = state['last_recorded_value']
@@ -199,11 +199,12 @@ module RightScale
         else
           # CASE 4 -- restart without reboot; continue with retries if recorded state does not match
           @value = state['value']
+          @reboot = state['reboot']
           @startup_tags = state['startup_tags']
           @log_level = state['log_level']
           @last_recorded_value = state['last_recorded_value']
           @record_retries = state['record_retries']
-          @decommission_type = state['decommission_type'] if @value == 'decommissioning'
+          @decommission_type = state['decommission_type'] if (@value == 'decommissioning' || @value == 'decommissioned')
           if @value != @last_recorded_value && RECORDED_STATES.include?(@value) &&
              @record_retries < MAX_RECORD_STATE_RETRIES && !@read_only
             record_state
@@ -251,7 +252,7 @@ module RightScale
       Log.info("Transitioning state from #{previous_val} to #{val}")
       @reboot = false if val != :booting
       @value = val
-      @decommission_type = nil unless @value == 'decommissioning'
+      @decommission_type = nil unless (@value == 'decommissioning' || @value == 'decommissioned')
 
       update_logger
       update_motd
@@ -270,7 +271,7 @@ module RightScale
     #
     # === Return
     # result(String):: new decommission type
-    # 
+    #
     # === Raise
     # RightScale::Exceptions::Application:: Cannot update in read-only mod
     def self.decommission_type=(decommission_type)
@@ -510,9 +511,9 @@ module RightScale
       return unless RightScale::Platform.linux?
 
       if SUCCESSFUL_STATES.include?(@value)
-        system('echo "RightScale installation complete. Details can be found in system logs." | wall') rescue nil
+        system('echo "RightScale installation complete. Details can be found in system logs." | wall > /dev/null 2>&1') rescue nil
       elsif FAILED_STATES.include?(@value)
-        system('echo "RightScale installation failed. Please review system logs." | wall') rescue nil
+        system('echo "RightScale installation failed. Please review system logs." | wall > /dev/null 2>&1') rescue nil
       end
 
       return nil
@@ -537,7 +538,7 @@ module RightScale
                         'last_observed_resource_uid' => @resource_uid}
 
       # Only include deommission_type when decommissioning
-      state_to_store['decommission_type'] = @decommission_type if @value == 'decommissioning'
+      state_to_store['decommission_type'] = @decommission_type if (@value == 'decommissioning' || @value == 'decommissioned')
 
       RightScale::JsonUtilities::write_json(STATE_FILE, state_to_store)
       true

data/lib/instance/login_user_manager.rb

@@ -190,7 +190,6 @@ module RightScale
       when 0
         home_dir = Shellwords.escape(Etc.getpwnam(username).dir)
 
-        sudo("chmod 0771 #{Shellwords.escape(home_dir)}")
         # Locking account to prevent warning os SUSE(it complains on unlocking non-locked account)
         modify_user(username, true, shell)
 
@@ -346,33 +345,6 @@ module RightScale
       groups.include?(name)
     end
 
-    def setup_profile(username, home_dir, custom_data, force)
-      return false if custom_data.nil? || custom_data.empty?
-
-      checksum_path = File.join('.rightscale', PROFILE_CHECKSUM)
-      return false if !force && File.exists?(File.join(home_dir, checksum_path))
-
-      t0 = Time.now.to_i
-      yield("Performing profile setup for #{username}...") if block_given?
-
-      tmpdir = Dir.mktmpdir
-      file_path = File.join(tmpdir, File.basename(custom_data))
-      if download_files(custom_data, file_path) && extract_files(username, file_path, home_dir)
-        save_checksum(username, file_path, checksum_path, home_dir)
-        t1 = Time.now.to_i
-        yield("Setup complete (#{t1 - t0} sec)") if block_given? && (t1 - t0 >= 2)
-      end
-
-      return true
-    rescue Exception => e
-      yield("Failed to create profile for #{username}; continuing") if block_given?
-      yield("#{e.class.name}: #{e.message} - #{e.backtrace.first}") if block_given?
-      Log.error("#{e.class.name}: #{e.message} - #{e.backtrace.first}")
-      return false
-    ensure
-      FileUtils.rm_rf(tmpdir) if tmpdir && File.exists?(tmpdir)
-    end
-
     # Set some of the environment variables that would normally be set if a user
     # were to login to an interactive shell. This is useful when simulating an
     # interactive login, e.g. for purposes of running a user-specified command
@@ -432,100 +404,5 @@ module RightScale
 
       File.join(path, cmd)
     end
-
-    # Downloads a file from specified URL
-    #
-    # === Parameters
-    # url(String):: URL to file
-    # path(String):: downloaded file path
-    #
-    # === Return
-    # downloaded(Boolean):: true if downloaded and saved successfully
-    def download_files(url, path)
-      client = RightSupport::Net::HTTPClient.new
-      response = client.get(url, :timeout => 10)
-      File.open(path, "wb") { |file| file.write(response) } unless response.empty?
-      File.exists?(path)
-    rescue Exception => e
-      Log.error("#{e.class.name}: #{e.message} - #{e.backtrace.first}")
-      false
-    end
-
-    # Extracts an archive and moves files to destination directory
-    # Supported archive types are:
-    #   .tar.bz2 / .tbz
-    #   .tar.gz / .tgz
-    #   .zip
-    #
-    # === Parameters
-    # username(String):: account's username
-    # filename(String):: archive's path
-    # destination_path(String):: path where extracted files should be
-    # moved
-    #
-    # === Return
-    # extracted(Boolean):: true if archive is extracted successfully
-    def extract_files(username, filename, destination_path)
-      escaped_filename = Shellwords.escape(filename)
-
-      case filename
-      when /(?:\.tar\.bz2|\.tbz)$/
-        result = sudo("tar jxf #{escaped_filename} -C #{destination_path}")
-      when /(?:\.tar\.gz|\.tgz)$/
-        result = sudo("tar zxf #{escaped_filename} -C #{destination_path}")
-      when /\.zip$/
-        result = sudo("unzip -o #{escaped_filename} -d #{destination_path}")
-      else
-        raise ArgumentError, "Don't know how to extract #{filename}'"
-      end
-
-      extracted = result.success?
-      chowned = change_owner(username, username, destination_path)
-
-      extracted && chowned
-    end
-
-    # Calculates MD5 checksum for specified file and saves it
-    #
-    # === Parameters
-    # username(String):: account's username
-    # target(String):: path to file
-    # checksum_path(String):: relative path to checksum file
-    # destination(String):: path to file where checksum should be saved
-    #
-    # === Return
-    # nil
-    def save_checksum(username, target, checksum_path, destination)
-      checksum = Digest::MD5.file(target).to_s
-
-      temp_dir = File.join(File.dirname(target), File.dirname(checksum_path))
-      temp_path = File.join(File.dirname(target), checksum_path)
-
-      FileUtils.mkdir_p(temp_dir)
-      FileUtils.chmod_R(0771, temp_dir) # need +x to others for File.exists? => true
-      File.open(temp_path, "w") { |f| f.write(checksum) }
-
-      change_owner(username, username, temp_dir)
-      sudo("mv #{temp_dir} #{destination}")
-    rescue Exception => e
-      STDERR.puts "Failed to save checksum for #{username} profile"
-      STDERR.puts "#{e.class.name}: #{e.message} - #{e.backtrace.first}"
-      Log.error("#{e.class.name}: #{e.message} - #{e.backtrace.first}")
-    end
-
-    # Changes owner of directories and files from given path
-    #
-    # === Parameters
-    # username(String):: desired owner's username
-    # group(String):: desired group name
-    # path(String):: path for owner changing
-    #
-    # === Return
-    # chowned(Boolean):: true if owner changed successfully
-    def change_owner(username, group, path)
-      result = sudo("chown -R #{Shellwords.escape(username)}:#{Shellwords.escape(group)} #{path}")
-
-      result.success?
-    end
   end
 end