right_aws 1.1.0 → 1.2.0

data/lib/right_aws.rb

@@ -32,11 +32,11 @@ require "openssl"
 require "digest/sha1"
 
 require 'rubygems'
-require 'active_support'
 require 'right_http_connection'
 
 $:.unshift(File.dirname(__FILE__))
 require 'awsbase/benchmark_fix'
+require 'awsbase/support'
 require 'awsbase/right_awsbase'
 require 'ec2/right_ec2'
 require 's3/right_s3_interface'
@@ -48,13 +48,15 @@ require 'sqs/right_sqs'
 module RightAws #:nodoc:
   module VERSION #:nodoc:
     MAJOR = 1
-    MINOR = 1
+    MINOR = 2
     TINY  = 0
 
     STRING = [MAJOR, MINOR, TINY].join('.')
   end
 end
 
+#-
+
 # We also want everything available in the Rightscale namespace for backward
 # compatibility reasons.
 module Rightscale

data/lib/s3/right_s3.rb

@@ -22,20 +22,35 @@
 #
 
 module RightAws
-
+  
+  # = RightAws::S3 -- RightScale's Amazon S3 interface
+  # The RightAws::S3 class provides a complete interface to Amazon's Simple
+  # Storage Service.
+  # For explanations of the semantics
+  # of each call, please refer to Amazon's documentation at
+  # http://developer.amazonwebservices.com/connect/kbcategory.jspa?categoryID=48
+  #
+  # See examples below for the bucket and buckets methods.
+  #
+  # Error handling: all operations raise an RightAws::AwsError in case
+  # of problems. Note that transient errors are automatically retried.
+    
   class S3
     attr_reader :interface
     
+    # Create a new handle to an S3 account. All handles share the same per process or per thread
+    # HTTP connection to Amazon S3. Each handle is for a specific account.
+    # The +params+ are passed through as-is to RightAws::S3Interface.new
     def initialize(aws_access_key_id, aws_secret_access_key, params={})
       @interface = S3Interface.new(aws_access_key_id, aws_secret_access_key, params)
     end
     
-      # Retrieve a list of buckets.
-      # Returns an array of Bucket instances.
-      #
-      #  s3 = RightAws::S3.new(aws_access_key_id, aws_secret_access_key)
-      #  p s3.buckets #=> array of buckets
-      #
+    # Retrieve a list of buckets.
+    # Returns an array of RightAws::S3::Bucket instances.
+    #  # Create handle to S3 account
+    #  s3 = RightAws::S3.new(aws_access_key_id, aws_secret_access_key)
+    #  my_buckets_names = s3.buckets.map{|b| b.name}
+    #  puts "Buckets on S3: #{my_bucket_names.join(', ')}"
     def buckets
       @interface.list_all_my_buckets.map! do |entry|
         owner = Owner.new(entry[:owner_id], entry[:owner_display_name])
@@ -43,23 +58,23 @@ module RightAws
       end
     end
     
-      # Return an object representing a bucket.
-      # If the bucket does not exist and +create+ is set, a new bucket
-      # is created on S3.  The +create+ parameter has no effect if
-      # the bucket alrady exists. 
-      # Returns Bucket instance or +nil+ if the bucket does not exist 
-      # and +create+ is not set.
-      #
-      #  s3 = RightAws::S3.new(aws_access_key_id, aws_secret_access_key)
-      #  bucket1 = s3.bucket('my_awesome_bucket')
-      #  bucket1.keys  #=> exception here if the bucket does not exists
-      #   ...
-      #  bucket2 = s3.bucket('my_awesome_bucket', true)
-      #  bucket2.keys  #=> list of keys
-      #
-      #  see http://docs.amazonwebservices.com/AmazonS3/2006-03-01/RESTAccessPolicy.html
-      #  (section: Canned Access Policies)
-      #
+    # Retrieve an individual bucket.
+    # If the bucket does not exist and +create+ is set, a new bucket
+    # is created on S3.  The +create+ parameter has no effect if
+    # the bucket alrady exists. 
+    # Returns a RightAws::S3::Bucket instance or +nil+ if the bucket does not exist 
+    # and +create+ is not set.
+    #
+    #  s3 = RightAws::S3.new(aws_access_key_id, aws_secret_access_key)
+    #  bucket1 = s3.bucket('my_awesome_bucket')
+    #  bucket1.keys  #=> exception here if the bucket does not exists
+    #   ...
+    #  bucket2 = s3.bucket('my_awesome_bucket', true)
+    #  bucket2.keys  #=> list of keys
+    #
+    #  see http://docs.amazonwebservices.com/AmazonS3/2006-03-01/RESTAccessPolicy.html
+    #  (section: Canned Access Policies)
+    #
     def bucket(name, create=true, perms=nil, headers={})
       headers['x-amz-acl'] = perms if perms
       @interface.create_bucket(name, headers) if create

data/lib/s3/right_s3_interface.rb

@@ -29,7 +29,7 @@ module RightAws
     DEFAULT_PORT           = 443
     DEFAULT_PROTOCOL       = 'https'
     REQUEST_TTL            = 30
-    DEFAULT_EXPIRES_AFTER  = 1.day
+    DEFAULT_EXPIRES_AFTER  = 1 * 24 * 60 * 60 # One day's worth of seconds
     AMAZON_HEADER_PREFIX   = 'x-amz-'
     AMAZON_METADATA_PREFIX = 'x-amz-meta-'
 
@@ -68,13 +68,15 @@ module RightAws
       # Benchmark::Tms instance for XML parsing benchmark.
     def self.bench_xml; @@bench_xml; end  # For benchmark puposes.
 
-      # Returns a list of Amazon service responses which are known as problems on Amazon side. 
-      # We have to re-request again if we've got any of them - probably the problem will disappear. By default returns the same value as AMAZON_PROBLEMS const.
+      # Returns a list of Amazon service responses which are known to be transient problems. 
+      # We have to re-request if we get any of them, because the problem will probably disappear. 
+      # By default this method returns the same value as the AMAZON_PROBLEMS const.
     def self.amazon_problems
       @@amazon_problems
     end
 
-      # Sets a list of Amazon side problems.
+      # Sets the list of Amazon side problems.  Use in conjunction with the
+      # getter to append problems.
     def self.amazon_problems=(problems_list)
       @@amazon_problems = problems_list
     end
@@ -111,6 +113,7 @@ module RightAws
       @logger = RAILS_DEFAULT_LOGGER if !@logger && defined?(RAILS_DEFAULT_LOGGER)
       @logger = Logger.new(STDOUT)   if !@logger
       @logger.info "New #{self.class.name} using #{@params[:multi_thread] ? 'multi' : 'single'}-threaded mode"
+      @error_handler = nil
     end
 
 	# TODO TRB 6/19/07 - Service gem common method
@@ -163,7 +166,7 @@ module RightAws
       headers['content-type'] ||= ''
       headers['date']           = Time.now.httpdate
         # create request
-      request      = "Net::HTTP::#{method.titleize}".constantize.new(URI::escape(CGI::unescape(path)))
+      request      = "Net::HTTP::#{method.capitalize}".constantize.new(URI::escape(CGI::unescape(path)))
       request.body = data if data
         # set request headers and meta headers
       headers.each      { |key, value| request[key.to_s] = value }
@@ -219,13 +222,7 @@ module RightAws
         @last_response = response
         if response.is_a?(Net::HTTPSuccess)
           @error_handler = nil
-          @@bench_xml.add! do
-            if parser.kind_of?(RightAWSParser)
-              REXML::Document.parse_stream(response.body, parser)
-            else
-              parser.parse(response)
-            end
-          end
+          @@bench_xml.add! { parser.parse(response) }
           return parser.result
         else
           @error_handler = AWSErrorHandler.new(self, parser, @@amazon_problems) unless @error_handler
@@ -253,7 +250,7 @@ module RightAws
       #
     def list_all_my_buckets(headers={})
       req_hash = generate_rest_request('GET', headers.merge(:url=>''))
-      request_info(req_hash, S3ListAllMyBucketsParser.new)
+      request_info(req_hash, S3ListAllMyBucketsParser.new(:logger => @logger))
     rescue
       on_exception
     end
@@ -301,7 +298,7 @@ module RightAws
     def list_bucket(bucket, options={}, headers={})
       bucket  += '?'+options.map{|k, v| "#{k.to_s}=#{CGI::escape v.to_s}"}.join('&') unless options.blank?
       req_hash = generate_rest_request('GET', headers.merge(:url=>bucket))
-      request_info(req_hash, S3ListBucketParser.new)
+      request_info(req_hash, S3ListBucketParser.new(:logger => @logger))
     rescue
       on_exception
     end
@@ -339,7 +336,7 @@ module RightAws
         internal_bucket = bucket.dup
         internal_bucket  += '?'+internal_options.map{|k, v| "#{k.to_s}=#{CGI::escape v.to_s}"}.join('&') unless internal_options.blank?
         req_hash = generate_rest_request('GET', headers.merge(:url=>internal_bucket))
-        response = request_info(req_hash, S3ImprovedListBucketParser.new)
+        response = request_info(req_hash, S3ImprovedListBucketParser.new(:logger => @logger))
         there_are_more_keys = response[:is_truncated]
         if(there_are_more_keys)
           if(response[:next_marker])
@@ -482,7 +479,7 @@ module RightAws
     def get_acl_parse(bucket, key='', headers={})
       key = key.blank? ? '' : "/#{CGI::escape key}"
       req_hash = generate_rest_request('GET', headers.merge(:url=>"#{bucket}#{key}?acl"))
-      acl = request_info(req_hash, S3AclParser.new)
+      acl = request_info(req_hash, S3AclParser.new(:logger => @logger))
       result = {}
       result[:owner]    = acl[:owner]
       result[:grantees] = {}

data/lib/sqs/right_sqs.rb

@@ -24,7 +24,15 @@
 module RightAws
 
     #
-    # SQS.
+    # = RightAws::Sqs -- RightScale's Amazon SQS interface
+    # The RightAws::Sqs class provides a complete interface to Amazon's Simple
+    # Queue Service.
+    # For explanations of the semantics
+    # of each call, please refer to Amazon's documentation at
+    # http://developer.amazonwebservices.com/connect/kbcategory.jspa?categoryID=31
+    #
+    # Error handling: all operations raise an RightAws::AwsError in case
+    # of problems. Note that transient errors are automatically retried.
     #
     #  sqs    = RightAws::Sqs.new(aws_access_key_id, aws_secret_access_key)
     #  queue1 = sqs.queue('my_awesome_queue')
@@ -66,7 +74,7 @@ module RightAws
     end
     
       # Returns Queue instance by queue name. 
-      # If the queue does not exist at Amazon SQS and +create+ then creates it.
+      # If the queue does not exist at Amazon SQS and +create+ is true, the method creates it.
       #
       #  RightAws::Sqs.queue('my_awesome_queue') #=> #<RightAws::Sqs::Queue:0xb7b626e4 ... >
       #
@@ -81,16 +89,16 @@ module RightAws
       attr_reader :name, :url, :sqs
       
         # Returns Queue instance by queue name. 
-        # If the queue does not exist at Amazon SQS and +create+ then creates it.
+        # If the queue does not exist at Amazon SQS and +create+ is true, the method creates it.
         #
         #  RightAws::Sqs::Queue.create(sqs, 'my_awesome_queue') #=> #<RightAws::Sqs::Queue:0xb7b626e4 ... >
         #
       def self.create(sqs, url_or_name, create=true, visibility=nil)
-        sqs.queue(url_or_name, create=true, visibility)
+        sqs.queue(url_or_name, create, visibility)
       end
       
         # Creates new Queue instance. 
-        # Does not create queue at Amazon.
+        # Does not create a queue at Amazon.
         #
         #  queue = RightAws::Sqs::Queue.new(sqs, 'my_awesome_queue')
         #
@@ -114,17 +122,20 @@ module RightAws
         #  queue.clear(true) #=> true
         #
         # P.S. when <tt>force==true</tt> the queue deletes then creates again. This is 
-        # the quickest method to clear big queue oe the queue with 'locked' messages. All queue
-        # attributes restores. But there is no way to restore grantees permissions to 
-        # this queue. If you have no grantees except of 'root' then you have no problems.
-        # But if the grantees are there - better use <tt>queue.clear(false)</tt>.
+        # the quickest method to clear a big queue or a queue with 'locked' messages. All queue
+        # attributes are restored. But there is no way to restore grantees' permissions to 
+        # this queue. If you have no grantees except 'root' then you have no problems.
+        # Otherwise, it's better to use <tt>queue.clear(false)</tt>.
+        #
+        # PS This function is no longer supported.  Amazon has changed the SQS semantics to require at least 60 seconds between 
+        # queue deletion and creation. Hence this method will fail with an exception.
         #
       def clear(force=false)
-        if force
-          @sqs.interface.force_clear_queue(@url)
-        else
+##        if force
+##          @sqs.interface.force_clear_queue(@url)
+##        else
           @sqs.interface.clear_queue(@url)
-        end
+##        end
       end
       
         # Deletes queue. 
@@ -147,7 +158,7 @@ module RightAws
       end
       alias_method :push, :send_message
 
-        # Retrieves a bunch of message from queue. 
+        # Retrieves several messages from queue. 
         # Returns an array of Message instances. 
         #
         #  queue.receive_messages(2,10) #=> array of messages
@@ -228,7 +239,7 @@ module RightAws
         
         # Retrieves queue attributes. 
         # At this moment Amazon supports +VisibilityTimeout+ and +ApproximateNumberOfMessages+ only. 
-        # If the name of attribute is set - returns its value otherwise - returns a hash of attributes.
+        # If the name of attribute is set, returns its value. Otherwise, returns a hash of attributes.
         #
         # queue.get_attribute('VisibilityTimeout')  #=> '100'
         #
@@ -237,9 +248,9 @@ module RightAws
         attribute=='All' ? attributes : attributes[attribute]
       end
         
-        # Retrieves a list grantees. 
+        # Retrieves a list of grantees. 
         # Returns an +array+ of Grantee instances if the +grantee_email_address+ is unset. 
-        # Else returns Grantee instance that points to +grantee_email_address+ or +nil+.
+        # Otherwise returns a Grantee instance that points to +grantee_email_address+ or +nil+.
         #
         #  grantees = queue.grantees #=> [#<RightAws::Sqs::Grantee:0xb7bf0888 ... >, ...]
         #   ...
@@ -312,7 +323,7 @@ module RightAws
       end
 
         # Retrieves security information for grantee identified by email. 
-        # Returns +nil+ if such user does not has any permissions for this queue or 
+        # Returns +nil+ if the named user has no privileges on this queue, or 
         # +true+ if perms updated successfully. 
       def retrieve # :nodoc:
         @id    = nil
@@ -331,7 +342,7 @@ module RightAws
         
         # Adds permissions for grantee. 
         # Permission: 'FULLCONTROL' | 'RECEIVEMESSAGE' | 'SENDMESSAGE'. 
-        # User must have @email set. 
+        # The caller must have set the email instance variable. 
       def grant(permission=nil)
         raise "You can't grant permission without defining a grantee email address!" unless @email
         @queue.sqs.interface.add_grant(@queue.url, @email, permission)

data/lib/sqs/right_sqs_interface.rb

@@ -32,7 +32,7 @@ module RightAws
     DEFAULT_PROTOCOL  = 'https'
     REQUEST_TTL       = 30
     DEFAULT_VISIBILITY_TIMEOUT = 30
-      # A list if Amazons problems we can handle by AWSErrorHandler.
+      # A list of Amazon problems we can handle via AWSErrorHandler.
     @@amazon_problems = RightAws::AMAZON_PROBLEMS
 
       # Current aws_access_key_id
@@ -53,25 +53,27 @@ module RightAws
     @@bench_sqs = Benchmark::Tms.new()
     @@bench_xml = Benchmark::Tms.new()
     
-      # Benchmark::Tms instance for SQS access benchmark.
+      # Benchmark::Tms instance for SQS access benchmarking.
     def self.bench_sqs; @@bench_sqs;  end  
-      # Benchmark::Tms instance for XML parsing benchmark.
-    def self.bench_xml; @@bench_xml; end  # For benchmark puposes.
+      # Benchmark::Tms instance for XML parsing benchmarking.
+    def self.bench_xml; @@bench_xml; end  # For benchmark purposes.
 
-      # Returns a list of Amazon service responses which are known as problems on Amazon side. 
-      # We have to re-request again if we've got any of them - probably the problem will disappear. By default returns the same value as AMAZON_PROBLEMS const.
+      # Returns a list of Amazon service responses which are known to be transient problems. 
+      # We have to re-request if we get any of them, because the problem will probably disappear. 
+      # By default this method returns the same value as the AMAZON_PROBLEMS const.
     def self.amazon_problems
       @@amazon_problems
     end
     
-      # Sets a list of Amazon side problems.
+      # Sets the list of Amazon side problems.  Use in conjunction with the
+      # getter to append problems.
     def self.amazon_problems=(problems_list)
       @@amazon_problems = problems_list
     end
 
-      # Creates new RightSqs instance.
+      # Creates a new SqsInterface instance.
       #
-      #  sqs = RightSqs.new('1E3GDYEOGFJPIT75KDT40','hgTHt68JY07JKUY08ftHYtERkjgtfERn57DFE379', {:multi_thread => true, :logger => Logger.new('/tmp/x.log')}) #=> <RightSqs:0xb7af6264>
+      #  sqs = RightAws::SqsInterface.new('1E3GDYEOGFJPIT75KDT40','hgTHt68JY07JKUY08ftHYtERkjgtfERn57DFE379', {:multi_thread => true, :logger => Logger.new('/tmp/x.log')}) #=> <RightSqs:0xb7af6264>
       #  
       # Params is a hash:
       #
@@ -102,7 +104,7 @@ module RightAws
       AwsError::on_aws_exception(self, options)
     end
 
-      # Return the +true+ if this RightS3 instance works in multi_thread state and +false+ otherwise.
+      # Return +true+ if this RightS3 instance is running in multi_thread state and +false+ otherwise.
     def multi_thread
       @params[:multi_thread]
     end
@@ -111,7 +113,7 @@ module RightAws
   #      Requests
   #-----------------------------------------------------------------
 
-      # Generates request hash for QUERY API
+      # Generates a request hash for the query API
     def generate_request(action, param={})  # :nodoc:
         # Sometimes we need to use queue uri (delete queue etc)
         # In that case we will use Symbol key: 'param[:queue_url]'
@@ -120,7 +122,8 @@ module RightAws
       param.each{ |key, value| param.delete(key) if (value.nil? || key.is_a?(Symbol)) }
         # prepare output hash
       request_hash = { "Action"           => action,
-                       "Expires"          => Time.now.utc.since(REQUEST_TTL).strftime("%Y-%m-%dT%H:%M:%SZ"),
+                       # "Expires"          => Time.now.utc.since(REQUEST_TTL).strftime("%Y-%m-%dT%H:%M:%SZ"),
+                       "Expires"          => (Time.now + REQUEST_TTL).utc.strftime("%Y-%m-%dT%H:%M:%SZ"),
                        "AWSAccessKeyId"   => @aws_access_key_id,
                        "Version"          => API_VERSION,
                        "SignatureVersion" => SIGNATURE_VERSION }
@@ -136,7 +139,7 @@ module RightAws
         :protocol => @params[:protocol] }
     end
 
-      # Generates request hash for REST API
+      # Generates a request hash for the REST API
     def generate_rest_request(method, param) # :nodoc:
       queue_uri = param[:queue_url] ? URI(param[:queue_url]).path : '/'
       message   = param[:message]                # extract message body if nesessary
@@ -145,7 +148,7 @@ module RightAws
         # created request
       param_to_str = param.to_a.collect{|key,val| key.to_s + "=" + CGI::escape(val.to_s) }.join("&")
       param_to_str = "?#{param_to_str}" unless param_to_str.blank?
-      request = "Net::HTTP::#{method.titleize}".constantize.new("#{queue_uri}#{param_to_str}")
+      request = "Net::HTTP::#{method.capitalize}".constantize.new("#{queue_uri}#{param_to_str}")
       request.body = message if message
         # set main headers
       request['content-md5']  = ''
@@ -179,13 +182,7 @@ module RightAws
       @last_response = response
       if response.is_a?(Net::HTTPSuccess)
         @error_handler = nil
-        @@bench_xml.add! do
-          if parser.kind_of?(RightAWSParser)
-            REXML::Document.parse_stream(response.body, parser)
-          else
-            parser.parse(response)
-          end
-        end
+        @@bench_xml.add! { parser.parse(response) }
         return parser.result
       else
         @error_handler = AWSErrorHandler.new(self, parser, @@amazon_problems) unless @error_handler
@@ -206,22 +203,25 @@ module RightAws
       #
       #  sqs.create_queue('my_awesome_queue') #=> 'http://queue.amazonaws.com/ZZ7XXXYYYBINS/my_awesome_queue'
       #
+      # PS Some queue based requests may not become available until a couple of minutes after queue creation
+      # (permission grant and removal for example)
+      #
     def create_queue(queue_name, default_visibility_timeout=nil)
       req_hash = generate_request('CreateQueue', 
                                   'QueueName'                => queue_name,
                                   'DefaultVisibilityTimeout' => default_visibility_timeout || DEFAULT_VISIBILITY_TIMEOUT )
-      request_info(req_hash, SqsCreateQueueParser.new)
+      request_info(req_hash, SqsCreateQueueParser.new(:logger => @logger))
     end
 
-     # Creates new queue. If +queue_name_prefix+ is omitted then retrieves a list of all queues.
+     # Lists all queues owned by this user that have names beginning with +queue_name_prefix+. If +queue_name_prefix+ is omitted then retrieves a list of all queues.
      #
      #  sqs.create_queue('my_awesome_queue')
      #  sqs.create_queue('my_awesome_queue_2')
-     #  sqs.list_queues('my_qwesome') #=> ['http://queue.amazonaws.com/ZZ7XXXYYYBINS/my_awesome_queue','http://queue.amazonaws.com/ZZ7XXXYYYBINS/my_awesome_queue_2']
+     #  sqs.list_queues('my_awesome') #=> ['http://queue.amazonaws.com/ZZ7XXXYYYBINS/my_awesome_queue','http://queue.amazonaws.com/ZZ7XXXYYYBINS/my_awesome_queue_2']
      #
     def list_queues(queue_name_prefix=nil)
       req_hash = generate_request('ListQueues', 'QueueNamePrefix' => queue_name_prefix)
-      request_info(req_hash, SqsListQueuesParser.new)
+      request_info(req_hash, SqsListQueuesParser.new(:logger => @logger))
     rescue
       on_exception
     end
@@ -234,7 +234,7 @@ module RightAws
       req_hash = generate_request('DeleteQueue', 
                                   'ForceDeletion' => force_deletion.to_s,
                                   :queue_url      => queue_url)
-      request_info(req_hash, SqsStatusParser.new)
+      request_info(req_hash, SqsStatusParser.new(:logger => @logger))
     rescue
       on_exception
     end
@@ -247,7 +247,7 @@ module RightAws
       req_hash = generate_request('GetQueueAttributes', 
                                   'Attribute' => attribute,
                                   :queue_url  => queue_url)
-      request_info(req_hash, SqsGetQueueAttributesParser.new)
+      request_info(req_hash, SqsGetQueueAttributesParser.new(:logger => @logger))
     rescue
       on_exception
     end
@@ -256,13 +256,15 @@ module RightAws
       #
       #  sqs.set_queue_attributes('http://queue.amazonaws.com/ZZ7XXXYYYBINS/my_awesome_queue', "VisibilityTimeout", 10) #=> true
       #
-      # P.S. Hmm... Amazon returns success even if such attribute does not exist. And they need some seconds to change attribute value.
+      # P.S. Amazon returns success even if the attribute does not exist. Also, attribute values may not be immediately available to other queries
+      # for some time after an update (see the SQS documentation for
+      # semantics).
     def set_queue_attributes(queue_url, attribute, value)
       req_hash = generate_request('SetQueueAttributes', 
                                   'Attribute' => attribute,
                                   'Value'     => value,
                                   :queue_url  => queue_url)
-      request_info(req_hash, SqsStatusParser.new)
+      request_info(req_hash, SqsStatusParser.new(:logger => @logger))
     rescue
       on_exception
     end
@@ -277,7 +279,7 @@ module RightAws
       req_hash = generate_request('SetVisibilityTimeout', 
                                   'VisibilityTimeout' => visibility_timeout || DEFAULT_VISIBILITY_TIMEOUT,
                                   :queue_url => queue_url )
-      request_info(req_hash, SqsStatusParser.new)
+      request_info(req_hash, SqsStatusParser.new(:logger => @logger))
     rescue
       on_exception
     end
@@ -290,7 +292,7 @@ module RightAws
      #
     def get_visibility_timeout(queue_url)
       req_hash = generate_request('GetVisibilityTimeout', :queue_url => queue_url )
-      request_info(req_hash, SqsGetVisibilityTimeoutParser.new)
+      request_info(req_hash, SqsGetVisibilityTimeoutParser.new(:logger => @logger))
     rescue
       on_exception
     end
@@ -304,7 +306,7 @@ module RightAws
                                   'Grantee.EmailAddress' => grantee_email_address,
                                   'Permission'           => permission,
                                   :queue_url             => queue_url)
-      request_info(req_hash, SqsStatusParser.new)
+      request_info(req_hash, SqsStatusParser.new(:logger => @logger))
     rescue
       on_exception
     end
@@ -320,7 +322,7 @@ module RightAws
                                   'Grantee.EmailAddress' => grantee_email_address,
                                   'Permission'           => permission,
                                   :queue_url             => queue_url)
-      response = request_info(req_hash, SqsListGrantsParser.new)
+      response = request_info(req_hash, SqsListGrantsParser.new(:logger => @logger))
         # One user may have up to 3 permission records for every queue.
         # We will join these records to one.
       result = {}    
@@ -345,7 +347,7 @@ module RightAws
                                   grantee_key  => grantee_email_address_or_id,
                                   'Permission' => permission,
                                   :queue_url   => queue_url)
-      request_info(req_hash, SqsStatusParser.new)
+      request_info(req_hash, SqsStatusParser.new(:logger => @logger))
     rescue
       on_exception
     end
@@ -355,7 +357,7 @@ module RightAws
       #   sqs.receive_messages('http://queue.amazonaws.com/ZZ7XXXYYYBINS/my_awesome_queue',10, 5) #=>
       #    [{:id=>"12345678904GEZX9746N|0N9ED344VK5Z3SV1DTM0|1RVYH4X3TJ0987654321", :body=>"message_1"}, ..., {}]
       #
-      # P.S. Usually returns less messages than have been requested even if they are available.
+      # P.S. Usually returns fewer messages than requested even if they are available.
       #
     def receive_messages(queue_url, number_of_messages=1, visibility_timeout=nil)
       return [] if number_of_messages == 0
@@ -363,7 +365,7 @@ module RightAws
                                        'NumberOfMessages'  => number_of_messages,
                                        'VisibilityTimeout' => visibility_timeout,
                                        :queue_url          => "#{queue_url}/front" )
-      request_info(req_hash, SqsReceiveMessagesParser.new)
+      request_info(req_hash, SqsReceiveMessagesParser.new(:logger => @logger))
     rescue
       on_exception
     end
@@ -375,7 +377,7 @@ module RightAws
       #
     def peek_message(queue_url, message_id)
       req_hash = generate_rest_request('GET', :queue_url => "#{queue_url}/#{CGI::escape message_id}" )
-      messages = request_info(req_hash, SqsReceiveMessagesParser.new)
+      messages = request_info(req_hash, SqsReceiveMessagesParser.new(:logger => @logger))
       messages.blank? ? nil : messages[0]
     rescue
       on_exception
@@ -389,12 +391,13 @@ module RightAws
       req_hash = generate_rest_request('PUT',
                                        :message   => message,
                                        :queue_url => "#{queue_url}/back")
-      request_info(req_hash, SqsSendMessagesParser.new)
+      request_info(req_hash, SqsSendMessagesParser.new(:logger => @logger))
     rescue
       on_exception
     end
     
-      # Deletes message from queue. Returns +true+ or an exception.
+      # Deletes message from queue. Returns +true+ or an exception.  Amazon
+      # returns +true+ on deletion of non-existent messages.
       #
       #  sqs.delete_message('http://queue.amazonaws.com/ZZ7XXXYYYBINS/my_awesome_queue', '12345678904...0987654321') #=> true
       #
@@ -402,7 +405,7 @@ module RightAws
       req_hash = generate_request('DeleteMessage', 
                                   'MessageId' => message_id,
                                   :queue_url  => queue_url)
-      request_info(req_hash, SqsStatusParser.new)
+      request_info(req_hash, SqsStatusParser.new(:logger => @logger))
     rescue
       on_exception
     end
@@ -416,7 +419,7 @@ module RightAws
                                   'MessageId'         => message_id,
                                   'VisibilityTimeout' => visibility_timeout.to_s,
                                   :queue_url          => queue_url)
-      request_info(req_hash, SqsStatusParser.new)
+      request_info(req_hash, SqsStatusParser.new(:logger => @logger))
     rescue
       on_exception
     end
@@ -456,7 +459,7 @@ module RightAws
       on_exception
     end
 
-      # Returns approximate amount of messages in queue.
+      # Returns approximate number of messages in queue.
       #
       #  sqs.get_queue_length('http://queue.amazonaws.com/ZZ7XXXYYYBINS/my_awesome_queue') #=> 3
       #
@@ -481,12 +484,15 @@ module RightAws
       #
       #  sqs.force_clear_queue('http://queue.amazonaws.com/ZZ7XXXYYYBINS/my_awesome_queue') #=> true
       #
+      # PS This function is no longer supported.  Amazon has changed the SQS semantics to require at least 60 seconds between 
+      # queue deletion and creation. Hence this method will fail with an exception.
+      #
     def force_clear_queue(queue_url)
       queue_name       = queue_name_by_url(queue_url)
       queue_attributes = get_queue_attributes(queue_url)
       force_delete_queue(queue_url)
       create_queue(queue_name)
-        # hmmm... The next like is a trick. Amazon do not want change attributes immediately after queue creation
+        # hmmm... The next line is a trick. Amazon do not want change attributes immediately after queue creation
         # So we do 'empty' get_queue_attributes. Probably they need some time to allow attributes change.
       get_queue_attributes(queue_url)  
       queue_attributes.each{ |attribute, value| set_queue_attributes(queue_url, attribute, value) }