right_agent 1.0.1 → 2.0.7

data/spec/clients/spec_helper.rb

@@ -0,0 +1,111 @@
+#
+# Copyright (c) 2009-2011 RightScale Inc
+#
+# Permission is hereby granted, free of charge, to any person obtaining
+# a copy of this software and associated documentation files (the
+# "Software"), to deal in the Software without restriction, including
+# without limitation the rights to use, copy, modify, merge, publish,
+# distribute, sublicense, and/or sell copies of the Software, and to
+# permit persons to whom the Software is furnished to do so, subject to
+# the following conditions:
+#
+# The above copyright notice and this permission notice shall be
+# included in all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+# NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+# LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+# OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+# WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+
+require 'restclient'
+
+require ::File.expand_path('../../spec_helper', __FILE__)
+
+# Mock auth client providing basic support needed by various clients
+class AuthClientMock < RightScale::AuthClient
+  attr_reader :test_url, :expired_called, :redirect_location
+
+  def initialize(url, auth_header, state = nil, account_id = nil, identity = nil)
+    @test_url = @api_url = @router_url = url
+    @auth_header = auth_header
+    @account_id = account_id
+    @identity = identity || "rs-agent-1-1"
+    @state = :authorized if state
+  end
+
+  def identity
+    @identity
+  end
+
+  def headers
+    auth_header
+  end
+
+  def auth_header
+    @auth_header
+  end
+
+  def expired
+    @expired_called = true
+  end
+
+  def redirect(location)
+    @redirect_location = location
+  end
+end
+
+# Mock WebSocket event
+class WebSocketEventMock
+  attr_reader :code, :data, :reason
+
+  def initialize(data, code = nil, reason = nil)
+    @code = code
+    @data = data
+    @reason = reason
+  end
+end
+
+# Mock of WebSocket so that can call on methods
+class WebSocketClientMock
+  attr_reader :sent, :closed, :code, :reason
+
+  def send(event)
+    @sent = @sent.nil? ? event : (@sent.is_a?(Array) ? @sent << event : [@sent, event])
+  end
+
+  def close(code = nil, reason = nil)
+    @code = code
+    @reason = reason
+    @closed = true
+  end
+
+  def onclose=(block)
+    @close_block = block
+  end
+
+  def onclose(code, reason = nil)
+    @event = WebSocketEventMock.new(nil, code, reason)
+    @close_block.call(@event)
+  end
+
+  def onerror=(block)
+    @error_block = block
+  end
+
+  def onerror(data)
+    @event = WebSocketEventMock.new(data)
+    @error_block.call(@event)
+  end
+
+  def onmessage=(block)
+    @message_block = block
+  end
+
+  def onmessage(data)
+    @event = WebSocketEventMock.new(data)
+    @message_block.call(@event)
+  end
+end

data/spec/command/command_io_spec.rb

@@ -53,7 +53,7 @@ describe RightScale::CommandIO do
   end
 
   it 'should detect missing blocks' do
-    lambda { RightScale::CommandIO.instance.listen(@socket_port) }.should raise_error(RightScale::Exceptions::Argument)
+    lambda { RightScale::CommandIO.instance.listen(@socket_port) }.should raise_error(ArgumentError)
   end
 
   it 'should receive a command' do

data/spec/command/command_parser_spec.rb

@@ -25,7 +25,7 @@ require File.expand_path(File.join(File.dirname(__FILE__), '..', 'spec_helper'))
 describe RightScale::CommandParser do
 
   it 'should detect missing block' do
-    lambda { RightScale::CommandParser.new }.should raise_error(RightScale::Exceptions::Argument)
+    lambda { RightScale::CommandParser.new }.should raise_error(ArgumentError)
   end
 
   it 'should parse' do

data/spec/connectivity_checker_spec.rb

@@ -0,0 +1,83 @@
+#
+# Copyright (c) 2009-2013 RightScale Inc
+#
+# Permission is hereby granted, free of charge, to any person obtaining
+# a copy of this software and associated documentation files (the
+# "Software"), to deal in the Software without restriction, including
+# without limitation the rights to use, copy, modify, merge, publish,
+# distribute, sublicense, and/or sell copies of the Software, and to
+# permit persons to whom the Software is furnished to do so, subject to
+# the following conditions:
+#
+# The above copyright notice and this permission notice shall be
+# included in all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+# NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+# LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+# OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+# WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+
+require File.expand_path(File.join(File.dirname(__FILE__), 'spec_helper'))
+
+describe RightScale::ConnectivityChecker do
+
+  include FlexMock::ArgumentTypes
+
+  #describe "and checking connection status" do
+  #  before(:each) do
+  #    @broker_id = "rs-broker-host-123"
+  #    @broker_ids = [@broker_id]
+  #  end
+  #
+  #  it "should not check connection if check already in progress" do
+  #    flexmock(EM::Timer).should_receive(:new).and_return(@timer).never
+  #    @instance.connectivity_checker.ping_timer = true
+  #    flexmock(@instance).should_receive(:publish).never
+  #    @instance.connectivity_checker.check(@broker_ids)
+  #  end
+  #
+  #  it "should publish ping to router" do
+  #    flexmock(EM::Timer).should_receive(:new).and_return(@timer).once
+  #    flexmock(@instance).should_receive(:publish).with(on { |request| request.type.should == "/router/ping" },
+  #                                                      @broker_ids).and_return(@broker_ids).once
+  #    @instance.connectivity_checker.check(@broker_id)
+  #    @instance.pending_requests.size.should == 1
+  #  end
+  #
+  #  it "should not make any connection changes if receive ping response" do
+  #    flexmock(RightScale::AgentIdentity).should_receive(:generate).and_return('abc').once
+  #    @timer.should_receive(:cancel).once
+  #    flexmock(EM::Timer).should_receive(:new).and_return(@timer).once
+  #    flexmock(@instance).should_receive(:publish).and_return(@broker_ids).once
+  #    @instance.connectivity_checker.check(@broker_id)
+  #    @instance.connectivity_checker.ping_timer.should == @timer
+  #    @instance.pending_requests.size.should == 1
+  #    @instance.pending_requests['abc'].response_handler.call(nil)
+  #    @instance.connectivity_checker.ping_timer.should == nil
+  #  end
+  #
+  #  it "should try to reconnect if ping times out repeatedly" do
+  #    @log.should_receive(:warning).with(/timed out after 30 seconds/).twice
+  #    @log.should_receive(:error).with(/reached maximum of 3 timeouts/).once
+  #    flexmock(EM::Timer).should_receive(:new).and_yield.times(3)
+  #    flexmock(@agent).should_receive(:connect).once
+  #    @instance.connectivity_checker.check(@broker_id)
+  #    @instance.connectivity_checker.check(@broker_id)
+  #    @instance.connectivity_checker.check(@broker_id)
+  #    @instance.connectivity_checker.ping_timer.should == nil
+  #  end
+  #
+  #  it "should log error if attempt to reconnect fails" do
+  #    @log.should_receive(:warning).with(/timed out after 30 seconds/).twice
+  #    @log.should_receive(:error).with(/Failed to reconnect/, Exception, :trace).once
+  #    flexmock(@agent).should_receive(:connect).and_raise(Exception)
+  #    flexmock(EM::Timer).should_receive(:new).and_yield.times(3)
+  #    @instance.connectivity_checker.check(@broker_id)
+  #    @instance.connectivity_checker.check(@broker_id)
+  #    @instance.connectivity_checker.check(@broker_id)
+  #  end
+  #end
+end

data/spec/dispatcher_spec.rb

@@ -89,7 +89,7 @@ describe "RightScale::Dispatcher" do
     @registry = RightScale::ActorRegistry.new
     @registry.register(@actor, nil)
     @agent_id = "rs-agent-1-1"
-    @agent = flexmock("Agent", :identity => @agent_id, :registry => @registry).by_default
+    @agent = flexmock("Agent", :identity => @agent_id, :registry => @registry, :exception_callback => nil).by_default
     @cache = RightScale::DispatchedCache.new(@agent_id)
     @dispatcher = RightScale::Dispatcher.new(@agent, @cache)
   end
@@ -218,7 +218,8 @@ describe "RightScale::Dispatcher" do
       flexmock(Time).should_receive(:now).and_return(Time.at(1000000)).by_default
       @log.should_receive(:info).once.with(on {|arg| arg =~ /REJECT EXPIRED/})
       @dispatcher = RightScale::Dispatcher.new(@agent, @cache)
-      req = RightScale::Request.new('/foo/bar', 'you', {:reply_to => "rs-mapper-1-1", :expires_at => @now.to_i + 8}, [12, 13])
+      req = RightScale::Request.new('/foo/bar', 'you', {:reply_to => "rs-router-1-1", :expires_at => @now.to_i + 8},
+                                    [version_cannot_handle_non_delivery_result, RightScale::AgentConfig.protocol_version])
       flexmock(Time).should_receive(:now).and_return(@now += 10)
       res = @dispatcher.dispatch(req)
       res.results.error?.should be_true

data/spec/enrollment_result_spec.rb

@@ -15,7 +15,7 @@ require File.expand_path(File.join(File.dirname(__FILE__), '..' , 'lib', 'right_
 describe RightScale::EnrollmentResult do
   before(:each) do
     @key = 'topsecret'
-    @result = RightScale::EnrollmentResult.new(6, Time.now, 'mapper cert', 'my cert', 'my private key', @key)
+    @result = RightScale::EnrollmentResult.new(6, Time.now, 'router cert', 'my cert', 'my private key', @key)
     @message  = RightScale::EnrollmentResult.dump(@result)
   end
 
@@ -27,7 +27,7 @@ describe RightScale::EnrollmentResult do
   context "supporting different versions" do
     RightScale::EnrollmentResult::SUPPORTED_VERSIONS.each do |v|
       it "should support version #{v}" do
-        @result = RightScale::EnrollmentResult.new(v, Time.now, 'mapper cert', 'my cert', 'my private key', @key)
+        @result = RightScale::EnrollmentResult.new(v, Time.now, 'router cert', 'my cert', 'my private key', @key)
         serialized = RightScale::EnrollmentResult.dump(@result)
         @result2 = RightScale::EnrollmentResult.load(serialized, @key)
         @result.should == @result2

data/spec/history_spec.rb

@@ -25,19 +25,11 @@ require 'tmpdir'
 
 describe RightScale::History do
 
-  # Mock Time.now with well-defined interval
-  def mock_time(size = 20, interval = 10)
-    now = Time.at(1000000)
-    list = []
-    size.times { list << (now += interval) }
-    flexmock(Time).should_receive(:now).and_return(*list)
-  end
-
   before(:each) do
     @identity = "rs-agent-1-1"
     @pid = Process.pid
-    @now = Time.at(1000000)
-    flexmock(Time).should_receive(:now).and_return(@now).by_default
+    now = Time.at(1000000)
+    flexmock(Time).should_receive(:now).and_return { now += 10 }
     FileUtils.mkdir_p(@test_dir = File.join(RightScale::Platform.filesystem.temp_dir, 'history_test'))
     RightScale::AgentConfig.pid_dir = @test_dir
     @history = RightScale::History.new(@identity)
@@ -51,15 +43,14 @@ describe RightScale::History do
 
     it "should store event in history file" do
       @history.update("some event").should be_true
-      @history.load.should == [{"time" => 1000000, "pid" => @pid, "event" => "some event"}]
+      @history.load.should == [{"time" => 1000010, "pid" => @pid, "event" => "some event"}]
     end
 
     it "should store event in history file following previous event" do
       @history.update("some event").should be_true
-      flexmock(Time).should_receive(:now).and_return(@now += 10)
       @history.update("another event").should be_true
-      @history.load.should == [{"time" => 1000000, "pid" => @pid, "event" => "some event"},
-                                          {"time" => 1000010, "pid" => @pid, "event" => "another event"}]
+      @history.load.should == [{"time" => 1000010, "pid" => @pid, "event" => "some event"},
+                               {"time" => 1000020, "pid" => @pid, "event" => "another event"}]
     end
 
   end
@@ -72,7 +63,7 @@ describe RightScale::History do
 
     it "should load events from history file" do
       @history.update("some event").should be_true
-      @history.load.should == [{"time" => 1000000, "pid" => @pid, "event" => "some event"}]
+      @history.load.should == [{"time" => 1000010, "pid" => @pid, "event" => "some event"}]
     end
 
   end
@@ -84,29 +75,27 @@ describe RightScale::History do
     end
 
     it "should indicate no uptime if not yet running" do
-      mock_time
       @history.update("start")
       @history.analyze_service.should == {:uptime => 0, :total_uptime => 0}
     end
 
     it "should measure uptime starting from last run time" do
-      mock_time
       @history.update("start")
       @history.update("run")
       @history.analyze_service.should == {:uptime => 10, :total_uptime => 10}
     end
 
-    it "should not count initial start as a restart" do
-      @history.update("start")
-      @history.update("run")
-      @history.analyze_service.should == {:uptime => 0, :total_uptime => 0}
-    end
-
     it "should count restarts" do
       @history.update("start")
       @history.update("stop")
       @history.update("start")
-      @history.analyze_service.should == {:uptime => 0, :total_uptime => 0, :restarts => 1, :graceful_exits => 0}
+      @history.analyze_service[:restarts].should == 1
+    end
+
+    it "should not count initial start as a restart" do
+      @history.update("start")
+      @history.update("run")
+      @history.analyze_service[:restarts].should be_nil
     end
 
     it "should ignore repeated stops when counting restarts" do
@@ -114,7 +103,7 @@ describe RightScale::History do
       @history.update("stop")
       @history.update("stop")
       @history.update("start")
-      @history.analyze_service.should == {:uptime => 0, :total_uptime => 0, :restarts => 1, :graceful_exits => 0}
+      @history.analyze_service[:restarts].should == 1
     end
 
     it "should record number of graceful exits if there are restarts" do
@@ -130,11 +119,11 @@ describe RightScale::History do
       @history.update("graceful exit")
       @history.update("start")
       @history.update("run")
-      @history.analyze_service.should == {:uptime => 0, :total_uptime => 0, :restarts => 3, :graceful_exits => 2}
+      @history.analyze_service[:graceful_exits].should == 2
+      @history.analyze_service[:restarts].should == 3
     end
 
     it "should measure total uptime across restarts and include current uptime" do
-      mock_time
       @history.update("start")
       @history.update("run")
       @history.update("stop")
@@ -153,18 +142,41 @@ describe RightScale::History do
     it "should count crashes" do
       @history.update("start")
       @history.update("start")
-      @history.analyze_service.should == {:uptime => 0, :total_uptime => 0, :crashes => 1, :last_crash_time => 1000000}
+      @history.analyze_service[:crashes].should == 1
+      @history.analyze_service[:last_crash_time].should == 1000020
+      @history.analyze_service[:crashed_last].should be_true
     end
 
     it "should record last crash age if there are crashes" do
-      mock_time
       @history.update("start")
       @history.update("start")
-      @history.analyze_service.should == {:uptime => 0, :total_uptime => 0, :crashes => 1, :last_crash_time => 1000020}
+      @history.analyze_service[:crashed_last].should be_true
+    end
+
+    it "should determine whether crashed last time was started" do
+      @history.update("start")
+      @history.update("start")
+      @history.analyze_service[:crashed_last].should be_true
+      @history.update("run")
+      @history.analyze_service[:crashed_last].should be_true
+      @history.update("stop")
+      @history.analyze_service[:crashed_last].should be_false
+      @history.update("start")
+      @history.analyze_service[:crashed_last].should be_false
+      @history.update("stop")
+      @history.update("start")
+      @history.analyze_service[:crashed_last].should be_false
+      @history.update("run")
+      @history.update("stop")
+      @history.update("graceful exit")
+      @history.analyze_service[:crashed_last].should be_false
+      @history.update("start")
+      @history.analyze_service[:crashed_last].should be_false
+      @history.update("start")
+      @history.analyze_service[:crashed_last].should be_true
     end
 
     it "should count restarts and crashes" do
-      mock_time
       @history.update("start")
       @history.update("run")
       @history.update("stop")
@@ -180,8 +192,10 @@ describe RightScale::History do
       @history.update("run")
       @history.update("start")
       @history.update("run")
-      @history.analyze_service.should == {:uptime => 10, :total_uptime => 40, :restarts => 3, :graceful_exits => 2,
-                                          :crashes => 2, :last_crash_time => 1000140}
+      @history.analyze_service[:crashes].should == 2
+      @history.analyze_service[:restarts].should == 3
+      @history.analyze_service[:last_crash_time].should == 1000140
+      @history.analyze_service[:crashed_last].should be_true
     end
 
     it "should ignore unrecognized events" do
@@ -195,7 +209,6 @@ describe RightScale::History do
     end
 
     it "should not re-analyze if there are no new events" do
-      mock_time
       @history.update("start")
       @history.update("run")
       @history.analyze_service.should == {:uptime => 10, :total_uptime => 10}
@@ -204,7 +217,6 @@ describe RightScale::History do
     end
 
     it "should update uptime and total_uptime even if do not do re-analyze" do
-      mock_time
       @history.update("start")
       @history.update("run")
       @history.update("start")
@@ -214,19 +226,19 @@ describe RightScale::History do
       @history.update("start")
       @history.update("run")
       @history.analyze_service.should == {:uptime => 10, :total_uptime => 30, :restarts => 1, :graceful_exits => 1,
-                                          :crashes => 1, :last_crash_time => 1000030}
+                                          :crashes => 1, :last_crash_time => 1000030, :crashed_last => false}
       @history.analyze_service.should == {:uptime => 20, :total_uptime => 40, :restarts => 1, :graceful_exits => 1,
-                                          :crashes => 1, :last_crash_time => 1000030}
+                                          :crashes => 1, :last_crash_time => 1000030, :crashed_last => false}
     end
 
     it "should re-analyze if there was a new event since last analysis" do
-      mock_time
       @history.update("start")
       @history.update("run")
       @history.analyze_service.should == {:uptime => 10, :total_uptime => 10}
       @history.instance_variable_set(:@pid, -1) # Simulate new process id following crash
       @history.update("start")
-      @history.analyze_service.should == {:uptime => 0, :total_uptime => 20, :crashes => 1, :last_crash_time => 1000040}
+      @history.analyze_service.should == {:uptime => 0, :total_uptime => 20, :crashes => 1, :last_crash_time => 1000040,
+                                          :crashed_last => true}
     end
 
   end