right_agent 0.14.0 → 0.16.2

data/spec/core_payload_types/recipe_instantiation_spec.rb

@@ -0,0 +1,81 @@
+#--  -*- mode: ruby; encoding: utf-8 -*-
+# Copyright: Copyright (c) 2009-2013 RightScale, Inc.
+#
+# Permission is hereby granted, free of charge, to any person obtaining
+# a copy of this software and associated documentation files (the
+# 'Software'), to deal in the Software without restriction, including
+# without limitation the rights to use, copy, modify, merge, publish,
+# distribute, sublicense, and/or sell copies of the Software, and to
+# permit persons to whom the Software is furnished to do so, subject to
+# the following conditions:
+#
+# The above copyright notice and this permission notice shall be
+# included in all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED 'AS IS', WITHOUT WARRANTY OF ANY KIND,
+# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
+# IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
+# CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
+# TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
+# SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+#++
+
+require File.expand_path(File.join(File.dirname(__FILE__), '..', 'spec_helper'))
+require File.expand_path(File.join(File.dirname(__FILE__), '..', '..', 'lib', 'right_agent', 'core_payload_types'))
+
+module RightScale
+  describe RecipeInstantiation do
+    let(:nickname)   { 'foo' }
+    let(:attributes) do
+      {
+        'rightscale' => {
+          'instance_uuid' => '123-abc',
+          'servers' => {
+            'sketchy' => {
+              'hostname' => 'sketchy123.sketchy.com',
+              'identifier' => '123-abc'
+            },
+            'lumberjack' => {
+              'hostname' => 'syslog123.lumberjack.com',
+              'identifier' => '123-abc'
+            }
+          }
+        }
+      }
+    end
+    let(:id)              { 123 }
+    let(:ready)           { true }
+    let(:external_inputs) { {} }
+    let(:input_flags)     { {} }
+
+    context 'given all fields' do
+      subject do
+        described_class.new(
+          nickname, attributes, id, ready, external_inputs, input_flags)
+      end
+
+      its(:title) { should == nickname }
+      its(:nickname) { should == nickname }
+      its(:attributes) { should == attributes }
+      its(:id) { should == id }
+      its(:ready) { should == ready }
+      its(:external_inputs) { should == external_inputs }
+      its(:input_flags) { should == input_flags }
+    end
+
+    context 'given minimal fields' do
+      subject do
+        described_class.new(nickname, attributes, id, ready)
+      end
+
+      its(:title) { should == nickname }
+      its(:nickname) { should == nickname }
+      its(:attributes) { should == attributes }
+      its(:id) { should == id }
+      its(:ready) { should == ready }
+      its(:external_inputs) { should == nil }
+      its(:input_flags) { should == nil }
+    end
+  end
+end

data/spec/core_payload_types/right_script_instantiation_spec.rb

@@ -0,0 +1,79 @@
+#--  -*- mode: ruby; encoding: utf-8 -*-
+# Copyright: Copyright (c) 2009-2013 RightScale, Inc.
+#
+# Permission is hereby granted, free of charge, to any person obtaining
+# a copy of this software and associated documentation files (the
+# 'Software'), to deal in the Software without restriction, including
+# without limitation the rights to use, copy, modify, merge, publish,
+# distribute, sublicense, and/or sell copies of the Software, and to
+# permit persons to whom the Software is furnished to do so, subject to
+# the following conditions:
+#
+# The above copyright notice and this permission notice shall be
+# included in all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED 'AS IS', WITHOUT WARRANTY OF ANY KIND,
+# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
+# IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
+# CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
+# TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
+# SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+#++
+
+require File.expand_path(File.join(File.dirname(__FILE__), '..', 'spec_helper'))
+require File.expand_path(File.join(File.dirname(__FILE__), '..', '..', 'lib', 'right_agent', 'core_payload_types'))
+
+module RightScale
+  describe RightScriptInstantiation do
+    let(:nickname)        { 'foo' }
+    let(:source)          { "echo 'hello world'" }
+    let(:parameters)      { { 'ADMIN_PASSWORD' => 'clandestine' } }
+    let(:attachments)     { [] }
+    let(:packages)        { '' }
+    let(:id)              { 123 }
+    let(:ready)           { true }
+    let(:external_inputs) { {} }
+    let(:input_flags)     { {} }
+    let(:display_version) { 'HEAD' }
+
+    context 'given all fields' do
+      subject do
+        described_class.new(
+          nickname, source, parameters, attachments, packages, id, ready,
+          external_inputs, input_flags, display_version)
+      end
+
+      its(:title) { should == "'#{nickname}' #{display_version}" }
+      its(:nickname) { should == nickname }
+      its(:source) { should == source }
+      its(:parameters) { should == parameters }
+      its(:attachments) { should == attachments }
+      its(:packages) { should == packages }
+      its(:id) { should == id }
+      its(:ready) { should == ready }
+      its(:external_inputs) { should == external_inputs }
+      its(:input_flags) { should == input_flags }
+      its(:display_version) { should == display_version }
+    end
+
+    context 'given minimal fields' do
+      subject do
+        described_class.new(
+          nickname, source, parameters, attachments, packages, id, ready)
+      end
+
+      its(:title) { should == nickname }
+      its(:nickname) { should == nickname }
+      its(:source) { should == source }
+      its(:parameters) { should == parameters }
+      its(:attachments) { should == attachments }
+      its(:packages) { should == packages }
+      its(:id) { should == id }
+      its(:ready) { should == ready }
+      its(:external_inputs) { should be_nil }
+      its(:input_flags) { should be_nil }
+      its(:display_version) { should be_nil }
+    end
+  end
+end

data/spec/security/cached_certificate_store_proxy_spec.rb

@@ -1,5 +1,5 @@
 #
-# Copyright (c) 2009-2011 RightScale Inc
+# Copyright (c) 2009-2013 RightScale Inc
 #
 # Permission is hereby granted, free of charge, to any person obtaining
 # a copy of this software and associated documentation files (the
@@ -27,30 +27,36 @@ describe RightScale::CachedCertificateStoreProxy do
   include RightScale::SpecHelper
 
   before(:all) do
+    @cert, @key = issue_cert
     @signer, key = issue_cert
-    @recipient, key = issue_cert
+    @target, key = issue_cert
     @store = flexmock("Store")
     @proxy = RightScale::CachedCertificateStoreProxy.new(@store)
   end
 
   it 'should not raise and return nil for non existent certificates' do
     res = nil
-    @store.should_receive(:get_recipients).with(nil).and_return(nil)
-    lambda { res = @proxy.get_recipients(nil) }.should_not raise_error
+    @store.should_receive(:get_target).with(nil).and_return(nil)
+    lambda { res = @proxy.get_target(nil) }.should_not raise_error
     res.should == nil
     @store.should_receive(:get_signer).with(nil).and_return(nil)
     lambda { res = @proxy.get_signer(nil) }.should_not raise_error
     res.should == nil
   end
 
-  it 'should return recipient certificates' do
-    @store.should_receive(:get_recipients).with('anything').and_return(@recipient)
-    @proxy.get_recipients('anything').should == @recipient
+  it 'should return target certificates' do
+    @store.should_receive(:get_target).with('anything').and_return(@target)
+    @proxy.get_target('anything').should == @target
   end
   
   it 'should return signer certificates' do
     @store.should_receive(:get_signer).with('anything').and_return(@signer)
     @proxy.get_signer('anything').should == @signer
   end
-  
+
+  it 'should return receiver certificate and key' do
+    @store.should_receive(:get_receiver).with('anything').and_return([@cert, @key])
+    @proxy.get_receiver('anything').should == [@cert, @key]
+  end
+
 end

data/spec/security/static_certificate_store_spec.rb

@@ -1,5 +1,5 @@
 #
-# Copyright (c) 2009-2011 RightScale Inc
+# Copyright (c) 2009-2013 RightScale Inc
 #
 # Permission is hereby granted, free of charge, to any person obtaining
 # a copy of this software and associated documentation files (the
@@ -28,25 +28,31 @@ describe RightScale::StaticCertificateStore do
 
   before(:all) do
     @signer, key = issue_cert
-    @recipient, key = issue_cert
+    @target, key = issue_cert
     @cert, @key = issue_cert
-    @store = RightScale::StaticCertificateStore.new(@signer, @recipient)
+    @store = RightScale::StaticCertificateStore.new(@cert, @key, @signer, @target)
   end
 
   it 'should not raise when passed nil objects' do
     res = nil
     lambda { res = @store.get_signer(nil) }.should_not raise_error
     res.should == [ @signer ]
-    lambda { res = @store.get_recipients(nil) }.should_not raise_error
-    res.should == [ @recipient ]
+    lambda { res = @store.get_target(nil) }.should_not raise_error
+    res.should == [ @target ]
+    lambda { res = @store.get_receiver(nil) }.should_not raise_error
+    res.should == [ @cert, @key ]
   end
 
   it 'should return signer certificates' do
     @store.get_signer('anything').should == [ @signer ]
   end
 
-  it 'should return recipient certificates' do
-    @store.get_recipients('anything').should == [ @recipient ]
+  it 'should return target certificates' do
+    @store.get_target('anything').should == [ @target ]
+  end
+
+  it 'should return certificate and key for decrypting' do
+    @store.get_receiver('anything').should == [ @cert, @key ]
   end
   
 end

data/spec/sender_spec.rb

@@ -508,7 +508,7 @@ describe RightScale::Sender do
     before(:each) do
       @timer = flexmock("timer")
       flexmock(EM::Timer).should_receive(:new).and_return(@timer).by_default
-      @broker_id = "broker"
+      @broker_id = "rs-broker-host-123"
       @broker_ids = [@broker_id]
       @broker = flexmock("Broker", :subscribe => true, :publish => @broker_ids, :connected? => true,
                          :all => @broker_ids, :identity_parts => ["host", 123, 0, 0]).by_default
@@ -520,7 +520,7 @@ describe RightScale::Sender do
     end
 
     it "should validate target" do
-      @broker.should_receive(:publish)
+      @broker.should_receive(:publish).and_return(@broker_ids).once
       flexmock(@instance).should_receive(:validate_target).with("target", false).once
       @instance.send_retryable_request('/foo/bar', nil, "target") {_}.should be_true
     end
@@ -528,7 +528,7 @@ describe RightScale::Sender do
     it "should create a Request object" do
       @broker.should_receive(:publish).with(hsh(:name => "request"), on do |request|
         request.class.should == RightScale::Request
-      end, hsh(:persistent => false, :mandatory => true)).once
+      end, hsh(:persistent => false, :mandatory => true)).and_return(@broker_ids).once
       @instance.send_retryable_request('/welcome/aboard', 'iZac') {|_|}
     end
 
@@ -541,7 +541,7 @@ describe RightScale::Sender do
         request.from.should == 'agent'
         request.target.should be_nil
         request.expires_at.should == 1000100
-      end, hsh(:persistent => false, :mandatory => true)).once
+      end, hsh(:persistent => false, :mandatory => true)).and_return(@broker_ids).once
       @instance.send_retryable_request('/welcome/aboard', 'iZac') {|_|}
     end
 
@@ -553,14 +553,14 @@ describe RightScale::Sender do
       flexmock(Time).should_receive(:now).and_return(Time.at(1000000))
       @broker.should_receive(:publish).with(hsh(:name => "request"), on do |request|
         request.expires_at.should == 0
-      end, hsh(:persistent => false, :mandatory => true)).once
+      end, hsh(:persistent => false, :mandatory => true)).and_return(@broker_ids).once
       @instance.send_retryable_request('/welcome/aboard', 'iZac') {|_|}
     end
 
     it "should set the correct target if specified" do
       @broker.should_receive(:publish).with(hsh(:name => "request"), on do |request|
         request.target.should == 'my-target'
-      end, hsh(:persistent => false, :mandatory => true)).once
+      end, hsh(:persistent => false, :mandatory => true)).and_return(@broker_ids).once
       @instance.send_retryable_request('/welcome/aboard', 'iZac', 'my-target') {|_|}
     end
 
@@ -569,7 +569,7 @@ describe RightScale::Sender do
         request.tags.should == ['tag']
         request.selector.should == :any
         request.scope.should == {:account => 123}
-      end, hsh(:persistent => false, :mandatory => true)).once
+      end, hsh(:persistent => false, :mandatory => true)).and_return(@broker_ids).once
       @instance.send_retryable_request('/welcome/aboard', 'iZac', :tags => ['tag'], :scope => {:account => 123}) {|_|}
     end
 
@@ -643,7 +643,7 @@ describe RightScale::Sender do
         @agent.should_receive(:options).and_return({:retry_timeout => nil})
         RightScale::Sender.new(@agent)
         @instance = RightScale::Sender.instance
-        @broker.should_receive(:publish).once
+        @broker.should_receive(:publish).and_return(@broker_ids).once
         @instance.send_retryable_request('/welcome/aboard', 'iZac') {|_|}
       end
 
@@ -652,7 +652,7 @@ describe RightScale::Sender do
         @agent.should_receive(:options).and_return({:retry_interval => nil})
         RightScale::Sender.new(@agent)
         @instance = RightScale::Sender.instance
-        @broker.should_receive(:publish).once
+        @broker.should_receive(:publish).and_return(@broker_ids).once
         @instance.send_retryable_request('/welcome/aboard', 'iZac') {|_|}
       end
 
@@ -661,8 +661,11 @@ describe RightScale::Sender do
         @agent.should_receive(:options).and_return({:retry_timeout => 60, :retry_interval => 60})
         RightScale::Sender.new(@agent)
         @instance = RightScale::Sender.instance
-        @broker.should_receive(:publish).and_return([]).once
-        @instance.send_retryable_request('/welcome/aboard', 'iZac') {|_|}
+        @broker.should_receive(:publish).and_raise(Exception).once
+        @log.should_receive(:error).with(/Failed to publish request/, Exception, :trace).once
+        lambda do
+          @instance.send_retryable_request('/welcome/aboard', 'iZac') {|_|}
+        end.should raise_error(RightScale::Sender::SendFailure)
       end
 
       it "should setup for retry if retry_timeout and retry_interval not nil and publish successful" do
@@ -674,10 +677,6 @@ describe RightScale::Sender do
         @instance.send_retryable_request('/welcome/aboard', 'iZac') {|_|}
       end
 
-      it "should adjust retry interval by recent request duration" do
-
-      end
-
       it "should succeed after retrying once" do
         EM.run do
           token = 'abc'
@@ -704,6 +703,78 @@ describe RightScale::Sender do
         end
       end
 
+      it "should respond with retry if publish fails with no brokers when retrying" do
+        EM.run do
+          token = 'abc'
+          result = RightScale::OperationResult.non_delivery(RightScale::OperationResult::RETRY_TIMEOUT)
+          flexmock(RightScale::AgentIdentity).should_receive(:generate).and_return(token).twice
+          @agent.should_receive(:options).and_return({:retry_timeout => 0.3, :retry_interval => 0.1})
+          RightScale::Sender.new(@agent)
+          @instance = RightScale::Sender.instance
+          flexmock(@instance.connectivity_checker).should_receive(:check).never
+          @broker.should_receive(:publish).and_return(@broker_ids).ordered.once
+          @broker.should_receive(:publish).and_raise(RightAMQP::HABrokerClient::NoConnectedBrokers).ordered.once
+          @log.should_receive(:error).with(/Failed to publish request/, RightAMQP::HABrokerClient::NoConnectedBrokers).once
+          @log.should_receive(:error).with(/Failed retry for.*temporarily offline/).once
+          @instance.send_retryable_request('/welcome/aboard', 'iZac') do |response|
+            result = RightScale::OperationResult.from_results(response)
+            result.retry?.should be_true
+            result.content.should == "lost connectivity"
+          end
+          EM.add_timer(0.15) do
+            EM.stop
+            result.retry?.should be_true
+            @instance.pending_requests.empty?.should be_true
+          end
+        end
+      end
+
+      it "should respond with non-delivery if publish fails in unknown way when retrying" do
+        EM.run do
+          token = 'abc'
+          result = RightScale::OperationResult.non_delivery(RightScale::OperationResult::RETRY_TIMEOUT)
+          flexmock(RightScale::AgentIdentity).should_receive(:generate).and_return(token).twice
+          @agent.should_receive(:options).and_return({:retry_timeout => 0.3, :retry_interval => 0.1})
+          RightScale::Sender.new(@agent)
+          @instance = RightScale::Sender.instance
+          flexmock(@instance.connectivity_checker).should_receive(:check).never
+          @broker.should_receive(:publish).and_return(@broker_ids).ordered.once
+          @broker.should_receive(:publish).and_raise(Exception.new).ordered.once
+          @log.should_receive(:error).with(/Failed to publish request/, Exception, :trace).once
+          @log.should_receive(:error).with(/Failed retry for.*send failure/).once
+          @instance.send_retryable_request('/welcome/aboard', 'iZac') do |response|
+            result = RightScale::OperationResult.from_results(response)
+            result.non_delivery?.should be_true
+            result.content.should == "retry failed"
+          end
+          EM.add_timer(0.15) do
+            EM.stop
+            result.non_delivery?.should be_true
+            @instance.pending_requests.empty?.should be_true
+          end
+        end
+      end
+
+      it "should not respond if retry mechanism fails in unknown way" do
+        EM.run do
+          token = 'abc'
+          result = nil
+          flexmock(RightScale::AgentIdentity).should_receive(:generate).and_return(token).twice
+          @agent.should_receive(:options).and_return({:retry_timeout => 0.3, :retry_interval => 0.1})
+          RightScale::Sender.new(@agent)
+          @instance = RightScale::Sender.instance
+          flexmock(@instance.connectivity_checker).should_receive(:check).and_raise(Exception).once
+          @broker.should_receive(:publish).and_return(@broker_ids).twice
+          @log.should_receive(:error).with(/Failed retry for.*without responding/, Exception, :trace).once
+          @instance.send_retryable_request('/welcome/aboard', 'iZac') {_}
+          EM.add_timer(0.15) do
+            EM.stop
+            result.should be_nil
+            @instance.pending_requests.empty?.should be_false
+          end
+        end
+      end
+
       it "should timeout after retrying twice" do
         pending 'Too difficult to get timing right for Windows' if RightScale::Platform.windows?
         EM.run do
@@ -727,6 +798,32 @@ describe RightScale::Sender do
         end
       end
 
+      it "should return non-delivery after timeout if any attempt failed due to non-delivery" do
+        pending 'Too difficult to get timing right for Windows' if RightScale::Platform.windows?
+        EM.run do
+          result = RightScale::OperationResult.success
+          @log.should_receive(:warning).once
+          @agent.should_receive(:options).and_return({:retry_timeout => 0.6, :retry_interval => 0.1})
+          RightScale::Sender.new(@agent)
+          @instance = RightScale::Sender.instance
+          flexmock(@instance.connectivity_checker).should_receive(:check).once
+          @broker.should_receive(:publish).and_return(@broker_ids).times(3)
+          @instance.send_retryable_request('/welcome/aboard', 'iZac') do |response|
+            result = RightScale::OperationResult.from_results(response)
+          end
+          @instance.pending_requests.empty?.should be_false
+          token = @instance.pending_requests.keys.last
+          non_delivery = RightScale::OperationResult.non_delivery(RightScale::OperationResult::TTL_EXPIRATION)
+          @instance.handle_response(RightScale::Result.new(token, 'iZac', non_delivery, "from"))
+          EM.add_timer(1) do
+            EM.stop
+            result.non_delivery?.should be_true
+            result.content.should == non_delivery.content
+            @instance.pending_requests.empty?.should be_true
+          end
+        end
+      end
+
       it "should retry with same request expires_at value" do
         EM.run do
           token = 'abc'
@@ -746,7 +843,7 @@ describe RightScale::Sender do
 
       describe "and checking connection status" do
         before(:each) do
-          @broker_id = "broker"
+          @broker_id = "rs-broker-host-123"
           @broker_ids = [@broker_id]
         end
 
@@ -805,7 +902,7 @@ describe RightScale::Sender do
     before(:each) do
       @timer = flexmock("timer")
       flexmock(EM::Timer).should_receive(:new).and_return(@timer).by_default
-      @broker_id = "broker"
+      @broker_id = "rs-broker-host-123"
       @broker_ids = [@broker_id]
       @broker = flexmock("Broker", :subscribe => true, :publish => @broker_ids, :connected? => true,
                          :identity_parts => ["host", 123, 0, 0]).by_default