right_agent 0.10.13 → 0.13.5

data/spec/history_spec.rb

@@ -0,0 +1,234 @@
+#
+# Copyright (c) 2009-2011 RightScale Inc
+#
+# Permission is hereby granted, free of charge, to any person obtaining
+# a copy of this software and associated documentation files (the
+# "Software"), to deal in the Software without restriction, including
+# without limitation the rights to use, copy, modify, merge, publish,
+# distribute, sublicense, and/or sell copies of the Software, and to
+# permit persons to whom the Software is furnished to do so, subject to
+# the following conditions:
+#
+# The above copyright notice and this permission notice shall be
+# included in all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+# NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+# LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+# OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+# WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+
+require File.expand_path(File.join(File.dirname(__FILE__), 'spec_helper'))
+require 'tmpdir'
+
+describe RightScale::History do
+
+  # Mock Time.now with well-defined interval
+  def mock_time(size = 20, interval = 10)
+    now = Time.at(1000000)
+    list = []
+    size.times { list << (now += interval) }
+    flexmock(Time).should_receive(:now).and_return(*list)
+  end
+
+  before(:each) do
+    @identity = "rs-agent-1-1"
+    @pid = Process.pid
+    @now = Time.at(1000000)
+    flexmock(Time).should_receive(:now).and_return(@now).by_default
+    FileUtils.mkdir_p(@test_dir = File.join(RightScale::Platform.filesystem.temp_dir, 'history_test'))
+    RightScale::AgentConfig.pid_dir = @test_dir
+    @history = RightScale::History.new(@identity)
+  end
+
+  after(:each) do
+    FileUtils.remove_dir(@test_dir)
+  end
+
+  describe "update" do
+
+    it "should store event in history file" do
+      @history.update("some event").should be_true
+      @history.load.should == [{"time" => 1000000, "pid" => @pid, "event" => "some event"}]
+    end
+
+    it "should store event in history file following previous event" do
+      @history.update("some event").should be_true
+      flexmock(Time).should_receive(:now).and_return(@now += 10)
+      @history.update("another event").should be_true
+      @history.load.should == [{"time" => 1000000, "pid" => @pid, "event" => "some event"},
+                                          {"time" => 1000010, "pid" => @pid, "event" => "another event"}]
+    end
+
+  end
+
+  describe "load" do
+
+    it "should load no events if there is no history" do
+      @history.load.should == []
+    end
+
+    it "should load events from history file" do
+      @history.update("some event").should be_true
+      @history.load.should == [{"time" => 1000000, "pid" => @pid, "event" => "some event"}]
+    end
+
+  end
+
+  describe "analyze_service" do
+
+    it "should indicate no uptime if history empty" do
+      @history.analyze_service.should == {:uptime => 0, :total_uptime => 0}
+    end
+
+    it "should indicate no uptime if not yet running" do
+      mock_time
+      @history.update("start")
+      @history.analyze_service.should == {:uptime => 0, :total_uptime => 0}
+    end
+
+    it "should measure uptime starting from last run time" do
+      mock_time
+      @history.update("start")
+      @history.update("run")
+      @history.analyze_service.should == {:uptime => 10, :total_uptime => 10}
+    end
+
+    it "should not count initial start as a restart" do
+      @history.update("start")
+      @history.update("run")
+      @history.analyze_service.should == {:uptime => 0, :total_uptime => 0}
+    end
+
+    it "should count restarts" do
+      @history.update("start")
+      @history.update("stop")
+      @history.update("start")
+      @history.analyze_service.should == {:uptime => 0, :total_uptime => 0, :restarts => 1, :graceful_exits => 0}
+    end
+
+    it "should ignore repeated stops when counting restarts" do
+      @history.update("start")
+      @history.update("stop")
+      @history.update("stop")
+      @history.update("start")
+      @history.analyze_service.should == {:uptime => 0, :total_uptime => 0, :restarts => 1, :graceful_exits => 0}
+    end
+
+    it "should record number of graceful exits if there are restarts" do
+      @history.update("start")
+      @history.update("run")
+      @history.update("stop")
+      @history.update("graceful exit")
+      @history.update("start")
+      @history.update("stop")
+      @history.update("start")
+      @history.update("run")
+      @history.update("stop")
+      @history.update("graceful exit")
+      @history.update("start")
+      @history.update("run")
+      @history.analyze_service.should == {:uptime => 0, :total_uptime => 0, :restarts => 3, :graceful_exits => 2}
+    end
+
+    it "should measure total uptime across restarts and include current uptime" do
+      mock_time
+      @history.update("start")
+      @history.update("run")
+      @history.update("stop")
+      @history.update("graceful exit")
+      @history.update("start")
+      @history.update("stop")
+      @history.update("start")
+      @history.update("run")
+      @history.update("stop")
+      @history.update("graceful exit")
+      @history.update("start")
+      @history.update("run")
+      @history.analyze_service.should == {:uptime => 10, :total_uptime => 30, :restarts => 3, :graceful_exits => 2}
+    end
+
+    it "should count crashes" do
+      @history.update("start")
+      @history.update("start")
+      @history.analyze_service.should == {:uptime => 0, :total_uptime => 0, :crashes => 1, :last_crash_time => 1000000}
+    end
+
+    it "should record last crash age if there are crashes" do
+      mock_time
+      @history.update("start")
+      @history.update("start")
+      @history.analyze_service.should == {:uptime => 0, :total_uptime => 0, :crashes => 1, :last_crash_time => 1000020}
+    end
+
+    it "should count restarts and crashes" do
+      mock_time
+      @history.update("start")
+      @history.update("run")
+      @history.update("stop")
+      @history.update("graceful exit")
+      @history.update("start")
+      @history.update("start")
+      @history.update("stop")
+      @history.update("start")
+      @history.update("run")
+      @history.update("stop")
+      @history.update("graceful exit")
+      @history.update("start")
+      @history.update("run")
+      @history.update("start")
+      @history.update("run")
+      @history.analyze_service.should == {:uptime => 10, :total_uptime => 40, :restarts => 3, :graceful_exits => 2,
+                                          :crashes => 2, :last_crash_time => 1000140}
+    end
+
+    it "should ignore unrecognized events" do
+      @history.update("other event")
+      @history.update("start")
+      @history.update("other event")
+      @history.update("stop")
+      @history.update("start")
+      @history.update("other event")
+      @history.analyze_service.should == {:uptime => 0, :total_uptime => 0, :restarts => 1, :graceful_exits => 0}
+    end
+
+    it "should not re-analyze if there are no new events" do
+      mock_time
+      @history.update("start")
+      @history.update("run")
+      @history.analyze_service.should == {:uptime => 10, :total_uptime => 10}
+      flexmock(@history).should_receive(:load).never
+      @history.analyze_service
+    end
+
+    it "should update uptime and total_uptime even if do not do re-analyze" do
+      mock_time
+      @history.update("start")
+      @history.update("run")
+      @history.update("start")
+      @history.update("run")
+      @history.update("stop")
+      @history.update("graceful exit")
+      @history.update("start")
+      @history.update("run")
+      @history.analyze_service.should == {:uptime => 10, :total_uptime => 30, :restarts => 1, :graceful_exits => 1,
+                                          :crashes => 1, :last_crash_time => 1000030}
+      @history.analyze_service.should == {:uptime => 20, :total_uptime => 40, :restarts => 1, :graceful_exits => 1,
+                                          :crashes => 1, :last_crash_time => 1000030}
+    end
+
+    it "should re-analyze if there was a new event since last analysis" do
+      mock_time
+      @history.update("start")
+      @history.update("run")
+      @history.analyze_service.should == {:uptime => 10, :total_uptime => 10}
+      @history.instance_variable_set(:@pid, -1) # Simulate new process id following crash
+      @history.update("start")
+      @history.analyze_service.should == {:uptime => 0, :total_uptime => 20, :crashes => 1, :last_crash_time => 1000040}
+    end
+
+  end
+
+end

data/spec/idempotent_request_spec.rb

@@ -26,7 +26,7 @@ describe RightScale::IdempotentRequest do
 
   module RightScale
     class SenderMock
-      include Singleton
+      include RightSupport::Ruby::EasySingleton
     end
   end
 

data/spec/log_spec.rb

@@ -40,6 +40,21 @@ describe RightScale::Log do
 
   before(:all) do
     ENV['RS_LOG'] = 'true'
+
+    class RightScale::Platform::Filesystem
+      alias original_log_dir log_dir
+      def log_dir
+        # For specs, write all logs to temp_dir
+        # since log_dir may not be writable
+        temp_dir
+      end
+    end
+  end
+
+  after(:all) do
+    class RightScale::Platform::Filesystem
+      alias log_dir original_log_dir
+    end
   end
 
   before(:each) do

data/spec/operation_result_spec.rb

@@ -40,7 +40,7 @@ describe RightScale::OperationResult do
       result = RightScale::OperationResult.from_results(@hash)
       result.kind_of?(RightScale::OperationResult).should be_true
       result.status_code.should == RightScale::OperationResult::SUCCESS
-      result.content.should == 1
+      result.content.should == @hash.values[0].content
     end
 
     it "should handle individual result and return it as an OperationResult" do
@@ -158,7 +158,9 @@ describe RightScale::OperationResult do
 
     it "should convert error content to string if necessary" do
       result = RightScale::OperationResult.error({"data" => "some data", "message" => "some problem"})
-      result.to_s.should == "error ({\"data\"=>\"some data\", \"message\"=>\"some problem\"})"
+      result.to_s.should start_with ("error (")
+      result.to_s.should include("\"data\"=>\"some data\"")
+      result.to_s.should include("\"message\"=>\"some problem\"")
     end
 
     it "should truncate error message if too long" do

data/spec/platform/darwin_spec.rb

@@ -0,0 +1,13 @@
+require File.expand_path(File.join(File.dirname(__FILE__), '..', 'spec_helper'))
+
+describe 'RightScale::Platform' do
+  subject { RightScale::Platform }
+
+  context 'under Darwin' do
+    context :installer do
+      context :install do
+        specify { lambda { subject.installer.install([]) }.should raise_exception }
+      end
+    end
+  end
+end if RightScale::Platform.darwin?

data/spec/platform/linux_spec.rb

@@ -0,0 +1,38 @@
+require File.expand_path(File.join(File.dirname(__FILE__), '..', 'spec_helper'))
+
+describe RightScale::Platform do
+  subject { RightScale::Platform }
+
+  context 'under Linux' do
+    context :installer do
+      context :install do
+        it 'should succeed if no packages are specified' do
+          packages = []
+          flexmock(subject.installer).should_receive(:run_installer_command).and_return('ok')
+          subject.installer.install(packages).should == true
+        end
+
+        it 'should succeed if all packages install successfully' do
+          packages = ['syslog-ng']
+          flexmock(subject.installer).should_receive(:run_installer_command).and_return('ok')
+          subject.installer.install(packages).should == true
+        end
+
+        it 'should fail if one more packages are not found' do
+          if subject.installer.yum?
+            failure_message = "No package l33th4x0r available."
+          elsif subject.installer.aptitude?
+            failure_message = "E: Couldn't find package l33th4x0r"
+          elsif subject.installer.zypper?
+            failure_message = "Package 'l33h4x0r' not found."
+          end
+          packages = ['syslog-ng', 'l33th4x0r']
+
+          flexmock(subject.installer).should_receive(:run_installer_command).and_return(failure_message)
+
+          lambda { subject.installer.install(packages) }.should raise_error
+        end
+      end
+    end
+  end
+end if RightScale::Platform.linux?

data/spec/platform/platform_spec.rb

@@ -21,64 +21,59 @@
 # WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 require File.expand_path(File.join(File.dirname(__FILE__), '..', 'spec_helper'))
-require File.expand_path(File.join(File.dirname(__FILE__), 'darwin')) if RightScale::Platform.darwin?
-require File.expand_path(File.join(File.dirname(__FILE__), 'windows')) if RightScale::Platform.windows?
-require File.expand_path(File.join(File.dirname(__FILE__), 'linux')) if RightScale::Platform.linux?
 
-module RightScale
-  describe Platform do
-    subject { RightScale::Platform }
-    
-    context :shell do
-      context :uptime do
-        it 'should be positive' do
-          subject.shell.uptime.should > 0
-        end
-  
-        it 'should be strictly increasing' do
-          u0 = subject.shell.uptime
-          sleep(1)
-          u1 = subject.shell.uptime
-          
-          (u1 - u0).should >= 0
-        end
+describe RightScale::Platform do
+  subject { RightScale::Platform }
+
+  context :shell do
+    context :uptime do
+      it 'should be positive' do
+        subject.shell.uptime.should > 0
       end
-  
-      context :booted_at do
-        it 'should be some time in the past' do
-          Time.at(subject.shell.booted_at).to_i.should < Time.now.to_i
-        end
-  
-        it 'should be constant' do
-          b0 = subject.shell.booted_at
-          sleep(1)
-          b1 = subject.shell.booted_at
-  
-          b0.should == b1
-        end
+
+      it 'should be strictly increasing' do
+        u0 = subject.shell.uptime
+        sleep(1)
+        u1 = subject.shell.uptime
+
+        (u1 - u0).should >= 0
       end
     end
 
-    context 'cloud-family queries' do
-      # PLEASE NOTE: we are unable to use the magic RSpec "subject" because
-      # we are dispatching calls to a Singleton and we must partially mock its
-      # calls, and both __send__ and flexmock partial-mocking gets confused by
-      # the fact that #subject returns a Proc, not the actual subject. Do not
-      # attempt to use the pretty RSpec feature within this context. You have
-      # been warned!
-      before(:each) do
-        @subject = subject.instance
-        @subject.instance_variable_set(:@ec2, nil)
-        @subject.instance_variable_set(:@rackspace, nil)
-        @subject.instance_variable_set(:@eucalyptus, nil)
+    context :booted_at do
+      it 'should be some time in the past' do
+        Time.at(subject.shell.booted_at).to_i.should < Time.now.to_i
+      end
+
+      it 'should be constant' do
+        b0 = subject.shell.booted_at
+        sleep(1)
+        b1 = subject.shell.booted_at
+
+        b0.should == b1
       end
+    end
+  end
+
+  context 'cloud-family queries' do
+    # PLEASE NOTE: we are unable to use the magic RSpec "subject" because
+    # we are dispatching calls to a Singleton and we must partially mock its
+    # calls, and both __send__ and flexmock partial-mocking gets confused by
+    # the fact that #subject returns a Proc, not the actual subject. Do not
+    # attempt to use the pretty RSpec feature within this context. You have
+    # been warned!
+    before(:each) do
+      @subject = subject.instance
+      @subject.instance_variable_set(:@ec2, nil)
+      @subject.instance_variable_set(:@rackspace, nil)
+      @subject.instance_variable_set(:@eucalyptus, nil)
+    end
 
-      ['ec2', 'rackspace', 'eucalyptus'].each do |cloud|
-        it "should detect #{cloud}" do
-          query = "#{cloud}?".to_sym
-          flexmock(@subject).should_receive(:read_cloud_file).once.and_return(cloud)
-          @subject.__send__(query).should be_true
-        end
+    ['ec2', 'rackspace', 'eucalyptus'].each do |cloud|
+      it "should detect #{cloud}" do
+        query = "#{cloud}?".to_sym
+        flexmock(@subject).should_receive(:read_cloud_file).once.and_return(cloud)
+        @subject.__send__(query).should be_true
       end
     end
   end