ridley 0.10.0.rc1 → 0.10.0.rc2

data/spec/unit/ridley/host_connector/winrm_spec.rb

@@ -10,6 +10,11 @@ describe Ridley::HostConnector::WinRM do
   let(:node_two) do
     Ridley::NodeResource.new(connection, automatic: { cloud: { public_hostname: "33.33.33.11" } })
   end
+  let(:command_uploader) { double('command_uploader', cleanup: nil) }
+
+  before do
+    Ridley::HostConnector::WinRM::CommandUploader.stub(:new).and_return(command_uploader)
+  end
 
   describe "ClassMethods" do
     subject { Ridley::HostConnector::WinRM }

data/spec/unit/ridley/host_connector_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Ridley::HostConnector do
-  
   subject do
     described_class
   end
@@ -14,29 +13,50 @@ describe Ridley::HostConnector do
     described_class::DEFAULT_WINRM_PORT.should eq(5985)
   end
 
-  describe "#connector_port_open" do
-    let(:host) {"127.0.0.1"}
-    let(:port) {22}
-    let(:socket) {double(:new => true, :close => nil)}
+  describe "#connector_port_open?" do
+    let(:host) { "127.0.0.1" }
+    let(:port) { 22 }
+    let(:socket) { double(:new => true, :close => nil) }
 
     context "when a port is open" do
-      it "returns true" do
+      before do
         TCPSocket.stub(:new).and_return(socket)
-        subject.connector_port_open?(host, port).should eq(true)
+      end
+
+      it "returns true" do
+        subject.connector_port_open?(host, port).should eql(true)
+      end
+
+      it "closes the opened socket" do
+        socket.should_receive(:close)
+        subject.connector_port_open?(host, port)
       end
     end
 
     context "when a port is closed" do
-      it "returns false" do
+      before do
         TCPSocket.stub(:new).and_raise(Errno::ECONNREFUSED)
+      end
+
+      it "returns false" do
         subject.connector_port_open?(host, port).should eq(false)
       end
     end
+
+    context "when host is unreachable" do
+      before do
+        TCPSocket.stub(:new).and_raise(SocketError)
+      end
+
+      it "returns false" do
+        subject.connector_port_open?(host, port).should eql(false)
+      end
+    end
   end
 
   describe "#best_connector_for" do
     let(:host) {"127.0.0.1"}
-    
+
     context "when an SSH port is open" do
       it "returns Ridley::HostConnector::SSH" do
         subject.stub(:connector_port_open?).and_return(true)
@@ -59,6 +79,15 @@ describe Ridley::HostConnector do
         }.to raise_error(Ridley::Errors::HostConnectionError)
       end
     end
+
+    context "when a block is provided" do
+      it "yields the best HostConnector to the block" do
+        subject.stub(:connector_port_open?).and_return(true)
+        subject.best_connector_for(host) do |yielded|
+          yielded.should eq(Ridley::HostConnector::SSH)
+        end
+      end
+    end
   end
 
   describe "#parse_port_options" do
@@ -72,7 +101,7 @@ describe Ridley::HostConnector do
         }
       }
     end
-    
+
     context "when :ssh has a key for :port" do
       it "returns the value of port instead of the default" do
         subject.parse_port_options(options).should include(1234)

data/spec/unit/ridley/resources/node_resource_spec.rb

@@ -10,13 +10,21 @@ describe Ridley::NodeResource do
       ssh: {
         user: "reset",
         password: "lol"
-      }
+      },
+      winrm: {
+        user: "Administrator",
+        password: "secret"
+      },
+      encrypted_data_bag_secret_path: nil
     )
   end
+  let(:host) { "33.33.33.10" }
 
   describe "ClassMethods" do
     subject { Ridley::NodeResource }
 
+    let(:worker) { double('worker', alive?: true, terminate: nil) }
+
     describe "::bootstrap" do
       let(:boot_options) do
         {
@@ -36,6 +44,133 @@ describe Ridley::NodeResource do
       end
     end
 
+    describe "::chef_run" do
+      subject { chef_run }
+      let(:chef_run) { described_class.chef_run(connection, host) }
+      let(:response) { [:ok, double('response', stdout: 'success_message')] }
+
+      before do
+        Ridley::NodeResource.stub(:configured_worker_for).and_return(worker)
+        worker.stub(:chef_client).and_return(response)
+      end
+
+      it { should eq(response) }
+
+      context "when it executes unsuccessfully" do
+        let(:response) { [:error, double('response', stderr: 'failure_message')] }
+
+        it {should eq(response)}
+      end
+
+      it "terminates the worker" do
+        worker.should_receive(:terminate)
+        chef_run
+      end
+    end
+
+    describe "::put_secret" do
+      subject { put_secret }
+      let(:put_secret) { described_class.put_secret(connection, host, secret_path)}
+      let(:response) { [:ok, double('response', stdout: 'success_message')] }
+      let(:secret_path) { fixtures_path.join("reset.pem").to_s }
+
+      before do
+        Ridley::NodeResource.stub(:configured_worker_for).and_return(worker)
+        worker.stub(:put_secret).and_return(response)
+      end
+
+      it { should eq(response) }
+
+      context "when it executes unsuccessfully" do
+        let(:response) { [:error, double('response', stderr: 'failure_message')] }
+
+        it { should eq(response) }
+      end
+
+      it "terminates the worker" do
+        worker.should_receive(:terminate)
+        put_secret
+      end
+    end
+
+    describe "::ruby_script" do
+      subject { ruby_script }
+      let(:ruby_script) { described_class.ruby_script(connection, host, command_lines) }
+      let(:response) { [:ok, double('response', stdout: 'success_message')] }
+      let(:command_lines) { ["puts 'hello'", "puts 'there'"] }
+
+      before do
+        Ridley::NodeResource.stub(:configured_worker_for).and_return(worker)
+        worker.stub(:ruby_script).and_return(response)
+      end
+
+      it { should eq(response) }
+
+      context "when it executes unsuccessfully" do
+        let(:response) { [:error, double('response', stderr: 'failure_message')] }
+
+        it { should eq(response) }
+      end
+
+      it "terminates the worker" do
+        worker.should_receive(:terminate)
+        ruby_script
+      end
+    end
+
+    describe "::execute_command" do
+      subject { execute_command }
+
+      let(:execute_command) { described_class.execute_command(connection, host, command) }
+      let(:response) { [:ok, double('response', stdout: 'success_message')] }
+      let(:command) { "echo 'hello world'" }
+
+      before do
+        Ridley::NodeResource.stub(:configured_worker_for).and_return(worker)
+        worker.stub(:run).and_return(response)
+      end
+
+      it { should eq(response) }
+
+      context "when it executes unsuccessfully" do
+        let(:response) { [:error, double('response', stderr: 'failure_message')] }
+
+        it { should eq(response) }
+      end
+    end
+
+    describe "::configured_worker_for" do
+      subject { configured_worker_for }
+
+      let(:configured_worker_for) { described_class.send(:configured_worker_for, connection, host) }
+
+      context "when the best connector is SSH" do
+        before do
+          Ridley::HostConnector.stub(:best_connector_for).and_yield(Ridley::HostConnector::SSH)
+        end
+
+        it "returns an SSH worker instance" do
+          configured_worker_for.should be_a(Ridley::HostConnector::SSH::Worker)
+        end
+
+        its(:user) { should eq("reset") }
+      end
+
+      context "when the best connector is WinRM" do
+        before do
+          Ridley::HostConnector.stub(:best_connector_for).and_yield(Ridley::HostConnector::WinRM)
+          Ridley::HostConnector::WinRM::CommandUploader.stub(:new)
+        end
+
+        it "returns a WinRm worker instance" do
+          configured_worker_for.should be_a(Ridley::HostConnector::WinRM::Worker)
+        end
+
+        its(:user) { should eq("Administrator") }
+        its(:password) { should eq("secret") }
+      end
+    end
+
     describe "::merge_data" do
       it "finds the target node and sends it the merge_data message" do
         data = double('data')
@@ -48,7 +183,8 @@ describe Ridley::NodeResource do
     end
   end
 
-  subject { Ridley::NodeResource.new(connection) }
+  subject { node_resource }
+  let(:node_resource) { Ridley::NodeResource.new(connection) }
 
   describe "#set_chef_attribute" do
     it "sets an normal node attribute at the nested path" do
@@ -242,11 +378,42 @@ describe Ridley::NodeResource do
   end
 
   describe "#chef_client" do
-    pending
+    subject { chef_client }
+    let(:chef_client) { node_resource.chef_client }
+    let(:worker) { double('worker', chef_client: response) }
+    let(:response) { [:ok, Ridley::HostConnector::Response.new(host)] }
+
+    before do
+      Ridley::HostConnector.stub(:best_connector_for).and_yield(Ridley::HostConnector::SSH)
+      Ridley::HostConnector::SSH.stub(:start).and_yield(worker)
+    end
+
+    it "returns a HostConnector::Response" do
+
+      chef_client.should be_a(Ridley::HostConnector::Response)
+    end
   end
 
   describe "#put_secret" do
-    pending
+    subject { put_secret }
+    let(:put_secret) { node_resource.put_secret }
+    let(:worker) { double('worker', put_secret: response) }
+    let(:response) { [:ok, Ridley::HostConnector::Response.new(host)] }
+
+    before do
+      Ridley::HostConnector.stub(:best_connector_for).and_yield(Ridley::HostConnector::SSH)
+      Ridley::HostConnector::SSH.stub(:start).and_yield(worker)
+    end
+
+    context "when the client does not have an encrypted file" do
+      it "returns nil" do
+        put_secret.should be_nil
+      end
+    end
+
+    it "returns a HostConnector::Response" do
+      pending
+    end
   end
 
   describe "#merge_data" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ridley
 version: !ruby/object:Gem::Version
-  version: 0.10.0.rc1
+  version: 0.10.0.rc2
   prerelease: 7
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-10 00:00:00.000000000 Z
+date: 2013-04-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -321,6 +321,7 @@ files:
 - lib/ridley/host_connector/ssh.rb
 - lib/ridley/host_connector/ssh/worker.rb
 - lib/ridley/host_connector/winrm.rb
+- lib/ridley/host_connector/winrm/command_uploader.rb
 - lib/ridley/host_connector/winrm/worker.rb
 - lib/ridley/log.rb
 - lib/ridley/logging.rb
@@ -391,6 +392,7 @@ files:
 - spec/unit/ridley/host_connector/response_set_spec.rb
 - spec/unit/ridley/host_connector/ssh/worker_spec.rb
 - spec/unit/ridley/host_connector/ssh_spec.rb
+- spec/unit/ridley/host_connector/winrm/command_uploader_spec.rb
 - spec/unit/ridley/host_connector/winrm/worker_spec.rb
 - spec/unit/ridley/host_connector/winrm_spec.rb
 - spec/unit/ridley/host_connector_spec.rb
@@ -478,6 +480,7 @@ test_files:
 - spec/unit/ridley/host_connector/response_set_spec.rb
 - spec/unit/ridley/host_connector/ssh/worker_spec.rb
 - spec/unit/ridley/host_connector/ssh_spec.rb
+- spec/unit/ridley/host_connector/winrm/command_uploader_spec.rb
 - spec/unit/ridley/host_connector/winrm/worker_spec.rb
 - spec/unit/ridley/host_connector/winrm_spec.rb
 - spec/unit/ridley/host_connector_spec.rb