ridgepole 3.2.0 → 3.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 58a248172bd53075285dcb1fa69f4c8e3bcfa8ab382445e78823d1a284695c3d
-  data.tar.gz: f7568382f78041f9279ff389e1b4f17f389f6ebfef37bde0c9b557ea2f0efeed
+  metadata.gz: 44c06587d61c4599e0f7f0b10cdcc16829bd43122c9545a9e7441e22e5d1a5be
+  data.tar.gz: 350526f0a2303c72901e214c9c01996062a3758581815605152ef702ffefcc16
 SHA512:
-  metadata.gz: 331e86965d4537a88a18d56fc593bf7359a8cee7d4ea69e1e401d53cf2c704b86dae70db004b29738025b2851b528d4a03cc8cea0270b56ffe96cbb41df4d3a9
-  data.tar.gz: 1704cb3599ee8de9695efa8a4af09134f876192ff902ec111a705bdb0ab6f56a8af7bf2e59148fee9037866dab605e622b99c11137330f66decf4df316728e00
+  metadata.gz: 0634c00dfc3a1c34f44e22d76cef892d17b5115a344ed600f5152ebba12e776668e8aa987650ee680cf8263a1cf779f39963a1b5cf2c7cbd20393d8a31c29b40
+  data.tar.gz: e5303a3b7c53068957d7b27613cb2b608043d1cd6a7adf9ee278378d7e6227794909f32d01289f484e00c5b480613c6dd6ce18066b6cf634b6849d69e9a304b0

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## 3.2
 
+### 3.2.1 (2026/05/04)
+
+- Warn when an anonymous index ambiguously matches multiple DB indexes. [pull#692](https://github.com/ridgepole/ridgepole/pull/692)
+
 ### 3.2.0 (2026/03/28)
 
 - Fix spurious diff for `timestamp`/`datetime` with `precision: 6` on MySQL. [pull#665](https://github.com/ridgepole/ridgepole/pull/665)

data/README.md

@@ -9,6 +9,11 @@ It defines DB schema using [Rails DSL](http://guides.rubyonrails.org/migrations.
 [![test](https://github.com/ridgepole/ridgepole/actions/workflows/test.yml/badge.svg)](https://github.com/ridgepole/ridgepole/actions/workflows/test.yml)
 [![codecov](https://codecov.io/gh/ridgepole/ridgepole/graph/badge.svg)](https://codecov.io/gh/ridgepole/ridgepole)
 
+> [!TIP]
+> Currently developing a similar tool for PostgreSQL.
+> 
+> see https://github.com/winebarrel/pistachio
+
 > [!warning]
 > The order of columns when exporting has changed in Rails 8.1. https://github.com/rails/rails/pull/53281
 >
@@ -315,11 +320,11 @@ EOS
 
 execute("CREATE OR REPLACE VIEW `active_users` AS #{view_select}") do |c|
   definition = c.raw_connection.query(<<-SQL).first&.first
-    SELECT SHA(VIEW_DEFINITION) FROM information_schema.views
+    SELECT VIEW_DEFINITION FROM information_schema.views
      WHERE TABLE_SCHEMA = 'mydb'
        AND TABLE_NAME = 'active_users';
   SQL
-  definition != view_select
+  definition&.strip != view_select
 end
 ```
 

data/lib/ridgepole/diff.rb

@@ -104,7 +104,7 @@ module Ridgepole
       scan_options_change(table_name, from[:options], to[:options], table_delta)
       scan_definition_change(from[:definition], to[:definition], from[:indices], table_name, from[:options], table_delta)
       apply_column_renames_to_indices(from[:indices], table_delta.dig(:definition, :rename))
-      scan_indices_change(from[:indices], to[:indices], to[:definition], table_delta, from[:options], to[:options])
+      scan_indices_change(table_name, from[:indices], to[:indices], to[:definition], table_delta, from[:options], to[:options])
       scan_foreign_keys_change(from[:foreign_keys], to[:foreign_keys], table_delta, @options)
       scan_check_constraints_change(from[:check_constraints], to[:check_constraints], table_delta)
       scan_exclusion_constraints_change(from[:exclusion_constraints], to[:exclusion_constraints], table_delta)
@@ -356,7 +356,7 @@ module Ridgepole
       end
     end
 
-    def scan_indices_change(from, to, to_columns, table_delta, _from_table_options, to_table_options)
+    def scan_indices_change(table_name, from, to, to_columns, table_delta, _from_table_options, to_table_options)
       from = (from || {}).dup
       to = (to || {}).dup
       indices_delta = {}
@@ -365,7 +365,18 @@ module Ridgepole
         ignore_index = to_attrs.fetch(:options, {}).delete(:ignore)
 
         if index_name.is_a?(Array)
-          from_index_name, from_attrs = from.find { |_name, attrs| attrs[:column_name] == index_name }
+          matching = from.select { |_name, attrs| attrs[:column_name] == index_name }
+
+          if matching.size > 1 && !ignore_index
+            @logger.warn(
+              "[WARNING] Multiple existing indexes on `#{table_name}` match column #{index_name.inspect}: " \
+              "#{matching.keys.map(&:inspect).join(', ')}. " \
+              'The choice of which index to keep depends on iteration order; ' \
+              'specify `name:` explicitly to disambiguate.'
+            )
+          end
+
+          from_index_name, from_attrs = matching.first
 
           if from_attrs
             from.delete(from_index_name)

data/lib/ridgepole/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ridgepole
-  VERSION = '3.2.0'
+  VERSION = '3.2.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ridgepole
 version: !ruby/object:Gem::Version
-  version: 3.2.0
+  version: 3.2.1
 platform: ruby
 authors:
 - Genki Sugawara
@@ -245,14 +245,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.85.1
+        version: 1.86.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.85.1
+        version: 1.86.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement