ridgepole 1.0.2.beta → 1.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a14d5a37589fdd2639feba516071c7593f98f05f485c96401dca5f3021674330
-  data.tar.gz: 96747ebd0c5da3c8e77726e839b721aeb78c088d7d6dfd25476ac6f34421d7fb
+  metadata.gz: 93755589225b2104033ca2e660fdb5e4d3efa0da2784dbbd7fe4d0f1ff2a455d
+  data.tar.gz: 297bc45e7568a26ebec4a410cb2ce8bece3fd0c960fda4ad3955f09f58981004
 SHA512:
-  metadata.gz: 946b32832ab928d03a22caa78fe4bd6379778732817de10d9df12eb976d1feb0260cacb436ae848f47e98cae923542b4494e26690a78069dd5559a6278799286
-  data.tar.gz: 3bd4e975d7aa90162d3813f57215db79c5c0680553cb46e62cf820c4dfe6500af8c8f0845fe4799e481dfad453698439e84362d5f19ee2c0aafa454d28eae62a
+  metadata.gz: 32fca405de8475e0a09fcac001fbc92ed955a13ae2b2a6175b161c8cec135b5f2c99fb18d214f0e34aa0015503b2885c0c9420ae1d2912ac70b7ce98bbfbfe12
+  data.tar.gz: 20cebc14f9eb4976b644569af06c93c78a4573c8368dbe98447153aaabf601113a6cc8db8a2e8f3bd6def07ebb7971c5358dfcced15513e9fcc0d69903a0d233

data/CHANGELOG.md

@@ -2,7 +2,15 @@
 
 ## 1.0
 
-### 1.0.2 (Unreleased)
+### 1.0.4 (2022/03/28)
+
+* Add warning for generated column [pull#382](https://github.com/ridgepole/ridgepole/pull/382)
+
+### 1.0.3 (2022/02/12)
+
+* Support Rails 7.0.2 [pull#380](https://github.com/ridgepole/ridgepole/pull/380)
+
+### 1.0.2 (2022/02/06)
 
 * Add support for partitioning ([pull#374](https://github.com/ridgepole/ridgepole/pull/374))
 * Suppress warning of table option differences ([pull#378](https://github.com/ridgepole/ridgepole/pull/378))

data/README.md

@@ -11,6 +11,10 @@ It defines DB schema using [Rails DSL](http://guides.rubyonrails.org/migrations.
 
 **Notice**
 
+* ActiveRecord 7.x has some incompatible changes. If you get unintended differences in `datetime`, add `precision`.
+  * cf. https://github.com/ridgepole/ridgepole/issues/381
+* For ActiveRecord 7.x series, please use AcriveRecord 7.0.2 or higher / Ridgepole 1.0.3 or higher.
+  * cf. https://github.com/ridgepole/ridgepole/pull/380
 * ActiveRecord 6.1 is supported in ridgepole v0.9, but the ActiveRecord dump has been changed, so there is a difference between ActiveRecord 5.x/6.0 format.
   * **If you use ActiveRecord 6.1, please modify Schemafile format**.
   * cf. https://github.com/ridgepole/ridgepole/pull/323
@@ -210,6 +214,19 @@ activerecord 5.0.0 and activerecord-mysql-awesome dumps a collation rather than
 
 See `mysql> show character set;` to find charset / collation pair for your system.
 
+## Generated Column (MySQL)
+
+There should be NO extra white spaces in the expression (such as after comma).  
+Quotes in expression may cause the operations failure with MySQL 8.0.
+
+```ruby
+create_table "users", force: :cascade do |t|
+  t.string   "last_name"
+  t.string   "first_name"
+  t.virtual  "full_name", type: :string, as: "concat(`last_name`,' ',`first_name`)", stored: true
+end
+```
+
 ## Execute
 ```ruby
 create_table "authors", force: :cascade do |t|

data/lib/ridgepole/diff.rb

@@ -422,9 +422,6 @@ module Ridgepole
             opts[:limit] = 4_294_967_295
           end
         end
-
-        # Workaround for Active Record 7.0
-        opts.delete(:precision) if attrs[:type] == :datetime && opts[:precision].nil?
       end
     end
 
@@ -509,6 +506,14 @@ module Ridgepole
         attrs2.fetch(:options).delete(:comment)
       end
 
+      if attrs1[:options][:as] != attrs2[:options][:as] && attrs1[:options].fetch(:as, '').delete(' ') == attrs2[:options].fetch(:as, '').delete(' ')
+        @logger.warn(<<-MSG)
+[WARNING] Same expressions but only differed by white spaces were detected. This operation may fail.
+  Before: '#{attrs1[:options][:as]}'
+  After : '#{attrs2[:options][:as]}'
+        MSG
+      end
+
       attrs1 == attrs2
     end
 
@@ -652,7 +657,7 @@ MSG
 
       (from_partitions.keys - to_partitions.keys).each do |name|
         partition_definitions_delta[:delete] ||= {}
-        partition_definitions_delta[:delete][name] = attrs.merge(valuve: from_partitions[name][:values])
+        partition_definitions_delta[:delete][name] = attrs.merge(values: from_partitions[name][:values])
       end
 
       (to_partitions.keys - from_partitions.keys).each do |name|

data/lib/ridgepole/dumper.rb

@@ -39,7 +39,7 @@ module Ridgepole
 
       dsl = stream.string.lines.select do |line|
         line !~ /\A#/ &&
-          line !~ /\AActiveRecord::Schema\.define/ &&
+          line !~ /\AActiveRecord::Schema(\[\d\.\d\])?\.define/ &&
           line !~ /\Aend/
       end
 

data/lib/ridgepole/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ridgepole
-  VERSION = '1.0.2.beta'
+  VERSION = '1.0.4'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ridgepole
 version: !ruby/object:Gem::Version
-  version: 1.0.2.beta
+  version: 1.0.4
 platform: ruby
 authors:
 - Genki Sugawara
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-01-22 00:00:00.000000000 Z
+date: 2022-03-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -338,9 +338,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 2.2.7
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubygems_version: 3.2.32
 signing_key: