ridgepole 0.9.2 → 0.9.6

data/spec/mysql/fk/migrate_change_fk2_spec.rb

@@ -1,47 +0,0 @@
-# frozen_string_literal: true
-
-describe 'Ridgepole::Client#diff -> migrate' do
-  context 'when change fk' do
-    let(:actual_dsl) do
-      erbh(<<-ERB)
-        create_table "users", id: false, force: :cascade do |t|
-          t.bigint :my_original_id, null: false
-          t.index %i[my_original_id], unique: true
-        end
-
-        create_table "lessons", force: :cascade do |t|
-          t.bigint :user_id2, null: false
-          t.index %i[user_id2], name: :index_lessons_on_user_id2
-        end
-
-        add_foreign_key :lessons, :users, primary_key: :my_original_id, column: :user_id2
-      ERB
-    end
-
-    let(:expected_dsl) do
-      erbh(<<-ERB)
-        create_table "lessons", force: :cascade do |t|
-          t.bigint "user_id2", null: false
-          t.index ["user_id2"], name: "index_lessons_on_user_id2"
-        end
-
-        create_table "users", id: false, force: :cascade do |t|
-          t.bigint "my_original_id", null: false
-          t.index ["my_original_id"], name: "index_users_on_my_original_id", unique: true
-        end
-
-        add_foreign_key "lessons", "users", primary_key: "my_original_id", column: "user_id2"
-      ERB
-    end
-
-    before { subject.diff(actual_dsl).migrate }
-
-    subject { client }
-
-    it {
-      expect(subject.diff(actual_dsl).differ?).to be_falsey
-      expect(subject.diff(expected_dsl).differ?).to be_falsey
-      expect(subject.dump).to match_ruby expected_dsl
-    }
-  end
-end

data/spec/mysql/fk/migrate_change_fk_spec.rb

@@ -1,265 +0,0 @@
-# frozen_string_literal: true
-
-describe 'Ridgepole::Client#diff -> migrate' do
-  context 'when change fk' do
-    let(:actual_dsl) do
-      erbh(<<-ERB)
-        create_table "parent", id: :integer, force: :cascade do |t|
-        end
-
-        create_table "child", force: :cascade do |t|
-          t.integer "parent_id"
-          t.index ["parent_id"], name: "par_id"
-        end
-
-        add_foreign_key "child", "parent", name: "child_ibfk_1", on_delete: :cascade
-      ERB
-    end
-
-    let(:sorted_actual_dsl) do
-      erbh(<<-ERB)
-        create_table "child", force: :cascade do |t|
-          t.integer "parent_id"
-          t.index ["parent_id"], name: "par_id"
-        end
-
-        create_table "parent", id: :integer, force: :cascade do |t|
-        end
-
-        add_foreign_key "child", "parent", name: "child_ibfk_1", on_delete: :cascade
-      ERB
-    end
-
-    let(:expected_dsl) do
-      erbh(<<-ERB)
-        create_table "child", force: :cascade do |t|
-          t.integer "parent_id"
-          t.index ["parent_id"], name: "par_id"
-        end
-
-        create_table "parent", id: :integer, force: :cascade do |t|
-        end
-
-        add_foreign_key "child", "parent", name: "child_ibfk_1"
-      ERB
-    end
-
-    before { subject.diff(actual_dsl).migrate }
-
-    subject { client }
-
-    it {
-      delta = subject.diff(expected_dsl)
-      expect(delta.differ?).to be_truthy
-      expect(subject.dump).to match_fuzzy sorted_actual_dsl
-      delta.migrate
-      expect(subject.dump).to match_ruby expected_dsl
-    }
-  end
-
-  context 'when change fk using `t.foreign_key`' do
-    let(:actual_dsl) do
-      erbh(<<-ERB)
-        create_table "parent", id: :integer, force: :cascade do |t|
-        end
-
-        create_table "child", force: :cascade do |t|
-          t.integer "parent_id"
-          t.index ["parent_id"], name: "par_id"
-          t.foreign_key "parent", name: "child_ibfk_1", on_delete: :cascade
-        end
-      ERB
-    end
-
-    let(:sorted_actual_dsl) do
-      erbh(<<-ERB)
-        create_table "child", force: :cascade do |t|
-          t.integer "parent_id"
-          t.index ["parent_id"], name: "par_id"
-        end
-
-        create_table "parent", id: :integer, force: :cascade do |t|
-        end
-
-        add_foreign_key "child", "parent", name: "child_ibfk_1", on_delete: :cascade
-      ERB
-    end
-
-    let(:expected_dsl) do
-      erbh(<<-ERB)
-        create_table "child", force: :cascade do |t|
-          t.integer "parent_id"
-          t.index ["parent_id"], name: "par_id"
-        end
-
-        create_table "parent", id: :integer, force: :cascade do |t|
-        end
-
-        add_foreign_key "child", "parent", name: "child_ibfk_1"
-      ERB
-    end
-
-    let(:expected_dsl_using_t_foreign_key) do
-      erbh(<<-ERB)
-        create_table "child", force: :cascade do |t|
-          t.integer "parent_id"
-          t.index ["parent_id"], name: "par_id"
-          t.foreign_key "parent", name: "child_ibfk_1"
-        end
-
-        create_table "parent", id: :integer, force: :cascade do |t|
-        end
-      ERB
-    end
-
-    before { subject.diff(actual_dsl).migrate }
-
-    subject { client }
-
-    it {
-      delta = subject.diff(expected_dsl_using_t_foreign_key)
-      expect(delta.differ?).to be_truthy
-      expect(subject.dump).to match_fuzzy sorted_actual_dsl
-      delta.migrate
-      expect(subject.dump).to match_ruby expected_dsl
-    }
-  end
-
-  context 'when change fk without name' do
-    let(:actual_dsl) do
-      erbh(<<-ERB)
-        create_table "parent", id: :integer, force: :cascade do |t|
-        end
-
-        create_table "child", force: :cascade do |t|
-          t.integer "parent_id"
-          t.index ["parent_id"], name: "par_id"
-        end
-
-        add_foreign_key "child", "parent", on_delete: :cascade
-      ERB
-    end
-
-    let(:sorted_actual_dsl) do
-      erbh(<<-ERB)
-        create_table "child", force: :cascade do |t|
-          t.integer "parent_id"
-          t.index ["parent_id"], name: "par_id"
-        end
-
-        create_table "parent", id: :integer, force: :cascade do |t|
-        end
-
-        add_foreign_key "child", "parent", on_delete: :cascade
-      ERB
-    end
-
-    let(:expected_dsl) do
-      erbh(<<-ERB)
-        create_table "child", force: :cascade do |t|
-          t.integer "parent_id"
-          t.index ["parent_id"], name: "par_id"
-        end
-
-        create_table "parent", id: :integer, force: :cascade do |t|
-        end
-
-        add_foreign_key "child", "parent"
-      ERB
-    end
-
-    before { subject.diff(actual_dsl).migrate }
-
-    subject { client }
-
-    it {
-      delta = subject.diff(expected_dsl)
-      expect(delta.differ?).to be_truthy
-      expect(subject.dump).to match_fuzzy sorted_actual_dsl
-      delta.migrate
-      expect(subject.dump).to match_ruby expected_dsl
-    }
-  end
-
-  context 'when drop/add fk with parent table' do
-    let(:actual_dsl) do
-      erbh(<<-ERB)
-        create_table "child", force: :cascade do |t|
-          t.integer "parent_id"
-          t.index ["parent_id"], name: "par_id"
-        end
-
-        create_table "parent", id: :integer, force: :cascade do |t|
-        end
-
-        add_foreign_key "child", "parent", name: "child_ibfk_1"
-      ERB
-    end
-
-    let(:expected_dsl) do
-      erbh(<<-ERB)
-        create_table "child", force: :cascade do |t|
-          t.integer "parent2_id"
-          t.index ["parent2_id"], name: "par2_id"
-        end
-
-        create_table "parent2", id: :integer, force: :cascade do |t|
-        end
-
-        add_foreign_key "child", "parent2", name: "child_ibfk_2"
-      ERB
-    end
-
-    before { subject.diff(actual_dsl).migrate }
-    subject { client }
-
-    it {
-      delta = subject.diff(expected_dsl)
-      expect(delta.differ?).to be_truthy
-      expect(subject.dump).to match_ruby actual_dsl
-      delta.migrate
-      expect(subject.dump).to match_ruby expected_dsl
-    }
-  end
-
-  context 'when drop/add fk with parent table without name' do
-    let(:actual_dsl) do
-      erbh(<<-ERB)
-        create_table "child", force: :cascade do |t|
-          t.integer "parent_id"
-          t.index ["parent_id"], name: "par_id"
-        end
-
-        create_table "parent", id: :integer, force: :cascade do |t|
-        end
-
-        add_foreign_key "child", "parent"
-      ERB
-    end
-
-    let(:expected_dsl) do
-      erbh(<<-ERB)
-        create_table "child", force: :cascade do |t|
-          t.integer "parent2_id"
-          t.index ["parent2_id"], name: "par2_id"
-        end
-
-        create_table "parent2", id: :integer, force: :cascade do |t|
-        end
-
-        add_foreign_key "child", "parent2"
-      ERB
-    end
-
-    before { subject.diff(actual_dsl).migrate }
-    subject { client }
-
-    it {
-      delta = subject.diff(expected_dsl)
-      expect(delta.differ?).to be_truthy
-      expect(subject.dump).to match_ruby actual_dsl
-      delta.migrate
-      expect(subject.dump).to match_ruby expected_dsl
-    }
-  end
-end

data/spec/mysql/fk/migrate_create_fk_spec.rb

@@ -1,349 +0,0 @@
-# frozen_string_literal: true
-
-describe 'Ridgepole::Client#diff -> migrate' do
-  context 'when create fk' do
-    let(:actual_dsl) do
-      erbh(<<-ERB)
-        create_table "child", force: :cascade do |t|
-          t.integer "parent_id"
-          t.index ["parent_id"], name: "par_id"
-        end
-
-        create_table "parent", id: :integer, force: :cascade do |t|
-        end
-      ERB
-    end
-
-    let(:expected_dsl) do
-      erbh(actual_dsl + <<-ERB)
-        add_foreign_key "child", "parent", name: "child_ibfk_1"
-      ERB
-    end
-
-    before { subject.diff(actual_dsl).migrate }
-    subject { client }
-
-    it {
-      delta = subject.diff(expected_dsl)
-      expect(delta.differ?).to be_truthy
-      expect(subject.dump).to match_ruby actual_dsl
-      delta.migrate
-      expect(subject.dump).to match_ruby expected_dsl
-    }
-
-    it {
-      delta = client(bulk_change: true).diff(expected_dsl)
-      expect(delta.differ?).to be_truthy
-      expect(subject.dump).to match_ruby actual_dsl
-      expect(delta.script).to match_fuzzy <<-RUBY
-        add_foreign_key("child", "parent", **{:name=>"child_ibfk_1"})
-      RUBY
-      delta.migrate
-      expect(subject.dump).to match_ruby expected_dsl
-    }
-  end
-
-  context 'when create fk using `t.foreign_key`' do
-    let(:actual_dsl) do
-      erbh(<<-ERB)
-        create_table "child", force: :cascade do |t|
-          t.integer "parent_id"
-          t.index ["parent_id"], name: "par_id"
-        end
-
-        create_table "parent", id: :integer, force: :cascade do |t|
-        end
-      ERB
-    end
-
-    let(:expected_dsl) do
-      erbh(actual_dsl + <<-ERB)
-        add_foreign_key "child", "parent", name: "child_ibfk_1"
-      ERB
-    end
-
-    let(:expected_dsl_using_t_foreign_key) do
-      erbh(<<-ERB)
-        create_table "child", force: :cascade do |t|
-          t.integer "parent_id"
-          t.index ["parent_id"], name: "par_id"
-          t.foreign_key "parent", name: "child_ibfk_1"
-        end
-
-        create_table "parent", id: :integer, force: :cascade do |t|
-        end
-      ERB
-    end
-
-    before { subject.diff(actual_dsl).migrate }
-    subject { client }
-
-    it {
-      delta = subject.diff(expected_dsl_using_t_foreign_key)
-      expect(delta.differ?).to be_truthy
-      expect(subject.dump).to match_ruby actual_dsl
-      delta.migrate
-      expect(subject.dump).to match_ruby expected_dsl
-    }
-
-    it {
-      delta = client(bulk_change: true).diff(expected_dsl_using_t_foreign_key)
-      expect(delta.differ?).to be_truthy
-      expect(subject.dump).to match_ruby actual_dsl
-      expect(delta.script).to match_fuzzy <<-RUBY
-        add_foreign_key("child", "parent", **{:name=>"child_ibfk_1"})
-      RUBY
-      delta.migrate
-      expect(subject.dump).to match_ruby expected_dsl
-    }
-  end
-
-  context 'when create fk when create table' do
-    let(:dsl) do
-      erbh(<<-ERB)
-        create_table "child", force: :cascade do |t|
-          t.integer "parent_id"
-          t.index ["parent_id"], name: "par_id"
-        end
-
-        add_foreign_key "child", "parent", name: "child_ibfk_1"
-
-        create_table "parent", id: :integer, force: :cascade do |t|
-        end
-      ERB
-    end
-
-    let(:sorted_dsl) do
-      erbh(<<-ERB)
-        create_table "child", force: :cascade do |t|
-          t.integer "parent_id"
-          t.index ["parent_id"], name: "par_id"
-        end
-
-        create_table "parent", id: :integer, force: :cascade do |t|
-        end
-
-        add_foreign_key "child", "parent", name: "child_ibfk_1"
-      ERB
-    end
-
-    subject { client }
-
-    it {
-      delta = subject.diff(dsl)
-      expect(delta.differ?).to be_truthy
-      expect(subject.dump).to match_fuzzy ''
-      delta.migrate
-      expect(subject.dump).to match_fuzzy sorted_dsl
-    }
-  end
-
-  context 'already defined' do
-    let(:dsl) do
-      erbh(<<-ERB)
-        create_table "child", force: :cascade do |t|
-          t.integer "parent_id", unsigned: true
-          t.index ["parent_id"], name: "par_id"
-        end
-
-        add_foreign_key "child", "parent", name: "child_ibfk_1"
-
-        add_foreign_key "child", "parent", name: "child_ibfk_1"
-
-        create_table "parent", id: :integer, force: :cascade do |t|
-        end
-      ERB
-    end
-
-    subject { client }
-
-    it {
-      expect do
-        subject.diff(dsl)
-      end.to raise_error('Foreign Key `child(child_ibfk_1)` already defined')
-    }
-  end
-
-  context 'when create fk without name' do
-    let(:actual_dsl) do
-      erbh(<<-ERB)
-        create_table "child", force: :cascade do |t|
-          t.integer "parent_id"
-          t.index ["parent_id"], name: "par_id"
-        end
-
-        create_table "parent", id: :integer, force: :cascade do |t|
-        end
-      ERB
-    end
-
-    let(:expected_dsl) do
-      erbh(actual_dsl + <<-ERB)
-        add_foreign_key "child", "parent"
-      ERB
-    end
-
-    before { subject.diff(actual_dsl).migrate }
-    subject { client }
-
-    it {
-      delta = subject.diff(expected_dsl)
-      expect(delta.differ?).to be_truthy
-      expect(subject.dump).to match_ruby actual_dsl
-      delta.migrate
-      expect(subject.dump).to match_ruby expected_dsl
-    }
-
-    it {
-      delta = client(bulk_change: true).diff(expected_dsl)
-      expect(delta.differ?).to be_truthy
-      expect(subject.dump).to match_ruby actual_dsl
-      expect(delta.script).to match_fuzzy <<-RUBY
-        add_foreign_key("child", "parent", **{})
-      RUBY
-      delta.migrate
-      expect(subject.dump).to match_ruby expected_dsl
-    }
-  end
-
-  context 'orphan fk' do
-    let(:dsl) do
-      erbh(<<-ERB)
-        add_foreign_key "child", "parent", name: "child_ibfk_1"
-
-        create_table "parent", id: :integer, force: :cascade do |t|
-        end
-      ERB
-    end
-
-    subject { client }
-
-    it {
-      expect do
-        subject.diff(dsl)
-      end.to raise_error('Table `child` to create the foreign key is not defined: child_ibfk_1')
-    }
-  end
-
-  context 'when create fk without any indexes for its column' do
-    let(:dsl) do
-      erbh(<<-ERB)
-        create_table "parent", id: :integer, force: :cascade, options: "ENGINE=InnoDB DEFAULT CHARSET=utf8" do |t|
-        end
-
-        create_table "child", force: :cascade, options: "ENGINE=InnoDB DEFAULT CHARSET=utf8" do |t|
-          t.integer "parent_id"
-        end
-        add_foreign_key "child", "parent", name: "child_ibfk_1"
-      ERB
-    end
-
-    subject { client(dump_without_table_options: false) }
-
-    it {
-      expect do
-        subject.diff(dsl).migrate
-      end.to raise_error('The column `parent_id` of the table `child` has a foreign key but no index. Although InnoDB creates an index automatically, please add one explicitly in order for ridgepole to manage it.')
-    }
-  end
-
-  context 'when create fk with first key of multiple column indexes for its column' do
-    let(:dsl) do
-      erbh(<<-ERB)
-        create_table "parent", id: :integer, force: :cascade, <%= i cond('>= 6.1', { charset: 'utf8' }, { options: "ENGINE=InnoDB DEFAULT CHARSET=utf8" }) %> do |t|
-        end
-
-        create_table "child", force: :cascade, <%= i cond('>= 6.1', { charset: 'utf8' }, { options: "ENGINE=InnoDB DEFAULT CHARSET=utf8" }) %> do |t|
-          t.integer "parent_id"
-          t.string "name"
-          t.index ["parent_id", "name"], name: "par_id"
-        end
-        add_foreign_key "child", "parent", name: "child_ibfk_1"
-      ERB
-    end
-
-    subject { client(dump_without_table_options: false) }
-
-    it {
-      expect(Ridgepole::Logger.instance).to_not receive(:warn)
-      subject.diff(dsl).migrate
-
-      expect(subject.diff(dsl).differ?).to be_falsey
-    }
-  end
-
-  context 'when create fk on the primary key' do
-    let(:dsl) do
-      erbh(<<-ERB)
-        create_table "users", force: :cascade, <%= i cond('>= 6.1', { charset: 'utf8' }, { options: "ENGINE=InnoDB DEFAULT CHARSET=utf8" }) %> do |t|
-        end
-
-        create_table "icons", primary_key: "user_id", force: :cascade, <%= i cond('>= 6.1', { charset: 'utf8' }, { options: "ENGINE=InnoDB DEFAULT CHARSET=utf8" }) %> do |t|
-        end
-        add_foreign_key "icons", "users", name: "fk_icons_users"
-      ERB
-    end
-
-    subject { client(dump_without_table_options: false) }
-
-    it {
-      expect(Ridgepole::Logger.instance).to_not receive(:warn)
-      subject.diff(dsl).migrate
-
-      expect(subject.diff(dsl).differ?).to be_falsey
-    }
-  end
-end
-
-context 'when create fk on the first primary key' do
-  let(:dsl) do
-    erbh(<<-ERB)
-      create_table "users", id: :integer, force: :cascade, <%= i cond('>= 6.1', { charset: 'utf8' }, { options: "ENGINE=InnoDB DEFAULT CHARSET=utf8" }) %> do |t|
-      end
-
-      create_table "employee", id: :integer, force: :cascade, <%= i cond('>= 6.1', { charset: 'utf8' }, { options: "ENGINE=InnoDB DEFAULT CHARSET=utf8" }) %> do |t|
-      end
-
-      create_table "icons", primary_key: ["user_id", "employee_id"], force: :cascade, <%= i cond('>= 6.1', { charset: 'utf8' }, { options: "ENGINE=InnoDB DEFAULT CHARSET=utf8" }) %> do |t|
-        t.integer "user_id", null: false
-        t.integer "employee_id", null: false
-      end
-      add_foreign_key "icons", "users", name: "fk_icons_users"
-    ERB
-  end
-
-  subject { client(dump_without_table_options: false) }
-
-  it {
-    expect(Ridgepole::Logger.instance).to_not receive(:warn)
-    subject.diff(dsl).migrate
-
-    expect(subject.diff(dsl).differ?).to be_falsey
-  }
-end
-
-context 'when create fk on the second primary key' do
-  let(:dsl) do
-    erbh(<<-ERB)
-      create_table "users", id: :integer, force: :cascade, options: "ENGINE=InnoDB DEFAULT CHARSET=utf8" do |t|
-      end
-
-      create_table "employee", id: :integer, force: :cascade, options: "ENGINE=InnoDB DEFAULT CHARSET=utf8" do |t|
-      end
-
-      create_table "icons", primary_key: ["user_id", "employee_id"], force: :cascade, options: "ENGINE=InnoDB DEFAULT CHARSET=utf8" do |t|
-        t.integer "user_id", null: false
-        t.integer "employee_id", null: false
-      end
-      add_foreign_key "icons", "employees", name: "fk_icons_employees"
-    ERB
-  end
-
-  subject { client(dump_without_table_options: false) }
-
-  it {
-    expect do
-      subject.diff(dsl).migrate
-    end.to raise_error('The column `employee_id` of the table `icons` has a foreign key but no index. Although InnoDB creates an index automatically, please add one explicitly in order for ridgepole to manage it.')
-  }
-end