ridgepole 0.7.8 → 0.8.0.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 539602e5232c6d1a295f937ff1fd26d51b830c68d8f185da876b1bedd95decfa
-  data.tar.gz: b3c43db2efc39c4d93117bcc4ea5397928396e391c95aa5d9cb7c5db02bcd504
+  metadata.gz: 51752811fa355ec8328988d3f2b78f5eaa972379763e56498d7a9d8130e72b7c
+  data.tar.gz: 0e7dc4410a0c90fadc8c49d17292f947dfb14740cd89556e00420712a667ee79
 SHA512:
-  metadata.gz: a66a60e376e529fae24fc91823e09e74812f0a476b6f63655cd69ec32edbf34907a9dce5a53d3add7446255a21ddac3452dc1ab17653bd6ac3e2c5be498f63fa
-  data.tar.gz: b70c61a6f678547799517a053dd2946dd1480d61c9f9c0f09627e72956de042ff0cec31be74c5b763ab10e1dba1ea22454eb91949f149066f89c9674c6f85371
+  metadata.gz: cec836a87f959d8ded39667c3e726c9c11756fa20a03e75d9082cb5e7325ecb75aa6e4faf4660ad08615d333e50f8799157228b60fed4f176480656e9b0c9d46
+  data.tar.gz: e1dd85e686cf7ebf3bee192e2ac26f1f533f935a9e0c286ab6717badd288572325fe6dca5fb8393d94d8c138407a5ca4718480274cd6c4d618ffe01b411ea196

data/.rspec

@@ -1,3 +1,3 @@
---color
+--colour
 --require spec_helper
 --format HidePendingFormatter

data/.rubocop.yml

@@ -2,7 +2,7 @@ AllCops:
   Exclude:
     - 'gemfiles/**/*'
     - 'omnibus-ridgepole/**/*'
-  TargetRubyVersion: 2.4
+  TargetRubyVersion: 2.2
 Bundler/OrderedGems:
   Include:
     - 'Appraisals'
@@ -39,5 +39,3 @@ Style/TrailingCommaInHashLiteral:
   EnforcedStyleForMultiline: consistent_comma
 Layout/ClosingHeredocIndentation:
   Enabled: false
-Style/NumericPredicate:
-  Enabled: false

data/.travis.yml

@@ -6,9 +6,10 @@ cache:
   - bundler
   - apt
 rvm:
-  - 2.4.6
-  - 2.5.5
-  - 2.6.3
+  - 2.3.8
+  - 2.4.5
+  - 2.5.3
+  - 2.6.0
 before_script:
   - sudo service mysql stop
   - sudo service postgresql stop
@@ -25,6 +26,7 @@ gemfile:
   - gemfiles/activerecord_5.0.gemfile
   - gemfiles/activerecord_5.1.gemfile
   - gemfiles/activerecord_5.2.gemfile
+  - gemfiles/activerecord_6.0.gemfile
 env:
   matrix:
     - MYSQL56=1
@@ -38,3 +40,9 @@ addons:
       - mysql-client-core-5.6
       - mysql-client-5.6
       - postgresql-client-9.4
+matrix:
+  exclude:
+    - rvm: 2.3.8
+      gemfile: gemfiles/activerecord_6.0.gemfile
+    - rvm: 2.4.5
+      gemfile: gemfiles/activerecord_6.0.gemfile

data/Appraisals

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 appraise 'activerecord-5.0' do
   gem 'activerecord', '~> 5.0.1'
   gem 'pg', '< 1.0.0'
@@ -13,3 +11,7 @@ appraise 'activerecord-5.2' do
   gem 'activerecord', '~> 5.2.0'
   gem 'mysql2', '~> 0.4.4'
 end
+
+appraise 'activerecord-6.0' do
+  gem 'activerecord', '~> 6.0.0.rc1'
+end

data/Gemfile

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in ridgepole.gemspec

data/README.md

@@ -5,8 +5,9 @@ Ridgepole is a tool to manage DB schema.
 It defines DB schema using [Rails DSL](http://guides.rubyonrails.org/migrations.html#types-of-schema-dumps), and updates DB schema according to DSL.
 (like Chef/Puppet)
 
-[![Gem Version](https://badge.fury.io/rb/ridgepole.svg)](http://badge.fury.io/rb/ridgepole)
-[![Unstable Version](https://img.shields.io/badge/unstable-0.8.0.rc1-green.svg?longCache=true&style=flat)](https://rubygems.org/gems/ridgepole/versions/0.8.0.rc1)
+[![Gem Version](https://badge.fury.io/rb/ridgepole.svg)](http://badge.fury.io/rb/ridgepole)<!--
+[![Unstable Version](https://img.shields.io/badge/unstable-0.7.5.beta2-green.svg?longCache=true&style=flat)](https://rubygems.org/gems/ridgepole/versions/0.7.5.beta2)
+-->
 [![Build Status](https://travis-ci.org/winebarrel/ridgepole.svg?branch=0.7)](https://travis-ci.org/winebarrel/ridgepole)
 [![Coverage Status](https://coveralls.io/repos/github/winebarrel/ridgepole/badge.svg?branch=0.7)](https://coveralls.io/github/winebarrel/ridgepole?branch=0.7)
 
@@ -98,8 +99,6 @@ It defines DB schema using [Rails DSL](http://guides.rubyonrails.org/migrations.
   * Add ignore option ([pull#267](https://github.com/winebarrel/ridgepole/pull/267))
 * `>= 0.7.7`
   * Support URI query string ([pull#273](https://github.com/winebarrel/ridgepole/pull/273))
-* `>= 0.7.8`
-  * Fix for `add_foreign_key(..., column: ,,,)` ([pull#278](https://github.com/winebarrel/ridgepole/pull/278))
 </details>
 
 ## Installation

data/Rakefile

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 require 'rubocop/rake_task'

data/bin/ridgepole

@@ -1,6 +1,4 @@
 #!/usr/bin/env ruby
-# frozen_string_literal: true
-
 $LOAD_PATH << File.expand_path('../lib', __dir__)
 require 'yaml'
 require 'optparse'
@@ -12,9 +10,9 @@ $stdout.sync = true
 $stderr.sync = true
 
 Version = Ridgepole::VERSION
-DEFAULT_FILENAME = 'Schemafile'
+DEFAULT_FILENAME = 'Schemafile'.freeze
 
-MAGIC_COMMENT = <<-RUBY
+MAGIC_COMMENT = <<-RUBY.freeze
 # -*- mode: ruby -*-
 # vi: set ft=ruby :
 RUBY

data/gemfiles/activerecord_6.0.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "activerecord", "~> 6.0.0.rc1"
+
+gemspec path: "../"

data/lib/ridgepole.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 require 'logger'
 require 'open3'
 require 'pp'

data/lib/ridgepole/cli/config.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 require 'erb'
 require 'yaml'
 

data/lib/ridgepole/client.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Ridgepole
   class Client
     def initialize(conn_spec, options = {})

data/lib/ridgepole/connection_adapters.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Ridgepole
   class ConnectionAdapters
     def self.mysql?

data/lib/ridgepole/default_limit.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Ridgepole
   class DefaultsLimit
     DEFAULTS_LIMITS = {

data/lib/ridgepole/delta.rb

@@ -1,8 +1,6 @@
-# frozen_string_literal: true
-
 module Ridgepole
   class Delta
-    SCRIPT_NAME = '<Schema>'
+    SCRIPT_NAME = '<Schema>'.freeze
 
     def initialize(delta, options = {})
       @delta = delta

data/lib/ridgepole/diff.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Ridgepole
   class Diff
     PRIMARY_KEY_OPTIONS = %i[id limit default null precision scale collation unsigned].freeze
@@ -351,9 +349,9 @@ module Ridgepole
     end
 
     def target?(table_name)
-      if @options[:tables]&.include?(table_name)
+      if @options[:tables] && @options[:tables].include?(table_name)
         true
-      elsif @options[:ignore_tables]&.any? { |i| i =~ table_name }
+      elsif @options[:ignore_tables] && @options[:ignore_tables].any? { |i| i =~ table_name }
         false
       elsif @options[:tables]
         false

data/lib/ridgepole/dsl_parser.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Ridgepole
   class DSLParser
     def initialize(options = {})

data/lib/ridgepole/dsl_parser/context.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Ridgepole
   class DSLParser
     class Context
@@ -28,7 +26,7 @@ module Ridgepole
         table_name = table_name.to_s
         table_definition = TableDefinition.new(table_name, self)
 
-        options[:primary_key] = options[:primary_key].to_s if options[:primary_key]&.is_a?(Symbol)
+        options[:primary_key] = options[:primary_key].to_s if options[:primary_key] && options[:primary_key].is_a?(Symbol)
         if options[:id] && TableDefinition::ALIAS_TYPES.key?(options[:id])
           type, type_default_opts = TableDefinition::ALIAS_TYPES[options[:id]]
           options[:id] = type
@@ -82,7 +80,7 @@ module Ridgepole
         options[:column] = options[:column].to_s if options[:column]
         @__definition[from_table] ||= {}
         @__definition[from_table][:foreign_keys] ||= {}
-        idx = options[:name] || [from_table, to_table, options[:column]]
+        idx = options[:name] || [from_table, to_table]
 
         raise "Foreign Key `#{from_table}(#{idx})` already defined" if @__definition[from_table][:foreign_keys][idx]
 
@@ -93,7 +91,7 @@ module Ridgepole
       end
 
       def require(file)
-        schemafile = %r{\A/}.match?(file) ? file : File.join(@__working_dir, file)
+        schemafile = file =~ %r{\A/} ? file : File.join(@__working_dir, file)
 
         if File.exist?(schemafile)
           instance_eval(File.read(schemafile), schemafile)

data/lib/ridgepole/dsl_parser/table_definition.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Ridgepole
   class DSLParser
     class TableDefinition

data/lib/ridgepole/dumper.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Ridgepole
   class Dumper
     def initialize(options = {})

data/lib/ridgepole/execute_expander.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Ridgepole
   class ExecuteExpander
     class Stub
@@ -20,7 +18,7 @@ module Ridgepole
             callback.call(sql, name)
           end
 
-          if /\A(SELECT|SHOW)\b/i.match?(sql)
+          if sql =~ /\A(SELECT|SHOW)\b/i
             begin
               super(sql, name)
             rescue StandardError
@@ -30,7 +28,7 @@ module Ridgepole
             Stub.new
           end
         elsif Ridgepole::ExecuteExpander.use_script
-          if /\A(SELECT|SHOW)\b/i.match?(sql)
+          if sql =~ /\A(SELECT|SHOW)\b/i
             super(sql, name)
           else
             sql = append_alter_extra(sql)

data/lib/ridgepole/ext/abstract_adapter/disable_table_options.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 require 'active_record/connection_adapters/abstract_adapter'
 
 module Ridgepole

data/lib/ridgepole/ext/abstract_mysql_adapter/dump_auto_increment.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 require 'active_record/connection_adapters/abstract_mysql_adapter'
 
 module Ridgepole

data/lib/ridgepole/ext/abstract_mysql_adapter/use_alter_index.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 require 'active_record/connection_adapters/abstract_mysql_adapter'
 
 module Ridgepole

data/lib/ridgepole/ext/pp_sort_hash.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Ridgepole
   module Ext
     module PpSortHash

data/lib/ridgepole/ext/schema_dumper.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 require 'active_record/schema_dumper'
 
 module Ridgepole

data/lib/ridgepole/external_sql_executer.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Ridgepole
   class ExternalSqlExecuter
     def initialize(script, logger)

data/lib/ridgepole/logger.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Ridgepole
   class Logger < ::Logger
     include Singleton

data/lib/ridgepole/migration_ext.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 require 'active_record/migration'
 
 module Ridgepole

data/lib/ridgepole/schema_dumper_ext.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 require 'active_record/schema_dumper'
 
 module Ridgepole

data/lib/ridgepole/schema_statements_ext.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 require 'active_record/connection_adapters/abstract/schema_statements'
 
 module Ridgepole

data/lib/ridgepole/version.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Ridgepole
-  VERSION = '0.7.8'
+  VERSION = '0.8.0.rc1'.freeze
 end

data/ridgepole.gemspec

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'ridgepole/version'

data/spec/cli_helper.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module CLIHelper
   def default_cli_hook
     <<-RUBY.strip_heredoc

data/spec/erb_helper.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 include ERBh
 
 ERBh.define_method(:i) do |obj|

data/spec/hide_pending_formatter.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 class HidePendingFormatter < RSpec::Core::Formatters::ProgressFormatter
   RSpec::Core::Formatters.register self, :example_pending
   RSpec::Core::Formatters.register self, :dump_pending

data/spec/mysql/_migrate/migrate_change_table_option_spec.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 describe 'Ridgepole::Client#diff -> migrate' do
   context 'when change mysql table options' do
     let(:actual_dsl) do
@@ -18,9 +16,9 @@ describe 'Ridgepole::Client#diff -> migrate' do
       erbh(<<-ERB)
         create_table "employees", primary_key: "emp_no", force: :cascade, options: "ENGINE=InnoDB DEFAULT CHARSET=ascii" do |t|
           t.date   "birth_date", null: false
-          t.string "first_name", limit: 14, null: false, <%= i cond(5.2, collation: "utf8_general_ci") %>
-          t.string "last_name", limit: 16, null: false, <%= i cond(5.2, collation: "utf8_general_ci") %>
-          t.string "gender", limit: 1, null: false, <%= i cond(5.2, collation: "utf8_general_ci") %>
+          t.string "first_name", limit: 14, null: false, <%= i cond('>= 5.2', collation: "utf8_general_ci") %>
+          t.string "last_name", limit: 16, null: false, <%= i cond('>= 5.2', collation: "utf8_general_ci") %>
+          t.string "gender", limit: 1, null: false, <%= i cond('>= 5.2', collation: "utf8_general_ci") %>
           t.date   "hire_date", null: false
         end
       ERB

data/spec/mysql/bigint_pk/bigint_pk_spec.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 describe 'Ridgepole::Client (with bigint pk)', condition: 5.0 do
   let(:id_primary_key_create_table) do
     <<-RUBY

data/spec/mysql/bigint_pk/int_pk_spec.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 describe 'Ridgepole::Client (with integer pk)', condition: '>= 5.1.0' do
   context 'when with id:integer' do
     let(:dsl) do

data/spec/mysql/cli/config_spec.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 describe Ridgepole::Config do
   subject { Ridgepole::Config.load(config, env) }
 

data/spec/mysql/cli/ridgepole_spec.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 describe 'ridgepole' do
   let(:differ) { false }
   let(:conf) { "'" + JSON.dump(conn_spec) + "'" }