ridgepole 0.7.3.beta → 0.7.3.beta2

data/spec/postgresql/migrate/migrate_create_table_with_default_proc_spec.rb

@@ -2,15 +2,15 @@ describe 'Ridgepole::Client#diff -> migrate' do
   context 'when create table with default proc' do
     let(:dsl) { '' }
 
-    let(:actual_dsl) {
-      erbh(<<-EOS)
+    let(:actual_dsl) do
+      erbh(<<-ERB)
         create_table "users", id: :uuid, default: -> { "uuid_generate_v4()" }, force: :cascade do |t|
           t.string   "name"
           t.datetime "created_at", null: false
           t.datetime "updated_at", null: false
         end
-      EOS
-    }
+      ERB
+    end
 
     let(:expected_dsl) { dsl }
 
@@ -29,15 +29,15 @@ describe 'Ridgepole::Client#diff -> migrate' do
   end
 
   context 'when create table with default proc without change' do
-    let(:dsl) {
-      erbh(<<-EOS)
+    let(:dsl) do
+      erbh(<<-ERB)
         create_table "users", id: :uuid, default: -> { "uuid_generate_v4()" }, force: :cascade do |t|
           t.string   "name"
           t.datetime "created_at", null: false
           t.datetime "updated_at", null: false
         end
-      EOS
-    }
+      ERB
+    end
 
     before { subject.diff(dsl).migrate }
     subject { client }
@@ -54,25 +54,25 @@ describe 'Ridgepole::Client#diff -> migrate' do
   end
 
   context 'when migrate table with default proc change' do
-    let(:actual_dsl) {
-      erbh(<<-EOS)
+    let(:actual_dsl) do
+      erbh(<<-ERB)
         create_table "users", id: :uuid, default: -> { "uuid_generate_v1()" }, force: :cascade do |t|
           t.string   "name"
           t.datetime "created_at", null: false
           t.datetime "updated_at", null: false
         end
-      EOS
-    }
+      ERB
+    end
 
-    let(:expected_dsl) {
-      erbh(<<-EOS)
+    let(:expected_dsl) do
+      erbh(<<-ERB)
         create_table "users", id: :uuid, default: -> { "uuid_generate_v4()" }, force: :cascade do |t|
           t.string   "name"
           t.datetime "created_at", null: false
           t.datetime "updated_at", null: false
         end
-      EOS
-    }
+      ERB
+    end
 
     before { subject.diff(actual_dsl).migrate }
     subject { client(allow_pk_change: allow_pk_change) }
@@ -81,11 +81,11 @@ describe 'Ridgepole::Client#diff -> migrate' do
       let(:allow_pk_change) { false }
 
       it {
-        expect(Ridgepole::Logger.instance).to receive(:warn).with(<<-EOS)
+        expect(Ridgepole::Logger.instance).to receive(:warn).with(<<-MSG)
 [WARNING] Primary key definition of `users` differ but `allow_pk_change` option is false
   from: {:id=>:uuid, :default=>"uuid_generate_v1()"}
     to: {:id=>:uuid, :default=>"uuid_generate_v4()"}
-        EOS
+        MSG
 
         delta = subject.diff(expected_dsl)
         expect(delta.differ?).to be_falsey

data/spec/postgresql/migrate/migrate_drop_column_spec.rb

@@ -1,7 +1,7 @@
 describe 'Ridgepole::Client#diff -> migrate' do
   context 'when drop column' do
-    let(:actual_dsl) {
-      erbh(<<-EOS)
+    let(:actual_dsl) do
+      erbh(<<-ERB)
         create_table "clubs", force: :cascade do |t|
           t.string "name", limit: 255, default: "", null: false
           t.index ["name"], name: "idx_name", unique: true, <%= i cond(5.0, using: :btree) %>
@@ -58,11 +58,11 @@ describe 'Ridgepole::Client#diff -> migrate' do
           t.date    "to_date"
           t.index ["emp_no"], name: "idx_titles_emp_no", <%= i cond(5.0, using: :btree) %>
         end
-      EOS
-    }
+      ERB
+    end
 
-    let(:expected_dsl) {
-      erbh(<<-EOS)
+    let(:expected_dsl) do
+      erbh(<<-ERB)
         create_table "clubs", force: :cascade do |t|
           t.string "name", limit: 255, default: "", null: false
           t.index ["name"], name: "idx_name", unique: true, <%= i cond(5.0, using: :btree) %>
@@ -113,8 +113,8 @@ describe 'Ridgepole::Client#diff -> migrate' do
           t.date    "to_date"
           t.index ["emp_no"], name: "idx_titles_emp_no", <%= i cond(5.0, using: :btree) %>
         end
-      EOS
-    }
+      ERB
+    end
 
     before { subject.diff(actual_dsl).migrate }
     subject { client }
@@ -128,10 +128,10 @@ describe 'Ridgepole::Client#diff -> migrate' do
     }
 
     it {
-      delta = client(:bulk_change => true).diff(expected_dsl)
+      delta = client(bulk_change: true).diff(expected_dsl)
       expect(delta.differ?).to be_truthy
       expect(subject.dump).to match_ruby actual_dsl
-      expect(delta.script).to match_fuzzy <<-EOS
+      expect(delta.script).to match_fuzzy <<-RUBY
         change_table("dept_emp", {:bulk => true}) do |t|
           t.remove("from_date")
           t.remove("to_date")
@@ -146,7 +146,7 @@ describe 'Ridgepole::Client#diff -> migrate' do
           t.remove("last_name")
           t.remove("hire_date")
         end
-      EOS
+      RUBY
       delta.migrate
       expect(subject.dump).to match_ruby expected_dsl
     }

data/spec/postgresql/migrate/migrate_drop_column_with_index_spec.rb

@@ -1,7 +1,7 @@
 describe 'Ridgepole::Client#diff -> migrate' do
   context 'when drop column and index' do
-    let(:actual_dsl) {
-      erbh(<<-EOS)
+    let(:actual_dsl) do
+      erbh(<<-ERB)
         create_table "clubs", force: :cascade do |t|
           t.string "name", limit: 255, default: "", null: false
           t.index ["name"], name: "idx_name", unique: true, <%= i cond(5.0, using: :btree) %>
@@ -58,11 +58,11 @@ describe 'Ridgepole::Client#diff -> migrate' do
           t.date    "to_date"
           t.index ["emp_no"], name: "idx_titles_emp_no", <%= i cond(5.0, using: :btree) %>
         end
-      EOS
-    }
+      ERB
+    end
 
-    let(:expected_dsl) {
-      erbh(<<-EOS)
+    let(:expected_dsl) do
+      erbh(<<-ERB)
         create_table "clubs", force: :cascade do |t|
           t.string "name", limit: 255, default: "", null: false
           t.index ["name"], name: "idx_name", unique: true, <%= i cond(5.0, using: :btree) %>
@@ -108,8 +108,8 @@ describe 'Ridgepole::Client#diff -> migrate' do
           t.date    "to_date"
           t.index ["emp_no"], name: "idx_titles_emp_no", <%= i cond(5.0, using: :btree) %>
         end
-      EOS
-    }
+      ERB
+    end
 
     before { subject.diff(actual_dsl).migrate }
     subject { client }
@@ -126,15 +126,15 @@ describe 'Ridgepole::Client#diff -> migrate' do
       delta = subject.diff(expected_dsl)
       expect(delta.differ?).to be_truthy
       expect(subject.dump).to match_ruby actual_dsl
-      delta.migrate(:noop => true)
+      delta.migrate(noop: true)
       expect(subject.dump).to match_ruby actual_dsl
     }
 
     it {
-      delta = client(:bulk_change => true).diff(expected_dsl)
+      delta = client(bulk_change: true).diff(expected_dsl)
       expect(delta.differ?).to be_truthy
       expect(subject.dump).to match_ruby actual_dsl
-      expect(delta.script).to match_fuzzy erbh(<<-EOS)
+      expect(delta.script).to match_fuzzy erbh(<<-ERB)
 change_table("dept_emp", {:bulk => true}) do |t|
   t.remove("emp_no")
   t.remove("from_date")
@@ -156,7 +156,7 @@ change_table("employees", {:bulk => true}) do |t|
   t.remove("last_name")
   t.remove("hire_date")
 end
-      EOS
+      ERB
       delta.migrate
       expect(subject.dump).to match_ruby expected_dsl
     }

data/spec/postgresql/migrate/migrate_drop_expression_index_spec.rb

@@ -6,20 +6,20 @@ describe 'Ridgepole::Client#diff -> migrate' do
   end
 
   context 'when drop column from table containing an expression index' do
-    let(:actual_dsl) { erbh(<<-EOS) }
+    let(:actual_dsl) { erbh(<<-ERB) }
       create_table "users", force: :cascade do |t|
         t.string "name", null: false
         t.datetime "created_at", null: false
         t.index "lower((name)::text)", name: "index_users_on_lower_name", <%= i cond(5.0, using: :btree) %>
       end
-    EOS
+    ERB
 
-    let(:expected_dsl) { erbh(<<-EOS) }
+    let(:expected_dsl) { erbh(<<-ERB) }
       create_table "users", force: :cascade do |t|
         t.string "name", null: false
         t.index "lower((name)::text)", name: "index_users_on_lower_name", <%= i cond(5.0, using: :btree) %>
       end
-    EOS
+    ERB
 
     specify do
       delta = subject.diff(expected_dsl)
@@ -32,18 +32,18 @@ describe 'Ridgepole::Client#diff -> migrate' do
   end
 
   context 'when drop expression index' do
-    let(:actual_dsl) { erbh(<<-EOS) }
+    let(:actual_dsl) { erbh(<<-ERB) }
       create_table "users", force: :cascade do |t|
         t.string "name", null: false
         t.index "lower((name)::text)", name: "index_users_on_lower_name", <%= i cond(5.0, using: :btree) %>
       end
-    EOS
+    ERB
 
-    let(:expected_dsl) { <<-EOS }
+    let(:expected_dsl) { <<-RUBY }
       create_table "users", force: :cascade do |t|
         t.string "name", null: false
       end
-    EOS
+    RUBY
 
     specify do
       delta = subject.diff(expected_dsl)

data/spec/postgresql/migrate/migrate_drop_index_spec.rb

@@ -1,7 +1,7 @@
 describe 'Ridgepole::Client#diff -> migrate' do
   context 'when drop index' do
-    let(:dsl) {
-      erbh(<<-EOS)
+    let(:dsl) do
+      erbh(<<-ERB)
         create_table "clubs", force: :cascade do |t|
           t.string "name", limit: 255, default: "", null: false
           t.index ["name"], name: "idx_name", unique: true, <%= i cond(5.0, using: :btree) %>
@@ -58,13 +58,13 @@ describe 'Ridgepole::Client#diff -> migrate' do
           t.date    "to_date"
           t.index ["emp_no"], name: "idx_titles_emp_no", <%= i cond(5.0, using: :btree) %>
         end
-      EOS
-    }
+      ERB
+    end
 
     let(:actual_dsl) { dsl }
 
-    let(:expected_dsl) {
-      erbh(<<-EOS)
+    let(:expected_dsl) do
+      erbh(<<-ERB)
         create_table "clubs", force: :cascade do |t|
           t.string "name", limit: 255, default: "", null: false
         end
@@ -118,8 +118,8 @@ describe 'Ridgepole::Client#diff -> migrate' do
           t.date    "from_date", null: false
           t.date    "to_date"
         end
-      EOS
-    }
+      ERB
+    end
 
     before { subject.diff(actual_dsl).migrate }
     subject { client }
@@ -133,10 +133,10 @@ describe 'Ridgepole::Client#diff -> migrate' do
     }
 
     it {
-      delta = client(:bulk_change => true).diff(expected_dsl)
+      delta = client(bulk_change: true).diff(expected_dsl)
       expect(delta.differ?).to be_truthy
       expect(subject.dump).to match_ruby actual_dsl
-      expect(delta.script).to match_fuzzy <<-EOS
+      expect(delta.script).to match_fuzzy <<-RUBY
         change_table("clubs", {:bulk => true}) do |t|
           t.remove_index({:name=>"idx_name"})
         end
@@ -148,7 +148,7 @@ describe 'Ridgepole::Client#diff -> migrate' do
         change_table("titles", {:bulk => true}) do |t|
           t.remove_index({:name=>"idx_titles_emp_no"})
         end
-      EOS
+      RUBY
       delta.migrate
       expect(subject.dump).to match_ruby expected_dsl
     }

data/spec/postgresql/migrate/migrate_drop_table_spec.rb

@@ -1,7 +1,7 @@
 describe 'Ridgepole::Client#diff -> migrate' do
   context 'when drop table' do
-    let(:dsl) {
-      erbh(<<-EOS)
+    let(:dsl) do
+      erbh(<<-ERB)
         create_table "clubs", force: :cascade do |t|
           t.string "name", limit: 255, default: "", null: false
           t.index ["name"], name: "idx_name", unique: true, <%= i cond(5.0, using: :btree) %>
@@ -58,13 +58,13 @@ describe 'Ridgepole::Client#diff -> migrate' do
           t.date    "to_date"
           t.index ["emp_no"], name: "idx_titles_emp_no", <%= i cond(5.0, using: :btree) %>
         end
-      EOS
-    }
+      ERB
+    end
 
     let(:actual_dsl) { dsl }
 
-    let(:expected_dsl) {
-      erbh(<<-EOS)
+    let(:expected_dsl) do
+      erbh(<<-ERB)
         create_table "departments", primary_key: "dept_no", force: :cascade do |t|
           t.string "dept_name", limit: 40, null: false
           t.index ["dept_name"], name: "idx_dept_name", unique: true, <%= i cond(5.0, using: :btree) %>
@@ -103,8 +103,8 @@ describe 'Ridgepole::Client#diff -> migrate' do
           t.date    "to_date"
           t.index ["emp_no"], name: "idx_titles_emp_no", <%= i cond(5.0, using: :btree) %>
         end
-      EOS
-    }
+      ERB
+    end
 
     before { subject.diff(actual_dsl).migrate }
     subject { client }

data/spec/postgresql/migrate/migrate_ext_cols_spec.rb

@@ -1,7 +1,7 @@
 describe 'Ridgepole::Client#diff -> migrate' do
   context 'when add column (ext cols)' do
-    let(:actual_dsl) {
-      <<-EOS
+    let(:actual_dsl) do
+      <<-RUBY
         create_table "items", force: :cascade do |t|
           t.string   "name"
           t.integer  "price"
@@ -9,11 +9,11 @@ describe 'Ridgepole::Client#diff -> migrate' do
           t.datetime "created_at", null: false
           t.datetime "updated_at", null: false
         end
-      EOS
-    }
+      RUBY
+    end
 
-    let(:expected_dsl) {
-      <<-EOS
+    let(:expected_dsl) do
+      <<-RUBY
         create_table "items", force: :cascade do |t|
           t.string      "name"
           t.integer     "price"
@@ -45,8 +45,8 @@ describe 'Ridgepole::Client#diff -> migrate' do
           t.bit_varying "bit varying"
           t.money       "money", scale: 2
         end
-      EOS
-    }
+      RUBY
+    end
 
     before { subject.diff(actual_dsl).migrate }
     subject { client }

data/spec/postgresql/migrate/migrate_primary_key_spec.rb

@@ -0,0 +1,97 @@
+describe 'Ridgepole::Client#diff -> migrate', condition: '>= 5.1.0' do
+  let(:actual_dsl) do
+    erbh(<<-ERB)
+      create_table "employees", id: :serial, force: :cascade do |t|
+      end
+    ERB
+  end
+
+  before do
+    subject.diff('').migrate
+    subject.diff(actual_dsl).migrate
+  end
+  subject { client(allow_pk_change: allow_pk_change) }
+
+  context 'when allow_pk_change option is false' do
+    let(:allow_pk_change) { false }
+
+    context 'with difference' do
+      let(:expected_dsl) do
+        erbh(<<-ERB)
+          create_table "employees", id: :bigint, force: :cascade do |t|
+          end
+        ERB
+      end
+
+      it {
+        expect(Ridgepole::Logger.instance).to receive(:warn).with(<<-MSG)
+[WARNING] Primary key definition of `employees` differ but `allow_pk_change` option is false
+  from: {:id=>:serial}
+    to: {:id=>:bigint}
+        MSG
+
+        delta = subject.diff(expected_dsl)
+        expect(delta.differ?).to be_falsey
+        delta.migrate
+        expect(subject.dump).to match_ruby actual_dsl
+      }
+    end
+
+    context 'with no difference' do
+      let(:actual_dsl) do
+        erbh(<<-ERB)
+          create_table "employees", id: :serial, force: :cascade do |t|
+          end
+        ERB
+      end
+      let(:expected_dsl) { actual_dsl }
+
+      it {
+        expect(Ridgepole::Logger.instance).to_not receive(:warn)
+
+        delta = subject.diff(expected_dsl)
+        expect(delta.differ?).to be_falsey
+      }
+    end
+  end
+
+  context 'when allow_pk_change option is true' do
+    let(:allow_pk_change) { true }
+    let(:actual_dsl) do
+      erbh(<<-ERB)
+        create_table "employees", id: :serial, force: :cascade do |t|
+        end
+      ERB
+    end
+    let(:expected_dsl) do
+      erbh(<<-ERB)
+        create_table "employees", force: :cascade do |t|
+        end
+      ERB
+    end
+
+    it {
+      delta = subject.diff(expected_dsl)
+      expect(delta.differ?).to be_truthy
+      delta.migrate
+      expect(subject.dump).to match_ruby expected_dsl
+    }
+  end
+
+  context 'when allow_pk_change option is true and :id is false' do
+    let(:allow_pk_change) { true }
+    let(:expected_dsl) do
+      erbh(<<-ERB)
+        create_table "employees", id: false, force: :cascade do |t|
+        end
+      ERB
+    end
+
+    it {
+      delta = subject.diff(expected_dsl)
+      expect(delta).to be_differ
+      delta.migrate
+      expect(subject.dump).to match_ruby expected_dsl
+    }
+  end
+end