ridgepole 0.6.0.beta2 → 0.6.0.beta3

data/spec/postgresql/migrate/migrate_rename_table_spec.rb

@@ -0,0 +1,199 @@
+if postgresql?
+describe 'Ridgepole::Client#diff -> migrate' do
+  context 'when rename table' do
+    let(:actual_dsl) {
+      <<-RUBY
+        create_table "clubs", force: :cascade do |t|
+          t.string "name", limit: 255, default: "", null: false
+        end
+
+        add_index "clubs", ["name"], name: "idx_name", unique: true, using: :btree
+
+        create_table "departments", primary_key: "dept_no", force: :cascade do |t|
+          t.string "dept_name", limit: 40, null: false
+        end
+
+        add_index "departments", ["dept_name"], name: "idx_dept_name", unique: true, using: :btree
+
+        create_table "dept_emp", id: false, force: :cascade do |t|
+          t.integer "emp_no",              null: false
+          t.string  "dept_no",   limit: 4, null: false
+          t.date    "from_date",           null: false
+          t.date    "to_date",             null: false
+        end
+
+        add_index "dept_emp", ["dept_no"], name: "idx_dept_emp_dept_no", using: :btree
+        add_index "dept_emp", ["emp_no"], name: "idx_dept_emp_emp_no", using: :btree
+
+        create_table "dept_manager", id: false, force: :cascade do |t|
+          t.string  "dept_no",   limit: 4, null: false
+          t.integer "emp_no",              null: false
+          t.date    "from_date",           null: false
+          t.date    "to_date",             null: false
+        end
+
+        add_index "dept_manager", ["dept_no"], name: "idx_dept_manager_dept_no", using: :btree
+        add_index "dept_manager", ["emp_no"], name: "idx_dept_manager_emp_no", using: :btree
+
+        create_table "employee_clubs", force: :cascade do |t|
+          t.integer "emp_no",  null: false
+          t.integer "club_id", null: false
+        end
+
+        add_index "employee_clubs", ["emp_no", "club_id"], name: "idx_employee_clubs_emp_no_club_id", using: :btree
+
+        create_table "employees", primary_key: "emp_no", force: :cascade do |t|
+          t.date   "birth_date",            null: false
+          t.string "first_name", limit: 14, null: false
+          t.string "last_name",  limit: 16, null: false
+          t.date   "hire_date",             null: false
+        end
+
+        create_table "salaries", id: false, force: :cascade do |t|
+          t.integer "emp_no",    null: false
+          t.integer "salary",    null: false
+          t.date    "from_date", null: false
+          t.date    "to_date",   null: false
+        end
+
+        add_index "salaries", ["emp_no"], name: "idx_salaries_emp_no", using: :btree
+
+        create_table "titles", id: false, force: :cascade do |t|
+          t.integer "emp_no",               null: false
+          t.string  "title",     limit: 50, null: false
+          t.date    "from_date",            null: false
+          t.date    "to_date"
+        end
+
+        add_index "titles", ["emp_no"], name: "idx_titles_emp_no", using: :btree
+      RUBY
+    }
+
+    let(:expected_dsl) {
+      <<-RUBY
+        create_table "clubs", force: :cascade do |t|
+          t.string "name", limit: 255, default: "", null: false
+        end
+
+        add_index "clubs", ["name"], name: "idx_name", unique: true, using: :btree
+
+        create_table "departments", primary_key: "dept_no", force: :cascade do |t|
+          t.string "dept_name", limit: 40, null: false
+        end
+
+        add_index "departments", ["dept_name"], name: "idx_dept_name", unique: true, using: :btree
+
+        create_table "dept_emp", id: false, force: :cascade do |t|
+          t.integer "emp_no",              null: false
+          t.string  "dept_no",   limit: 4, null: false
+          t.date    "from_date",           null: false
+          t.date    "to_date",             null: false
+        end
+
+        add_index "dept_emp", ["dept_no"], name: "idx_dept_emp_dept_no", using: :btree
+        add_index "dept_emp", ["emp_no"], name: "idx_dept_emp_emp_no", using: :btree
+
+        create_table "dept_manager", id: false, force: :cascade do |t|
+          t.string  "dept_no",   limit: 4, null: false
+          t.integer "emp_no",              null: false
+          t.date    "from_date",           null: false
+          t.date    "to_date",             null: false
+        end
+
+        add_index "dept_manager", ["dept_no"], name: "idx_dept_manager_dept_no", using: :btree
+        add_index "dept_manager", ["emp_no"], name: "idx_dept_manager_emp_no", using: :btree
+
+        create_table "employee_clubs", force: :cascade do |t|
+          t.integer "emp_no",  null: false
+          t.integer "club_id", null: false
+        end
+
+        add_index "employee_clubs", ["emp_no", "club_id"], name: "idx_employee_clubs_emp_no_club_id", using: :btree
+
+        create_table "employees2", primary_key: "emp_no", force: :cascade, renamed_from: 'employees' do |t|
+          t.date   "birth_date",            null: false
+          t.string "first_name", limit: 14, null: false
+          t.string "last_name",  limit: 16, null: false
+          t.date   "hire_date",             null: false
+        end
+
+        create_table "salaries", id: false, force: :cascade do |t|
+          t.integer "emp_no",    null: false
+          t.integer "salary",    null: false
+          t.date    "from_date", null: false
+          t.date    "to_date",   null: false
+        end
+
+        add_index "salaries", ["emp_no"], name: "idx_salaries_emp_no", using: :btree
+
+        create_table "titles", id: false, force: :cascade do |t|
+          t.integer "emp_no",               null: false
+          t.string  "title",     limit: 50, null: false
+          t.date    "from_date",            null: false
+          t.date    "to_date"
+        end
+
+        add_index "titles", ["emp_no"], name: "idx_titles_emp_no", using: :btree
+      RUBY
+    }
+
+    before { subject.diff(actual_dsl).migrate }
+    subject { client }
+
+    it {
+      delta = subject.diff(expected_dsl)
+      expect(delta.differ?).to be_truthy
+      expect(subject.dump).to eq actual_dsl.strip_heredoc.strip
+      delta.migrate
+      expect(subject.dump).to eq expected_dsl.strip_heredoc.strip.gsub(/, renamed_from: 'employees'/, '')
+    }
+
+    it {
+      delta = Ridgepole::Client.diff(actual_dsl, expected_dsl, reverse: true)
+      expect(delta.differ?).to be_truthy
+      expect(delta.script).to eq <<-RUBY.strip_heredoc.strip
+        rename_table("employees2", "employees")
+      RUBY
+    }
+  end
+
+  context 'when rename table (dry-run)' do
+    let(:actual_dsl) {
+      <<-RUBY
+        create_table "employees", primary_key: "emp_no", force: :cascade do |t|
+          t.date   "birth_date",            null: false
+          t.string "first_name", limit: 14, null: false
+          t.string "last_name",  limit: 16, null: false
+          t.date   "hire_date",             null: false
+        end
+
+        add_index "employees", ["first_name"], name: "first_name", using: :btree
+      RUBY
+    }
+
+    let(:expected_dsl) {
+      <<-RUBY
+        create_table "employees2", primary_key: "emp_no", force: :cascade, renamed_from: 'employees' do |t|
+          t.date   "birth_date",            null: false
+          t.string "first_name", limit: 14, null: false
+          t.string "last_name",  limit: 16, null: false
+          t.date   "hire_date",             null: false
+        end
+
+        add_index "employees2", ["first_name"], name: "first_name", using: :btree
+      RUBY
+    }
+
+    before { subject.diff(actual_dsl).migrate }
+    subject { client }
+
+    it {
+      delta = subject.diff(expected_dsl)
+      expect(delta.differ?).to be_truthy
+      expect(subject.dump).to eq actual_dsl.strip_heredoc.strip
+      delta.migrate(noop: true)
+      expect(subject.dump).to eq actual_dsl.strip_heredoc.strip
+    }
+  end
+end
+end

data/spec/postgresql/migrate/migrate_same_spec.rb

@@ -0,0 +1,84 @@
+if postgresql?
+describe 'Ridgepole::Client#diff -> migrate' do
+  context 'when database and definition are same' do
+    let(:dsl) {
+      <<-RUBY
+        create_table "clubs", force: :cascade do |t|
+          t.string "name", limit: 255, default: "", null: false
+        end
+
+        add_index "clubs", ["name"], name: "idx_name", unique: true, using: :btree
+
+        create_table "departments", primary_key: "dept_no", force: :cascade do |t|
+          t.string "dept_name", limit: 40, null: false
+        end
+
+        add_index "departments", ["dept_name"], name: "idx_dept_name", unique: true, using: :btree
+
+        create_table "dept_emp", id: false, force: :cascade do |t|
+          t.integer "emp_no",              null: false
+          t.string  "dept_no",   limit: 4, null: false
+          t.date    "from_date",           null: false
+          t.date    "to_date",             null: false
+        end
+
+        add_index "dept_emp", ["dept_no"], name: "idx_dept_emp_dept_no", using: :btree
+        add_index "dept_emp", ["emp_no"], name: "idx_dept_emp_emp_no", using: :btree
+
+        create_table "dept_manager", id: false, force: :cascade do |t|
+          t.string  "dept_no",   limit: 4, null: false
+          t.integer "emp_no",              null: false
+          t.date    "from_date",           null: false
+          t.date    "to_date",             null: false
+        end
+
+        add_index "dept_manager", ["dept_no"], name: "idx_dept_manager_dept_no", using: :btree
+        add_index "dept_manager", ["emp_no"], name: "idx_dept_manager_emp_no", using: :btree
+
+        create_table "employee_clubs", force: :cascade do |t|
+          t.integer "emp_no",  null: false
+          t.integer "club_id", null: false
+        end
+
+        add_index "employee_clubs", ["emp_no", "club_id"], name: "idx_employee_clubs_emp_no_club_id", using: :btree
+
+        create_table "employees", primary_key: "emp_no", force: :cascade do |t|
+          t.date   "birth_date",            null: false
+          t.string "first_name", limit: 14, null: false
+          t.string "last_name",  limit: 16, null: false
+          t.date   "hire_date",             null: false
+        end
+
+        create_table "salaries", id: false, force: :cascade do |t|
+          t.integer "emp_no",    null: false
+          t.integer "salary",    null: false
+          t.date    "from_date", null: false
+          t.date    "to_date",   null: false
+        end
+
+        add_index "salaries", ["emp_no"], name: "idx_salaries_emp_no", using: :btree
+
+        create_table "titles", id: false, force: :cascade do |t|
+          t.integer "emp_no",               null: false
+          t.string  "title",     limit: 50, null: false
+          t.date    "from_date",            null: false
+          t.date    "to_date"
+        end
+
+        add_index "titles", ["emp_no"], name: "idx_titles_emp_no", using: :btree
+      RUBY
+    }
+
+    before { restore_tables }
+    subject { client }
+
+    it {
+      delta = subject.diff(dsl)
+      expect(delta.differ?).to be_falsey
+      expect(subject.dump).to eq dsl.strip_heredoc.strip
+      delta.migrate
+      expect(subject.dump).to eq dsl.strip_heredoc.strip
+    }
+  end
+end
+end

data/spec/postgresql/ridgepole_test_database.sql

@@ -0,0 +1,15 @@
+CREATE DATABASE ridgepole_test;
+
+\c ridgepole_test;
+
+DO $$
+DECLARE
+  stmts CURSOR FOR
+    SELECT tablename FROM pg_tables
+    WHERE schemaname = 'public';
+BEGIN
+  FOR stmt IN stmts LOOP
+    EXECUTE 'DROP TABLE ' || quote_ident(stmt.tablename) || ';';
+  END LOOP;
+END;
+$$

data/spec/postgresql/ridgepole_test_tables.sql

@@ -0,0 +1,74 @@
+\c ridgepole_test;
+
+DROP TABLE IF EXISTS clubs;
+CREATE TABLE clubs (
+  id serial PRIMARY KEY,
+  name varchar(255) NOT NULL DEFAULT ''
+);
+CREATE UNIQUE INDEX idx_name ON clubs (name);
+
+DROP TABLE IF EXISTS departments;
+CREATE TABLE departments (
+  dept_no char(4) PRIMARY KEY,
+  dept_name varchar(40) NOT NULL
+);
+CREATE UNIQUE INDEX idx_dept_name ON departments (dept_name);
+
+DROP TABLE IF EXISTS dept_emp ;
+CREATE TABLE dept_emp (
+  emp_no int NOT NULL,
+  dept_no char(4) NOT NULL,
+  from_date date NOT NULL,
+  to_date date NOT NULL,
+  PRIMARY KEY (emp_no,dept_no)
+);
+CREATE INDEX idx_dept_emp_emp_no ON dept_emp (emp_no);
+CREATE INDEX idx_dept_emp_dept_no ON dept_emp (dept_no);
+
+DROP TABLE IF EXISTS dept_manager;
+CREATE TABLE dept_manager (
+  dept_no char(4) NOT NULL,
+  emp_no int NOT NULL,
+  from_date date NOT NULL,
+  to_date date NOT NULL,
+  PRIMARY KEY (emp_no,dept_no)
+);
+CREATE INDEX idx_dept_manager_emp_no ON dept_manager (emp_no);
+CREATE INDEX idx_dept_manager_dept_no ON dept_manager (dept_no);
+
+DROP TABLE IF EXISTS employee_clubs;
+CREATE TABLE employee_clubs (
+  id serial PRIMARY KEY,
+  emp_no int NOT NULL,
+  club_id int NOT NULL
+);
+CREATE INDEX idx_employee_clubs_emp_no_club_id ON employee_clubs (emp_no,club_id);
+
+DROP TABLE IF EXISTS employees;
+CREATE TABLE employees (
+  emp_no int PRIMARY KEY,
+  birth_date date NOT NULL,
+  first_name varchar(14) NOT NULL,
+  last_name varchar(16) NOT NULL,
+  hire_date date NOT NULL
+);
+
+DROP TABLE IF EXISTS salaries;
+CREATE TABLE salaries (
+  emp_no int NOT NULL,
+  salary int NOT NULL,
+  from_date date NOT NULL,
+  to_date date NOT NULL,
+  PRIMARY KEY (emp_no,from_date)
+);
+CREATE INDEX idx_salaries_emp_no ON salaries (emp_no);
+
+DROP TABLE IF EXISTS titles;
+CREATE TABLE titles (
+  emp_no int NOT NULL,
+  title varchar(50) NOT NULL,
+  from_date date NOT NULL,
+  to_date date DEFAULT NULL,
+  PRIMARY KEY (emp_no,title,from_date)
+);
+CREATE INDEX idx_titles_emp_no ON titles (emp_no);

data/spec/spec_helper.rb

@@ -1,6 +1,10 @@
 $: << File.expand_path('..', __FILE__)
 
-if ENV['TRAVIS']
+def travis?
+  !!ENV['TRAVIS']
+end
+
+if travis?
   require 'simplecov'
   require 'coveralls'
 
@@ -37,15 +41,41 @@ RSpec.configure do |config|
 end
 
 def restore_database
-  sql_file = File.expand_path('../ridgepole_test_database.sql', __FILE__)
+  if postgresql?
+    restore_database_postgresql
+  else
+    restore_database_mysql
+  end
+end
+
+def restore_database_mysql
+  sql_file = File.expand_path('../mysql/ridgepole_test_database.sql', __FILE__)
   system("mysql -uroot < #{sql_file}")
 end
 
+def restore_database_postgresql
+  sql_file = File.expand_path('../postgresql/ridgepole_test_database.sql', __FILE__)
+  system("psql #{travis? ? '-U postgres' : ''} --set ON_ERROR_STOP=off -q -f #{sql_file} 2>/dev/null")
+end
+
 def restore_tables
-  sql_file = File.expand_path('../ridgepole_test_tables.sql', __FILE__)
+  if postgresql?
+    restore_tables_postgresql
+  else
+    restore_tables_mysql
+  end
+end
+
+def restore_tables_mysql
+  sql_file = File.expand_path('../mysql/ridgepole_test_tables.sql', __FILE__)
   system("mysql -uroot < #{sql_file}")
 end
 
+def restore_tables_postgresql
+  sql_file = File.expand_path('../postgresql/ridgepole_test_tables.sql', __FILE__)
+  system("psql #{travis? ? '-U postgres' : ''} -q -f #{sql_file} 2>/dev/null")
+end
+
 def client(options = {}, config = {})
   config = conn_spec(config)
 
@@ -65,17 +95,39 @@ def client(options = {}, config = {})
 end
 
 def conn_spec(config = {})
-  {
-    adapter: 'mysql2',
-    database: TEST_SCHEMA,
-  }.merge(config)
+  if postgresql?
+    spec = {
+      adapter: 'postgresql',
+      database: TEST_SCHEMA,
+    }
+
+    spec[:username] = 'postgres' if travis?
+    spec.merge(config)
+  else
+    {
+      adapter: 'mysql2',
+      database: TEST_SCHEMA,
+    }.merge(config)
+  end
 end
 
 def show_create_table(table_name)
+  if postgresql?
+    show_create_table_postgresql(table_name)
+  else
+    show_create_table_mysql(table_name)
+  end
+end
+
+def show_create_table_mysql(table_name)
   raw_conn = ActiveRecord::Base.connection.raw_connection
   raw_conn.query("SHOW CREATE TABLE `#{table_name}`").first[1]
 end
 
+def show_create_table_postgresql(table_name)
+  `pg_dump #{travis? ? '-U postgres' : ''} --schema-only #{TEST_SCHEMA} --table=#{table_name} | awk '/^CREATE TABLE/,/);/{print} /^CREATE INDEX/{print}'`.strip
+end
+
 def default_cli_hook
   <<-RUBY.strip_heredoc
     require 'ridgepole'
@@ -141,6 +193,10 @@ def mysql_awesome_enabled?
   ENV['ENABLE_MYSQL_AWESOME'] == '1'
 end
 
+def postgresql?
+  ENV['POSTGRESQL'] == '1'
+end
+
 def if_mysql_awesome_enabled(then_str, else_str = '')
   if mysql_awesome_enabled?
     then_str