ridgepole 0.1.9 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 988e497c3cb8157b97776d601a5f474c3bba8bc2
-  data.tar.gz: 55e21555cd9fe613434c51534585a412c2bd54ef
+  metadata.gz: 8b78450efbe8c650197b9515c90abced3f6a6575
+  data.tar.gz: 4e78c9e6a877414d75d58735ad8ebd2c0b2d090f
 SHA512:
-  metadata.gz: 7c593d58d748470b551729a6d17cd83b727cce3a12c106fd56f6a705dc2f94ff24ddc31488f8f10681d21525124da2ffb66ae794f3fed7269199ba9f1c5384cb
-  data.tar.gz: 1ccbed73bacbbd1ff57cdbbf871f57ae540704ecafce402b0b95bc616b02c455a95a1ecb6cc07f0ab1c7142353764ce003cc69a6ff5bcad8aae2e6692b5c7b7d
+  metadata.gz: 8be2793d3f8bc2f8083c5c50805dc180cec3e0ce451203d74f678f601aa2f24c5225d0fe0b81d142ba87bf40d879f9c54cbe7547c2af14612ec9ea4d451a3459
+  data.tar.gz: f8e0160bb8ade13201edf404c30278705ec9d8fad1b2d3cbd6390b8739db82b6754ef6eda4ca281da7a6196b847d931299961f1a2b972754f736c8b1ec1f36b4

data/README.md

@@ -34,3 +34,9 @@ ridgepole --apply
 ## Demo
 
 * [asciinema.org/a/9349](https://asciinema.org/a/9349)
+
+## Example project
+
+* https://github.com/winebarrel/ridgepole-example
+  * https://github.com/winebarrel/ridgepole-example/pull/1
+  * https://github.com/winebarrel/ridgepole-example/pull/2

data/lib/ridgepole/diff.rb

@@ -61,7 +61,7 @@ class Ridgepole::Diff
   end
 
   def scan_options_change(from, to, table_delta)
-    # XXX: Warn differences of options
+    Ridgepole::Logger.instance.warn('[WARNING] Table options cannot be changed')
   end
 
   def scan_definition_change(from, to, table_delta)

data/lib/ridgepole/dsl_parser.rb

@@ -51,20 +51,28 @@ class Ridgepole::DSLParser
     end
 
     def create_table(table_name, options = {})
-      # XXX: Add exist check
       table_definition = TableDefinition.new
       yield(table_definition)
       @__definition[table_name] ||= {}
+
+      if @__definition[table_name][:definition]
+        raise "Table `#{table_name}` already defined"
+      end
+
       @__definition[table_name][:definition] = table_definition.__definition
       options.delete(:force)
       @__definition[table_name][:options] = options
     end
 
     def add_index(table_name, column_name, options = {})
-      # XXX: Add exist check
       @__definition[table_name] ||= {}
       @__definition[table_name][:indices] ||= {}
       idx = options[:name] || column_name
+
+      if @__definition[table_name][:indices][idx]
+        raise "Index `#{table_name}(#{idx})` already defined"
+      end
+
       @__definition[table_name][:indices][idx] = {
         :column_name => column_name,
         :options => options,

data/lib/ridgepole/version.rb

@@ -1,3 +1,3 @@
 module Ridgepole
-  VERSION = '0.1.9'
+  VERSION = '0.2.0'
 end

data/ridgepole.gemspec

@@ -10,7 +10,7 @@ Gem::Specification.new do |spec|
   spec.email         = ['sugawara@cookpad.com']
   spec.summary       = %q{Ridgepole is a tool to DB schema.}
   spec.description   = %q{Ridgepole is a tool to DB schema. It defines DB schema using Rails DSL, and updates DB schema according to DSL.}
-  spec.homepage      = 'https://bitbucket.org/winebarrel/ridgepole'
+  spec.homepage      = 'https://github.com/winebarrel/ridgepole'
   spec.license       = 'MIT'
 
   spec.files         = `git ls-files -z`.split("\x0")

data/spec/migrate/migrate_change_table_option_spec.rb

@@ -0,0 +1,40 @@
+describe 'Ridgepole::Client#diff -> migrate' do
+  context 'when change column' do
+    let(:actual_dsl) {
+      <<-RUBY
+        create_table "employees", primary_key: "emp_no", force: true do |t|
+          t.date   "birth_date",            null: false
+          t.string "first_name", limit: 14, null: false
+          t.string "last_name",  limit: 16, null: false
+          t.string "gender",     limit: 1,  null: false
+          t.date   "hire_date",             null: false
+        end
+
+      RUBY
+    }
+
+    let(:expected_dsl) {
+      <<-RUBY
+        create_table "employees", primary_key: "emp_no2", force: true do |t|
+          t.date   "birth_date",            null: false
+          t.string "first_name", limit: 14, null: false
+          t.string "last_name",  limit: 16, null: false
+          t.string "gender",     limit: 1,  null: false
+          t.date   "hire_date",             null: false
+        end
+      RUBY
+    }
+
+    before { subject.diff(actual_dsl).migrate }
+    subject { client }
+
+    it {
+      expect(Ridgepole::Logger.instance).to receive(:warn).with('[WARNING] Table options cannot be changed')
+      delta = subject.diff(expected_dsl)
+      expect(delta.differ?).to be_false
+      expect(subject.dump).to eq actual_dsl.undent.strip
+      delta.migrate
+      expect(subject.dump).to eq actual_dsl.undent.strip
+    }
+  end
+end

data/spec/migrate/migrate_duplicate_index_spec.rb

@@ -0,0 +1,25 @@
+describe 'Ridgepole::Client#diff -> migrate' do
+  context 'when index already defined' do
+    let(:dsl) {
+      <<-RUBY
+        create_table "salaries", id: false, force: true do |t|
+          t.integer "emp_no",    null: false
+          t.integer "salary",    null: false
+          t.date    "from_date", null: false
+          t.date    "to_date",   null: false
+        end
+
+        add_index "salaries", ["emp_no"], name: "emp_no", using: :btree
+        add_index "salaries", ["emp_no"], name: "emp_no", using: :btree
+      RUBY
+    }
+
+    subject { client }
+
+    it {
+      expect {
+        subject.diff(dsl)
+      }.to raise_error('Index `salaries(emp_no)` already defined')
+    }
+  end
+end

data/spec/migrate/migrate_duplicate_table_spec.rb

@@ -0,0 +1,35 @@
+describe 'Ridgepole::Client#diff -> migrate' do
+  context 'when table already defined' do
+    let(:dsl) {
+      <<-RUBY
+        create_table "employees", primary_key: "emp_no", force: true do |t|
+          t.date    "birth_date",                            null: false
+          t.string  "first_name", limit: 14,                 null: false
+          t.string  "last_name",  limit: 16,                 null: false
+          t.string  "gender",     limit: 1,                  null: false
+          t.date    "hire_date",                             null: false
+          t.integer "age",                   unsigned: true, null: false
+          t.date    "updated_at"
+        end
+
+        create_table "employees", primary_key: "emp_no", force: true do |t|
+          t.date    "birth_date",                            null: false
+          t.string  "first_name", limit: 14,                 null: false
+          t.string  "last_name",  limit: 16,                 null: false
+          t.string  "gender",     limit: 1,                  null: false
+          t.date    "hire_date",                             null: false
+          t.integer "age",                   unsigned: true, null: false
+          t.date    "updated_at"
+        end
+      RUBY
+    }
+
+    subject { client }
+
+    it {
+      expect {
+        subject.diff(dsl)
+      }.to raise_error('Table `employees` already defined')
+    }
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ridgepole
 version: !ruby/object:Gem::Version
-  version: 0.1.9
+  version: 0.2.0
 platform: ruby
 authors:
 - Genki Sugawara
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-29 00:00:00.000000000 Z
+date: 2014-06-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -127,11 +127,14 @@ files:
 - spec/dump/dump_spec.rb
 - spec/migrate/migrate_add_column_spec.rb
 - spec/migrate/migrate_change_column_spec.rb
+- spec/migrate/migrate_change_table_option_spec.rb
 - spec/migrate/migrate_create_index_spec.rb
 - spec/migrate/migrate_create_table_spec.rb
 - spec/migrate/migrate_drop_column_spec.rb
 - spec/migrate/migrate_drop_index.rb
 - spec/migrate/migrate_drop_table.rb
+- spec/migrate/migrate_duplicate_index_spec.rb
+- spec/migrate/migrate_duplicate_table_spec.rb
 - spec/migrate/migrate_empty_spec.rb
 - spec/migrate/migrate_merge_mode_spec.rb
 - spec/migrate/migrate_rename_column_spec.rb
@@ -143,7 +146,7 @@ files:
 - spec/ridgepole_test_tables.sql
 - spec/spec_helper.rb
 - spec/string_ext.rb
-homepage: https://bitbucket.org/winebarrel/ridgepole
+homepage: https://github.com/winebarrel/ridgepole
 licenses:
 - MIT
 metadata: {}
@@ -173,11 +176,14 @@ test_files:
 - spec/dump/dump_spec.rb
 - spec/migrate/migrate_add_column_spec.rb
 - spec/migrate/migrate_change_column_spec.rb
+- spec/migrate/migrate_change_table_option_spec.rb
 - spec/migrate/migrate_create_index_spec.rb
 - spec/migrate/migrate_create_table_spec.rb
 - spec/migrate/migrate_drop_column_spec.rb
 - spec/migrate/migrate_drop_index.rb
 - spec/migrate/migrate_drop_table.rb
+- spec/migrate/migrate_duplicate_index_spec.rb
+- spec/migrate/migrate_duplicate_table_spec.rb
 - spec/migrate/migrate_empty_spec.rb
 - spec/migrate/migrate_merge_mode_spec.rb
 - spec/migrate/migrate_rename_column_spec.rb