rice 4.5.0 → 4.6.1

data/rice/detail/Wrapper.ipp

@@ -2,11 +2,12 @@
 
 namespace Rice::detail
 {
-  inline Wrapper::Wrapper(bool isOwner): isOwner_(isOwner)
+  inline bool WrapperBase::isConst()
   {
+    return this->isConst_;
   }
 
-  inline void Wrapper::ruby_mark()
+  inline void WrapperBase::ruby_mark()
   {
     for (VALUE value : this->keepAlive_)
     {
@@ -14,133 +15,122 @@ namespace Rice::detail
     }
   }
 
-  inline void Wrapper::addKeepAlive(VALUE value)
+  inline void WrapperBase::addKeepAlive(VALUE value)
   {
     this->keepAlive_.push_back(value);
   }
 
-  inline void Wrapper::setOwner(bool value)
+  inline void WrapperBase::setOwner(bool value)
   {
     this->isOwner_ = value;
   }
 
+  // ----  Wrapper -----
   template <typename T>
-  class WrapperValue : public Wrapper
+  inline Wrapper<T>::Wrapper(T& data): data_(data)
   {
-  public:
-    WrapperValue(T& data): data_(std::move(data))
-    {
-    }
-
-    ~WrapperValue()
-    {
-      Registries::instance.instances.remove(this->get());
-    }
+  }
 
-    void* get() override
-    {
-      return (void*)&this->data_;
-    }
+  template <typename T>
+  inline Wrapper<T>::Wrapper(T&& data) : data_(std::move(data))
+  {
+  }
 
-  private:
-    T data_;
-  };
+  template <typename T>
+  inline Wrapper<T>::~Wrapper()
+  {
+    Registries::instance.instances.remove(this->get());
+  }
 
   template <typename T>
-  class WrapperReference : public Wrapper
+  inline void* Wrapper<T>::Wrapper::get()
   {
-  public:
-    WrapperReference(T& data): data_(data)
-    {
-    }
+    return (void*)&this->data_;
+  }
 
-    ~WrapperReference()
-    {
-      Registries::instance.instances.remove(this->get());
-    }
+  // ----  Wrapper& -----
+  template <typename T>
+  inline Wrapper<T&>::Wrapper(T& data): data_(data)
+  {
+    this->isConst_ = std::is_const_v<std::remove_reference_t<T>>;
+  }
 
-    void* get() override
-    {
-      return (void*)&this->data_;
-    }
+  template <typename T>
+  inline Wrapper<T&>::~Wrapper()
+  {
+    Registries::instance.instances.remove(this->get());
+  }
 
-  private:
-    T& data_;
-  };
+  template <typename T>
+  inline void* Wrapper<T&>::get()
+  {
+    return (void*)&this->data_;
+  }
 
+  // ----  Wrapper* -----
   template <typename T>
-  class WrapperPointer : public Wrapper
+  inline Wrapper<T*>::Wrapper(T* data, bool isOwner) : data_(data)
   {
-  public:
-    WrapperPointer(T* data, bool isOwner) : Wrapper(isOwner), data_(data)
-    {
-    }
+    this->isOwner_ = isOwner;
+    this->isConst_ = std::is_const_v<std::remove_pointer_t<T>>;
+  }
 
-    ~WrapperPointer()
+  template <typename T>
+  inline Wrapper<T*>::~Wrapper()
+  {
+    Registries::instance.instances.remove(this->get());
+    if constexpr (std::is_destructible_v<T>)
     {
-      Registries::instance.instances.remove(this->get());
-
-      if constexpr (std::is_destructible_v<T>)
+      if (this->isOwner_)
       {
-        if (this->isOwner_)
-        {
-          delete this->data_;
-        }
+        delete this->data_;
       }
     }
+  }
 
-    void* get() override
-    {
-      return (void*)this->data_;
-    }
-
-  private:
-    T* data_ = nullptr;
-  };
+  template <typename T>
+  inline void* Wrapper<T*>::get()
+  {
+    return (void*)this->data_;
+  }
 
   // ---- Helper Functions -------
-  template <typename T, typename Wrapper_T>
-  inline VALUE wrap(VALUE klass, rb_data_type_t* rb_type, T& data, bool isOwner)
+  template <typename T>
+  inline VALUE wrap(VALUE klass, rb_data_type_t* rb_data_type, T& data, bool isOwner)
   {
     VALUE result = Registries::instance.instances.lookup(&data);
 
     if (result != Qnil)
       return result;
 
-    Wrapper* wrapper = nullptr;
+    WrapperBase* wrapper = nullptr;
 
-    // Is this a pointer but cannot be copied? For example a std::unique_ptr
-    if constexpr (!std::is_void_v<Wrapper_T> && !std::is_copy_constructible_v<Wrapper_T>)
+    // If Ruby is not the owner then wrap the reference
+    if (!isOwner)
     {
-      wrapper = new Wrapper_T(std::move(data));
-      result = TypedData_Wrap_Struct(klass, rb_type, wrapper);
+      wrapper = new Wrapper<T&>(data);
+      result = TypedData_Wrap_Struct(klass, rb_data_type, wrapper);
     }
-    // Is this a pointer or smart pointer like std::shared_ptr
-    else if constexpr (!std::is_void_v<Wrapper_T>)
+
+    // Ruby is the owner so copy data
+    else if constexpr (std::is_copy_constructible_v<T>)
     {
-      wrapper = new Wrapper_T(data);
-      result = TypedData_Wrap_Struct(klass, rb_type, wrapper);
+      wrapper = new Wrapper<T>(data);
+      result = TypedData_Wrap_Struct(klass, rb_data_type, wrapper);
     }
-    // If ruby is the owner than copy the object if possible
-    else if (isOwner)
+
+    // Ruby is the owner so move data
+    else if constexpr (std::is_move_constructible_v<T>)
     {
-      if constexpr (std::is_copy_constructible_v<T> || std::is_move_constructible_v<T>)
-      {
-        wrapper = new WrapperValue<T>(data);
-        result = TypedData_Wrap_Struct(klass, rb_type, wrapper);
-      }
-      else
-      {
-        std::string message = "Ruby was directed to take ownership of a C++ object but it does not have an accessible copy or move constructor. Type: " +
-          typeName(typeid(T));
-        throw std::runtime_error(message);
-      }
+      wrapper = new Wrapper<T>(std::forward<T>(data));
+      result = TypedData_Wrap_Struct(klass, rb_data_type, wrapper);
     }
-    // Ruby is not the owner so just wrap the reference
+
     else
     {
-      wrapper = new WrapperReference<T>(data);
-      result = TypedData_Wrap_Struct(klass, rb_type, wrapper);
+      std::string message = "Rice was directed to take ownership of a C++ object but it does not have an accessible copy or move constructor. Type: " +
+        typeName(typeid(T));
+      throw std::runtime_error(message);
     }
 
     Registries::instance.instances.add(wrapper->get(), result);
@@ -148,37 +138,31 @@ namespace Rice::detail
     return result;
   };
 
-  template <typename T, typename Wrapper_T>
-  inline VALUE wrap(VALUE klass, rb_data_type_t* rb_type, T* data, bool isOwner)
+  template <typename T>
+  inline VALUE wrap(VALUE klass, rb_data_type_t* rb_data_type, T* data, bool isOwner)
   {
     VALUE result = Registries::instance.instances.lookup(data);
 
     if (result != Qnil)
       return result;
 
-    Wrapper* wrapper = nullptr;
-
-    if constexpr (!std::is_void_v<Wrapper_T>)
-    {
-      wrapper = new Wrapper_T(data);
-      result = TypedData_Wrap_Struct(klass, rb_type, wrapper);
-    }
-    else
-    {
-      wrapper = new WrapperPointer<T>(data, isOwner);
-      result = TypedData_Wrap_Struct(klass, rb_type, wrapper);
-    }
+    WrapperBase* wrapper = new Wrapper<T*>(data, isOwner);
+    result = TypedData_Wrap_Struct(klass, rb_data_type, wrapper);
 
     Registries::instance.instances.add(wrapper->get(), result);
     return result;
   };
 
   template <typename T>
-  inline T* unwrap(VALUE value, rb_data_type_t* rb_type, bool takeOwnership)
+  inline T* unwrap(VALUE value, rb_data_type_t* rb_data_type, bool takeOwnership)
   {
-    Wrapper* wrapper = getWrapper(value, rb_type);
-    if (takeOwnership)
-      wrapper->setOwner(false);
+    if (rb_type(value) != RUBY_T_DATA)
+    {
+      std::string message = "The provided Ruby object does not wrap a C++ object";
+      throw std::runtime_error(message);
+    }
+
+    WrapperBase* wrapper = getWrapper(value, rb_data_type);
 
     if (wrapper == nullptr)
     {
@@ -189,17 +173,21 @@ namespace Rice::detail
       throw std::runtime_error(message);
     }
 
+    if (takeOwnership)
+      wrapper->setOwner(false);
+
     return static_cast<T*>(wrapper->get());
   }
     
-  inline Wrapper* getWrapper(VALUE value, rb_data_type_t* rb_type)
+  template <typename Wrapper_T>
+  inline Wrapper_T* getWrapper(VALUE value, rb_data_type_t* rb_data_type)
   {
-    Wrapper* wrapper = nullptr;
-    TypedData_Get_Struct(value, Wrapper, rb_type, wrapper);
-    return wrapper;
+    WrapperBase* wrapper = nullptr;
+    TypedData_Get_Struct(value, WrapperBase, rb_data_type, wrapper);
+    return dynamic_cast<Wrapper_T*>(wrapper);
   }
 
-  inline Wrapper* getWrapper(VALUE value)
+  inline WrapperBase* getWrapper(VALUE value)
   {
     // Turn off spurious warning on g++ 12
     #if defined(__GNUC__) || defined(__clang__)
@@ -207,7 +195,7 @@ namespace Rice::detail
     #pragma GCC diagnostic ignored "-Warray-bounds"
     #endif
 
-    return RTYPEDDATA_P(value) ? static_cast<Wrapper*>(RTYPEDDATA_DATA(value)) : nullptr;
+    return RTYPEDDATA_P(value) ? static_cast<WrapperBase*>(RTYPEDDATA_DATA(value)) : nullptr;
     
     #if defined(__GNUC__) || defined(__clang__)
     #pragma GCC diagnostic pop
@@ -215,17 +203,19 @@ namespace Rice::detail
   }
 
   template <typename T>
-  inline void replace(VALUE value, rb_data_type_t* rb_type, T* data, bool isOwner)
+  inline void wrapConstructed(VALUE value, rb_data_type_t* rb_data_type, T* data, bool isOwner)
   {
-    WrapperPointer<T>* wrapper = nullptr;
-    TypedData_Get_Struct(value, WrapperPointer<T>, rb_type, wrapper);
+    using Wrapper_T = Wrapper<T*>;
+    
+    Wrapper_T* wrapper = nullptr;
+    TypedData_Get_Struct(value, Wrapper_T, rb_data_type, wrapper);
     if (wrapper)
     {
       Registries::instance.instances.remove(wrapper->get());
       delete wrapper;
     }
 
-    wrapper = new WrapperPointer<T>(data, isOwner);
+    wrapper = new Wrapper_T(data, true);
     RTYPEDDATA_DATA(value) = wrapper;
 
     Registries::instance.instances.add(data, value);

data/rice/detail/from_ruby.hpp

@@ -32,10 +32,11 @@ namespace Rice::detail
 
   enum class Convertible: uint8_t
   {
-      None =   0b000,
-      Narrowable = 0b001,
-      Cast =   0b011,
-      Exact =  0b111,
+      None   = 0b0000,
+      Narrow = 0b0001,
+      Cast   = 0b0011,
+      Const  = 0b0111,
+      Exact  = 0b1111
   };
 }