ribose 0.3.1 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b7c4b6c53a6c8d7f9a5648e1aa4cb0bf8e37ffa9cac3d9d1fecd5c6fbbc1c81a
-  data.tar.gz: 3a8eaac73e14e834ce155b3e2ca1c4ac1593d0925ad26dc61085c0a570f0883e
+  metadata.gz: c12513b80d2e78ad9faf2e3c64de85c0943ac3ba3b9ea7e048820e3fd35564eb
+  data.tar.gz: 373f583f12f65efb0ab2f76f6123d9f140c52e25fffd557718f0165b8bbff1f2
 SHA512:
-  metadata.gz: 1fe42b371ab20c599bc152089f439aebd1ad02c5e04dccdef71b64e5b353b3c88984dfe2d4b088ebe5d75e27d54d6ebc433dae3ebadfc5531abe9167a21c79c4
-  data.tar.gz: a6dd3241989f1499e3ee48710f8118eeafc886f4716cf3e59ef75a128eec2ae057073d7a5f39f23749744da25aa334b927afbdcabfd1991c50572a557f7b872f
+  metadata.gz: 734153a69502c7a0ffde70a561d9ba7842c5654c5f0cfde03267799a3a9dd2d0c0311382cab689135c87cfb28ca0349a6d4642abca7bac1786906e007af6b5f9
+  data.tar.gz: 578bab38e786870468f9a22c71785e819d06ee46e94fe050ea65e0aed1083abd96558bea5189939b9d64ffde608c5b19aa7303f7b697c17eb070b340d76069b6

data/.rubocop.yml

@@ -1,9 +1,4 @@
 AllCops:
-  Include:
-    - "**/*.rake"
-    - "**/Gemfile"
-    - "**/Rakefile"
-
   Exclude:
     - db/schema.rb
 
@@ -357,8 +352,18 @@ Style/TrailingCommaInArguments:
     - no_comma
   Enabled: true
 
-Style/TrailingCommaInLiteral:
-  Description: 'Checks for trailing comma in array and hash literals.'
+Style/TrailingCommaInArrayLiteral:
+  Description: 'Checks for trailing comma in array literals.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas'
+  EnforcedStyleForMultiline: comma
+  SupportedStylesForMultiline:
+    - comma
+    - consistent_comma
+    - no_comma
+  Enabled: true
+
+Style/TrailingCommaInHashLiteral:
+  Description: 'Checks for trailing comma in hash literals.'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas'
   EnforcedStyleForMultiline: comma
   SupportedStylesForMultiline:
@@ -403,6 +408,13 @@ Layout/AlignParameters:
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-double-indent'
   Enabled: false
 
+Layout/ConditionPosition:
+  Description: >-
+                 Checks for condition placed in a confusing position relative to
+                 the keyword.
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#same-line-condition'
+  Enabled: false
+
 Layout/DotPosition:
   Description: 'Checks the position of the dot in multi-line method calls.'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#consistent-multi-line-chains'
@@ -455,13 +467,6 @@ Lint/CircularArgumentReference:
   Description: "Don't refer to the keyword argument in the default value."
   Enabled: false
 
-Lint/ConditionPosition:
-  Description: >-
-                 Checks for condition placed in a confusing position relative to
-                 the keyword.
-  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#same-line-condition'
-  Enabled: false
-
 Lint/DeprecatedClassMethods:
   Description: 'Check for deprecated class method calls.'
   Enabled: false
@@ -487,7 +492,7 @@ Lint/HandleExceptions:
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#dont-hide-exceptions'
   Enabled: false
 
-Lint/LiteralInCondition:
+Lint/LiteralAsCondition:
   Description: 'Checks of literals used in conditions.'
   Enabled: false
 
@@ -528,7 +533,7 @@ Lint/UnderscorePrefixedVariableName:
   Description: 'Do not use prefix `_` for a variable that is used.'
   Enabled: false
 
-Lint/UnneededDisable:
+Lint/UnneededCopDisableDirective:
   Description: >-
                  Checks for rubocop:disable comments that can be removed.
                  Note: this cop is not disabled when disabling all cops.

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+## 0.3.2 (2018-06-28)
+
+Features:
+ - Add interface for calendar event resources
+ - Add interface for space category, file icon
+ - Add interface to fetch file version and etc.
+
+Fixes:
+  - Fix file upload related error
+
 ## 0.2.0 (2017-11-30)
 
 Features:

data/lib/ribose/file_uploader.rb

@@ -1,4 +1,6 @@
+require "json"
 require "faraday"
+require "ostruct"
 
 module Ribose
   class FileUploader
@@ -49,7 +51,8 @@ module Ribose
 
     def notify_ribose_file_upload_endpoint(response, key)
       if response.status.to_i == 200
-        Ribose::Request.post(space_file_path, file_attributes.merge(key: key))
+        content = Request.post(space_file_path, file_attributes.merge(key: key))
+        content.is_a?(Sawyer::Resource) ? content : parse_to_ribose_os(content)
       end
     end
 
@@ -70,6 +73,10 @@ module Ribose
       MIME::Types.type_for(file.path).first.content_type
     end
 
+    def parse_to_ribose_os(content)
+      JSON.parse(content, object_class: Ribose::OpenStruct)
+    end
+
     def file_attributes
       @file_attributes ||= {
         filesize: file.size,
@@ -90,4 +97,8 @@ module Ribose
       end
     end
   end
+
+  class OpenStruct < ::OpenStruct
+    alias :read_attribute_for_serialization :send
+  end
 end

data/lib/ribose/version.rb

@@ -1,3 +1,3 @@
 module Ribose
-  VERSION = "0.3.1".freeze
+  VERSION = "0.3.2".freeze
 end

data/spec/support/fake_ribose_api.rb

@@ -531,11 +531,11 @@ module Ribose
       end
     end
 
-    def response_with(filename:, status:)
+    def response_with(filename:, status:, content_type: "application/json")
       {
         status: status,
         body: ribose_fixture(filename),
-        headers: { content_type: "application/json" },
+        headers: { content_type: content_type },
       }
     end
 
@@ -546,11 +546,15 @@ module Ribose
       File.read(File.expand_path(file_path, __FILE__))
     end
 
-    def stub_api_response(method, endpoint, filename:,
-                          status: 200, data: nil, client: nil)
+    def stub_api_response(method, endpoint, filename:, status: 200, data: nil,
+                          client: nil, content_type: "application/json")
       stub_request(method, ribose_endpoint(endpoint)).
         with(ribose_headers(data: data, client: client)).
-        to_return(response_with(filename: filename, status: status))
+        to_return(
+          response_with(
+            filename: filename, status: status, content_type: content_type,
+          ),
+        )
     end
   end
 end

data/spec/support/file_upload_stub.rb

@@ -28,6 +28,7 @@ module Ribose
         ribose_file_endpoint(space_id),
         data: build_notify_request_body(attributes),
         filename: "file_uploaded",
+        content_type: "text/html",
       )
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ribose
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - Ribose Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-06-20 00:00:00.000000000 Z
+date: 2018-06-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: id_pack