riakpb 0.2.2 → 0.2.3

data/spec/riak/client_spec.rb

@@ -0,0 +1,199 @@
+require File.expand_path("../spec_helper", File.dirname(__FILE__))
+
+describe Riakpb::Client do
+  describe "when initializing" do
+    it "should default to the local interface on port 8087" do
+      client = Riakpb::Client.new
+      client.host.should      == "127.0.0.1"
+      client.port.should      == 8087
+    end
+
+    it "should accept a host" do
+      client = Riakpb::Client.new :host => "riak.basho.com"
+      client.host.should == "riak.basho.com"
+    end
+
+    it "should accept a port" do
+      client = Riakpb::Client.new :port => 9000
+      client.port.should == 9000
+    end
+  end
+
+  describe "reconfiguring" do
+    before :each do
+      @client = Riakpb::Client.new
+    end
+
+    describe "setting the host" do
+      it "should allow setting the host" do
+        @client.should respond_to(:host=)
+        @client.host = "riak.basho.com"
+        @client.host.should == "riak.basho.com"
+      end
+
+      it "should require the host to be an IP or hostname" do
+        [238472384972, "", "riak.basho-.com"].each do |invalid|
+          lambda { @client.host = invalid }.should raise_error(ArgumentError)
+        end
+        ["127.0.0.1", "10.0.100.5", "localhost", "otherhost.local", "riak.basho.com"].each do |valid|
+          lambda { @client.host = valid }.should_not raise_error
+        end
+      end
+    end # describe "setting the host"
+
+    describe "setting the port" do
+      it "should allow setting the port" do
+        @client.should respond_to(:port=)
+        @client.port = 9000
+        @client.port.should == 9000
+      end
+
+      it "should require the port to be a valid number" do
+        [-1,65536,"foo"].each do |invalid|
+          lambda { @client.port = invalid }.should raise_error(ArgumentError)
+        end
+        [0,1,65535,8098].each do |valid|
+          lambda { @client.port = valid }.should_not raise_error
+        end
+      end
+    end # describe "setting the port"
+
+    describe "setting the client id" do
+      it "should accept a string unmodified" do
+        @client.client_id = "foo"
+        @client.client_id.should == "foo"
+      end
+
+      it "should base64-encode an integer" do
+        @client.client_id = 1
+        @client.client_id.should == "AAAAAQ=="
+      end
+
+      it "should reject an integer equal to the maximum client id" do
+        lambda { @client.client_id = Riakpb::Client::MAX_CLIENT_ID }.should raise_error(ArgumentError)
+      end
+
+      it "should reject an integer larger than the maximum client id" do
+        lambda { @client.client_id = Riakpb::Client::MAX_CLIENT_ID + 1 }.should raise_error(ArgumentError)
+      end
+    end # describe "setting the client id"
+  end # describe "reconfiguring"
+
+  describe "sending and receiving protocol buffers" do
+    before :each do
+      @client = Riakpb::Client.new
+      @client.rpc.stub!(:status).and_return(true)
+      @client.rpc.stub!(:request).and_return(nil)
+    end
+
+    describe "basic communication with riak node" do
+      it "should send a ping request and return true" do
+        @client.rpc.stub!(:request).with(
+            Riakpb::Util::MessageCode::PING_REQUEST
+          ).and_return('')
+
+        @client.ping?.should          == true
+      end
+
+      it "should request the connected riak node's server info and return a Hash" do
+        # test length or content?  Need to look at what are considered acceptable values
+        @client.rpc.stub!(:request).with(
+            Riakpb::Util::MessageCode::GET_SERVER_INFO_REQUEST
+          ).and_return(Riakpb::RpbGetServerInfoResp.new(
+            {   :node           => "riak@127.0.0.1",
+                :server_version => "0.10.1"
+            }
+          ))
+
+        @client.info[:node].should            be_kind_of(String)
+        @client.info[:server_version].should  be_kind_of(String)
+      end
+    end # describe "basic communication with riak node"
+
+    describe "bucket operations: retrieval (get) and send (set)" do
+
+      describe "bucket retrieval (get)" do
+        it "should send a request to list available bucket names and return a Protobuf::Field::FieldArray" do
+          @client.rpc.stub!(:request).with(
+              Riakpb::Util::MessageCode::LIST_BUCKETS_REQUEST
+            ).and_return(
+              Riakpb::RpbListBucketsResp.new(
+                {   :buckets => ["goog"] }
+            ))
+
+          @client.buckets.should be_kind_of(Protobuf::Field::FieldArray)
+        end
+
+        it "should send a request with the bucket name and return a Riakpb::Bucket" do
+          @client.rpc.stub!(:request).with(
+              Riakpb::Util::MessageCode::GET_BUCKET_REQUEST,
+              Riakpb::RpbGetBucketReq.new(:bucket => "goog")
+            ).and_return(
+              Riakpb::RpbGetBucketResp.new(
+                {   :props  => {
+                    :allow_mult => false,
+                    :n_val      => 3
+                    }
+                }
+            ))
+
+          @client.bucket("goog").should be_kind_of(Riakpb::Bucket)
+        end
+
+        it "should send a request to list keys within a bucket and return a Protobuf::Field::FieldArray" do
+          @client.rpc.stub!(:request).with(
+              Riakpb::Util::MessageCode::LIST_KEYS_REQUEST,
+              Riakpb::RpbListKeysReq.new(:bucket => "goog")
+            ).and_return(
+              Riakpb::RpbListKeysResp.new(
+                {   :keys =>  ["2010-04-12", "2008-01-10", "2006-06-06"],
+                    :done =>  true
+                }
+            ))
+          @client.keys_in("goog").should be_kind_of(Protobuf::Field::FieldArray)
+        end
+      end # describe "bucket retrieval (get)"
+
+      describe "bucket sending (set)" do
+      end # describe "bucket sending (set)"
+    end # describe "bucket operations and retrieval"
+
+    describe "key operations: retrieval (get), send (put) and delete (del)" do
+      before :each do
+        @client.rpc.stub!(:request).with(
+            Riakpb::Util::MessageCode::GET_REQUEST,
+            Riakpb::RpbGetReq.new(:bucket => "goog", :key => "2010-04-12", :r => nil)
+          ).and_return(
+            Riakpb::RpbGetResp.new(
+              {   :content  =>  [],
+                  :vclock   =>  ""
+              }
+          ))
+      end
+
+      it "should send a request for a bucket/key pair and return a Riakpb::RpbGetResp" do
+        @client.get_request("goog", "2010-04-12").should be_kind_of(Riakpb::RpbGetResp)
+      end
+
+      it "should have a vclock attribute within Riakpb::RpbGetResp of that is a String" do
+        @client.get_request("goog", "2010-04-12").vclock.should be_kind_of(String)
+      end
+    end # describe "key operations and retrieval"
+
+    describe "key operations and retrieval" do
+      before :each do
+        @client.rpc.stub!(:request).with(
+            Riakpb::Util::MessageCode::GET_REQUEST,
+            Riakpb::RpbGetReq.new(:bucket => "goog", :key => "2010-04-12", :r => nil)
+          ).and_return(
+            Riakpb::RpbGetResp.new(
+              {   :content  =>  [],
+                  :vclock   =>  ""
+              }
+          ))
+      end
+
+
+    end # describe "key operations and retrieval"
+  end # describe "basic communication with riak node"
+end # Riakpb::Client

data/spec/riak/content_spec.rb

@@ -0,0 +1,74 @@
+require File.expand_path("../spec_helper", File.dirname(__FILE__))
+
+describe Riakpb::Content do
+  describe "when directly initializing" do
+    before :each do
+      @client = Riakpb::Client.new
+      @client.rpc.stub!(:request).with(
+          Riakpb::Util::MessageCode::GET_BUCKET_REQUEST,
+          Riakpb::RpbGetBucketReq.new(:bucket => "goog")
+        ).and_return(
+          Riakpb::RpbGetBucketResp.new(
+            {   :props  => {
+                :allow_mult => false,
+                :n_val      => 3
+                }
+            }
+        ))
+      @bucket = @client["goog"]
+      @key    = Riakpb::Key.new(@bucket, "test")
+    end
+
+    it "should default with nil attributes and links/usermeta as instances of Set/Hash" do
+      rcontent                          =   Riakpb::Content.new(@key)
+      rcontent.key.should               ==  @key
+      rcontent.value.should             ==  nil
+      rcontent.content_type.should      ==  nil
+      rcontent.charset.should           ==  nil
+      rcontent.content_encoding.should  ==  nil
+      rcontent.vtag.should              ==  nil
+      rcontent.links.should             be_kind_of(Hash)
+      rcontent.last_mod.should          be_kind_of(Time)
+      rcontent.last_mod_usecs.should    ==  nil
+      rcontent.usermeta.should          be_kind_of(Hash)
+    end
+
+    it "should allow you to set the Key, after initialization" do
+      rcontent                          =   Riakpb::Content.new(@key)
+      rcontent.key                      =   @key
+      rcontent.key.should               ==  @key
+    end
+
+    it "should accept a Key as an argument to new, tying it back to an owner" do
+      rcontent                          =   Riakpb::Content.new(@key)
+      rcontent.key.should               ==  @key
+    end
+
+    it "should serialize into a corresponding Protocol Buffer (RpbContent)" do
+      rcontent                          =   Riakpb::Content.new(@key, :value => "Test")
+      rcontent.to_pb.should             be_kind_of(Riakpb::RpbContent)
+    end
+    
+    it "should load a Riakpb::RpbContent instance, returning a matching self, Content" do
+      rcontent                          =   Riakpb::Content.new(@key)
+      rpb_content                       =   Riakpb::RpbContent.new
+      rpb_content.value                 =   "{\"Date\":\"2010-04-12\",\"Open\":567.35,\"High\":574.00,\"Low\":566.22,\"Close\":572.73,\"Volume\":2352400,\"Adj. Close\":572.73}"
+      rpb_content.content_type          =   "application/json"
+      rpb_content.vtag                  =   "4DNB6Vt0zLl5VJ6P2xx9dc"
+      rpb_content.last_mod              =   1274645855
+      rpb_content.last_mod_usecs        =   968694
+
+      rcontent.load(rpb_content)
+      rcontent.key.should               ==  @key
+      rcontent.value.should             ==  {"Date" => "2010-04-12".to_date,"Open" => 567.35,"High" => 574.00,"Low" => 566.22,"Close" => 572.73,"Volume" => 2352400,"Adj. Close" => 572.73}
+      rcontent.content_type.should      ==  "application/json"
+      rcontent.charset.should           ==  nil
+      rcontent.content_encoding.should  ==  nil
+      rcontent.vtag.should              ==  "4DNB6Vt0zLl5VJ6P2xx9dc"
+      rcontent.links.should             be_kind_of(Hash)
+      rcontent.last_mod.should          ==  Time.at(1274645855.968694)
+      rcontent.usermeta.should          be_kind_of(Hash)
+    end
+
+  end # describe "when directly initializing"
+end # Riakpb::Content

data/spec/riak/key_spec.rb

@@ -0,0 +1,54 @@
+require File.expand_path("../spec_helper", File.dirname(__FILE__))
+
+describe Riakpb::Key do
+  describe "when directly initializing" do
+    before :each do
+      @client = Riakpb::Client.new
+      @client.rpc.stub!(:request).with(
+          Riakpb::Util::MessageCode::GET_BUCKET_REQUEST,
+          Riakpb::RpbGetBucketReq.new(:bucket => "goog")
+        ).and_return(
+          Riakpb::RpbGetBucketResp.new(
+            {   :props  => {
+                :allow_mult => false,
+                :n_val      => 3
+                }
+            }
+        ))
+      @bucket = @client["goog"]
+    end
+
+    it "should default with the bucket and name, and an empty vclock" do
+      key                 =   Riakpb::Key.new(@bucket, "test")
+      key.bucket.should   ==  @bucket
+      key.name.should     ==  "test"
+      key.vclock.should   ==  nil
+      key.content.should  be_kind_of(Riakpb::Content)
+    end
+
+    it "should serialize into a Key Protocol Buffer (RpbPutReq)" do
+      @client.rpc.stub!(:request).with(
+          Riakpb::Util::MessageCode::GET_REQUEST,
+          Riakpb::RpbGetReq.new(:bucket => "goog", :key => "2010-04-12", :r => nil)
+        ).and_return(
+          Riakpb::RpbGetResp.new(
+            {   :content  =>  [Riakpb::RpbContent.new(:value => "Test")],
+                :vclock   =>  "k\xCEa```\xCC`\xCA\x05R,\xACL\xF7^e0%2\xE6\xB12\xC4s\xE6\x1D\xE5\xCB\x02\x00"
+            }
+        ))
+      key                   =   @bucket["2010-04-12"] # Riakpb::Key.new(@bucket, "test")
+      pb_put                =   key.to_pb_put
+      pb_put.should         be_kind_of(Riakpb::RpbPutReq)
+      pb_put.vclock.should  ==  "k\xCEa```\xCC`\xCA\x05R,\xACL\xF7^e0%2\xE6\xB12\xC4s\xE6\x1D\xE5\xCB\x02\x00"
+    end
+
+    it "should serialize into a Link Protocol Buffer (RpbLink)" do
+      key                   =   Riakpb::Key.new(@bucket, "test")
+      pb_link               =   key.to_pb_link
+      pb_link.should        be_kind_of(Riakpb::RpbLink)
+      pb_link.bucket.should ==  "goog"
+      pb_link.key.should    ==  "test"
+    end
+  end # describe "when directly initializing"
+end # Riakpb::Key
+

data/spec/riak/map_reduce_spec.rb

@@ -0,0 +1,327 @@
+require File.expand_path("../spec_helper", File.dirname(__FILE__))
+
+describe Riakpb::MapReduce do
+  before :each do
+    @client = Riakpb::Client.new
+    @client.rpc.stub!(:request).and_return(nil)
+    @mr = Riakpb::MapReduce.new(@client)
+  end
+
+  it "should require a client" do
+    lambda { Riakpb::MapReduce.new }.should raise_error
+    lambda { Riakpb::MapReduce.new(@client) }.should_not raise_error
+  end
+
+  it "should initialize the inputs and query to empty arrays" do
+    @mr.inputs.should == []
+    @mr.query.should == []
+  end
+
+  it "should yield itself when given a block on initializing" do
+    @mr2 = nil
+    @mr = Riakpb::MapReduce.new(@client) do |mr|
+      @mr2 = mr
+    end
+    @mr2.should == @mr
+  end
+
+  describe "adding inputs" do
+    it "should return self for chaining" do
+      @mr.add("foo", "bar").should == @mr
+    end
+
+    it "should add bucket/key pairs to the inputs" do
+      @mr.add("foo","bar")
+      @mr.inputs.should == [["foo","bar"]]
+    end
+
+    it "should add an array containing a bucket/key pair to the inputs" do
+      @mr.add(["foo","bar"])
+      @mr.inputs.should == [["foo","bar"]]
+    end
+
+    it "should add an object to the inputs by its bucket and key" do
+      bucket = Riakpb::Bucket.new(@client, "foo")
+      key = Riakpb::Key.new(bucket, "bar")
+      @mr.add(key)
+      @mr.inputs.should == [["foo", "bar"]]
+    end
+
+    it "should add an array containing a bucket/key/key-data triple to the inputs" do
+      @mr.add(["foo","bar",1000])
+      @mr.inputs.should == [["foo","bar",1000]]
+    end
+
+    it "should use a bucket name as the single input" do
+      @mr.add(Riakpb::Bucket.new(@client, "foo"))
+      @mr.inputs.should == "foo"
+      @mr.add("docs")
+      @mr.inputs.should == "docs"
+    end
+  end
+
+  [:map, :reduce].each do |type|
+    describe "adding #{type} phases" do
+      it "should return self for chaining" do
+        @mr.send(type, "function(){}").should == @mr
+      end
+
+      it "should accept a function string" do
+        @mr.send(type, "function(){}")
+        @mr.query.should have(1).items
+        phase = @mr.query.first
+        phase.function.should == "function(){}"
+        phase.type.should == type
+      end
+
+      it "should accept a function and options" do
+        @mr.send(type, "function(){}", :keep => true)
+        @mr.query.should have(1).items
+        phase = @mr.query.first
+        phase.function.should == "function(){}"
+        phase.type.should == type
+        phase.keep.should be_true
+      end
+
+      it "should accept a module/function pair" do
+        @mr.send(type, ["riak","mapsomething"])
+        @mr.query.should have(1).items
+        phase = @mr.query.first
+        phase.function.should == ["riak", "mapsomething"]
+        phase.type.should == type
+        phase.language.should == "erlang"
+      end
+
+      it "should accept a module/function pair with extra options" do
+        @mr.send(type, ["riak", "mapsomething"], :arg => [1000])
+        @mr.query.should have(1).items
+        phase = @mr.query.first
+        phase.function.should == ["riak", "mapsomething"]
+        phase.type.should == type
+        phase.language.should == "erlang"
+        phase.arg.should == [1000]
+      end
+    end
+  end
+
+  describe "adding link phases" do
+    it "should return self for chaining" do
+      @mr.link({}).should == @mr
+    end
+
+    it "should accept a Link" do
+      @mr.link({:tag => "next"})
+      @mr.query.should have(1).items
+      phase = @mr.query.first
+      phase.type.should == :link
+#      phase.function.should be_kind_of(Riakpb::WalkSpec)
+      phase.function[:tag].should == "next"
+    end
+
+    it "should accept a Link and a statement to keep" do
+      @mr.link({:bucket => "foo", :keep => true})
+      @mr.query.should have(1).items
+      phase = @mr.query.first
+      phase.type.should == :link
+#      phase.function.should be_kind_of(Riakpb::WalkSpec)
+      phase.function[:bucket].should == "foo"
+      phase.keep.should be_true
+    end
+  end
+
+  describe "converting to JSON for the job" do
+    it "should include the inputs and query keys" do
+      @mr.to_json.should =~ /"inputs":/
+    end
+
+    it "should map phases to their JSON equivalents" do
+      phase = Riakpb::MapReduce::Phase.new(:type => :map, :function => "function(){}")
+      @mr.query << phase
+      @mr.to_json.should include('"source":"function(){}"')
+      @mr.to_json.should include('"query":[{"map":{')
+    end
+
+    it "should emit only the bucket name when the input is the whole bucket" do
+      @mr.add("foo")
+      @mr.to_json.should include('"inputs":"foo"')
+    end
+
+    it "should emit an array of inputs when there are multiple inputs" do
+      @mr.add("foo","bar",1000).add("foo","baz")
+      @mr.to_json.should include('"inputs":[["foo","bar",1000],["foo","baz"]]')
+    end
+
+    it "should add the timeout value when set" do
+      @mr.timeout(50000)
+      @mr.to_json.should include('"timeout":50000')
+    end
+  end
+=begin
+  describe "executing the map reduce job" do
+    it "should issue POST request to the mapred endpoint" do
+      @http.should_receive(:post).with(200, "/mapred", @mr.to_json, hash_including("Content-Type" => "application/json")).and_return({:headers => {'content-type' => ["application/json"]}, :body => "{}"})
+      @mr.run
+    end
+
+    it "should vivify JSON responses" do
+      @http.stub!(:post).and_return(:headers => {'content-type' => ["application/json"]}, :body => '{"key":"value"}')
+      @mr.run.should == {"key" => "value"}
+    end
+
+    it "should return the full response hash for non-JSON responses" do
+      response = {:code => 200, :headers => {'content-type' => ["text/plain"]}, :body => 'This is some text.'}
+      @http.stub!(:post).and_return(response)
+      @mr.run.should == response
+    end
+
+    it "should interpret failed requests with JSON content-types as map reduce errors" do
+      @http.stub!(:post).and_raise(Riakpb::FailedRequest.new(:post, 200, 500, {"content-type" => ["application/json"]}, '{"error":"syntax error"}'))
+      lambda { @mr.run }.should raise_error(Riakpb::MapReduceError)
+      begin
+        @mr.run
+      rescue Riakpb::MapReduceError => mre
+        mre.message.should == '{"error":"syntax error"}'
+      else
+        fail "No exception raised!"
+      end
+    end
+
+    it "should re-raise non-JSON error responses" do
+      @http.stub!(:post).and_raise(Riakpb::FailedRequest.new(:post, 200, 500, {"content-type" => ["text/plain"]}, 'Oops, you bwoke it.'))
+      lambda { @mr.run }.should raise_error(Riakpb::FailedRequest)
+    end
+  end
+=end
+end
+
+describe Riakpb::MapReduce::Phase do
+  before :each do
+    @fun = "function(v,_,_){ return v['values'][0]['data']; }"
+  end
+
+  it "should initialize with a type and a function" do
+    phase = Riakpb::MapReduce::Phase.new(:type => :map, :function => @fun, :language => "javascript")
+    phase.type.should == :map
+    phase.function.should == @fun
+    phase.language.should == "javascript"
+  end
+
+  it "should initialize with a type and an MF" do
+    phase = Riakpb::MapReduce::Phase.new(:type => :map, :function => ["module", "function"], :language => "erlang")
+    phase.type.should == :map
+    phase.function.should == ["module", "function"]
+    phase.language.should == "erlang"
+  end
+
+  it "should initialize with a type and a bucket/key" do
+    phase = Riakpb::MapReduce::Phase.new(:type => :map, :function => {:bucket => "funs", :key => "awesome_map"}, :language => "javascript")
+    phase.type.should == :map
+    phase.function.should == {:bucket => "funs", :key => "awesome_map"}
+    phase.language.should == "javascript"
+  end
+
+  it "should assume the language is erlang when the function is an array" do
+    phase = Riakpb::MapReduce::Phase.new(:type => :map, :function => ["module", "function"])
+    phase.language.should == "erlang"
+  end
+
+  it "should assume the language is javascript when the function is a string" do
+    phase = Riakpb::MapReduce::Phase.new(:type => :map, :function => @fun)
+    phase.language.should == "javascript"
+  end
+
+  it "should assume the language is javascript when the function is a hash" do
+    phase = Riakpb::MapReduce::Phase.new(:type => :map, :function => {:bucket => "jobs", :key => "awesome_map"})
+    phase.language.should == "javascript"
+  end
+
+  it "should accept a WalkSpec for the function when a link phase" do
+#    phase = Riakpb::MapReduce::Phase.new(:type => :link, :function => Riakpb::WalkSpec.new({}))
+#    phase.function.should be_kind_of(Riakpb::WalkSpec)
+  end
+
+  it "should raise an error if a WalkSpec is given for a phase type other than :link" do
+#    lambda { Riakpb::MapReduce::Phase.new(:type => :map, :function => Riakpb::WalkSpec.new({})) }.should raise_error(ArgumentError)
+  end
+
+  describe "converting to JSON for the job" do
+    before :each do
+      @phase = Riakpb::MapReduce::Phase.new(:type => :map, :function => "")
+    end
+
+    [:map, :reduce].each do |type|
+      describe "when a #{type} phase" do
+        before :each do
+          @phase.type = type
+        end
+
+        it "should be an object with a single key of '#{type}'" do
+          @phase.to_json.should =~ /^\{"#{type}":/
+        end
+
+        it "should include the language" do
+          @phase.to_json.should =~ /"language":/
+        end
+
+        it "should include the keep value" do
+          @phase.to_json.should =~ /"keep":false/
+          @phase.keep = true
+          @phase.to_json.should =~ /"keep":true/
+        end
+
+        it "should include the function source when the function is a source string" do
+          @phase.function = "function(v,_,_){ return v; }"
+          @phase.to_json.should include(@phase.function)
+          @phase.to_json.should =~ /"source":/
+        end
+
+        it "should include the function name when the function is not a lambda" do
+          @phase.function = "Riakpb.mapValues"
+          @phase.to_json.should include('"name":"Riakpb.mapValues"')
+          @phase.to_json.should_not include('"source"')
+        end
+        
+        it "should include the bucket and key when referring to a stored function" do
+          @phase.function = {:bucket => "design", :key => "wordcount_map"}
+          @phase.to_json.should include('"bucket":"design"')
+          @phase.to_json.should include('"key":"wordcount_map"')
+        end
+
+        it "should include the module and function when invoking an Erlang function" do
+          @phase.function = ["riak_mapreduce", "mapreduce_fun"]
+          @phase.to_json.should include('"module":"riak_mapreduce"')
+          @phase.to_json.should include('"function":"mapreduce_fun"')
+        end
+      end
+    end
+
+    describe "when a link phase" do
+      before :each do
+        @phase.type = :link
+        @phase.function = {}
+      end
+
+      it "should be an object of a single key 'link'" do
+        @phase.to_json.should    == "{\"link\":{\"keep\":false}}"
+      end
+
+      it "should include the bucket" do
+        @phase.function[:bucket]  = "foo"
+        @phase.to_json.should    == "{\"link\":{\"bucket\":\"foo\",\"keep\":false}}"
+      end
+
+      it "should include the tag" do
+        @phase.function[:tag]     = "parent"
+        @phase.to_json.should    == "{\"link\":{\"tag\":\"parent\",\"keep\":false}}"
+      end
+
+      it "should include the keep value" do
+        @phase.keep               = true
+        @phase.to_json.should    == "{\"link\":{\"keep\":true}}"
+        @phase.keep               = false
+        @phase.function[:keep]    = true
+        @phase.to_json.should    == "{\"link\":{\"keep\":false}}"
+      end
+    end
+  end
+end

data/spec/riak/rpc_spec.rb

@@ -0,0 +1,4 @@
+require File.expand_path("../spec_helper", File.dirname(__FILE__))
+
+describe Riakpb::Client::Rpc do
+end # Riakpb::Client::Rpc