riaction 1.2.1 → 1.2.2

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # CHANGELOG #
 
+## 1.2.2 ##
+
+* Fixed bug in event performer when perform() received event name as a string rather than a symbol
+
 ## 1.2.1 ##
 
 * Added rake task to run an event on all records in a class

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    riaction (1.2.0)
+    riaction (1.2.1)
       activerecord (>= 3.0.0)
       activesupport (>= 3.0.0)
       rake

data/README.md

@@ -204,4 +204,5 @@ To run a specific event on all instances off a class that define that event:
 ## Authors ##
 
 Christopher Eberz; chris@chriseberz.com; @zortnac
+
 Katie Miller; kmiller@elctech.com

data/lib/riaction/event_performer.rb

@@ -6,18 +6,19 @@ module Riaction
     @queue = :riaction_event_logger
 
     def self.perform(event_name, klass_name, id, attempt=0)
+      event_name_sym = event_name.to_sym
       iactionable_api = IActionable::Api.new
       event_object = klass_name.constantize.find_by_id!(id)
       event_params = event_object.riaction_event_params
 
       if (  klass_name.constantize.riactionary? &&
             klass_name.constantize.riaction_events? &&
-            klass_name.constantize.riaction_defines_event?(event_name) )
-        iactionable_api.log_event(  event_params[event_name][:profile][:type],
-                                    event_params[event_name][:profile][:id_type],
-                                    event_params[event_name][:profile][:id],
-                                    event_name,
-                                    event_params[event_name][:params])
+            klass_name.constantize.riaction_defines_event?(event_name_sym) )
+        iactionable_api.log_event(  event_params[event_name_sym][:profile][:type],
+                                    event_params[event_name_sym][:profile][:id_type],
+                                    event_params[event_name_sym][:profile][:id],
+                                    event_name_sym,
+                                    event_params[event_name_sym][:params])
       else
         raise ::Riaction::ConfigurationError.new("#{klass_name} does not define event #{event_name}")
       end

data/lib/riaction/version.rb

@@ -1,3 +1,3 @@
 module Riaction
-  VERSION = "1.2.1"
+  VERSION = "1.2.2"
 end

data/spec/event_performer_spec.rb

@@ -224,6 +224,25 @@ describe "sending an event to IActionable from the name of a riaction class and
         ::Riaction::EventPerformer.perform(:make_a_comment, 'Comment', @comment.id)
       end
     end
+  
+    describe "when the arguments passed to perform() are all strings" do
+      before do
+        Comment.class_eval do
+          riaction :event, :name => :make_a_comment, :trigger => :create, :profile => :user, :profile_type => :npc
+        end
+        
+        @comment = Comment.riactionless{ Comment.create(:user_id => @user.id, :content => 'this is a comment') }
+      end
+      
+      it "should behave correctly and without error" do
+        @api.should_receive(:log_event).once.with(@comment.riaction_event_params[:make_a_comment][:profile][:type], 
+                                                  @comment.riaction_event_params[:make_a_comment][:profile][:id_type],
+                                                  @comment.riaction_event_params[:make_a_comment][:profile][:id],
+                                                  :make_a_comment, 
+                                                  {})
+        lambda {::Riaction::EventPerformer.perform('make_a_comment', 'Comment', @comment.id.to_s)}.should_not raise_error
+      end
+    end
   end
   
   after do

data/spec/profile_creation_spec.rb

@@ -126,6 +126,20 @@ describe "automatic profile creation from riaction definitions:" do
         ::Riaction::ProfileCreator.perform('User', @user.id, 0)
       end
     end
+  
+    describe "when the arguments passed to perform are all strings" do
+      before do
+        User.class_eval do
+          riaction :profile, :type => :player, :custom => :id
+        end
+        @user = User.riactionless{ User.create(:name => 'zortnac') }
+      end
+      
+      it "it should behave normally and without error" do
+        @api.should_receive(:create_profile).once.with('player', 'custom', @user.id.to_s, nil)
+        lambda {::Riaction::ProfileCreator.perform('User', @user.id.to_s)}.should_not raise_error
+      end
+    end
   end
   
   after do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: riaction
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.2.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-02-22 00:00:00.000000000Z
+date: 2012-02-28 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &2160261380 !ruby/object:Gem::Requirement
+  requirement: &2153265020 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '2.6'
   type: :development
   prerelease: false
-  version_requirements: *2160261380
+  version_requirements: *2153265020
 - !ruby/object:Gem::Dependency
   name: sqlite3
-  requirement: &2160260960 !ruby/object:Gem::Requirement
+  requirement: &2153264580 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2160260960
+  version_requirements: *2153264580
 - !ruby/object:Gem::Dependency
   name: ruby-debug19
-  requirement: &2160260500 !ruby/object:Gem::Requirement
+  requirement: &2153264060 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2160260500
+  version_requirements: *2153264060
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &2160260080 !ruby/object:Gem::Requirement
+  requirement: &2153263580 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2160260080
+  version_requirements: *2153263580
 - !ruby/object:Gem::Dependency
   name: activerecord
-  requirement: &2160259520 !ruby/object:Gem::Requirement
+  requirement: &2153263060 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,10 +65,10 @@ dependencies:
         version: 3.0.0
   type: :runtime
   prerelease: false
-  version_requirements: *2160259520
+  version_requirements: *2153263060
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &2160258980 !ruby/object:Gem::Requirement
+  requirement: &2153262560 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,10 +76,10 @@ dependencies:
         version: 3.0.0
   type: :runtime
   prerelease: false
-  version_requirements: *2160258980
+  version_requirements: *2153262560
 - !ruby/object:Gem::Dependency
   name: resque
-  requirement: &2160258500 !ruby/object:Gem::Requirement
+  requirement: &2153262180 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -87,10 +87,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2160258500
+  version_requirements: *2153262180
 - !ruby/object:Gem::Dependency
   name: ruby-iactionable
-  requirement: &2160257800 !ruby/object:Gem::Requirement
+  requirement: &2153261600 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -98,7 +98,7 @@ dependencies:
         version: 0.0.2
   type: :runtime
   prerelease: false
-  version_requirements: *2160257800
+  version_requirements: *2153261600
 description: Wrapper for IActionable's restful API and an "acts-as" style interface
   for models to behave as profiles and drive game events.
 email: