rhoconnect 3.3.6 → 3.4.2

data/spec/perf/perf_spec_helper.rb

@@ -33,16 +33,20 @@ def title
   "#{prefix} #{suffix}"
 end
 
-def generate_fake_data(num=1000)
+def generate_fake_data(num=1000,unique=false)
   res = {}
   num.times do |n|
+    unique_prefix = ""
+    if unique
+      unique_prefix = "#{n}-#{Time.now.to_s}"
+    end
     res[n.to_s] = {
-      "FirstName" => Faker::Name.first_name,
-      "LastName" => Faker::Name.last_name,
-      "Email" =>  Faker::Internet.free_email,
-      "Company" => Faker::Company.name,
-      "JobTitle" => title,
-      "Phone1" => Faker::PhoneNumber.phone_number
+      "FirstName" => Faker::Name.first_name + unique_prefix,
+      "LastName" => Faker::Name.last_name + unique_prefix,
+      "Email" =>  Faker::Internet.free_email + unique_prefix,
+      "Company" => Faker::Company.name + unique_prefix,
+      "JobTitle" => title + unique_prefix,
+      "Phone1" => Faker::PhoneNumber.phone_number + unique_prefix
     }
   end
   res

data/spec/perf/store_perf_spec.rb

@@ -2,25 +2,102 @@ require File.join(File.dirname(__FILE__),'perf_spec_helper')
 
 describe "Rhoconnect Performance" do
   it_behaves_like "SharedRhoconnectHelper", :rhoconnect_data => false do
-    it "should process get/put for 1000 records (6000 elements)" do
-      @data = get_test_data(1000)
+    it "should process get/put/delete for 10000 records (60000 elements)" do
+      @data = get_test_data(10000)
       start = start_timer
       Store.put_data('mdoc',@data).should == true
       start = lap_timer('put_data duration',start)
       Store.get_data('mdoc').should == @data
-      lap_timer('get_data duration',start)
+      start = lap_timer('get_data duration',start)
+      Store.rename('mdoc','mdoc_copy')
+      start = lap_timer("rename doc duration", start)
+      Store.clone('mdoc_copy','mdoc_copy1')
+      start = lap_timer("clone doc duration", start)
+      Store.delete_objects('mdoc_copy',@data.keys[0,2])
+      start = lap_timer("delete_objects duration", start)
+      Store.delete_data('mdoc_copy1',@data)
+      start = lap_timer("delete_data duration", start)
     end
-
-    it "should process single attribute update 1000-record doc" do
-      @data = get_test_data(1000)
-      @data1 = get_test_data(1000)
+    
+    it "should process update_objects in a set of 10000 records (60000 elements)" do
+      @data = get_test_data(10000)
+      updated_key = @data.keys[21]
+      @update_data = {}
+      @update_data[updated_key] = @data[updated_key].clone
+      @update_data[updated_key]['Phone'] = 'updated phone SADD'
+      @update_data[updated_key]['Phone1'] = 'updated phone SREM and SADD'
+      expected = @data.clone
+      expected.merge!(@update_data)
+      
+      Store.put_data('mdoc',@data).should == true
+      start = start_timer
+      Store.update_objects('mdoc', @update_data)
+      lap_timer("update_objects duration", start)
+      Store.get_data('mdoc').should == expected
+    end
+    
+    it "should process 1000 update_objects in a set of 10000 records (60000 elements)" do
+      @data = get_test_data(10000)
+      updated_keys = @data.keys[2001..3000]
+      @update_data = {}
+      updated_keys.each do |updated_key|
+        @update_data[updated_key] = @data[updated_key].clone
+        @update_data[updated_key]['Phone'] = 'updated phone SADD'
+        @update_data[updated_key]['Phone1'] = 'updated phone SREM and SADD'
+      end
+      expected = @data.dup
+      expected.merge!(@update_data)
+      
+      Store.put_data('mdoc',@data).should == true
+      start = start_timer
+      Store.update_objects('mdoc', @update_data)
+      lap_timer("update_objects duration", start)
+      
+      Store.get_data('mdoc').should == expected
+    end
+    
+    it "should process single attribute diff for 10000-record doc" do
+      @data = get_test_data(10000)
+      @data1 = get_test_data(10000)
       @data1['950']['Phone1'] = 'This is changed'
       expected = {'950' => {'Phone1' => 'This is changed'}}
-      Store.put_data('mdoc',@data).should == true
-      Store.put_data('cdoc',@data1).should == true
+      Store.put_data(@s.docname(:md),@data1).should == true
+      Store.put_data(@c.docname(:cd),@data).should == true
+      start = start_timer
+      cs = ClientSync.new(@s,@c)
+      token,progress_count,total_count,res = cs.send_new_page
+      lap_timer('compute_page duration', start)
+      Store.get_data(@c.docname(:page)).should == expected
+      res['insert'].should == expected
+      res['delete'].should == {'950' => {'Phone1' => @data['950']['Phone1']}}
+    end
+    
+    it "should process full-sync for 5000-record doc" do
+      @data = get_test_data(5000)
+      Store.put_data(@s.docname(:md),@data).should == true
+      start = start_timer
+      cs = ClientSync.new(@s,@c,5000)
+      token,progress_count,total_count,res = cs.send_new_page
+      lap_timer('compute_page duration', start)
+      Store.get_data(@c.docname(:page)).should == @data
+      res['insert'].should == @data
+      res['delete'].should == nil
+    end
+    
+    it "should process worst-case sync scenario there every attrib of every object is changed for 5000-record doc" do
+      @data = generate_fake_data(5000,true)
+      sleep(1.5)
+      @data1 = generate_fake_data(5000,true)
+      Store.put_data(@s.docname(:md),@data).should == true
+      Store.put_data(@c.docname(:cd),@data1).should == true
       start = start_timer
-      Store.get_diff_data('mdoc','cdoc').should == expected
-      lap_timer('get_diff_data duration', start)
+      cs = ClientSync.new(@s,@c,5000)
+      token,progress_count,total_count,res = cs.send_new_page
+      lap_timer('compute_page duration', start)
+      Store.get_data(@c.docname(:page)).should == @data
+      Store.get_data(@c.docname(:cd)).should == Store.get_data(@s.docname(:md))
+      res['insert'].should == @data
+      res['delete'].should == @data1
     end
   end
 

data/spec/ping/gcm_spec.rb

@@ -0,0 +1,99 @@
+require File.join(File.dirname(__FILE__),'..','spec_helper')
+
+describe "Ping Android GCM" do
+  it_behaves_like "SharedRhoconnectHelper", :rhoconnect_data => false do
+
+    before(:each) do
+      @params = {"device_pin" => @c.device_pin,
+        "sources" => [@s.name], "message" => 'hello world',
+        "vibrate" => '5', "badge" => '5', "sound" => 'hello.mp3'}
+      @response = mock('response')
+      Rhoconnect.settings[:gcm_api_key] = 'validkey'
+    end
+
+    it "should ping gcm successfully" do
+      result = 'id=0:34234234134254%abc123\n'
+      @response.stub!(:code).and_return(200)
+      @response.stub!(:body).and_return(result)
+      @response.stub!(:headers).and_return({})
+      @response.stub!(:return!).and_return(@response)
+      setup_post_yield(@response)
+      Gcm.ping(@params).body.should == result
+    end
+
+    it "should raise error on missing gcm_api_key setting" do
+      key = Rhoconnect.settings[:gcm_api_key].dup
+      Rhoconnect.settings[:gcm_api_key] = nil
+      lambda { Gcm.ping(@params) }.should raise_error(
+        Gcm::InvalidApiKey, 'Missing `:gcm_api_key:` option in settings/settings.yml'
+      )
+      Rhoconnect.settings[:gcm_api_key] = key
+    end
+
+    it "should ping gcm with 503 connection error" do
+      error = 'Connection refused'
+      @response.stub!(:body).and_return(error)
+      RestClient.stub!(:post).and_return { raise RestClient::Exception.new(@response,503) }
+      Gcm.should_receive(:log).twice
+      lambda { Gcm.ping(@params) }.should raise_error(RestClient::Exception)
+    end
+
+    it "should ping gcm with 200 error message" do
+      error = 'Error=QuotaExceeded'
+      @response.stub!(:code).and_return(200)
+      @response.stub!(:body).and_return(error)
+      @response.stub!(:headers).and_return(nil)
+      setup_post_yield(@response)
+      Gcm.should_receive(:log).twice
+      lambda { Gcm.ping(@params) }.should raise_error(Gcm::GCMPingError, "GCM ping error: QuotaExceeded")
+    end
+
+    it "should fail to ping with bad authentication" do
+      error = 'Error=BadAuthentication'
+      @response.stub!(:code).and_return(403)
+      @response.stub!(:body).and_return(error)
+      @response.stub!(:headers).and_return({})
+      setup_post_yield(@response)
+      Gcm.should_receive(:log).twice
+      lambda { Gcm.ping(@params) }.should raise_error(
+        Gcm::InvalidApiKey, "Invalid GCM api key. Obtain new api key from GCM service."
+      )
+    end
+
+    it "should ping gcm with 401 error message" do
+      @response.stub!(:code).and_return(401)
+      @response.stub!(:body).and_return('')
+      setup_post_yield(@response)
+      Gcm.should_receive(:log).twice
+      lambda { Gcm.ping(@params) }.should raise_error(
+        Gcm::InvalidApiKey, "Invalid GCM api key. Obtain new api key from GCM service."
+      )
+    end
+
+    it "should compute gcm_message" do
+      expected = {
+        'registration_ids' => [@c.device_pin],
+        'collapse_key' => "RAND_KEY",
+        'data' => {
+          'do_sync' => @s.name,
+          'alert' => "hello world",
+          'vibrate' => '5',
+          'sound' => "hello.mp3"
+        }
+      }
+      actual = Gcm.gcm_message(@params)
+      actual['collapse_key'] = "RAND_KEY" unless actual['collapse_key'].nil?
+      actual.should == expected
+    end
+
+    it "should trim empty or nil params from gcm_message" do
+      expected = {'registration_ids' => [@c.device_pin], 'collapse_key' => "RAND_KEY",
+        'data' => {'vibrate' => '5', 'do_sync' => '', 'sound' => "hello.mp3"} }
+      params = {"device_pin" => @c.device_pin,
+        "sources" => [], "message" => '', "vibrate" => '5', "sound" => 'hello.mp3'}
+      actual = Gcm.gcm_message(params)
+      actual['collapse_key'] = "RAND_KEY" unless actual['collapse_key'].nil?
+      actual.should == expected
+    end
+  end
+end

data/spec/server/server_spec.rb

@@ -382,6 +382,8 @@ describe "Server" do
         get "/app/#{Rhoconnect::API_VERSION}/#{@s.name}", {}, {Rhoconnect::CLIENT_ID_HEADER => @c.id}
         last_response.should be_ok
         token = @c.get_value(:page_token)
+        last_response.headers[Rhoconnect::PAGE_TOKEN_HEADER].should == token
+        last_response.headers[Rhoconnect::PAGE_OBJECT_COUNT_HEADER].should == 2.to_s
         JSON.parse(last_response.body).should == [{'version'=>ClientSync::SYNC_VERSION},{"token"=>token}, 
           {"count"=>2}, {"progress_count"=>0}, {"total_count"=>2},{'insert'=>data}]
 
@@ -391,6 +393,8 @@ describe "Server" do
         get "/app/#{Rhoconnect::API_VERSION}/#{@s.name}",{:token => token}, {Rhoconnect::CLIENT_ID_HEADER => @c.id}
         last_response.should be_ok
         token = @c.get_value(:page_token)
+        last_response.headers[Rhoconnect::PAGE_TOKEN_HEADER].should == token
+        last_response.headers[Rhoconnect::PAGE_OBJECT_COUNT_HEADER].should == 2.to_s
         JSON.parse(last_response.body).should == [{'version'=>ClientSync::SYNC_VERSION},{"token"=>token}, 
           {"count"=>2}, {"progress_count"=>0}, {"total_count"=>0},{'delete'=>data}]
       end
@@ -402,8 +406,11 @@ describe "Server" do
         params = {:client_id => @c.id,:sources => sources,:search => {'name' => 'iPhone'},
           :version => ClientSync::VERSION}
         get "/api/application/search",params
+        last_response.headers['Warning'].index('deprecated').should_not == nil
         last_response.content_type.should =~ /application\/json/
         token = @c.get_value(:search_token)
+        last_response.headers[Rhoconnect::PAGE_TOKEN_HEADER].should == token
+        last_response.headers[Rhoconnect::PAGE_OBJECT_COUNT_HEADER].should == 1.to_s
         JSON.parse(last_response.body).should == [[{'version'=>ClientSync::SYNC_VERSION},{'token'=>token},
           {'source'=>sources[0][:name]},{'count'=>1},{'insert'=>{'1'=>@product1}}]]
       end

data/spec/server/stats_spec.rb

@@ -26,7 +26,14 @@ describe "Middleware" do
   end
 
   it "should compute http average" do
-    Time.stub!(:now).and_return { @now += 0.3; @now }
+    @incr = 0
+    Time.stub!(:now).and_return do
+      if @incr > 0
+        @now += 0.3
+        @incr -= 1
+      end
+      @now
+    end
     env = {
       'rack.request.query_hash' => {
         'source_name' => 'SampleAdapter'
@@ -34,7 +41,7 @@ describe "Middleware" do
       'REQUEST_METHOD' => 'GET',
       'PATH_INFO' => '/api/application/query'
     }
-    10.times { @middleware_new_routes.call(env) }
+    10.times { @incr = 3; @middleware_new_routes.call(env) }
     metric = 'http:GET:/api/application/query:SampleAdapter'
     Rhoconnect::Stats::Record.key(metric).should == "stat:#{metric}"
 

data/spec/source_sync_spec.rb

@@ -130,6 +130,35 @@ describe "SourceSync" do
           @ss.process_query
         end
       end
+      
+      describe "push_notify" do
+        it "should do push_notify for source after push_objects if enabled" do
+          @s.push_notify = 'true'
+          data = {'1' => @product1, '2' => @product2, '3' => @product3}
+          params = {'user_id'=>["testuser"], 'sources'=>["SampleAdapter"]}
+          PingJob.should_receive(:perform).once.with(params)
+          @ss.push_objects(data)
+        end
+        
+        it "should do push_notify for source after push_deletes if enabled" do
+          @s.push_notify = 'true'
+          u2 = User.create(:login => 'user2')
+          @a.users << u2.id
+          data = {'1' => @product1, '2' => @product2, '3' => @product3}
+          params = {'user_id'=>["testuser"], 'sources'=>["SampleAdapter"]}
+          PingJob.should_receive(:perform).once.with(params)
+          @ss.push_deletes(data)
+        end
+        
+        it "should not do push_notify for source by default" do
+          @s.partition = :app
+          u2 = User.create(:login => 'user2')
+          @a.users << u2.id
+          data = {'1' => @product1}
+          PingJob.should_receive(:perform).never
+          @ss.fast_delete(data)
+        end
+      end
 
       describe "create" do
         it "should do create where adapter.create returns nil" do

data/spec/spec_helper.rb

@@ -4,23 +4,25 @@ require 'webmock/rspec'
 require 'rspec/autorun' # Required for Rcov to run with rspec '~> 2.8.0'
 if RUBY_VERSION =~ /1.9/ || defined?(JRUBY_VERSION)
   require 'simplecov'
-  SimpleCov.start
+  SimpleCov.start do
+    add_filter '/spec/'
+  end
 end
 
 # all specs are Async'd in new ruby
 if RUBY_VERSION =~ /1.9/ and not defined?(JRUBY_VERSION)
   require 'eventmachine'
   require 'fiber'
-  
+
   Thread.abort_on_exception = true
-  
+
   module RSpec
     module Core
       class ExampleGroup
- 
+
         class << self
           alias_method :run_alias, :run
- 
+
           def run(reporter)
             if EM.reactor_running?
               run_alias reporter
@@ -50,16 +52,16 @@ Dir["#{SPEC_PATH}/support/**/*.rb"].each { |f| require f }
 
 ENV['RACK_ENV'] = 'test'
 ERROR = '0_broken_object_id' unless defined? ERROR
-  
+
 module TestHelpers
   def get_testapp_path
     File.expand_path(File.join(File.dirname(__FILE__),'apps','rhotestapp'))
   end
-  
+
   def get_emptyapp_path
     File.expand_path(File.join(File.dirname(__FILE__),'apps','emptyapp'))
   end
-  
+
   def do_post(url,params,headers = {})
     headers.merge!('CONTENT_TYPE'=>'application/json')
     post url, params.to_json, headers
@@ -69,7 +71,7 @@ module TestHelpers
     headers.merge!('CONTENT_TYPE'=>'application/json')
     put url, params.to_json, headers
   end
-  
+
   def bulk_data_docname(app_id,user_id)
     if user_id == "*"
       File.join(app_id,app_id)
@@ -77,13 +79,13 @@ module TestHelpers
       File.join(app_id,user_id,user_id)
     end
   end
-  
+
   def dump_db_data(store)
-    puts "*"*50 
+    puts "*"*50
     puts "DATA DUMP"
     puts "*"*50
     store.db.keys('*').sort.each do |key|
-      next if not key =~ /md|cd/ 
+      next if not key =~ /md|cd/
       line = ""
       line << "#{key}: "
       type = store.db.type key
@@ -92,7 +94,7 @@ module TestHelpers
           line << "#{store.get_data(key).inspect}"
         else
           line << "#{store.db.smembers(key).inspect}"
-        end  
+        end
       else
         line << "#{store.db.get key}"
       end
@@ -100,22 +102,22 @@ module TestHelpers
     end
     puts "*"*50
   end
-  
+
   def add_client_id(data)
     res = Marshal.load(Marshal.dump(data))
     res.each { |key,value| value['rhomobile.rhoclient'] = @c.id.to_s }
   end
 
   def add_error_object(data,error_message,error_name='wrongname')
-    error = {'an_attribute'=>error_message,'name'=>error_name} 
+    error = {'an_attribute'=>error_message,'name'=>error_name}
     data.merge!({ERROR=>error})
     data
   end
-  
+
   def delete_data_directory
     FileUtils.rm_rf(Rhoconnect.data_directory)
   end
-  
+
   def json_clone(data)
     JSON.parse(data.to_json)
   end
@@ -127,7 +129,7 @@ module TestHelpers
       RestClient.stub!(:post).and_yield(response)
     end
   end
-      
+
   def set_state(state,append=false)
     state.each do |dockey,data|
       if data.is_a?(Hash) or data.is_a?(Array)
@@ -137,22 +139,22 @@ module TestHelpers
       end
     end
   end
-  
+
   def set_zstate(state,assoc_key,append=false)
     state.each do |dockey,data|
       Store.put_zdata(dockey,assoc_key,data,append)
     end
   end
-  
+
   def set_test_data(dockey,data,error_message=nil,error_name='wrongname')
     if error_message
-      error = {'an_attribute'=>error_message,'name'=>error_name} 
+      error = {'an_attribute'=>error_message,'name'=>error_name}
       data.merge!({ERROR=>error})
-    end  
+    end
     Store.put_data(dockey,data)
     data
   end
-  
+
   def verify_result(result)
     result.keys.sort.each do |dockey|
       expected = result[dockey]
@@ -170,7 +172,7 @@ module TestHelpers
       end
     end
   end
-  
+
   def verify_zresult(result)
     result.keys.sort.each do |dockey|
       expected = result[dockey]
@@ -183,25 +185,25 @@ module TestHelpers
       end
     end
   end
-  
+
   def validate_db(bulk_data,data)
-    validate_db_file(bulk_data.dbfile,bulk_data.sources[0, -1],data)  
+    validate_db_file(bulk_data.dbfile,bulk_data.sources[0, -1],data)
   end
-    
-  def validate_db_file(dbfile,sources,data)  
-    db = DBAdapter.instance.get_connection(dbfile)    
+
+  def validate_db_file(dbfile,sources,data)
+    db = DBAdapter.instance.get_connection(dbfile)
     sources.each do |source_name|
       s = Source.load(source_name,{:app_id => APP_NAME,:user_id => @u.login})
       return false unless validate_db_by_name(db,s,data[s.name])
-    end 
-    true 
+    end
+    true
   end
-  
+
   def validate_db_by_name(db,s,data)
     db.execute("select source_id,name,sync_priority,partition,sync_type,source_attribs,
       metadata,schema,blob_attribs,associations,last_inserted_size, backend_refresh_time
       from sources where name='#{s.name}'").each do |row|
-       
+
       return false if row[0].to_s != s.source_id.to_s
       return false if row[1] != s.name
       return false if row[2].to_s != s.priority.to_s
@@ -241,7 +243,7 @@ module TestHelpers
     end
     data.empty?
   end
-  
+
   def get_attrib_counter(data)
     counter = {}
     data.each do |object_name,object|
@@ -251,7 +253,7 @@ module TestHelpers
     end
     BulkDataJob.refs_to_s(counter)
   end
-  
+
   def mock_metadata_method(adapters, &block)
     adapters.each do |klass|
       klass.class_eval "def metadata; {'foo'=>'bar'}.to_json; end"
@@ -261,7 +263,7 @@ module TestHelpers
       klass.class_eval "def metadata; end"
     end
   end
-  
+
   def mock_schema_method(adapters, &block)
     adapters.each do |klass|
       klass.class_eval 'def schema
@@ -296,7 +298,7 @@ module TestHelpers
       klass.class_eval "def schema; end"
     end
   end
-  
+
   def unzip_file(file,file_dir)
     Zip::ZipFile.open(file) do |zip_file|
       zip_file.each do |f|
@@ -315,5 +317,5 @@ module TestHelpers
     BulkDataJob.perform(params)
     BulkDataJob.after_perform_x(params) if BulkData.is_exist?(params["data_name"])
   end
-     
+
 end #TestHelpers