rh-console 1.0.5 → 1.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b4caf5635220e379b72b6100e9c63e59d0846b2cc81895869a288a62379beb2c
-  data.tar.gz: 58a8a8cbd5c98a1cc41ceef48fdf93946fa1397c6210b5001ff128de9cc6620d
+  metadata.gz: f1fc087e337bef189aac07044fea9bf8b7c56507a17b1af9766f2f330ad7aca8
+  data.tar.gz: c6c0860c9b68fb60fd2daa685cbda6d66bcd3b785f873d02b538cb340fb19b83
 SHA512:
-  metadata.gz: 656bd2edfe7f38ed3dd3ad4db3686ef20616e6cea0dd150494aac358042cb490596216729ae7c65c58b7ec1c3bd46b34b16c20ee966c4ef7177c818c1da8544e
-  data.tar.gz: 9c4dde382ed6500caaf3dd0931b060aad2946a2664000d4ab00efcce83645aae1bc84f715b6eebb97750a741de0ec44170baba22df69c44b9c61fa7b2b6dbc84
+  metadata.gz: 245d0fc54eb0e26e0f07a76d6e9e4aafb65313bc483702f16a5f245fe3e098b3b2191158fe9ed959ec64bd037ff008de40fbae48b00edff375a24060eaeb3fc9
+  data.tar.gz: 51bff25f8bb675d4cf4406932894f67f8b3b3fa7d078e086fa3c4b0148ccee56619719faa9c2a9daa67ac02c87f86a3b5bb6710342d6cb3a142341f0846e0901

data/lib/helpers/format_helpers.rb

@@ -15,4 +15,16 @@ module FormatHelpers
       rounded
     end
   end
+
+  # Add commas to a dollar amount
+  #
+  # @param value [String] a float dollar value
+  #
+  # @return [String] A string with commas added appropriately
+  #
+  # @example
+  #   commarize(3901.5) => "3,901.5"
+  def self.commarize(value)
+    value.to_s.reverse.gsub(/(\d{3})(?=\d)/, '\\1,').reverse
+  end
 end

data/lib/robinhood_client.rb

@@ -20,8 +20,12 @@ class RobinhoodClient
   ROBINHOOD_ACCOUNTS_ROUTE              = "https://api.robinhood.com/accounts/".freeze
   # Route that returns authenticated user's order history
   ROBINHOOD_ORDERS_ROUTE                = "https://api.robinhood.com/orders/".freeze
+  # Route that returns the authenticated user's portfolio
+  ROBINHOOD_PORTFOLIO_ROUTE             = "https://api.robinhood.com/portfolios/".freeze
   # Route to fetch the authenticated user's default watchlist
   ROBINHOOD_DEFAULT_WATCHLIST           = "https://api.robinhood.com/watchlists/Default/".freeze
+  # Route to fetch the authenticated user's stock positions
+  ROBINHOOD_POSITIONS_ROUTE             = "https://api.robinhood.com/positions/".freeze
   # Route to fetch the authenticated user's option positions
   ROBINHOOD_OPTIONS_POSITIONS_ROUTE     = "https://api.robinhood.com/options/positions/".freeze
   # Route to get a quote for an option ID
@@ -115,7 +119,7 @@ class RobinhoodClient
   #   my_new_client = RobinhoodClient.interactively_create_client
   def self.interactively_create_client
     print "Enter your username: "
-    username = gets.chomp
+    username = STDIN.gets.chomp
     print "Password: "
     password = STDIN.noecho(&:gets).chomp
 
@@ -328,6 +332,7 @@ class RobinhoodClient
     instrument_urls.each do |instrument|
       instruments_string += "#{instrument},"
     end
+    instruments_string.chop!
     params["instruments"] = instruments_string
     quote = get(ROBINHOOD_OPTION_QUOTE_ROUTE, params: params, return_as_json: true)
     quote["results"]
@@ -527,11 +532,12 @@ class RobinhoodClient
   def stock_positions
     position_params = {}
     position_params["nonzero"] = true
-    get(self.account["positions"], params: position_params, return_as_json: true)["results"]
+    get("#{ROBINHOOD_POSITIONS_ROUTE}", params: position_params, return_as_json: true)["results"]
   end
 
   def portfolio
-    get(self.account["portfolio"], return_as_json: true)
+    account_number = self.account["account_number"]
+    get("#{ROBINHOOD_PORTFOLIO_ROUTE}#{account_number}/", return_as_json: true)
   end
 
   def account
@@ -769,17 +775,4 @@ class RobinhoodClient
     end
 
   end
-
-  # Add commas to a dollar amount
-  #
-  # @param value [String] a float dollar value
-  #
-  # @return [String] A string with commas added appropriately
-  #
-  # @example
-  #   commarize(3901.5) => "3,901.5"
-  def commarize(value)
-    value.to_s.reverse.gsub(/(\d{3})(?=\d)/, '\\1,').reverse
-  end
-
 end

data/lib/robinhood_console.rb

@@ -636,7 +636,7 @@ class RobinhoodConsole
 
       all_time_portfolio_change += all_time_dollar_change
 
-      stock_position_rows << [stock["symbol"], "#{'%.2f' % quantity}", "$ #{'%.2f' % latest_price}", "$ #{'%.2f' % cost_basis}", "$ #{'%.2f' % day_dollar_change}".send(day_color), "#{'%.2f' % day_percent_change} %".send(day_color), "$ #{@client.commarize('%.2f' % all_time_dollar_change)}".send(all_time_color)]
+      stock_position_rows << [stock["symbol"], "#{'%.2f' % quantity}", "$ #{'%.2f' % latest_price}", "$ #{'%.2f' % cost_basis}", "$ #{'%.2f' % day_dollar_change}".send(day_color), "#{'%.2f' % day_percent_change} %".send(day_color), "$ #{FormatHelpers.commarize('%.2f' % all_time_dollar_change)}".send(all_time_color)]
     end
 
     options_positions.each do |option_position|
@@ -675,10 +675,10 @@ class RobinhoodConsole
 
     all_time_portfolio_color = all_time_portfolio_change >= 0 ? :green : :red
 
-    portfolio_text += "\n\nHoldings: $ #{@client.commarize('%.2f' % portfolio["market_value"].to_f)}\n"
-    portfolio_text +=     "Cash:     $ #{@client.commarize('%.2f' % (account["cash"].to_f + account["unsettled_funds"].to_f))}\n"
-    portfolio_text +=     "Equity:   $ #{@client.commarize('%.2f' % portfolio["equity"].to_f)}\n"
-    portfolio_text += "\nAll time change on stock holdings: " + "$ #{@client.commarize('%.2f' % all_time_portfolio_change)}\n".send(all_time_portfolio_color)
+    portfolio_text += "\n\nHoldings: $ #{FormatHelpers.commarize('%.2f' % portfolio["market_value"].to_f)}\n"
+    portfolio_text +=     "Cash:     $ #{FormatHelpers.commarize('%.2f' % (account["cash"].to_f + account["unsettled_funds"].to_f))}\n"
+    portfolio_text +=     "Equity:   $ #{FormatHelpers.commarize('%.2f' % portfolio["equity"].to_f)}\n"
+    portfolio_text += "\nAll time change on stock holdings: " + "$ #{FormatHelpers.commarize('%.2f' % all_time_portfolio_change)}\n".send(all_time_portfolio_color)
     portfolio_text
 
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rh-console
 version: !ruby/object:Gem::Version
-  version: 1.0.5
+  version: 1.0.6
 platform: ruby
 authors:
 - https://github.com/brentjo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-04-04 00:00:00.000000000 Z
+date: 2020-07-20 00:00:00.000000000 Z
 dependencies: []
 description: A command line interface to the Robinhood API. View your portfolio, stream
   quotes, and place orders at the command line.