rgeo 2.3.1 → 3.0.0.pre.rc.2

data/lib/rgeo/cartesian/planar_graph.rb

@@ -0,0 +1,379 @@
+# frozen_string_literal: true
+
+module RGeo
+  module Cartesian
+    # A Doubly Connected Edge List (DCEL) implementation of a Planar Graph.
+    # It represents geometries as vertices and half-edges.
+    #
+    # It includes an incident_edges hash that maps vertices to an array
+    # of half-edges whose origins are that vertex.
+    #
+    # Upon instantiation, the graph will compute the intersections using
+    # the SweeplineIntersector, populate the incident_edges map, and
+    # link all cyclic edges.
+    class PlanarGraph
+      # HalfEdge represents an edge as 2 directed edges.
+      # One half-edge will have it's origin at edge.s, the other
+      # at edge.e. Both half-edges will be linked as each other's twins.
+      #
+      # HalfEdges also contain references to the next and prev half-edges,
+      # where next's origin is this half-edges destination. Prev's destination
+      # is this half-edge's origin.
+      class HalfEdge
+        include Comparable
+
+        # Creates 2 half edges from an edge.
+        # They will be assigned as each other's twins.
+        # The Half Edges will be returned in the order of points
+        # of the edge (start, end).
+        #
+        # @param edge [RGeo::Cartesian::Segment]
+        #
+        # @return [Array]
+        def self.from_edge(edge)
+          e1 = new(edge.s)
+          e2 = new(edge.e)
+
+          e1.twin = e2
+          e2.twin = e1
+          [e1, e2]
+        end
+
+        def initialize(origin)
+          @origin = origin
+          @twin = nil
+          @next = nil
+          @prev = nil
+        end
+        attr_reader :origin
+        attr_accessor :twin, :next, :prev
+
+        # HalfEdges will be sorted around their shared vertex
+        # in a CW fashion. This means that face interiors will be
+        # a CCW.
+        def <=>(other)
+          angle <=> other.angle
+        end
+
+        # Will find attempt to find a cycle starting at this
+        # HalfEdge. Will end upon finding the first repeated HalfEdge
+        # or a HalfEdge where +next+ is nil.
+        #
+        # If a block is given, each HalfEdge seen will be yielded to the block.
+        #
+        # @return [Enumerator]
+        def and_connected
+          return to_enum(__method__) unless block_given?
+
+          hedges = Set.new
+          yield(self)
+          hedges << self
+
+          n = self.next
+          until hedges.include?(n) || n.nil?
+            yield(n)
+            hedges << n
+            n = n.next
+          end
+        end
+
+        # Return the destination of the half edge
+        #
+        # @return [RGeo::Feature::Point]
+        def destination
+          twin&.origin
+        end
+
+        # Compute the angle from the positive x-axis.
+        # Used for sorting at each node.
+        #
+        # @return [Float]
+        def angle
+          @angle ||= Math.atan2(destination.y - origin.y, destination.x - origin.x)
+        end
+
+        def inspect
+          "#<#{self.class}:0x#{object_id.to_s(16)} #{self}>"
+        end
+
+        def to_s
+          dst = destination
+          pr = prev&.origin
+          n = @next&.origin
+          "HalfEdge(#{origin}, #{dst}), Prev: #{pr},  Next: #{n}"
+        end
+      end
+
+      # Create a new PlanarGraph
+      #
+      # @param edges [Array<RGeo::Cartesian::Segment>] of Segments
+      def initialize(edges = [])
+        @edges = []
+        @incident_edges = {}
+
+        add_edges(edges)
+      end
+      attr_reader :edges, :incident_edges
+
+      # Insert an edge into the graph. This will automatically
+      # calculate intersections and add new vertices if necessary.
+      #
+      # @param edge [RGeo::Cartesian::Segment]
+      def add_edge(edge)
+        @edges << edge
+        create_half_edge(edge)
+
+        # Check if a new intersection was made and handle it.
+        intersection_map.each do |seg, ints|
+          compute_split_edges(seg, ints)
+        end
+
+        link_half_edges
+      end
+
+      # Insert multiple edges into the graph. Like +add_edge+, this automatically
+      # calculates intersections and adds new vertices.
+      #
+      # @param new_edges [Array<RGeo::Cartesian::Segment>]
+      def add_edges(new_edges)
+        @edges.concat(new_edges)
+        new_edges.each do |edge|
+          create_half_edge(edge)
+        end
+
+        intersection_map.each do |seg, ints|
+          compute_split_edges(seg, ints)
+        end
+
+        link_half_edges
+      end
+
+      private
+
+      # Creates a map of +proper_intersections+ for each segment
+      # from a sweepline intersector.
+      #
+      # Can be used to determine which edges need to be split
+      # after adding edges.
+      def intersection_map
+        intersector = SweeplineIntersector.new(edges)
+        intersections = intersector.proper_intersections
+
+        intersection_map = {}
+        intersections.each do |int|
+          # check the int_point against each edge.
+          # if it is not on the boundary of the edge, add it to the
+          # list of intersections for that edge.
+          s1_intersects = int.point != int.s1.s && int.point != int.s1.e
+          if s1_intersects
+            unless intersection_map[int.s1]
+              intersection_map[int.s1] = []
+            end
+            intersection_map[int.s1] << int.point
+          end
+
+          s2_intersects = int.point != int.s2.s && int.point != int.s2.e
+          next unless s2_intersects
+          unless intersection_map[int.s2]
+            intersection_map[int.s2] = []
+          end
+          intersection_map[int.s2] << int.point
+        end
+        intersection_map
+      end
+
+      def create_half_edges
+        @edges.each do |edge|
+          create_half_edge(edge)
+        end
+      end
+
+      def create_half_edge(edge)
+        e1, e2 = HalfEdge.from_edge(edge)
+        insert_half_edge(e1)
+        insert_half_edge(e2)
+      end
+
+      def insert_half_edge(he)
+        unless incident_edges[he.origin.coordinates]
+          @incident_edges[he.origin.coordinates] = []
+        end
+        @incident_edges[he.origin.coordinates] << he
+      end
+
+      # Links all half-edges where possible.
+      # Defines +next+ and +prev+ for every half-edge by rotating
+      # through all half-edges originating at a vertex.
+      #
+      # Assuming half-edges are sorted CCW, every sequential pair of
+      # half-edges (e1, e2) can be linked by saying e1.prev = e2.twin
+      # and e2.twin.next = e1.
+      def link_half_edges
+        incident_edges.each_value do |hedges|
+          hedges.sort!
+          [*hedges, hedges.first].each_cons(2) do |e1, e2|
+            e1.prev = e2.twin
+            e2.twin.next = e1
+          end
+        end
+      end
+
+      # It is possible that intersections occur when new edges are added.
+      # This will split those edges into more half-edges while preserving
+      # the existing half-edges when possible since geometries may reference
+      # them.
+      def compute_split_edges(seg, ints)
+        points = ints.uniq.sort do |a, b|
+          a.distance(seg.s) <=> b.distance(seg.s)
+        end
+        points = [seg.s] + points + [seg.e]
+
+        he_start = incident_edges[points.first.coordinates].find { |he| he.destination == points.last }
+        he_end = incident_edges[points.last.coordinates].find { |he| he.destination == points.first }
+
+        points.each_cons(2) do |s, e|
+          edge = Segment.new(s, e)
+          if s == he_start.origin
+            he = HalfEdge.new(e)
+            he_start.twin = he
+            he.twin = he_start
+            insert_half_edge(he)
+          elsif e == he_end.origin
+            he = HalfEdge.new(s)
+            he_end.twin = he
+            he.twin = he_end
+            insert_half_edge(he)
+          else
+            create_half_edge(edge)
+          end
+          @edges << edge
+        end
+        @edges.delete(seg)
+      end
+    end
+
+    # GeometryGraph is a PlanarGraph that is built by adding
+    # geometries instead of edges. The GeometryGraph will
+    # hold a reference to an arbitrary HalfEdge on the
+    # interior of the geometry for every boundary in the geometry.
+    # For example, a polygon will have a reference to a HalfEdge for its
+    # exterior shell and one for every hole.
+    class GeometryGraph < PlanarGraph
+      # GeomEdge will be used to store the references to the HalfEdges
+      GeomEdge = Struct.new(:exterior_edge, :interior_edges)
+
+      def initialize(geom)
+        super()
+        @parent_geometry = geom
+        @geom_edges = []
+        add_geometry(geom)
+      end
+      attr_reader :parent_geometry, :geom_edges
+
+      private
+
+      # Adds a geometry to the graph and finds its
+      # reference HalfEdge(s).
+      #
+      # @param geom [RGeo::Feature::Instance]
+      def add_geometry(geom)
+        case geom
+        when Feature::Point
+          # Can't handle points yet, so just add an empty entry for them
+          @geom_edges << GeomEdge.new
+        when Feature::LineString, Feature::LinearRing
+          add_line_string(geom)
+        when Feature::Polygon
+          add_polygon(geom)
+        when Feature::GeometryCollection
+          add_collection(geom)
+        else
+          raise Error::RGeoError, "Invalid Geometry Type: #{geom.class}"
+        end
+      end
+
+      # Adds a LineString or LinearRing
+      # to the graph.
+      #
+      # @param geom [RGeo::Feature::LineString]
+      def add_line_string(geom)
+        add_edges(geom.segments)
+
+        hedge = unless geom.empty?
+                  @incident_edges[geom.start_point.coordinates].first
+                end
+
+        @geom_edges << GeomEdge.new(hedge, nil)
+      end
+
+      # Adds a Polygon to the graph.
+      #
+      # Will add each shell seperately and find a CCW half-edge
+      # for the exterior ring and a CW half-edge for interior rings
+      # since these are designated as being on the interior of the polygon.
+      #
+      # It is possible that the half-edge will be nil if a suitable one cannot
+      # be found. This indicates the polygon is likely invalid.
+      #
+      # @param geom [RGeo::Feature::Polygon]
+      def add_polygon(geom)
+        exterior = geom.exterior_ring
+        add_edges(exterior.segments)
+
+        hedge = find_hedge(exterior)
+
+        interior_hedges = []
+        geom.interior_rings.each do |interior|
+          add_edges(interior.segments)
+          interior_hedges << find_hedge(interior, ccw: false)
+        end
+
+        @geom_edges << GeomEdge.new(hedge, interior_hedges)
+      end
+
+      # Adds a GeometryCollection to the graph.
+      #
+      # @param col [RGeo::Feature::GeometryCollection]
+      def add_collection(col)
+        col.each do |geom|
+          add_geometry(geom)
+        end
+      end
+
+      # Finds a Half-Edge that is part of a CCW or CW rotation
+      # from the input ring. Returns nil if none found.
+      #
+      # Will only consider half-edges that are colinear with
+      # the first or last segments of the ring.
+      #
+      # @param ring [RGeo::Feature::LinearRing]
+      # @param ccw [Boolean] true for CCW, false for CW
+      # @return [HalfEdge, nil]
+      def find_hedge(ring, ccw: true)
+        return nil if ring.num_points.zero?
+        ccw_target = ccw ? 1 : -1
+
+        coords = ring.start_point.coordinates
+        hedges = incident_edges[coords]
+
+        # find half-edges that are colinear to the start or end
+        # segment of the ring.
+        start_seg = Segment.new(ring.start_point, ring.point_n(1))
+        end_seg = Segment.new(ring.point_n(ring.num_points - 2), ring.end_point)
+        colinear_hedges = hedges.select do |he|
+          start_seg.side(he.destination).zero? || end_seg.side(he.destination).zero?
+        end
+
+        colinear_hedges.find do |hedge|
+          pts = []
+          hedge.and_connected do |he|
+            pts << he.origin
+          end
+          pts << hedge.origin
+          lr = parent_geometry.factory.line_string(pts)
+          Analysis.ring_direction(lr) == ccw_target
+        end
+      end
+    end
+  end
+end

data/lib/rgeo/cartesian/sweepline_intersector.rb

@@ -0,0 +1,149 @@
+# frozen_string_literal: true
+
+# -----------------------------------------------------------------------------
+#
+# Simple Sweepline Intersector Class
+#
+# -----------------------------------------------------------------------------
+
+module RGeo
+  module Cartesian
+    # Implements a Sweepline intersector to find all intersections
+    # in a group of segments. The idea is to use a horizontal line starting
+    # at y = +Infinity that sweeps down to y = -Infinity and every time it hits
+    # a new line, it will check if it intersects with any of the segments
+    # the line currently intersects at that y value.
+    # This is a more simplistic implementation that uses an array to hold
+    # observed segments instead of a sorted BST, so performance may be significantly
+    # worse in the case of lots of segments overlapping in y-ranges.
+    class SweeplineIntersector
+      Event = Struct.new(:point, :segment, :is_start)
+      Intersection = Struct.new(:point, :s1, :s2)
+
+      def initialize(segments)
+        @segments = segments
+      end
+      attr_reader :segments
+
+      # Returns the "proper" intersections from the list of segments.
+      #
+      # This will only return intersections that are not the start/end or
+      # end/start of the 2 segments. This could be useful for finding intersections
+      # in a ring for example, because knowing that segments are connected in a linestring
+      # is not always helpful, but those are reported by default.
+      #
+      # Note: This is not the true definition of a proper intersection. A
+      # truly proper intersection does not include colinear intersections and
+      # the intersection must lie in the interior of both segments.
+      #
+      # @return [Array<RGeo::Cartesian::SweeplineIntersector::Intersection>]
+      def proper_intersections
+        return @proper_intersections if defined?(@proper_intersections)
+
+        @proper_intersections = []
+        intersections.each do |intersection|
+          s1 = intersection.s1
+          s2 = intersection.s2
+          pt = intersection.point
+
+          unless (pt == s1.s && pt == s2.e) || (pt == s1.e && pt == s2.s)
+            @proper_intersections << intersection
+          end
+        end
+        @proper_intersections
+      end
+
+      # Computes the intersections of the input segments.
+      #
+      # Creates an event queue from the +events+ and adds segments to the
+      # +observed_segments+ array while their ending event has not been popped
+      # from the queue.
+      #
+      # Compares the new segment from the +is_start+ event to each observed segment
+      # then adds it to +observed_segments+. Records any intersections in to the
+      # returned array.
+      #
+      # @return [Array<RGeo::Cartesian::SweeplineIntersector::Intersection>]
+      def intersections
+        return @intersections if defined?(@intersections)
+
+        @intersections = []
+        observed_segments = Set.new
+        events.each do |e|
+          seg = e.segment
+
+          if e.is_start
+            observed_segments.each do |oseg|
+              int_pt = seg.segment_intersection(oseg)
+              if int_pt
+                intersect = Intersection.new(int_pt, seg, oseg)
+                @intersections << intersect
+              end
+            end
+            observed_segments << seg
+          else
+            observed_segments.delete(seg)
+          end
+        end
+        @intersections
+      end
+
+      # Returns an ordered array of events from the input segments. Events
+      # are the start and endpoints of each segment with an is_start tag to
+      # indicate if this is the starting or ending event for that segment.
+      #
+      # Ordering is done by greatest-y -> smallest-x -> is_start = true.
+      #
+      # @return [Array]
+      def events
+        return @events if defined?(@events)
+
+        @events = []
+        segments.each do |segment|
+          event_pair = create_event_pair(segment)
+          @events.concat(event_pair)
+        end
+
+        @events.sort! do |a, b|
+          if a.point == b.point
+            if a.is_start
+              -1
+            else
+              1
+            end
+          elsif a.point.y == b.point.y
+            a.point.x <=> b.point.x
+          else
+            b.point.y <=> a.point.y
+          end
+        end
+        @events
+      end
+
+      private
+
+      # Creates a pair of events from a segment
+      #
+      # @param segment [Segment]
+      #
+      # @return [Array]
+      def create_event_pair(segment)
+        s = segment.s
+        e = segment.e
+
+        s_event = Event.new(s, segment)
+        e_event = Event.new(e, segment)
+
+        if s.y > e.y || (s.y == e.y && s.x < e.x)
+          s_event.is_start = true
+          e_event.is_start = false
+        else
+          s_event.is_start = false
+          e_event.is_start = true
+        end
+
+        [s_event, e_event]
+      end
+    end
+  end
+end

data/lib/rgeo/cartesian/valid_op.rb

@@ -0,0 +1,71 @@
+# frozen_string_literal: true
+
+module RGeo
+  module Cartesian
+    module ValidOp
+      include ImplHelper::ValidOp
+
+      def validity_helper
+        ValidOpHelpers
+      end
+    end
+
+    module ValidOpHelpers
+      include ImplHelper::ValidOpHelpers
+
+      module_function(*ImplHelper::ValidOpHelpers.singleton_methods) # rubocop:disable Style/AccessModifierDeclarations
+
+      module_function
+
+      # Checks that there are no invalid intersections between the components
+      # of a polygon.
+      #
+      # @param [RGeo::Feature::Polygon] poly
+      #
+      # @return [String] invalid_reason
+      def check_consistent_area(poly)
+        # Get set of unique coords
+        pts = poly.exterior_ring.coordinates.to_set
+        poly.interior_rings.each do |ring|
+          pts += ring.coordinates
+        end
+        num_points = pts.size
+
+        # if additional nodes were added, there must be an intersection
+        # through a boundary.
+        if poly.send(:graph).incident_edges.size > num_points
+          return Error::SELF_INTERSECTION
+        end
+
+        rings = [poly.exterior_ring] + poly.interior_rings
+        return Error::SELF_INTERSECTION if rings.uniq.size != rings.size
+
+        nil
+      end
+
+      # Checks that the interior of a polygon is connected.
+      #
+      # Process to do this is to walk around an interior cycle of the
+      # exterior shell in the polygon's geometry graph. It will keep track
+      # of all the nodes it visited and if that set is a superset of the
+      # coordinates in the exterior_ring, the interior is connected, otherwise
+      # it is split somewhere.
+      #
+      # @param [RGeo::Feature::Polygon] poly
+      #
+      # @return [String] invalid_reason
+      def check_connected_interiors(poly)
+        exterior_coords = poly.exterior_ring.coordinates.to_set
+
+        visited = Set.new
+        poly.send(:graph).geom_edges.first.exterior_edge.and_connected do |hedge|
+          visited << hedge.origin.coordinates
+        end
+
+        return Error::DISCONNECTED_INTERIOR unless exterior_coords.subset?(visited)
+
+        nil
+      end
+    end
+  end
+end

data/lib/rgeo/cartesian.rb

@@ -8,8 +8,11 @@
 
 require_relative "cartesian/calculations"
 require_relative "cartesian/feature_methods"
+require_relative "cartesian/valid_op"
 require_relative "cartesian/feature_classes"
 require_relative "cartesian/factory"
 require_relative "cartesian/interface"
 require_relative "cartesian/bounding_box"
 require_relative "cartesian/analysis"
+require_relative "cartesian/sweepline_intersector"
+require_relative "cartesian/planar_graph"

data/lib/rgeo/coord_sys/cs/wkt_parser.rb

@@ -24,7 +24,7 @@ module RGeo
             return value
           end
           unless @cur_token.is_a?(TypeString)
-            raise Error::ParseError("Found token #{@cur_token} when we expected a value")
+            raise Error::ParseError, "Found token #{@cur_token} when we expected a value"
           end
           type = @cur_token
           next_token
@@ -48,7 +48,7 @@ module RGeo
           when "TOWGS84"
             bursa_wolf_params = args.find_all(Numeric)
             unless bursa_wolf_params.size == 7
-              raise Error::ParseError("Expected 7 Bursa Wolf parameters but found #{bursa_wolf_params.size}")
+              raise Error::ParseError, "Expected 7 Bursa Wolf parameters but found #{bursa_wolf_params.size}"
             end
             obj = WGS84ConversionInfo.create(*bursa_wolf_params)
           when "UNIT"
@@ -87,7 +87,7 @@ module RGeo
             unit = args.find_first(Unit)
             axes = args.find_all(AxisInfo)
             unless axes.size > 0
-              raise Error::ParseError("Expected at least one AXIS in a LOCAL_CS")
+              raise Error::ParseError, "Expected at least one AXIS in a LOCAL_CS"
             end
             obj = LocalCoordinateSystem.create(name, local_datum, unit, axes, *args.create_optionals)
           when "GEOCCS"
@@ -97,7 +97,7 @@ module RGeo
             linear_unit = args.find_first(LinearUnit)
             axes = args.find_all(AxisInfo)
             unless axes.size == 0 || axes.size == 3
-              raise Error::ParseError("GEOCCS must contain either 0 or 3 AXIS parameters")
+              raise Error::ParseError, "GEOCCS must contain either 0 or 3 AXIS parameters"
             end
             obj = GeocentricCoordinateSystem.create(name, horizontal_datum, prime_meridian, linear_unit, axes[0], axes[1], axes[2], *args.create_optionals)
           when "VERT_CS"
@@ -113,7 +113,7 @@ module RGeo
             angular_unit = args.find_first(AngularUnit)
             axes = args.find_all(AxisInfo)
             unless axes.size == 0 || axes.size == 2
-              raise Error::ParseError("GEOGCS must contain either 0 or 2 AXIS parameters")
+              raise Error::ParseError, "GEOGCS must contain either 0 or 2 AXIS parameters"
             end
             obj = GeographicCoordinateSystem.create(name, angular_unit, horizontal_datum, prime_meridian, axes[0], axes[1], *args.create_optionals)
           when "PROJCS"
@@ -125,7 +125,7 @@ module RGeo
             linear_unit = args.find_first(LinearUnit)
             axes = args.find_all(AxisInfo)
             unless axes.size == 0 || axes.size == 2
-              raise Error::ParseError("PROJCS must contain either 0 or 2 AXIS parameters")
+              raise Error::ParseError, "PROJCS must contain either 0 or 2 AXIS parameters"
             end
             obj = ProjectedCoordinateSystem.create(name, geographic_coordinate_system, projection, linear_unit, axes[0], axes[1], *args.create_optionals)
           else

data/lib/rgeo/coord_sys.rb

@@ -9,9 +9,6 @@
 require_relative "coord_sys/cs/factories"
 require_relative "coord_sys/cs/entities"
 require_relative "coord_sys/cs/wkt_parser"
-require_relative "coord_sys/srs_database/entry"
-require_relative "coord_sys/srs_database/url_reader"
-require_relative "coord_sys/srs_database/sr_org"
 
 module RGeo
   # This module provides data structures and tools related to coordinate
@@ -26,14 +23,6 @@ module RGeo
   # This includes classes for representing ellipsoids, datums, coordinate
   # systems, and other related concepts, as well as a parser for the WKT
   # format for specifying coordinate systems.
-  #
-  # The RGeo::CoordSys::SRSDatabase module contains tools for accessing
-  # spatial reference databases, from which you can look up coordinate
-  # system specifications. You can access the <tt>spatial_ref_sys</tt>
-  # table provided with OGC-compliant spatial databases such as PostGIS,
-  # read the databases provided with the proj4 library, or access URLs
-  # such as those provided by spatialreference.org.
-
   module CoordSys
     # The only valid key is :proj4
     def self.supported?(key)