rfmt 0.3.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1344ebd75598608c54dc975f8afecc17be05152039542ac1c1e80007086530fc
-  data.tar.gz: b5a29adb45e5163fdfdbbea2526d4ac72bdbca410ee86e888ecb224f3b98c922
+  metadata.gz: f49bc8ba6c22392ac19d4f52cb9f82ee0476f849326745d821b952a75b13bb70
+  data.tar.gz: 59f68f137d3b769e17463c8c47b5ee3add7c06234caf50b3a20c03a34bf32cc0
 SHA512:
-  metadata.gz: 71db0a1b94b8a2288a5fae7e3a09ec41fac6e834abd9760fd45b4ac7dfef71baac7ada32582a6018b74fa22a6d0711f529b8372c491179dfbe66cc9c56c287aa
-  data.tar.gz: c7dc265d4ba68a15c653715bd26d8c087be6d361a7bb3170bd59057c0b9a65cfbf2093c02ff8528dcffd8a2b4ca445faef2fdc4fa4c5035016360d64ad297b9e
+  metadata.gz: 8bd5393bab836f18a889ddac8e00e997bc7e1d45a6e9b2e5f4d232dd9589ce367ed76c60129631ca6a1626ba76031a8517cdd96e05ad41ebe960468f9933fb1e
+  data.tar.gz: f6692b5a16f284c59e5d8281c5bb11e96ce6f70aee47f6656c8e13986e20b27874f2dbcbee1168a6314a67f234909bb4e94a55903bcecddd072c1b9804475212

data/CHANGELOG.md

@@ -1,5 +1,33 @@
 ## [Unreleased]
 
+## [0.4.1] - 2025-11-28
+
+### Fixed
+- CLI exec message output optimization for better user experience
+- RuboCop compliance issues resolved
+
+### Changed
+- Improved output formatting with colored success/failure messages
+- Debug logs now only shown with `--verbose` flag or debug environment variables
+- Enhanced progress indicators during file processing
+
+## [0.4.0] - 2025-11-26
+
+### Added
+- Verbose mode option (`--verbose` flag) for detailed output during formatting
+- Git commit hook configuration with Lefthook integration for automatic formatting
+- RubyGems badge and installation instructions in README
+
+### Changed
+- Improved documentation structure and readability in user guides (English and Japanese)
+- Enhanced logging system with verbose output support
+- Updated benchmark documentation in README
+
+### Fixed
+- Command formatting to execution conversion issues
+- Documentation version command display
+- Various code quality improvements based on Clippy suggestions
+
 ## [0.3.0] - 2025-11-25
 
 ### Changed

data/Cargo.lock

@@ -1219,7 +1219,7 @@ checksum = "caf4aa5b0f434c91fe5c7f1ecb6a5ece2130b02ad2a590589dda5146df959001"
 
 [[package]]
 name = "rfmt"
-version = "0.3.0"
+version = "0.4.1"
 dependencies = [
  "anyhow",
  "clap",

data/README.md

@@ -4,8 +4,7 @@
 
 A Ruby code formatter written in Rust
 
-[![Gem Version](https://badge.fury.io/rb/rfmt.svg)](https://badge.fury.io/rb/rfmt)
-[![Test Status](https://github.com/fujitanisora/rfmt/workflows/test/badge.svg)](https://github.com/fujitanisora/rfmt/actions)
+[![Gem Version](https://badge.fury.io/rb/rfmt.svg)](https://rubygems.org/gems/rfmt)
 [![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT)
 
 [Installation](#installation) •
@@ -20,6 +19,8 @@ A Ruby code formatter written in Rust
 
 ## What is rfmt?
 
+[RubyGems reference](https://rubygems.org/gems/rfmt)
+
 **rfmt** is a Ruby code formatter that enforces consistent style across your codebase. Key characteristics:
 
 - **Opinionated**: Minimal configuration with consistent output
@@ -44,7 +45,7 @@ Enforces code style rules:
 
 ## Performance Benchmarks
 
-Performance comparison with RuboCop on a Rails project (111 files, 3,241 lines):
+Execution time comparison on a Rails project (111 files, 3,241 lines):
 
 | Test Type | Files | rfmt | RuboCop | Ratio |
 |-----------|-------|------|---------|-------|
@@ -52,6 +53,13 @@ Performance comparison with RuboCop on a Rails project (111 files, 3,241 lines):
 | Directory | 14 | 176ms | 1.68s | 9.6x |
 | Full Project (check) | 111 | 172ms | 4.36s | 25.4x |
 
+**About this comparison:**
+- RuboCop times include startup overhead and loading all cops (linting rules)
+- RuboCop was run with default configuration (all cops enabled)
+- rfmt is a formatting-only tool with minimal overhead
+- Both tools were measured in check mode (no file modifications)
+- Results are averages from 10 runs per test
+
 **Observations:**
 - rfmt execution time remains constant (172-191ms) regardless of file count
 - Low variance across runs (standard deviation: 8-23ms)
@@ -59,7 +67,7 @@ Performance comparison with RuboCop on a Rails project (111 files, 3,241 lines):
 **Test Environment:**
 - CPU: Apple Silicon (arm64)
 - Ruby: 3.4.5
-- rfmt: 0.2.4, RuboCop: 1.81.7
+- rfmt: 0.3.0, RuboCop: 1.81.7
 
 See [detailed benchmark report](docs/benchmark.md) for complete data.
 
@@ -146,13 +154,13 @@ rfmt init --force
 Format a single file:
 
 ```bash
-rfmt format lib/user.rb
+rfmt exec lib/user.rb
 ```
 
 Format multiple files:
 
 ```bash
-rfmt format lib/**/*.rb
+rfmt exec lib/**/*.rb
 ```
 
 Check if files need formatting (CI/CD):
@@ -164,7 +172,15 @@ rfmt check .
 Show diff without modifying files:
 
 ```bash
-rfmt format lib/user.rb --diff
+rfmt exec lib/user.rb --diff
+```
+
+Enable verbose output for debugging:
+
+```bash
+rfmt exec lib/user.rb --verbose
+# or use environment variable
+DEBUG=1 rfmt exec lib/user.rb
 ```
 
 ### Ruby API
@@ -255,6 +271,48 @@ class User < ApplicationRecord
 end
 ```
 
+## Development
+
+### Setup
+
+After cloning the repository:
+
+```bash
+bundle install
+bundle exec lefthook install
+```
+
+### Git Hooks
+
+This project uses [lefthook](https://github.com/evilmartians/lefthook) for automated validation before push:
+
+**Pre-push checks:**
+- RuboCop (Ruby linting)
+- cargo fmt --check (Rust formatting)
+- cargo clippy (Rust linting)
+
+**Skip hooks temporarily:**
+```bash
+# Skip all hooks for this push
+LEFTHOOK=0 git push
+
+# Skip specific hook
+LEFTHOOK_EXCLUDE=rubocop git push
+```
+
+### Running Tests
+
+```bash
+# Ruby tests
+bundle exec rspec
+
+# Rust tests
+cargo test --manifest-path ext/rfmt/Cargo.toml
+
+# All tests
+bundle exec rake dev:test_all
+```
+
 ## Documentation
 
 Documentation is available in the [docs](docs/) directory:

data/ext/rfmt/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "rfmt"
-version = "0.3.0"
+version = "0.4.1"
 edition = "2021"
 authors = ["fujitani sora <fujitanisora0414@gmail.com>"]
 license = "MIT"

data/ext/rfmt/src/ast/mod.rs

@@ -174,6 +174,7 @@ impl Node {
 
     /// Add metadata to the node
     #[cfg(test)]
+    #[allow(dead_code)]
     pub fn with_metadata(mut self, metadata: HashMap<String, String>) -> Self {
         self.metadata = metadata;
         self
@@ -181,6 +182,7 @@ impl Node {
 
     /// Add comments to the node
     #[cfg(test)]
+    #[allow(dead_code)]
     pub fn with_comments(mut self, comments: Vec<Comment>) -> Self {
         self.comments = comments;
         self

data/ext/rfmt/src/config/mod.rs

@@ -181,6 +181,7 @@ impl Config {
     }
 
     /// Get the indent string based on configuration
+    #[cfg(test)]
     pub fn indent_string(&self) -> String {
         match self.formatting.indent_style {
             IndentStyle::Spaces => " ".repeat(self.formatting.indent_width),

data/ext/rfmt/src/emitter/mod.rs

@@ -309,11 +309,18 @@ impl Emitter {
     /// Emit if/unless/elsif/else node
     /// is_elsif: true if this is an elsif clause (don't emit 'end')
     /// keyword: "if" or "unless"
-    fn emit_if_unless(&mut self, node: &Node, indent_level: usize, is_elsif: bool, keyword: &str) -> Result<()> {
+    fn emit_if_unless(
+        &mut self,
+        node: &Node,
+        indent_level: usize,
+        is_elsif: bool,
+        keyword: &str,
+    ) -> Result<()> {
         // Check if this is a postfix if (modifier form)
         // In postfix if, the statements come before the if keyword in source
         let is_postfix = if let (Some(predicate), Some(statements)) =
-            (node.children.first(), node.children.get(1)) {
+            (node.children.first(), node.children.get(1))
+        {
             statements.location.start_offset < predicate.location.start_offset
         } else {
             false
@@ -399,7 +406,7 @@ impl Emitter {
                 NodeType::ElseNode => {
                     // This is an else clause
                     self.emit_indent(indent_level)?;
-                    write!(self.buffer, "else\n")?;
+                    writeln!(self.buffer, "else")?;
 
                     // Emit else body (first child of ElseNode)
                     if let Some(else_statements) = consequent.children.first() {

data/ext/rfmt/src/lib.rs

@@ -29,7 +29,10 @@ fn format_ruby_code(ruby: &Ruby, source: String, json: String) -> Result<String,
     // Load configuration from file or use defaults
     log::info!("Attempting to discover config file...");
     let config = Config::discover().map_err(|e| e.to_magnus_error(ruby))?;
-    log::info!("Config loaded successfully, line_length: {}", config.formatting.line_length);
+    log::info!(
+        "Config loaded successfully, line_length: {}",
+        config.formatting.line_length
+    );
     let mut emitter = Emitter::with_source(config, source);
 
     let formatted = emitter.emit(&ast).map_err(|e| e.to_magnus_error(ruby))?;

data/ext/rfmt/src/logging/logger.rs

@@ -22,10 +22,20 @@ impl RfmtLogger {
     }
 
     pub fn init() {
+        // Check for debug mode via environment variables
+        let debug_mode = std::env::var("DEBUG").is_ok()
+            || std::env::var("RFMT_DEBUG").is_ok()
+            || std::env::var("RUST_LOG").is_ok();
+
         let level = std::env::var("RFMT_LOG")
             .ok()
             .and_then(|s| s.parse().ok())
-            .unwrap_or(LevelFilter::Info);
+            .unwrap_or(if debug_mode {
+                LevelFilter::Info
+            } else {
+                // In normal mode, only show warnings and errors
+                LevelFilter::Warn
+            });
         let logger = Self::new(level);
         log::set_boxed_logger(Box::new(logger)).expect("Failed to initialize logger");
         log::set_max_level(LevelFilter::Trace);
@@ -63,7 +73,6 @@ impl Log for RfmtLogger {
 #[cfg(test)]
 mod tests {
     use super::*;
-    use log::{debug, error, info, trace, warn};
     use std::sync::{Arc, Mutex};
 
     struct TestWriter {

data/lib/rfmt/cli.rb

@@ -1,6 +1,10 @@
 # frozen_string_literal: true
 
 require 'thor'
+
+# Check for verbose flag before loading rfmt to set debug mode early
+ENV['RFMT_DEBUG'] = '1' if ARGV.include?('-v') || ARGV.include?('--verbose')
+
 require 'rfmt'
 require 'rfmt/configuration'
 require 'rfmt/cache'
@@ -43,7 +47,7 @@ module Rfmt
     class_option :config, type: :string, desc: 'Path to configuration file'
     class_option :verbose, type: :boolean, aliases: '-v', desc: 'Verbose output'
 
-    desc 'format [FILES]', 'Format Ruby files'
+    desc 'exec [FILES]', 'Format Ruby files'
     option :write, type: :boolean, default: true, desc: 'Write formatted output'
     option :check, type: :boolean, desc: "Check if files are formatted (don't write)"
     option :diff, type: :boolean, desc: 'Show diff of changes'
@@ -52,7 +56,7 @@ module Rfmt
     option :jobs, type: :numeric, desc: 'Number of parallel jobs (default: CPU count)'
     option :cache, type: :boolean, default: true, desc: 'Use cache to skip unchanged files'
     option :cache_dir, type: :string, desc: 'Cache directory (default: ~/.cache/rfmt)'
-    def format(*files)
+    def exec(*files)
       config = load_config
       files = files.empty? ? config.files_to_format : files.flatten
 
@@ -72,15 +76,20 @@ module Rfmt
         original_count = files.size
         files = files.select { |file| cache.needs_formatting?(file) }
         skipped = original_count - files.size
-        say "Skipped #{skipped} unchanged file(s) (cache hit)", :blue if skipped.positive? && options[:verbose]
+        say "ℹ Skipped #{skipped} unchanged file(s) (cached)", :cyan if skipped.positive? && options[:verbose]
       end
 
       if files.empty?
-        say 'All files are already formatted', :green
+        say '✓ All files are already formatted (cached)', :green
         return
       end
 
-      say "Formatting #{files.size} file(s)...", :blue if options[:verbose]
+      # Show progress message
+      if files.size == 1
+        say "Processing #{files.first}...", :blue
+      else
+        say "Processing #{files.size} file(s)...", :blue
+      end
 
       results = if options[:parallel] && files.size > 1
                   format_files_parallel(files)
@@ -92,7 +101,7 @@ module Rfmt
 
     desc 'check [FILES]', 'Check if files need formatting'
     def check(*files)
-      invoke :format, files, check: true, write: false
+      invoke :exec, files, check: true, write: false
     end
 
     desc 'version', 'Show version'
@@ -202,7 +211,8 @@ module Rfmt
             show_diff(result[:file], result[:original], result[:formatted])
           elsif options[:write]
             File.write(result[:file], result[:formatted])
-            say "Formatted #{result[:file]}", :green if options[:verbose]
+            # Always show formatted files (not just in verbose mode)
+            say "✓ Formatted #{result[:file]}", :green
 
             # Update cache after successful write
             cache&.mark_formatted(result[:file])
@@ -210,7 +220,8 @@ module Rfmt
             puts result[:formatted]
           end
         else
-          say "#{result[:file]} already formatted", :blue if options[:verbose]
+          # Show already formatted files in non-check mode
+          say "✓ #{result[:file]} already formatted", :cyan unless options[:check]
 
           # Update cache even if no changes (file was checked)
           cache&.mark_formatted(result[:file])
@@ -220,10 +231,25 @@ module Rfmt
       # Save cache to disk
       cache&.save
 
-      # Summary
-      say "\n#{results.size} file(s) processed", :blue if options[:verbose]
-      say "#{changed_count} file(s) changed", :yellow if changed_count.positive? && options[:verbose]
-      say "#{error_count} error(s)", :red if error_count.positive?
+      # Summary - always show a summary message
+      if error_count.positive?
+        say "\n✗ Failed: #{error_count} error(s) occurred", :red
+      elsif options[:check] && failed_count.positive?
+        say "\n✗ Check failed: #{failed_count} file(s) need formatting", :yellow
+      elsif changed_count.positive?
+        # Success message with appropriate details
+        say "\n✓ Success! Formatted #{changed_count} file(s)", :green
+      elsif results.size == 1
+        say "\n✓ Success! File is already formatted", :green
+      else
+        say "\n✓ Success! All #{results.size} files are already formatted", :green
+      end
+
+      # Detailed summary in verbose mode
+      if options[:verbose]
+        say "Total: #{results.size} file(s) processed", :blue
+        say "Changed: #{changed_count} file(s)", :yellow if changed_count.positive?
+      end
 
       exit(1) if (options[:check] && failed_count.positive?) || error_count.positive?
     end

data/lib/rfmt/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Rfmt
-  VERSION = '0.3.0'
+  VERSION = '0.4.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rfmt
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.1
 platform: ruby
 authors:
 - fujitani sora
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-11-25 00:00:00.000000000 Z
+date: 2025-11-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rb_sys