rflags 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4e189abe3d250038bcc8060c64d3cb8d14c11df2
-  data.tar.gz: 58d25ae13e6f8127cf9b27963f4536e0cef32628
+  metadata.gz: 777559cce034a5c0198966e148f18bd3e363f878
+  data.tar.gz: a5dcddfda202f53578037ef52687332c68c77a51
 SHA512:
-  metadata.gz: 546ea83be0666bb1e309ad435621824d029153d3752f214962f704e20f7a812098165a16a0e088ee65f2fd03de14b24abdf18af61bafb69de4d9223001333faa
-  data.tar.gz: 67e7a8d667c1311b059a2a5880892dc6cfa3d40536668ae4d108581415918f573c8af701424f97d9cadea75d9916c503237477a5e87258b06dc5fa5fb73d1aa1
+  metadata.gz: bc795e572b4aa88327b9af539da8f55351414e4891bc655de72b4528390dfee5580647a4d10f01753e79fe2bbd910c0d6b4676e88a03257baf2bf85e2859c85f
+  data.tar.gz: 8d660af52d41c2f4045cf2c837b1a190b54c7538a112af145f15e94c84ceb086bffceb23ff657e7491af88e48dc1e99682acf666354162bb7736dbc59321f4e5

data/lib/rflags.rb

@@ -5,39 +5,60 @@ require 'rflags/redis_flag'
 
 module RFlags
   def flag(definition)
-    case definition
-    when Symbol, String
-      define_flag(definition, RFlags::Flag.new)
-    when Hash
-      definition.each do |name, backend|
-        define_flag(name, resolve_flag_backend(backend))
+    name, backend = resolve_flag_params(definition)
+    instance_variable_set("@#{name}".to_sym, backend)
+    instance_eval <<-MTD, __FILE__, __LINE__
+      def #{name}
+        @#{name}
       end
-    else
-      raise TypeError,
-        "RFlags#flag expects Symbol, String or Hash, but have #{definition.class}"
-    end
+    MTD
   end
 
-  private
+  def lazy_flag(name, &block)
+    if !block
+      raise "RFlags##{__method__} needs a block"
+    end
 
-  def define_flag(name, backend)
-    instance_variable_set(:"@#{name}", backend)
+    resolve = -> do
+      opts = block.call
+      resolve_flag_backend_class(opts).new(*opts)
+    end
+
+    instance_variable_set(:"@#{name}_block", resolve)
     instance_eval(<<-MTD, __FILE__, __LINE__)
-      def #{name}; @#{name}; end
+      def #{name}
+        @#{name} ||= @#{name}_block.call
+      end
     MTD
   end
 
-  def resolve_flag_backend(backend)
-    case backend
-    when String
-      RFlags::FileFlag.new(backend)
+  private
+
+  def resolve_flag_params(definition)
+    case definition
+    when String, Symbol
+      [definition, RFlags::Flag.new]
+    when Hash
+      name = definition.keys[0]
+
+      backend_opts = definition[name]
+      backend_class = resolve_flag_backend_class(backend_opts)
+
+      [name, backend_class.new(*backend_opts)]
+    else
+      raise TypeError, "Can't handle #{definition.class}"
+    end
+  end
+
+  def resolve_flag_backend_class(opts)
+    case opts
+    when String, Pathname
+      RFlags::FileFlag
     when Array
-      ::Object.const_get("::RFlags::#{backend[0].class}Flag")
-        .new(*backend)
+      class_name = opts[0].class
+      ::Object.const_get("::RFlags::#{class_name}Flag")
     else
-      raise TypeError,
-        "Wrong backend definition for RFlags#flag.\n" <<
-        "Backend should be instance of String or Array, but have #{backend.class}"
+      raise TypeError, "Can't handle #{opts.class}"
     end
   end
 end

data/test/test_file_flag.rb

@@ -1,5 +1,6 @@
 class TestFileFlag < Minitest::Test
   def setup
+    FileUtils.mkdir_p('tmp')
     @flag = RFlags::FileFlag.new('tmp/file_flag')
     FileUtils.rm_f('tmp/file_flag')
   end

data/test/test_rflags.rb

@@ -8,6 +8,8 @@ class TestRFlags < Minitest::Test
     flag :flag_a
     flag :flag_b => 'tmp/flag_b'
     flag :flag_c => [Redis, 'key']
+    flag :flag_d => Pathname.new('tmp/flag_d')
+    lazy_flag(:flag_e) { Pathname.new('tmp/flag_e') }
   end
 
   def test_it_defines_flag_method
@@ -26,10 +28,18 @@ class TestRFlags < Minitest::Test
     assert_instance_of RFlags::RedisFlag, Flags.flag_c
   end
 
+  def test_it_defines_file_flag_from_pathname
+    assert_instance_of RFlags::FileFlag, Flags.flag_d
+  end
+
   def test_resolve_exception
     error = assert_raises(TypeError) do
-      Flags.flag wrong: Pathname.new('.')
+      Flags.flag wrong: Struct.new(:a)
     end
-    assert_match(/but have Pathname/, error.message)
+    assert_match(/Can't handle Class/, error.message)
+  end
+
+  def test_it_defines_lazy_evaluated_flag
+    assert_instance_of RFlags::FileFlag, Flags.flag_e
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rflags
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Michael Lutsiuk
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-28 00:00:00.000000000 Z
+date: 2015-06-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -81,3 +81,4 @@ signing_key:
 specification_version: 4
 summary: Boolean flags with different backends
 test_files: []
+has_rdoc: